Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Rodney W. Grimes]

-- Start of PGP signed section.
[ Charset UTF-8 unsupported, converting... ]
> 
> > On Mar 7, 2017, at 01:04, Rodney W. Grimes  
> > wrote:
> > 
> >>> 
> >>> On Mar 6, 2017, at 21:50, Rodney W. Grimes 
> >>>  wrote:
> >>> 
> > On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> > 
> > Author: rgrimes
> > Date: Tue Mar  7 05:10:38 2017
> > New Revision: 314833
> > URL: https://svnweb.freebsd.org/changeset/base/314833
> >>> ...
> >>> 
> > 
> > -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> > +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} 
> > /usr/lib/libxo/encoder/test.enc
>  
>   This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
>  employer depends on this being functional).
>  Thanks,
> >>> 
> >>> I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS 
> >>> and
> >>> probably a much better fix in bsd.*.mk can be implemented.  I can live 
> >>> with
> >>> one last nasty wart of an absolute link in DESTDIR until then.  The 
> >>> important
> >>> functional ones are gone now.
> >>> 
> >>> To fix this without changing SYMLINKS would involve adding a local 
> >>> install:
> >>> target which would be more mess than having the one absolute link.
> >> 
> >> The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: 
> >> https://reviews.freebsd.org/D9919 .
> > 
> > I dont think that is what bapt/bdrewery had in mind, I think they wanted to
> > replicate the SYMLINK= as RSYMLINK= and use that when needed.
> > 
> > I have thought about this and we do not ever want absolute links in the 
> > tree,
> > so much simpler fix is to just convert SYMLINKS to call INSTALL_RSYMLINKS
> > instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be 
> > fixed,
> > and as long as no one uses INSTALL_SYMLINKS.
> 
> SYMLINKS has been around since r245752. I personally don?t know if it?s wise 
> to remove functionality that?s been ?in production? for 4+ years.

SYMLINKS has been around since 198x.

> Making the target intelligently use one command over the other might seem ok, 
> but it could have unintended consequences.
> I think it?s best to have another well-documented variable that uses 
> INSTALL_RSYMLINK vs INSTALL_SYMLINK.

It has 0 consequencies, it actually achives that all installed symbolic
links be relative, which is how things should be.  There is no doubt about
this, if you have doubt please defer to myself, Julian Elisher and some other
grey beards that know about this.  You simply do NOT want absolute path symbolic
links in the distribution, ever! 

> Also, in the CR, please note that the SYMLINKS piece doesn?t prefix source 
> targets with ${DESTDIR},
whereas the LINKS (and soon to be RSYMLINKS portion) will need it in order to 
compute the right paths and execute the right behavior. Otherwise, you?re going 
to be breaking someone?s use for SYMLINKS for no good reason.

That is correct, LINKS need 2 absolute paths to things in DESTDIR to create the 
proper hardlink,
where as SYMLINKS need the prooper DESTDIR relative source to place as the link 
body at
the target.  

I suggest your run a make installworld DESTDIR=/some/place and see just how 
broken your
symbolic links end up if you add ${DESTDIOR] to both sides of SYMLINK

> -Ngie

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Ngie Cooper (yaneurabeya)]

> On Mar 7, 2017, at 01:04, Rodney W. Grimes  
> wrote:
> 
>>> 
>>> On Mar 6, 2017, at 21:50, Rodney W. Grimes  
>>> wrote:
>>> 
> On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> 
> Author: rgrimes
> Date: Tue Mar  7 05:10:38 2017
> New Revision: 314833
> URL: https://svnweb.freebsd.org/changeset/base/314833
>>> ...
>>> 
> 
> -SYMLINKS+=   ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> +SYMLINKS+=   ../../../tests/lib/libxo/${SHLIB_NAME} 
> /usr/lib/libxo/encoder/test.enc
 
This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
 employer depends on this being functional).
 Thanks,
>>> 
>>> I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS 
>>> and
>>> probably a much better fix in bsd.*.mk can be implemented.  I can live with
>>> one last nasty wart of an absolute link in DESTDIR until then.  The 
>>> important
>>> functional ones are gone now.
>>> 
>>> To fix this without changing SYMLINKS would involve adding a local install:
>>> target which would be more mess than having the one absolute link.
>> 
>> The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: 
>> https://reviews.freebsd.org/D9919 .
> 
> I dont think that is what bapt/bdrewery had in mind, I think they wanted to
> replicate the SYMLINK= as RSYMLINK= and use that when needed.
> 
> I have thought about this and we do not ever want absolute links in the tree,
> so much simpler fix is to just convert SYMLINKS to call INSTALL_RSYMLINKS
> instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be fixed,
> and as long as no one uses INSTALL_SYMLINKS.

SYMLINKS has been around since r245752. I personally don’t know if it’s wise to 
remove functionality that’s been “in production” for 4+ years.

Making the target intelligently use one command over the other might seem ok, 
but it could have unintended consequences. I think it’s best to have another 
well-documented variable that uses INSTALL_RSYMLINK vs INSTALL_SYMLINK.

Also, in the CR, please note that the SYMLINKS piece doesn’t prefix source 
targets with ${DESTDIR}, whereas the LINKS (and soon to be RSYMLINKS portion) 
will need it in order to compute the right paths and execute the right 
behavior. Otherwise, you’re going to be breaking someone’s use for SYMLINKS for 
no good reason.

Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Rodney W. Grimes]

> 
> > On Mar 6, 2017, at 21:50, Rodney W. Grimes  
> > wrote:
> > 
> >>> On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> >>> 
> >>> Author: rgrimes
> >>> Date: Tue Mar  7 05:10:38 2017
> >>> New Revision: 314833
> >>> URL: https://svnweb.freebsd.org/changeset/base/314833
> > ...
> > 
> >>> 
> >>> -SYMLINKS+=   ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> >>> +SYMLINKS+=   ../../../tests/lib/libxo/${SHLIB_NAME} 
> >>> /usr/lib/libxo/encoder/test.enc
> >> 
> >>This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
> >> employer depends on this being functional).
> >> Thanks,
> > 
> > I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS 
> > and
> > probably a much better fix in bsd.*.mk can be implemented.  I can live with
> > one last nasty wart of an absolute link in DESTDIR until then.  The 
> > important
> > functional ones are gone now.
> > 
> > To fix this without changing SYMLINKS would involve adding a local install:
> > target which would be more mess than having the one absolute link.
> 
> The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: 
> https://reviews.freebsd.org/D9919 .

I dont think that is what bapt/bdrewery had in mind, I think they wanted to
replicate the SYMLINK= as RSYMLINK= and use that when needed.

I have thought about this and we do not ever want absolute links in the tree,
so much simpler fix is to just convert SYMLINKS to call INSTALL_RSYMLINKS
instead of INSTALL_SYMLINKS and bam, its all fixed and shall always be fixed,
and as long as no one uses INSTALL_SYMLINKS.

> Thanks,
> -Ngie
-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Ngie Cooper (yaneurabeya)]

> On Mar 6, 2017, at 21:50, Rodney W. Grimes  
> wrote:
> 
>>> On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
>>> 
>>> Author: rgrimes
>>> Date: Tue Mar  7 05:10:38 2017
>>> New Revision: 314833
>>> URL: https://svnweb.freebsd.org/changeset/base/314833
> ...
> 
>>> 
>>> -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
>>> +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} 
>>> /usr/lib/libxo/encoder/test.enc
>> 
>>  This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
>> employer depends on this being functional).
>> Thanks,
> 
> I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and
> probably a much better fix in bsd.*.mk can be implemented.  I can live with
> one last nasty wart of an absolute link in DESTDIR until then.  The important
> functional ones are gone now.
> 
> To fix this without changing SYMLINKS would involve adding a local install:
> target which would be more mess than having the one absolute link.

The proposed enhancement for bsd.links.mk for RSYMLINKS can be found here: 
https://reviews.freebsd.org/D9919 .
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Warner Losh]

On Tue, Mar 7, 2017 at 12:44 AM, Ngie Cooper (yaneurabeya)
 wrote:
>
>> On Mar 6, 2017, at 21:56, Rodney W. Grimes  
>> wrote:
>>
>>> On Mon, Mar 6, 2017 at 9:10 PM, Rodney W. Grimes  
>>> wrote:
 Author: rgrimes
 Date: Tue Mar  7 05:10:38 2017
 New Revision: 314833
 URL: https://svnweb.freebsd.org/changeset/base/314833

 Log:
  Convert absolute links to relative links.
  Style.Makefile(9) has been ignored to produce minimal diffs.
>>>
>>> Hey Rod,
>>>
>>> Not to pick nits excessively, but the style.Makefile manual page
>>> (which I'd never heard of before today) appears to be in section 5,
>>> not 9.  That may be wrong ? I thought 5 was for configuration files.
>>
>> *sigh*   Yet more messes to sweep up.  It defanitly does not belong
>> in 5, I had just assumed it was in 9 as that is where style(9) is.
>>
>> I am in no hurry to fix this, but glad you get to read some new
>> info.
>
> Why does it belong in 9 (also, thanks Conrad for noting my faux pas too)?
>
>5.   FreeBSD File Formats Manual
> ...
>9.   FreeBSD Kernel Developer's Manual
>
> 9 looks inappropriate in this case according to `man man` :).

style(9) is there because it started out life for the kernel.

It belongs in section 5. This was extensively debated when it went
into the tree.

Please do not move it.

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Ngie Cooper (yaneurabeya)]

> On Mar 6, 2017, at 21:56, Rodney W. Grimes  
> wrote:
> 
>> On Mon, Mar 6, 2017 at 9:10 PM, Rodney W. Grimes  wrote:
>>> Author: rgrimes
>>> Date: Tue Mar  7 05:10:38 2017
>>> New Revision: 314833
>>> URL: https://svnweb.freebsd.org/changeset/base/314833
>>> 
>>> Log:
>>>  Convert absolute links to relative links.
>>>  Style.Makefile(9) has been ignored to produce minimal diffs.
>> 
>> Hey Rod,
>> 
>> Not to pick nits excessively, but the style.Makefile manual page
>> (which I'd never heard of before today) appears to be in section 5,
>> not 9.  That may be wrong ? I thought 5 was for configuration files.
> 
> *sigh*   Yet more messes to sweep up.  It defanitly does not belong
> in 5, I had just assumed it was in 9 as that is where style(9) is.
> 
> I am in no hurry to fix this, but glad you get to read some new
> info.

Why does it belong in 9 (also, thanks Conrad for noting my faux pas too)?

   5.   FreeBSD File Formats Manual
...
   9.   FreeBSD Kernel Developer's Manual

9 looks inappropriate in this case according to `man man` :).
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Rodney W. Grimes]

> On Mon, Mar 6, 2017 at 9:10 PM, Rodney W. Grimes  wrote:
> > Author: rgrimes
> > Date: Tue Mar  7 05:10:38 2017
> > New Revision: 314833
> > URL: https://svnweb.freebsd.org/changeset/base/314833
> >
> > Log:
> >   Convert absolute links to relative links.
> >   Style.Makefile(9) has been ignored to produce minimal diffs.
> 
> Hey Rod,
> 
> Not to pick nits excessively, but the style.Makefile manual page
> (which I'd never heard of before today) appears to be in section 5,
> not 9.  That may be wrong ? I thought 5 was for configuration files.

*sigh*   Yet more messes to sweep up.  It defanitly does not belong
in 5, I had just assumed it was in 9 as that is where style(9) is.

I am in no hurry to fix this, but glad you get to read some new
info.

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Rodney W. Grimes]

> > On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> > 
> > Author: rgrimes
> > Date: Tue Mar  7 05:10:38 2017
> > New Revision: 314833
> > URL: https://svnweb.freebsd.org/changeset/base/314833
...

> > 
> > -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> > +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} 
> > /usr/lib/libxo/encoder/test.enc
> 
>   This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
> employer depends on this being functional).
> Thanks,

I am just going to revert this until the issue with SYMLINKS vs RSYMLINKS and
probably a much better fix in bsd.*.mk can be implemented.  I can live with
one last nasty wart of an absolute link in DESTDIR until then.  The important
functional ones are gone now.

To fix this without changing SYMLINKS would involve adding a local install:
target which would be more mess than having the one absolute link.

> -Ngie

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Conrad Meyer]

On Mon, Mar 6, 2017 at 9:10 PM, Rodney W. Grimes  wrote:
> Author: rgrimes
> Date: Tue Mar  7 05:10:38 2017
> New Revision: 314833
> URL: https://svnweb.freebsd.org/changeset/base/314833
>
> Log:
>   Convert absolute links to relative links.
>   Style.Makefile(9) has been ignored to produce minimal diffs.

Hey Rod,

Not to pick nits excessively, but the style.Makefile manual page
(which I'd never heard of before today) appears to be in section 5,
not 9.  That may be wrong — I thought 5 was for configuration files.

Best,
Conrad
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Rodney W. Grimes]

-- Start of PGP signed section.
> 
> > On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> > 
> > Author: rgrimes
> > Date: Tue Mar  7 05:10:38 2017
> > New Revision: 314833
> > URL: https://svnweb.freebsd.org/changeset/base/314833
> > 
> > Log:
> >  Convert absolute links to relative links.
> >  Style.Makefile(9) has been ignored to produce minimal diffs.
> > 
> >  Approved by:   grehan (mentor)
> >  MFC after: 1 week
> > 
> > Modified:
> >  head/bin/pkill/Makefile
> >  head/lib/libxo/tests/encoder/Makefile
> >  head/libexec/rtld-elf/Makefile
> >  head/share/termcap/Makefile
> >  head/usr.bin/chpass/Makefile
> >  head/usr.bin/passwd/Makefile
> >  head/usr.sbin/bsdinstall/partedit/Makefile
> >  head/usr.sbin/mailwrapper/Makefile
> >  head/usr.sbin/nologin/Makefile
> > 
> > Modified: head/bin/pkill/Makefile
> > ==
> > --- head/bin/pkill/Makefile Tue Mar  7 04:51:35 2017(r314832)
> > +++ head/bin/pkill/Makefile Tue Mar  7 05:10:38 2017(r314833)
> > @@ -16,8 +16,8 @@ MLINKS=   pkill.1 pgrep.1
> > # keep in mind that pkill is installed to /usr/bin in other
> > # OS types, e.g., NetBSD, OpenBSD, Solaris, and Linux.
> > #
> > -SYMLINKS=  ${BINDIR}/pkill /usr/bin/pkill
> > -SYMLINKS+= ${BINDIR}/pgrep /usr/bin/pgrep
> > +SYMLINKS=  ../..${BINDIR}/pkill /usr/bin/pkill
> > +SYMLINKS+= ../..${BINDIR}/pgrep /usr/bin/pgrep
> > 
> > .if ${MK_TESTS} != "no"
> > SUBDIR+= tests
> > 
> > Modified: head/lib/libxo/tests/encoder/Makefile
> > ==
> > --- head/lib/libxo/tests/encoder/Makefile   Tue Mar  7 04:51:35 2017
> > (r314832)
> > +++ head/lib/libxo/tests/encoder/Makefile   Tue Mar  7 05:10:38 2017
> > (r314833)
> > @@ -8,7 +8,7 @@ SHLIB_NAME= libenc_test.so
> > 
> > LIBDIR= ${TESTSBASE}/lib/libxo
> > 
> > -SYMLINKS+= ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> > +SYMLINKS+= ../../../tests/lib/libxo/${SHLIB_NAME} 
> > /usr/lib/libxo/encoder/test.enc
> 
>   This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
> employer depends on this being functional).

That well happen when I resolve the SYMLINKS .mk glue that should probalby be 
calling
INSTALL_RSYMLINKS and not INSTALL_SYMLINKS.  For now this was the minimal diff 
that
corrected the contents of DESTDIR.

I did not get a response from either Bdrewery or Bapt on my direct question
about the issue that SYMLINKS has no relative mechansim, other than we
could add a RSYMLINKS possibly. 

> Thanks,
> -Ngie
-- End of PGP section, PGP failed!

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r314833 - in head: bin/pkill lib/libxo/tests/encoder libexec/rtld-elf share/termcap usr.bin/chpass usr.bin/passwd usr.sbin/bsdinstall/partedit usr.sbin/mailwrapper usr.sbin/nologin

[Ngie Cooper (yaneurabeya)]

> On Mar 6, 2017, at 21:10, Rodney W. Grimes  wrote:
> 
> Author: rgrimes
> Date: Tue Mar  7 05:10:38 2017
> New Revision: 314833
> URL: https://svnweb.freebsd.org/changeset/base/314833
> 
> Log:
>  Convert absolute links to relative links.
>  Style.Makefile(9) has been ignored to produce minimal diffs.
> 
>  Approved by: grehan (mentor)
>  MFC after:   1 week
> 
> Modified:
>  head/bin/pkill/Makefile
>  head/lib/libxo/tests/encoder/Makefile
>  head/libexec/rtld-elf/Makefile
>  head/share/termcap/Makefile
>  head/usr.bin/chpass/Makefile
>  head/usr.bin/passwd/Makefile
>  head/usr.sbin/bsdinstall/partedit/Makefile
>  head/usr.sbin/mailwrapper/Makefile
>  head/usr.sbin/nologin/Makefile
> 
> Modified: head/bin/pkill/Makefile
> ==
> --- head/bin/pkill/Makefile   Tue Mar  7 04:51:35 2017(r314832)
> +++ head/bin/pkill/Makefile   Tue Mar  7 05:10:38 2017(r314833)
> @@ -16,8 +16,8 @@ MLINKS= pkill.1 pgrep.1
> # keep in mind that pkill is installed to /usr/bin in other
> # OS types, e.g., NetBSD, OpenBSD, Solaris, and Linux.
> #
> -SYMLINKS=${BINDIR}/pkill /usr/bin/pkill
> -SYMLINKS+=   ${BINDIR}/pgrep /usr/bin/pgrep
> +SYMLINKS=../..${BINDIR}/pkill /usr/bin/pkill
> +SYMLINKS+=   ../..${BINDIR}/pgrep /usr/bin/pgrep
> 
> .if ${MK_TESTS} != "no"
> SUBDIR+= tests
> 
> Modified: head/lib/libxo/tests/encoder/Makefile
> ==
> --- head/lib/libxo/tests/encoder/Makefile Tue Mar  7 04:51:35 2017
> (r314832)
> +++ head/lib/libxo/tests/encoder/Makefile Tue Mar  7 05:10:38 2017
> (r314833)
> @@ -8,7 +8,7 @@ SHLIB_NAME=   libenc_test.so
> 
> LIBDIR=   ${TESTSBASE}/lib/libxo
> 
> -SYMLINKS+=   ${LIBDIR}/${SHLIB_NAME} /usr/lib/libxo/encoder/test.enc
> +SYMLINKS+=   ../../../tests/lib/libxo/${SHLIB_NAME} 
> /usr/lib/libxo/encoder/test.enc

This change breaks setting TESTSBASE != /usr/tests . Please fix (my 
employer depends on this being functional).
Thanks,
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail