Re: svn commit: r333995 - head/sys/teken

[Warner Losh]

On Tue, May 22, 2018 at 3:25 AM, Ed Schouten  wrote:

> Hi Bruce,
>
> 2018-05-22 3:18 GMT+02:00 Bruce Evans :
> > DECSCUSR is a verbose yet cryptic abbreviation which is not even expanded
> > its name.  It is the only abbreviation longer than 7 characters.  This
> > messes up the souce formatting.
>
> Yeah, it's a bit silly, but that's simply how it's called:
>
> https://vt100.net/docs/vt510-rm/DECSCUSR.html
>
> I think the state machine generator doesn't mind if we added an extra
> tab between all other entries to get it to line up again. Maybe that
> does push us over 80 columns, though...


Yea, back in the day, ANSI had official mnemonics for the escape sequences.
And DEC's extensions to ANSI sequences had official mnemonics as well, but
all started with DEC so you knew about them. These mnemonics were akin to
the assembler at the time, where one had to keep track of the differences
between HRLI and HRROS in assembler, SCUSR isn't so crazy. These days, it's
a bit brief.

Warner

[*] These are MACRO-10 half word instructions that I've forgotten all
meaning of other than they were half word instructions that did weird
things depending on which letters... Half [LR src] [LR dst] .
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333995 - head/sys/teken

[Ed Schouten]

Hi Bruce,

2018-05-22 3:18 GMT+02:00 Bruce Evans :
> DECSCUSR is a verbose yet cryptic abbreviation which is not even expanded
> its name.  It is the only abbreviation longer than 7 characters.  This
> messes up the souce formatting.

Yeah, it's a bit silly, but that's simply how it's called:

https://vt100.net/docs/vt510-rm/DECSCUSR.html

I think the state machine generator doesn't mind if we added an extra
tab between all other entries to get it to line up again. Maybe that
does push us over 80 columns, though...

-- 
Ed Schouten 
Nuxi, 's-Hertogenbosch, the Netherlands
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333995 - head/sys/teken

[Stefan Esser]

Am 22.05.18 um 03:18 schrieb Bruce Evans:
> On Mon, 21 May 2018, [UTF-8] Jean-Sébastien Pédron wrote:
>> -CS    Cursor style    ^[ [ SP q    r
>> +DECSCUSR    Set Cursor Style    ^[ [ SP q    r
>> DA1    Primary Device Attributes    ^[ [ c    r
>> DA2    Secondary Device Attributes    ^[ [ > c    r
>> DC    Delete character    ^[ [ P    n
> 
> Any chance of keeping this file sorted?
> 
> DECSCUSR is a verbose yet cryptic abbreviation which is not even expanded
> its name.  It is the only abbreviation longer than 7 characters.  This messes
> up the souce formatting.
> 
> Not expanding DEC in the name is normal, but other letters are normally
> expanded.  I don't know what USR is.  It looks like a bad abbreviation
> for "user".  'S' in it might mean style.

DECSCUSR = DEC SetCUrSoR ... (not quite so) obviously ;-)

Regards, STefan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333995 - head/sys/teken

[Bruce Evans]

On Mon, 21 May 2018, [UTF-8] Jean-S??bastien P??dron wrote:


Log:
 teken: Rename the "Set Cursor Style" sequence to match vt100.net docs

 This fixes inconsistencies with the rest of the `sequences` file.

 No functional changes.

 Requested by:  ed

Modified: head/sys/teken/sequences
==
--- head/sys/teken/sequencesMon May 21 20:23:04 2018(r333994)
+++ head/sys/teken/sequencesMon May 21 20:35:16 2018(r333995)
@@ -48,7 +48,7 @@ CUF   Cursor Forward  ^[ [ a  
n
CUP Cursor Position ^[ [ H  n n
CUP Cursor Position ^[ [ f  n n
CUU Cursor Up   ^[ [ A  n
-CS Cursor style^[ [ SP q   r
+DECSCUSR   Set Cursor Style^[ [ SP q   r
DA1 Primary Device Attributes   ^[ [ c  r
DA2 Secondary Device Attributes ^[ [ > c r
DC  Delete character^[ [ P  n


Any chance of keeping this file sorted?

DECSCUSR is a verbose yet cryptic abbreviation which is not even expanded
its name.  It is the only abbreviation longer than 7 characters.  This messes
up the souce formatting.

Not expanding DEC in the name is normal, but other letters are normally
expanded.  I don't know what USR is.  It looks like a bad abbreviation
for "user".  'S' in it might mean style.


Modified: head/sys/teken/teken_subr.h
==
--- head/sys/teken/teken_subr.h Mon May 21 20:23:04 2018(r333994)
+++ head/sys/teken/teken_subr.h Mon May 21 20:35:16 2018(r333995)
@@ -372,7 +372,7 @@ teken_subr_cursor_up(teken_t *t, unsigned int nrows)
}

static void
-teken_subr_cursor_style(teken_t *t, unsigned int style)
+teken_subr_set_cursor_style(teken_t *t, unsigned int style)
{

/* TODO */


Names must be chosen carefully since they become function names which tend
to be long and ugly.  This one is not long but is a bit to generic.  The
worst function name double_height_double_width_line_bottom() has one of
the best abbreviations (DECDHL).  DEC is mercifully not spelled out in the
function name, and Double Width Bottom is omitted from the abbreviation.

Bruce___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"