Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Oct 21, 2012, at 11:10 AM, Alexey Dokuchaev wrote: On Fri, Oct 19, 2012 at 11:36:04AM -0700, Devin Teske wrote: On Oct 19, 2012, at 10:02 AM, Alexey Dokuchaev wrote: Ah, I guess it might explain the shitty colors I see on newish FreeBSD screenshots of dialog(1). I actually prefer the colors in cdialog (more specifically, I prefer the lack-of-yellow!). I'm curious about how others feel about the use of yellow (specifically that old dialog(1)/libdialog used it a lot and new cdialog-based dialog(1)/ libdialog doesn't use it hardly at all). While you probably know my opinion at this point, I'd like to remark that our original dialog(1) colors seem like one of our distinctive features (similar to e.g. RedHat's or Debian's text-based installers) that had been around for years and are immediately recognizable. It is sad to loose them. Hmm, you make an interesting point and I think I know why the change in colors. I saw this hit my inbox recently: %begin excerpt% --- head/contrib/dialog/CHANGES Sun Oct 21 18:18:49 2012(r241817) +++ head/contrib/dialog/CHANGES Sun Oct 21 18:25:12 2012(r241818) @@ -1,9 +1,172 @@ --- $Id: CHANGES,v 1.360 2011/07/07 23:35:10 tom Exp $ +-- $Id: CHANGES,v 1.419 2012/07/06 18:18:48 tom Exp $ -- Thomas E. Dickey dic...@invisible-island.net This version of dialog was originally from a Debian snapshot. I've done this to it: %end excerpt% The dialog(1) that we're using in 9+ was originally from Debian and then tom makes a bunch of modifications (and I think our own nwhitehorn might make some more changes). I think this explains the [recent] similarity in color choices. I think you make a good point about diminished diversity. However, I'd inquire with nwhitehorn about any/all changes to the dialog(1) contrib code as it is still vendor maintained (and he's the one doing the importing these days). It is possible to change the colorings by first creating (if you don't already have one) a ~/.dialogrc by executing the below command: dialog --create-rc ~/.dialogrc followed by editing said file. So while the default look and feel has changed, it's possible to customize it to your liking. I would wholeheartedly prefer us to have original colors by default, and to Changing the default colors introduces [more] maintenance for the importer/maintainer of the contrib code. Exactly how much more maintenance, I'm unsure of. provide alternative color scheme for those how experience some difficulties with them (e.g. MacOSX users), not the other way around. Mac OS X was only one example, and I agree it should not be the sole source of reasoning here. However, I experience the same problem using XTerm natively on FreeBSD. My personal issue although has already been heard on the topic (unable to see the yellow titles, yellow hlines, or pretty much any yellow on a light background) -- so I'm inclined to not push too hard in restoring the original coloring _exactly_ as it was (read: I think we can do better). -- Devin _ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Fri, Oct 19, 2012 at 11:36:04AM -0700, Devin Teske wrote: On Oct 19, 2012, at 10:02 AM, Alexey Dokuchaev wrote: Ah, I guess it might explain the shitty colors I see on newish FreeBSD screenshots of dialog(1). I actually prefer the colors in cdialog (more specifically, I prefer the lack-of-yellow!). I'm curious about how others feel about the use of yellow (specifically that old dialog(1)/libdialog used it a lot and new cdialog-based dialog(1)/ libdialog doesn't use it hardly at all). While you probably know my opinion at this point, I'd like to remark that our original dialog(1) colors seem like one of our distinctive features (similar to e.g. RedHat's or Debian's text-based installers) that had been around for years and are immediately recognizable. It is sad to loose them. It is possible to change the colorings by first creating (if you don't already have one) a ~/.dialogrc by executing the below command: dialog --create-rc ~/.dialogrc followed by editing said file. So while the default look and feel has changed, it's possible to customize it to your liking. I would wholeheartedly prefer us to have original colors by default, and to provide alternative color scheme for those how experience some difficulties with them (e.g. MacOSX users), not the other way around. ./danfe ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Oct 18, 2012, at 10:54 PM, Alexey Dokuchaev wrote: On Thu, Oct 18, 2012 at 06:43:54PM +, Devin Teske wrote: NOTE: In FreeBSD-9 and higher, dialog(1) does not support the F1 hook, so the mechanism for providing help to the user had to be changed to a button. How come that new dialog(1) lacks functionality of the old one? SVN r217309 brought in cdialog to replace our the [unmaintained] dialog. cdialog is different, but mostly compatible with its predecessor. The benefits of cdialog far out-weigh the few problems that were reported (and then quickly fixed). Most importantly, cdialog is actively maintained while its predecessor (in FreeBSD-8.x and older) is not. -- Devin _ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Fri, Oct 19, 2012 at 08:22:36AM -0700, Devin Teske wrote: On Oct 18, 2012, at 10:54 PM, Alexey Dokuchaev wrote: How come that new dialog(1) lacks functionality of the old one? SVN r217309 brought in cdialog to replace our the [unmaintained] dialog. cdialog is different, but mostly compatible with its predecessor. Ah, I guess it might explain the shitty colors I see on newish FreeBSD screenshots of dialog(1). The benefits of cdialog far out-weigh the few problems that were reported (and then quickly fixed). OK, but do we plan to retain the look of original dialog(1)? ./danfe ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Oct 19, 2012, at 10:02 AM, Alexey Dokuchaev wrote: On Fri, Oct 19, 2012 at 08:22:36AM -0700, Devin Teske wrote: On Oct 18, 2012, at 10:54 PM, Alexey Dokuchaev wrote: How come that new dialog(1) lacks functionality of the old one? SVN r217309 brought in cdialog to replace our the [unmaintained] dialog. cdialog is different, but mostly compatible with its predecessor. Ah, I guess it might explain the shitty colors I see on newish FreeBSD screenshots of dialog(1). I actually prefer the colors in cdialog (more specifically, I prefer the lack-of-yellow!). Whenever I want a reminder of bad colors, I run sade (which links against the old libdialog now named lib*o*dialog). When I'm on the physical console, I don't have nearly as much trouble with the yellow color used both for the title bar and for the hline at the bottom, but when I'm (say) ssh'd from Mac OS X, that text is just completely unreadable to me. I'm curious about how others feel about the use of yellow (specifically that old dialog(1)/libdialog used it a lot and new cdialog-based dialog(1)/libdialog doesn't use it hardly at all). I for one embrace my new cdialog overlord. The benefits of cdialog far out-weigh the few problems that were reported (and then quickly fixed). OK, but do we plan to retain the look of original dialog(1)? It is possible to change the colorings by first creating (if you don't already have one) a ~/.dialogrc by executing the below command: dialog --create-rc ~/.dialogrc followed by editing said file. So while the default look and feel has changed, it's possible to customize it to your liking. HINT: I bet if you ran the above command on FreeBSD-8 or lower, it would make dialog(1) in FreeBSD-9 and higher look like its predecessor. -- Devin _ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
Author: dteske
Date: Thu Oct 18 18:43:54 2012
New Revision: 241701
URL: http://svn.freebsd.org/changeset/base/241701
Log:
More-accurately replicate the help system from sysinstall(8). However, also
improve upon the system by giving the user a Help button instead of
requiring
the user to press F1.
NOTE: In FreeBSD-9 and higher, dialog(1) does not support the F1 hook, so the
mechanism for providing help to the user had to be changed to a button.
This now means we can resurrect *.hlp files from usr.sbin/sysinstall/help/ as-
is and reusing them as-needed in bsdconfig (holding to the goal of losing as
little functionality from sysinstall as possible).
Reviewed by: adrian (co-mentor)
Approved by: adrian (co-mentor)
Added:
head/usr.sbin/bsdconfig/include/bsdconfig.hlp (contents, props changed)
Modified:
head/usr.sbin/bsdconfig/bsdconfig
head/usr.sbin/bsdconfig/include/Makefile
head/usr.sbin/bsdconfig/include/messages.subr
head/usr.sbin/bsdconfig/share/common.subr
Modified: head/usr.sbin/bsdconfig/bsdconfig
==
--- head/usr.sbin/bsdconfig/bsdconfig Thu Oct 18 17:09:45 2012
(r241700)
+++ head/usr.sbin/bsdconfig/bsdconfig Thu Oct 18 18:43:54 2012
(r241701)
@@ -37,6 +37,7 @@ f_include $BSDCFG_SHARE/strings.subr
BSDCFG_LIBE=/usr/libexec/bsdconfig
f_include_lang $BSDCFG_LIBE/include/messages.subr
+f_include_help $BSDCFG_LIBE/include/bsdconfig.hlp
FUNCTIONS
@@ -185,6 +186,8 @@ dialog_menu_main()
--item-help \
--ok-label \\$msg_ok\ \
--cancel-label \\$msg_exit_bsdconfig\ \
+ --help-button \
+ ${USE_XDIALOG:+--help \\$( f_include_help )\} \
--menu \\$prompt\ $size $menu_list\
21 $DIALOG_TERMINAL_PASSTHRU_FD
)
@@ -286,8 +289,6 @@ if [ $1 ]; then
exec $cmd ${USE_XDIALOG:+-X} $@ || exit 1
fi
-[ -f $HOME/.bsdconfigrc ] || f_dialog_msgbox $msg_help_text
-
#
# Launch application main menu
#
@@ -297,7 +298,13 @@ while :; do
mtag=$( f_dialog_menutag )
f_dprintf retval=$retval mtag=[$mtag]
- [ $retval -eq 0 ] || f_die
+ if [ $retval -eq 2 ]; then
+ # The Help button was pressed
+ f_show_msg %s $( f_include_help )
+ continue
+ elif [ $retval -ne 0 ]; then
+ f_die
+ fi
case $mtag in
X) # Exit
Modified: head/usr.sbin/bsdconfig/include/Makefile
==
--- head/usr.sbin/bsdconfig/include/MakefileThu Oct 18 17:09:45 2012
(r241700)
+++ head/usr.sbin/bsdconfig/include/MakefileThu Oct 18 18:43:54 2012
(r241701)
@@ -3,7 +3,7 @@
NO_OBJ=
FILESDIR= ${LIBEXECDIR}/bsdconfig/include
-FILES= messages.subr
+FILES= bsdconfig.hlp messages.subr
beforeinstall:
mkdir -p ${DESTDIR}${FILESDIR}
Added: head/usr.sbin/bsdconfig/include/bsdconfig.hlp
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/usr.sbin/bsdconfig/include/bsdconfig.hlp Thu Oct 18 18:43:54
2012(r241701)
@@ -0,0 +1,12 @@
+This menu allows you to configure your system after the installation
+process is complete. At the minimum, you should probably set the root
+password and the system time zone.
+
+For extra goodies like bash, emacs, firefox, etc., you should look at
+the Packages item in this menu.
+
+For setting the timezone after the system is installed, use the 'Time
+Zone' item in this menu.
+
+For more information on the overall general system configuration, see
+the /etc/rc.conf and /etc/defaults/rc.conf files.
Modified: head/usr.sbin/bsdconfig/include/messages.subr
==
--- head/usr.sbin/bsdconfig/include/messages.subr Thu Oct 18 17:09:45
2012(r241700)
+++ head/usr.sbin/bsdconfig/include/messages.subr Thu Oct 18 18:43:54
2012(r241701)
@@ -38,7 +38,6 @@ msg_created_path=Created %s
msg_directory_not_found=%s: Directory not found.
msg_exit=Exit
msg_exit_bsdconfig=Exit bsdconfig
-msg_help_text=This menu allows you to configure your system after the
installation\nprocess is complete. At the minimum, you should probably set the
root\npassword and the system time zone.\n\nFor extra goodies like bash, emacs,
firefox, etc., you should look at the\n'Packages' item in this menu.\n\nFor
setting the timezone after the system is installed, use the 'Time\nZone' item
in this menu.\n\nFor more information on the overall general system
configuration, see the\n/etc/rc.conf and /etc/defaults/rc.conf files. (Note: to
Re: svn commit: r241701 - in head/usr.sbin/bsdconfig: . include share
On Thu, Oct 18, 2012 at 06:43:54PM +, Devin Teske wrote: NOTE: In FreeBSD-9 and higher, dialog(1) does not support the F1 hook, so the mechanism for providing help to the user had to be changed to a button. How come that new dialog(1) lacks functionality of the old one? ./danfe ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
