Re: svn commit: r255613 - head/sys/arm/arm

2013-09-17 Thread Zbigniew Bodek
2013/9/16 Ed Schouten e...@80386.nl

 2013/9/16 Zbigniew Bodek z...@freebsd.org:
  Log:
Fix GCC build error when building for ARMv6
 
Apply theravens's idea to move __strong_reference
macros into the proper ifdef section.
 
Approved by:  cognet (mentor)
Approved by:  re
 
  Modified:
head/sys/arm/arm/stdatomic.c

 For some reason, this still breaks the build of the AVILA kernel:

 Hello Ed,

You mean that this doesn't help for AVILA?
To be precise the patch is for ARMv6/v7 issues and AVILA is ARMv5te?

Nevertheless if the problem occurs for ARMs  v6 then another patch for
that needs to be done.

Best regards
Zbyszek
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r255613 - head/sys/arm/arm

2013-09-17 Thread Zbigniew Bodek
2013/9/17 Zbigniew Bodek z...@freebsd.org

 2013/9/16 Ed Schouten e...@80386.nl

 2013/9/16 Zbigniew Bodek z...@freebsd.org:
  Log:
Fix GCC build error when building for ARMv6
 
Apply theravens's idea to move __strong_reference
macros into the proper ifdef section.
 
Approved by:  cognet (mentor)
Approved by:  re
 
  Modified:
head/sys/arm/arm/stdatomic.c

 For some reason, this still breaks the build of the AVILA kernel:

 Hello Ed,

 You mean that this doesn't help for AVILA?
 To be precise the patch is for ARMv6/v7 issues and AVILA is ARMv5te?

 Nevertheless if the problem occurs for ARMs  v6 then another patch for
 that needs to be done.

 Best regards
 Zbyszek


Hello again Ed,

Can you test this one:
http://people.freebsd.org/~zbb/arm/other/stdatomic_fix_vol2.diff

Best regards
Zbyszek
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r255613 - head/sys/arm/arm

2013-09-17 Thread Ed Schouten
2013/9/17 Zbigniew Bodek z...@freebsd.org:
 Can you test this one:
 http://people.freebsd.org/~zbb/arm/other/stdatomic_fix_vol2.diff

Works. Thanks!

-- 
Ed Schouten e...@80386.nl
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


svn commit: r255613 - head/sys/arm/arm

2013-09-16 Thread Zbigniew Bodek
Author: zbb
Date: Mon Sep 16 10:46:58 2013
New Revision: 255613
URL: http://svnweb.freebsd.org/changeset/base/255613

Log:
  Fix GCC build error when building for ARMv6
  
  Apply theravens's idea to move __strong_reference
  macros into the proper ifdef section.
  
  Approved by:  cognet (mentor)
  Approved by:  re

Modified:
  head/sys/arm/arm/stdatomic.c

Modified: head/sys/arm/arm/stdatomic.c
==
--- head/sys/arm/arm/stdatomic.cMon Sep 16 10:39:35 2013
(r255612)
+++ head/sys/arm/arm/stdatomic.cMon Sep 16 10:46:58 2013
(r255613)
@@ -834,6 +834,10 @@ EMIT_ALL_OPS_N(1, uint8_t, ldrb, strb
 EMIT_ALL_OPS_N(2, uint16_t, ldrh, strh, streqh)
 EMIT_ALL_OPS_N(4, uint32_t, ldr, str, streq)
 
+#endif /* _KERNEL */
+
+#endif
+
 #ifndef __clang__
 __strong_reference(__sync_lock_test_and_set_1_c, __sync_lock_test_and_set_1);
 __strong_reference(__sync_lock_test_and_set_2_c, __sync_lock_test_and_set_2);
@@ -858,8 +862,4 @@ __strong_reference(__sync_fetch_and_xor_
 __strong_reference(__sync_fetch_and_xor_4_c, __sync_fetch_and_xor_4);
 #endif
 
-#endif /* _KERNEL */
-
-#endif
-
 #endif /* __SYNC_ATOMICS */
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org


Re: svn commit: r255613 - head/sys/arm/arm

2013-09-16 Thread Ed Schouten
2013/9/16 Zbigniew Bodek z...@freebsd.org:
 Log:
   Fix GCC build error when building for ARMv6

   Apply theravens's idea to move __strong_reference
   macros into the proper ifdef section.

   Approved by:  cognet (mentor)
   Approved by:  re

 Modified:
   head/sys/arm/arm/stdatomic.c

For some reason, this still breaks the build of the AVILA kernel:

/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:842: error:
'__sync_lock_test_and_set_1_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:842:
warning: type defaults to 'int' in declaration of
'__sync_lock_test_and_set_1'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:842: error:
'__sync_lock_test_and_set_1' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:843: error:
'__sync_lock_test_and_set_2_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:843:
warning: type defaults to 'int' in declaration of
'__sync_lock_test_and_set_2'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:843: error:
'__sync_lock_test_and_set_2' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:844: error:
'__sync_lock_test_and_set_4_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:844:
warning: type defaults to 'int' in declaration of
'__sync_lock_test_and_set_4'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:844: error:
'__sync_lock_test_and_set_4' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:845: error:
'__sync_val_compare_and_swap_1_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:845:
warning: type defaults to 'int' in declaration of
'__sync_val_compare_and_swap_1'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:845: error:
'__sync_val_compare_and_swap_1' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:846: error:
'__sync_val_compare_and_swap_2_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:846:
warning: type defaults to 'int' in declaration of
'__sync_val_compare_and_swap_2'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:846: error:
'__sync_val_compare_and_swap_2' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:847: error:
'__sync_val_compare_and_swap_4_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:847:
warning: type defaults to 'int' in declaration of
'__sync_val_compare_and_swap_4'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:847: error:
'__sync_val_compare_and_swap_4' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:848: error:
'__sync_fetch_and_add_1_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:848:
warning: type defaults to 'int' in declaration of
'__sync_fetch_and_add_1'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:848: error:
'__sync_fetch_and_add_1' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:849: error:
'__sync_fetch_and_add_2_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:849:
warning: type defaults to 'int' in declaration of
'__sync_fetch_and_add_2'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:849: error:
'__sync_fetch_and_add_2' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:850: error:
'__sync_fetch_and_add_4_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:850:
warning: type defaults to 'int' in declaration of
'__sync_fetch_and_add_4'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:850: error:
'__sync_fetch_and_add_4' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:851: error:
'__sync_fetch_and_and_1_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:851:
warning: type defaults to 'int' in declaration of
'__sync_fetch_and_and_1'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:851: error:
'__sync_fetch_and_and_1' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:852: error:
'__sync_fetch_and_and_2_c' undeclared here (not in a function)
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:852:
warning: type defaults to 'int' in declaration of
'__sync_fetch_and_and_2'
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:852: error:
'__sync_fetch_and_and_2' redeclared as different kind of symbol
/usr/edje/projects/freebsd-head-4/sys/arm/arm/stdatomic.c:853: error: