Re: svn commit: r272649 - head/contrib/byacc
On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin b...@freebsd.org wrote: On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin b...@freebsd.org wrote: Why a direct commit instead of a proper import of 20141005 version? it would have imho been better, simpler and easier to maintain. Because according to Thomas Dickey, he did not fix all the memory related problems in snapshot 20141005. Specifically there are still some issues not fixed when realloc() is called. I was going to wait for the next snapshot. However, I wanted to get that one fix into FreeBSD to fix the kyua tests, which have been failing under Jenkins. See: https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ (see runs #10 and #11). In that case I will import the new one which has the fix (do you confirm?) According to http://invisible-island.net/byacc/CHANGES.html , the 2014-10-06 has a fix to address my concerns. However, this fix involves a lot of changes to the code, and I don't have time right now to audit everything. There have been a lot of changes to the byacc code in the past few days. The changes are good bugfixes, but I would recommend auditing everything beore importing the snapshot into FreeBSD. -- Craig ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r272649 - head/contrib/byacc
On Wed, Oct 08, 2014 at 01:10:19PM -0700, Craig Rodrigues wrote: On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin b...@freebsd.org wrote: On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin b...@freebsd.org wrote: Why a direct commit instead of a proper import of 20141005 version? it would have imho been better, simpler and easier to maintain. Because according to Thomas Dickey, he did not fix all the memory related problems in snapshot 20141005. Specifically there are still some issues not fixed when realloc() is called. I was going to wait for the next snapshot. However, I wanted to get that one fix into FreeBSD to fix the kyua tests, which have been failing under Jenkins. See: https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ (see runs #10 and #11). In that case I will import the new one which has the fix (do you confirm?) According to http://invisible-island.net/byacc/CHANGES.html , the 2014-10-06 has a fix to address my concerns. However, this fix involves a lot of changes to the code, and I don't have time right now to audit everything. There have been a lot of changes to the byacc code in the past few days. The changes are good bugfixes, but I would recommend auditing everything beore importing the snapshot into FreeBSD. It has already been imported the only difference between the version in base since 2 days ago and the version upstream now is your change. regards, Bapt pgpHxJKxdJyTX.pgp Description: PGP signature
Re: svn commit: r272649 - head/contrib/byacc
On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin b...@freebsd.org wrote: Why a direct commit instead of a proper import of 20141005 version? it would have imho been better, simpler and easier to maintain. Because according to Thomas Dickey, he did not fix all the memory related problems in snapshot 20141005. Specifically there are still some issues not fixed when realloc() is called. I was going to wait for the next snapshot. However, I wanted to get that one fix into FreeBSD to fix the kyua tests, which have been failing under Jenkins. See: https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ (see runs #10 and #11). -- Craig ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r272649 - head/contrib/byacc
On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin b...@freebsd.org wrote: Why a direct commit instead of a proper import of 20141005 version? it would have imho been better, simpler and easier to maintain. Because according to Thomas Dickey, he did not fix all the memory related problems in snapshot 20141005. Specifically there are still some issues not fixed when realloc() is called. I was going to wait for the next snapshot. However, I wanted to get that one fix into FreeBSD to fix the kyua tests, which have been failing under Jenkins. See: https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ (see runs #10 and #11). In that case I will import the new one which has the fix (do you confirm?) Best regards, Bapt pgpdulM1jocbi.pgp Description: PGP signature
svn commit: r272649 - head/contrib/byacc
Author: rodrigc Date: Mon Oct 6 14:43:02 2014 New Revision: 272649 URL: https://svnweb.freebsd.org/changeset/base/272649 Log: MFV: use calloc in get_line() when allocating line to ensure it is fully initialized, fixes a later uninitialized value in copy_param() (FreeBSD #193499). PR: 193499 Submitted by: Thomas E. Dickey t...@invisible-island.net Modified: head/contrib/byacc/CHANGES head/contrib/byacc/defs.h head/contrib/byacc/reader.c Modified: head/contrib/byacc/CHANGES == --- head/contrib/byacc/CHANGES Mon Oct 6 14:39:45 2014(r272648) +++ head/contrib/byacc/CHANGES Mon Oct 6 14:43:02 2014(r272649) @@ -1,3 +1,9 @@ +2014-10-02 Thomas E. Dickey t...@invisible-island.net + + * reader.c, defs.h: + use calloc in get_line() when allocating line to ensure it is fully initialized, + fixes a later uninitialized value in copy_param() (FreeBSD #193499). + 2014-07-15 Thomas E. Dickey t...@invisible-island.net * aclocal.m4: resync with my-autoconf (no change to configure script) Modified: head/contrib/byacc/defs.h == --- head/contrib/byacc/defs.h Mon Oct 6 14:39:45 2014(r272648) +++ head/contrib/byacc/defs.h Mon Oct 6 14:43:02 2014(r272649) @@ -157,6 +157,7 @@ #define CALLOC(k,n)(calloc((size_t)(k),(size_t)(n))) #defineFREE(x) (free((char*)(x))) #define MALLOC(n) (malloc((size_t)(n))) +#define TCMALLOC(t,n) ((t*) calloc((size_t)(n), sizeof(t))) #define TMALLOC(t,n) ((t*) malloc((size_t)(n) * sizeof(t))) #defineNEW(t) ((t*)allocate(sizeof(t))) #defineNEW2(n,t) ((t*)allocate(((size_t)(n)*sizeof(t Modified: head/contrib/byacc/reader.c == --- head/contrib/byacc/reader.c Mon Oct 6 14:39:45 2014(r272648) +++ head/contrib/byacc/reader.c Mon Oct 6 14:43:02 2014(r272649) @@ -125,7 +125,7 @@ get_line(void) if (line) FREE(line); linesize = LINESIZE + 1; - line = TMALLOC(char, linesize); + line = TCMALLOC(char, linesize); NO_SPACE(line); } ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r272649 - head/contrib/byacc
On Mon, Oct 06, 2014 at 02:43:02PM +, Craig Rodrigues wrote: Author: rodrigc Date: Mon Oct 6 14:43:02 2014 New Revision: 272649 URL: https://svnweb.freebsd.org/changeset/base/272649 Log: MFV: use calloc in get_line() when allocating line to ensure it is fully initialized, fixes a later uninitialized value in copy_param() (FreeBSD #193499). PR: 193499 Submitted by: Thomas E. Dickey t...@invisible-island.net Why a direct commit instead of a proper import of 20141005 version? it would have imho been better, simpler and easier to maintain. regards, Bapt pgpNhZHpo9u8S.pgp Description: PGP signature
