Re: svn commit: r273919 - head/etc/rc.d
Garrett Cooper yaneurab...@gmail.com writes: rcorder errors are indeed cryptic/confusing. I can quickly add a testcase for this if you like (basically check for all the scenarios that need to be covered via /etc/rc). Does that sound good? Yes, that sounds great. I'll look into adding a loop detection and reporting mode to rcorder so we can get a better error message. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r273919 - head/etc/rc.d
Author: delphij Date: Fri Oct 31 22:20:27 2014 New Revision: 273919 URL: https://svnweb.freebsd.org/changeset/base/273919 Log: rc.d/geli should not depend on random, as the attach functionality do not require additional entropy to function. It would create a circular dependency (not immediately obvious: geli provides 'disks' and requires 'random' as of r273872, 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', 'root' requires 'swap', and finally 'swap' requires 'disk'). Modified: head/etc/rc.d/geli Modified: head/etc/rc.d/geli == --- head/etc/rc.d/geli Fri Oct 31 19:26:12 2014(r273918) +++ head/etc/rc.d/geli Fri Oct 31 22:20:27 2014(r273919) @@ -28,7 +28,6 @@ # # PROVIDE: disks -# REQUIRE: random # KEYWORD: nojail . /etc/rc.subr ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r273919 - head/etc/rc.d
Xin LI delp...@freebsd.org writes: Log: rc.d/geli should not depend on random, as the attach functionality do not require additional entropy to function. It would create a circular dependency (not immediately obvious: geli provides 'disks' and requires 'random' as of r273872, 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', 'root' requires 'swap', and finally 'swap' requires 'disk'). My first instinct was: shouldn't rcorder warn about this? It turns out that it does, but in a very cryptic fashion: des@nine ~head/etc/rc.d% svn up -qr273871 des@nine ~head/etc/rc.d% rcorder * /dev/null des@nine ~head/etc/rc.d% svn up -qr273872 des@nine ~head/etc/rc.d% rcorder * /dev/null rcorder: Circular dependency on file `zfs'. rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'. rcorder: Circular dependency on provision `mountcritlocal' in file `var'. rcorder: Circular dependency on provision `mountcritlocal' in file `FILESYSTEMS'. rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'. des@nine ~head/etc/rc.d% svn up -qr273919 des@nine ~head/etc/rc.d% rcorder * /dev/null des@nine ~head/etc/rc.d% DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r273919 - head/etc/rc.d
On Oct 31, 2014, at 17:51, Dag-Erling Smørgrav d...@des.no wrote: Xin LI delp...@freebsd.org writes: Log: rc.d/geli should not depend on random, as the attach functionality do not require additional entropy to function. It would create a circular dependency (not immediately obvious: geli provides 'disks' and requires 'random' as of r273872, 'random' requires 'FILESYSTEMS', 'FILESYSTEMS' requires 'root', 'root' requires 'swap', and finally 'swap' requires 'disk'). My first instinct was: shouldn't rcorder warn about this? It turns out that it does, but in a very cryptic fashion: des@nine ~head/etc/rc.d% svn up -qr273871 des@nine ~head/etc/rc.d% rcorder * /dev/null des@nine ~head/etc/rc.d% svn up -qr273872 des@nine ~head/etc/rc.d% rcorder * /dev/null rcorder: Circular dependency on file `zfs'. rcorder: Circular dependency on provision `mountcritlocal' in file `zfs'. rcorder: Circular dependency on provision `mountcritlocal' in file `var'. rcorder: Circular dependency on provision `mountcritlocal' in file `FILESYSTEMS'. rcorder: Circular dependency on provision `root' in file `FILESYSTEMS'. des@nine ~head/etc/rc.d% svn up -qr273919 des@nine ~head/etc/rc.d% rcorder * /dev/null des@nine ~head/etc/rc.d% rcorder errors are indeed cryptic/confusing. I can quickly add a testcase for this if you like (basically check for all the scenarios that need to be covered via /etc/rc). Does that sound good? Thanks! signature.asc Description: Message signed with OpenPGP using GPGMail
