Re: svn commit: r288362 - head/sys/cddl/dev/sdt

2015-10-02 Thread Andriy Gapon 
On 02/10/2015 20:54, Rui Paulo wrote:
> On Tue, 2015-09-29 at 11:58 +, Andriy Gapon wrote:
>> Author: avg
>> Date: Tue Sep 29 11:58:21 2015
>> New Revision: 288362
>> URL: https://svnweb.freebsd.org/changeset/base/288362
>>
>> Log:
>>   sdt: start checking version field when parsing probe definitions
>>   
>>   This is an extra safety measure.
>>   
>>   MFC after: 21 days
>>
>> Modified:
>>   head/sys/cddl/dev/sdt/sdt.c
>>
>> Modified: head/sys/cddl/dev/sdt/sdt.c
>> =
>> =
>> --- head/sys/cddl/dev/sdt/sdt.c  Tue Sep 29 11:55:26 2015
>> (r288361)
>> +++ head/sys/cddl/dev/sdt/sdt.c  Tue Sep 29 11:58:21 2015
>> (r288362)
>> @@ -141,6 +141,12 @@ sdt_create_probe(struct sdt_probe *probe
>>  char *to;
>>  size_t len;
>>  
>> +if (probe->version != (int)sizeof(*probe)) {
>> +printf("ignoring probe %p, version %u expected
>> %u\n",
>> +probe, probe->version, (int)sizeof(*probe));
>> +return;
>> +}
>> +
>>
> 
> Not picking on your change, but this version management sounds like a
> bad idea to me...
> 

It's certainly not very robust, but I think that it's better than nothing.
Having proper SDT binary layout versions would be better, of course.

-- 
Andriy Gapon
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r288362 - head/sys/cddl/dev/sdt

2015-10-02 Thread Rui Paulo 
On Tue, 2015-09-29 at 11:58 +, Andriy Gapon wrote:
> Author: avg
> Date: Tue Sep 29 11:58:21 2015
> New Revision: 288362
> URL: https://svnweb.freebsd.org/changeset/base/288362
> 
> Log:
>   sdt: start checking version field when parsing probe definitions
>   
>   This is an extra safety measure.
>   
>   MFC after:  21 days
> 
> Modified:
>   head/sys/cddl/dev/sdt/sdt.c
> 
> Modified: head/sys/cddl/dev/sdt/sdt.c
> =
> =
> --- head/sys/cddl/dev/sdt/sdt.c   Tue Sep 29 11:55:26 2015
> (r288361)
> +++ head/sys/cddl/dev/sdt/sdt.c   Tue Sep 29 11:58:21 2015
> (r288362)
> @@ -141,6 +141,12 @@ sdt_create_probe(struct sdt_probe *probe
>   char *to;
>   size_t len;
>  
> + if (probe->version != (int)sizeof(*probe)) {
> + printf("ignoring probe %p, version %u expected
> %u\n",
> + probe, probe->version, (int)sizeof(*probe));
> + return;
> + }
> +
> 

Not picking on your change, but this version management sounds like a
bad idea to me...

-- 
Rui Paulo

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r288362 - head/sys/cddl/dev/sdt

2015-09-29 Thread Andriy Gapon 
Author: avg
Date: Tue Sep 29 11:58:21 2015
New Revision: 288362
URL: https://svnweb.freebsd.org/changeset/base/288362

Log:
  sdt: start checking version field when parsing probe definitions
  
  This is an extra safety measure.
  
  MFC after:21 days

Modified:
  head/sys/cddl/dev/sdt/sdt.c

Modified: head/sys/cddl/dev/sdt/sdt.c
==
--- head/sys/cddl/dev/sdt/sdt.c Tue Sep 29 11:55:26 2015(r288361)
+++ head/sys/cddl/dev/sdt/sdt.c Tue Sep 29 11:58:21 2015(r288362)
@@ -141,6 +141,12 @@ sdt_create_probe(struct sdt_probe *probe
char *to;
size_t len;
 
+   if (probe->version != (int)sizeof(*probe)) {
+   printf("ignoring probe %p, version %u expected %u\n",
+   probe, probe->version, (int)sizeof(*probe));
+   return;
+   }
+
TAILQ_FOREACH(prov, _prov_list, prov_entry)
if (strcmp(prov->name, probe->prov->name) == 0)
break;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"