Re: svn commit: r290828 - head/sys/net

[Alexander V . Chernikov]

Well, initially it was my mistake :) Anyway, AF_UNSPEC was better than 
non-deterministic "i".
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r290828 - head/sys/net

[Alexander V. Chernikov]

Author: melifaro
Date: Sat Nov 14 18:16:17 2015
New Revision: 290828
URL: https://svnweb.freebsd.org/changeset/base/290828

Log:
  Pass provided af instead of AF_UNSPEC to setwa_f callback.

Modified:
  head/sys/net/route.c

Modified: head/sys/net/route.c
==
--- head/sys/net/route.cSat Nov 14 17:32:38 2015(r290827)
+++ head/sys/net/route.cSat Nov 14 18:16:17 2015(r290828)
@@ -845,7 +845,7 @@ rt_foreach_fib_walk(int af, rt_setwarg_t
if (rnh == NULL)
continue;
if (setwa_f != NULL)
-   setwa_f(rnh, fibnum, AF_UNSPEC, arg);
+   setwa_f(rnh, fibnum, af, arg);
 
RADIX_NODE_HEAD_LOCK(rnh);
rnh->rnh_walktree(rnh, (walktree_f_t *)wa_f, arg);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r290828 - head/sys/net

[Bryan Drewery]

On 11/14/2015 10:16 AM, Alexander V. Chernikov wrote:
> Author: melifaro
> Date: Sat Nov 14 18:16:17 2015
> New Revision: 290828
> URL: https://svnweb.freebsd.org/changeset/base/290828
> 
> Log:
>   Pass provided af instead of AF_UNSPEC to setwa_f callback.
> 
> Modified:
>   head/sys/net/route.c
> 
> Modified: head/sys/net/route.c
> ==
> --- head/sys/net/route.c  Sat Nov 14 17:32:38 2015(r290827)
> +++ head/sys/net/route.c  Sat Nov 14 18:16:17 2015(r290828)
> @@ -845,7 +845,7 @@ rt_foreach_fib_walk(int af, rt_setwarg_t
>   if (rnh == NULL)
>   continue;
>   if (setwa_f != NULL)
> - setwa_f(rnh, fibnum, AF_UNSPEC, arg);
> + setwa_f(rnh, fibnum, af, arg);
>  
>   RADIX_NODE_HEAD_LOCK(rnh);
>   rnh->rnh_walktree(rnh, (walktree_f_t *)wa_f, arg);
> 

Ah damn. I mis-read the 'if' a few lines up when fixing the coverity
warning. Sorry about that. At least none of the callbacks were using it yet.

-- 
Regards,
Bryan Drewery



signature.asc
Description: OpenPGP digital signature