Re: svn commit: r308230 - head/sys/dev/ioat

[Conrad Meyer]

Nope.

On Mon, Nov 7, 2016 at 12:17 PM, Ngie Cooper  wrote:
> On Wed, Nov 2, 2016 at 4:18 PM, Conrad E. Meyer  wrote:
>> Author: cem
>> Date: Wed Nov  2 23:18:16 2016
>> New Revision: 308230
>> URL: https://svnweb.freebsd.org/changeset/base/308230
>>
>> Log:
>>   ioat(4): Read CHANSTS register for suspended/halted checks
>>
>>   The device doesn't accurately update the CHANCMP address with the device 
>> state
>>   when the device is suspended or halted.  So, read the CHANSTS register to 
>> check
>>   for those states.
>>
>>   We still need to read the CHANCMP address for the last completed 
>> descriptor.
>>
>>   Sponsored by: Dell EMC Isilon
>
> Did anyone review this change, either external or internal to Isilon?
> Thanks,
> -Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r308230 - head/sys/dev/ioat

[Ngie Cooper]

On Wed, Nov 2, 2016 at 4:18 PM, Conrad E. Meyer  wrote:
> Author: cem
> Date: Wed Nov  2 23:18:16 2016
> New Revision: 308230
> URL: https://svnweb.freebsd.org/changeset/base/308230
>
> Log:
>   ioat(4): Read CHANSTS register for suspended/halted checks
>
>   The device doesn't accurately update the CHANCMP address with the device 
> state
>   when the device is suspended or halted.  So, read the CHANSTS register to 
> check
>   for those states.
>
>   We still need to read the CHANCMP address for the last completed descriptor.
>
>   Sponsored by: Dell EMC Isilon

Did anyone review this change, either external or internal to Isilon?
Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r308230 - head/sys/dev/ioat

[Conrad E. Meyer]

Author: cem
Date: Wed Nov  2 23:18:16 2016
New Revision: 308230
URL: https://svnweb.freebsd.org/changeset/base/308230

Log:
  ioat(4): Read CHANSTS register for suspended/halted checks
  
  The device doesn't accurately update the CHANCMP address with the device state
  when the device is suspended or halted.  So, read the CHANSTS register to 
check
  for those states.
  
  We still need to read the CHANCMP address for the last completed descriptor.
  
  Sponsored by: Dell EMC Isilon

Modified:
  head/sys/dev/ioat/ioat.c

Modified: head/sys/dev/ioat/ioat.c
==
--- head/sys/dev/ioat/ioat.cWed Nov  2 22:33:37 2016(r308229)
+++ head/sys/dev/ioat/ioat.cWed Nov  2 23:18:16 2016(r308230)
@@ -747,6 +747,12 @@ out:
wakeup(>tail);
}
 
+   /*
+* The device doesn't seem to reliably push suspend/halt statuses to
+* the channel completion memory address, so poll the device register
+* here.
+*/
+   comp_update = ioat_get_chansts(ioat) & IOAT_CHANSTS_STATUS;
if (!is_ioat_halted(comp_update) && !is_ioat_suspended(comp_update))
return;
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"