Re: svn commit: r309344 - head/lib/libutil

[Ngie Cooper]

On Thu, Dec 1, 2016 at 10:32 AM, Ian Lepore  wrote:
...
> And how is that a bad thing, compared to the prior situation?  Insult
> has been removed and information has been added.  You complain that the
> information that was added was incomplete.  Well, there is one person
> who could fix that, and he has apparently chosen not to.  So perhaps
> your ongoing complaint should be directed accordingly.

Maybe.

But this is a useless bikeshed.

I've said my piece.

-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309344 - head/lib/libutil

[Ian Lepore]

On Thu, 2016-12-01 at 09:33 -0800, Ngie Cooper (yaneurabeya) wrote:
> > 
> > On Dec 1, 2016, at 9:01 AM, Mark Linimon 
> > wrote:
> > 
> > On Thu, Dec 01, 2016 at 09:32:07AM -0700, Ian Lepore wrote:
> > > 
> > > On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote:
> > > > 
> > > > Really?? I wish you hadn't added me to this list.. I don't in
> > > > any way
> > > > endorse the way that you went about dealing with this
> > > > disagreement.
> > > Really?  Well then feel free to ADD my name to the list of people
> > > who
> > > found that comment, and the subsequent non-response to the
> > > complaints
> > > about it, completely inappropriate.  
> > I expressed an opinion on an IRC channel that I found the comment
> > offensive.
> > 
> > But I would rather my permission had been asked ahead of time
> > before
> > having that comment attached to a public commit log.  I think this
> > is
> > part of the point that ngie is trying to make.
> > 
> > I'm well-known for my wish that core took a more active, public,
> > stance
> > on such matters, but I think here that two wrongs may not have made
> > a
> > right.
> Yes.
> 
> And more importantly, the new comment doesn’t tell me *why* I
> shouldn’t use FD_CLOEXEC. The owness is still on the reader to figure
> out why using `fcntl(fd, F_SETFD, FD_CLOEXEC)` is wrong.
> 
> All the new commit does is makes the commit that des@ made more
> palatable and benign to readers.

And how is that a bad thing, compared to the prior situation?  Insult
has been removed and information has been added.  You complain that the
information that was added was incomplete.  Well, there is one person
who could fix that, and he has apparently chosen not to.  So perhaps
your ongoing complaint should be directed accordingly.

-- Ian

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309344 - head/lib/libutil

[Ngie Cooper (yaneurabeya)]

> On Dec 1, 2016, at 9:01 AM, Mark Linimon  wrote:
> 
> On Thu, Dec 01, 2016 at 09:32:07AM -0700, Ian Lepore wrote:
>> On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote:
>>> Really?? I wish you hadn't added me to this list.. I don't in any way
>>> endorse the way that you went about dealing with this disagreement.
>> 
>> Really?  Well then feel free to ADD my name to the list of people who
>> found that comment, and the subsequent non-response to the complaints
>> about it, completely inappropriate.  
> 
> I expressed an opinion on an IRC channel that I found the comment
> offensive.
> 
> But I would rather my permission had been asked ahead of time before
> having that comment attached to a public commit log.  I think this is
> part of the point that ngie is trying to make.
> 
> I'm well-known for my wish that core took a more active, public, stance
> on such matters, but I think here that two wrongs may not have made a
> right.

Yes.

And more importantly, the new comment doesn’t tell me *why* I shouldn’t use 
FD_CLOEXEC. The owness is still on the reader to figure out why using 
`fcntl(fd, F_SETFD, FD_CLOEXEC)` is wrong.

All the new commit does is makes the commit that des@ made more palatable and 
benign to readers.

Thanks,
-Ngie
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309344 - head/lib/libutil

[Mark Linimon]

On Thu, Dec 01, 2016 at 09:32:07AM -0700, Ian Lepore wrote:
> On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote:
> > Really?? I wish you hadn't added me to this list.. I don't in any way
> > endorse the way that you went about dealing with this disagreement.
> 
> Really?  Well then feel free to ADD my name to the list of people who
> found that comment, and the subsequent non-response to the complaints
> about it, completely inappropriate.  

I expressed an opinion on an IRC channel that I found the comment
offensive.

But I would rather my permission had been asked ahead of time before
having that comment attached to a public commit log.  I think this is
part of the point that ngie is trying to make.

I'm well-known for my wish that core took a more active, public, stance
on such matters, but I think here that two wrongs may not have made a
right.

mcl
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309344 - head/lib/libutil

[Ian Lepore]

On Wed, 2016-11-30 at 19:07 -0800, Ngie Cooper wrote:
> > 
> > On Nov 30, 2016, at 18:21, Conrad E. Meyer  wrote:
> > 
> > Author: cem
> > Date: Thu Dec  1 02:21:36 2016
> > New Revision: 309344
> > URL: https://svnweb.freebsd.org/changeset/base/309344
> > 
> > Log:
> >  Remove a death threat from the FreeBSD sources
> > 
> >  Reported by:koobs@, araujo@, linimon@, bjk@, emaste@, jhb@,
> > ngie@, cem@
> >  Maintainer timeout:des@
> Really?? I wish you hadn't added me to this list.. I don't in any way
> endorse the way that you went about dealing with this disagreement.
> You kind of just pissed all over what des@ did out of spite.
> 
> 

Really?  Well then feel free to ADD my name to the list of people who
found that comment, and the subsequent non-response to the complaints
about it, completely inappropriate.  

-- Ian


> > 
> > 
> > Modified:
> >  head/lib/libutil/flopen.c
> > 
> > Modified: head/lib/libutil/flopen.c
> > ===
> > ===
> > --- head/lib/libutil/flopen.cThu Dec  1 01:56:34
> > 2016(r309343)
> > +++ head/lib/libutil/flopen.cThu Dec  1 02:21:36
> > 2016(r309344)
> > @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$");
> > /*
> >  * Reliably open and lock a file.
> >  *
> > - * DO NOT, UNDER PAIN OF DEATH, modify this code without first
> > reading the
> > - * revision history and discussing your changes with  > org>.
> > - * Don't be fooled by the code's apparent simplicity; there would
> > be no
> > - * need for this function if it was as easy to get right as you
> > think.
> > + * Please do not modify this code without first reading the
> > revision history
> > + * and discussing your changes with .  Don't be
> > fooled by the
> > + * code's apparent simplicity; there would be no need for this
> > function if it
> > + * was easy to get right.
> >  */
> > int
> > flopen(const char *path, int flags, ...)
> > @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...)
> >    errno = serrno;
> >    return (-1);
> >    }
> > -#ifdef DONT_EVEN_THINK_ABOUT_IT
> > +/*
> > + * The following change is provided as a specific example
> > to
> > + * avoid.
> > + */
> > +#if 0
> >    if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) {
> >    serrno = errno;
> >    (void)close(fd);
> > 
> 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r309344 - head/lib/libutil

[Ngie Cooper]

> On Nov 30, 2016, at 18:21, Conrad E. Meyer  wrote:
> 
> Author: cem
> Date: Thu Dec  1 02:21:36 2016
> New Revision: 309344
> URL: https://svnweb.freebsd.org/changeset/base/309344
> 
> Log:
>  Remove a death threat from the FreeBSD sources
> 
>  Reported by:koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, ngie@, cem@
>  Maintainer timeout:des@

Really?? I wish you hadn't added me to this list.. I don't in any way endorse 
the way that you went about dealing with this disagreement. You kind of just 
pissed all over what des@ did out of spite.


> Modified:
>  head/lib/libutil/flopen.c
> 
> Modified: head/lib/libutil/flopen.c
> ==
> --- head/lib/libutil/flopen.cThu Dec  1 01:56:34 2016(r309343)
> +++ head/lib/libutil/flopen.cThu Dec  1 02:21:36 2016(r309344)
> @@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$");
> /*
>  * Reliably open and lock a file.
>  *
> - * DO NOT, UNDER PAIN OF DEATH, modify this code without first reading the
> - * revision history and discussing your changes with .
> - * Don't be fooled by the code's apparent simplicity; there would be no
> - * need for this function if it was as easy to get right as you think.
> + * Please do not modify this code without first reading the revision history
> + * and discussing your changes with .  Don't be fooled by 
> the
> + * code's apparent simplicity; there would be no need for this function if it
> + * was easy to get right.
>  */
> int
> flopen(const char *path, int flags, ...)
> @@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...)
>errno = serrno;
>return (-1);
>}
> -#ifdef DONT_EVEN_THINK_ABOUT_IT
> +/*
> + * The following change is provided as a specific example to
> + * avoid.
> + */
> +#if 0
>if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) {
>serrno = errno;
>(void)close(fd);
> 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r309344 - head/lib/libutil

[Conrad E. Meyer]

Author: cem
Date: Thu Dec  1 02:21:36 2016
New Revision: 309344
URL: https://svnweb.freebsd.org/changeset/base/309344

Log:
  Remove a death threat from the FreeBSD sources
  
  Reported by:  koobs@, araujo@, linimon@, bjk@, emaste@, jhb@, ngie@, cem@
  Maintainer timeout:   des@

Modified:
  head/lib/libutil/flopen.c

Modified: head/lib/libutil/flopen.c
==
--- head/lib/libutil/flopen.c   Thu Dec  1 01:56:34 2016(r309343)
+++ head/lib/libutil/flopen.c   Thu Dec  1 02:21:36 2016(r309344)
@@ -40,10 +40,10 @@ __FBSDID("$FreeBSD$");
 /*
  * Reliably open and lock a file.
  *
- * DO NOT, UNDER PAIN OF DEATH, modify this code without first reading the
- * revision history and discussing your changes with .
- * Don't be fooled by the code's apparent simplicity; there would be no
- * need for this function if it was as easy to get right as you think.
+ * Please do not modify this code without first reading the revision history
+ * and discussing your changes with .  Don't be fooled by the
+ * code's apparent simplicity; there would be no need for this function if it
+ * was easy to get right.
  */
 int
 flopen(const char *path, int flags, ...)
@@ -108,7 +108,11 @@ flopen(const char *path, int flags, ...)
errno = serrno;
return (-1);
}
-#ifdef DONT_EVEN_THINK_ABOUT_IT
+   /*
+* The following change is provided as a specific example to
+* avoid.
+*/
+#if 0
if (fcntl(fd, F_SETFD, FD_CLOEXEC) != 0) {
serrno = errno;
(void)close(fd);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"