Re: svn commit: r317632 - head/sys

[Ngie Cooper (yaneurabeya)]

> On May 1, 2017, at 09:34, Warner Losh  wrote:
> 
> On Mon, May 1, 2017 at 10:30 AM, Rodney W. Grimes
>  wrote:
>>> Author: ngie
>>> Date: Mon May  1 05:59:52 2017
>>> New Revision: 317632
>>> URL: https://svnweb.freebsd.org/changeset/base/317632
>>> 
>>> Log:
>>>  Fix "make cscope-clean" when .OBJDIR already exists
>>> 
>>>  The cscope generated files are always put in .CURDIR .
>> 
>> If this is writing to src dir then it should be fixed,
>> or have we abandoned all hope of readonly src tree?
> 
> This is only for the cscope target, which isn't part of the normal build.
> 
> readonly src tree works great still….

Hi Rod,
I can’t personally vouch for readonly src trees working in all cases, 
but readonly src trees work well for installation purposes (I use readonly obj 
and src trees at work when installing over NFS).
As Warner noted, “make cscope” is a developer target that aids with 
building the cscope database in a consistent manner. It doesn’t conform to the 
existing “norms” of build targets in the tree; changing the behavior doesn’t 
seem prudent at this point in time because it would violate POLA.
Thanks!
-Ngie


signature.asc
Description: Message signed with OpenPGP using GPGMail

Re: svn commit: r317632 - head/sys

[Warner Losh]

On Mon, May 1, 2017 at 10:30 AM, Rodney W. Grimes
 wrote:
>> Author: ngie
>> Date: Mon May  1 05:59:52 2017
>> New Revision: 317632
>> URL: https://svnweb.freebsd.org/changeset/base/317632
>>
>> Log:
>>   Fix "make cscope-clean" when .OBJDIR already exists
>>
>>   The cscope generated files are always put in .CURDIR .
>
> If this is writing to src dir then it should be fixed,
> or have we abandoned all hope of readonly src tree?

This is only for the cscope target, which isn't part of the normal build.

readonly src tree works great still

Warner
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r317632 - head/sys

[Rodney W. Grimes]

> Author: ngie
> Date: Mon May  1 05:59:52 2017
> New Revision: 317632
> URL: https://svnweb.freebsd.org/changeset/base/317632
> 
> Log:
>   Fix "make cscope-clean" when .OBJDIR already exists
>   
>   The cscope generated files are always put in .CURDIR .

If this is writing to src dir then it should be fixed,
or have we abandoned all hope of readonly src tree?

>   MFC after:  1 month
>   Sponsored by:   Dell EMC Isilon
> 
> Modified:
>   head/sys/Makefile
> 
> Modified: head/sys/Makefile
> ==
> --- head/sys/Makefile Mon May  1 05:54:33 2017(r317631)
> +++ head/sys/Makefile Mon May  1 05:59:52 2017(r317632)
> @@ -32,7 +32,8 @@ ${.CURDIR}/cscope.files: .PHONY
>   find ${CSCOPEDIRS} -name "*.[chSsly]" -a -type f > ${.TARGET}
>  
>  cscope-clean:
> - rm -f cscope.files cscope.out cscope.in.out cscope.po.out
> + cd ${.CURDIR}; \
> + rm -f cscope.files cscope.out cscope.in.out cscope.po.out
>  
>  #
>  # Installs SCM hooks to update the cscope database every time the source tree
> 
> 

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r317632 - head/sys

[Ngie Cooper]

Author: ngie
Date: Mon May  1 05:59:52 2017
New Revision: 317632
URL: https://svnweb.freebsd.org/changeset/base/317632

Log:
  Fix "make cscope-clean" when .OBJDIR already exists
  
  The cscope generated files are always put in .CURDIR .
  
  MFC after:1 month
  Sponsored by: Dell EMC Isilon

Modified:
  head/sys/Makefile

Modified: head/sys/Makefile
==
--- head/sys/Makefile   Mon May  1 05:54:33 2017(r317631)
+++ head/sys/Makefile   Mon May  1 05:59:52 2017(r317632)
@@ -32,7 +32,8 @@ ${.CURDIR}/cscope.files: .PHONY
find ${CSCOPEDIRS} -name "*.[chSsly]" -a -type f > ${.TARGET}
 
 cscope-clean:
-   rm -f cscope.files cscope.out cscope.in.out cscope.po.out
+   cd ${.CURDIR}; \
+   rm -f cscope.files cscope.out cscope.in.out cscope.po.out
 
 #
 # Installs SCM hooks to update the cscope database every time the source tree
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"