Re: svn commit: r318354 - head/sys/amd64/amd64

2017-05-16 Thread Ngie Cooper (yaneurabeya) 

> On May 16, 2017, at 9:20 AM, Conrad Meyer  wrote:
> 
> Author: cem
> Date: Tue May 16 16:20:22 2017
> New Revision: 318354
> URL: https://svnweb.freebsd.org/changeset/base/318354
> 
> Log:
>  Correct page frame mask constant used in pmap_change_attr_locked
> 
>  This was introduced in r290156.  It's present in 11.0, but not any 10.x
>  release unless someone decided to MFC it.

Hi Conrad,
It wasn’t MFCed according to 
https://svnweb.freebsd.org/base/stable/10/sys/amd64/amd64/pmap.c 
, so that’s 
ok.
Could you please MFC this change since you understand it/made it?
Thank you,
-Ngie


signature.asc
Description: Message signed with OpenPGP

svn commit: r318354 - head/sys/amd64/amd64

2017-05-16 Thread Conrad Meyer 
Author: cem
Date: Tue May 16 16:20:22 2017
New Revision: 318354
URL: https://svnweb.freebsd.org/changeset/base/318354

Log:
  Correct page frame mask constant used in pmap_change_attr_locked
  
  This was introduced in r290156.  It's present in 11.0, but not any 10.x
  release unless someone decided to MFC it.
  
  It affects ordinary pages right above the DMAP limit, which is effectively
  system memory rounded up to a 1 GB (3rd level superpage) boundary (or up to
  a minimum of 4 GB, on small systems).
  
  Reported by:  vangyzen
  Reviewed by:  kib, alc
  Sponsored by: Dell EMC Isilon
  Differential Revision:https://reviews.freebsd.org/D4030

Modified:
  head/sys/amd64/amd64/pmap.c

Modified: head/sys/amd64/amd64/pmap.c
==
--- head/sys/amd64/amd64/pmap.c Tue May 16 14:21:37 2017(r318353)
+++ head/sys/amd64/amd64/pmap.c Tue May 16 16:20:22 2017(r318354)
@@ -6691,7 +6691,7 @@ pmap_change_attr_locked(vm_offset_t va, 
changed = TRUE;
}
if (tmpva >= VM_MIN_KERNEL_ADDRESS &&
-   (*pte & PG_PS_FRAME) < dmaplimit) {
+   (*pte & PG_FRAME) < dmaplimit) {
if (pa_start == pa_end) {
/* Start physical address run. */
pa_start = *pte & PG_FRAME;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"