Re: svn commit: r321080 - head/usr.bin/getconf
> You timed out because you never answered my question about other platforms. Hi Warner, I thought I answered your questions here: https://reviews.freebsd.org/D10787#224691 ? If not, I would be more than happy to run the tests on other platforms once I gain access to them. I only have access to x86 platforms and made an educated guess on what should be done based on grep’ing around the source tree, googling, and finding Linux mailing list posts suggesting our copy of getconf(1) wasn’t supporting all of the platforms it should have been. Thank you, -Ngie signature.asc Description: Message signed with OpenPGP using GPGMail
Re: svn commit: r321080 - head/usr.bin/getconf
On Mon, Jul 17, 2017 at 12:12 PM, Ngie Cooper wrote: > Author: ngie > Date: Mon Jul 17 18:12:08 2017 > New Revision: 321080 > URL: https://svnweb.freebsd.org/changeset/base/321080 > > Log: > Expose the ILP32/LP64 programming environments based on > __ILP32__/__LP64__ instead of by architecture. > > The list was incomplete (previous commits purged invalid architectures, > like __alpha__, but failed to add new ones). It's best to base the symbol > presence on whether or not the architecture is ILP32 / LP64 capable, per > the compiler. > > This fixes the ILP32/LP64 program environments on some architectures like > arm64, and by proxy fixes the tests on those architectures. > > MFC after:1 month > Reviewed by: no one (timed out on feedback from imp) > You timed out because you never answered my question about other platforms. Warner > Differential Revision:D10787 > > Modified: > head/usr.bin/getconf/progenv.gperf > > Modified: head/usr.bin/getconf/progenv.gperf > > == > --- head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:07:53 2017 > (r321079) > +++ head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:12:08 2017 > (r321080) > @@ -30,11 +30,11 @@ static const struct map *in_word_set(const char *str); > * be updated. (We cheat here and define the supported environments > * statically.) > */ > -#if defined(__sparc64__) || defined(__amd64__) > +#ifdef __LP64__ > #definehave_LP64_OFF64 NULL > #endif > > -#if defined(__i386__) || defined(__powerpc__) > +#ifdef __ILP32__ > #definehave_ILP32_OFFBIG NULL > #endif > > > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r321080 - head/usr.bin/getconf
Author: ngie Date: Mon Jul 17 18:12:08 2017 New Revision: 321080 URL: https://svnweb.freebsd.org/changeset/base/321080 Log: Expose the ILP32/LP64 programming environments based on __ILP32__/__LP64__ instead of by architecture. The list was incomplete (previous commits purged invalid architectures, like __alpha__, but failed to add new ones). It's best to base the symbol presence on whether or not the architecture is ILP32 / LP64 capable, per the compiler. This fixes the ILP32/LP64 program environments on some architectures like arm64, and by proxy fixes the tests on those architectures. MFC after:1 month Reviewed by: no one (timed out on feedback from imp) Differential Revision:D10787 Modified: head/usr.bin/getconf/progenv.gperf Modified: head/usr.bin/getconf/progenv.gperf == --- head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:07:53 2017 (r321079) +++ head/usr.bin/getconf/progenv.gperf Mon Jul 17 18:12:08 2017 (r321080) @@ -30,11 +30,11 @@ static const struct map *in_word_set(const char *str); * be updated. (We cheat here and define the supported environments * statically.) */ -#if defined(__sparc64__) || defined(__amd64__) +#ifdef __LP64__ #definehave_LP64_OFF64 NULL #endif -#if defined(__i386__) || defined(__powerpc__) +#ifdef __ILP32__ #definehave_ILP32_OFFBIG NULL #endif ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
