Re: svn commit: r322951 - head
On 10/30/17 1:44 AM, Ngie Cooper (yaneurabeya) wrote: > >> On Oct 25, 2017, at 13:34, Bryan Drewery wrote: > > … > >> I don't understand what you're saying here. If I build with MK_TCSH=yes >> and the host does not have tcsh, a failure occurs AFTER or BEFORE this >> change? >> Neither case makes sense to me. >> What is the failure? >> >> The change here is to build-tools which just calls 'make build-tools' in >> bin/csh which just builds 'gethost'. > > Yes. The relnotes concerns I mentioned are bogus. > > Yeah, a ~400 line C file isn’t that bad, I agree. > > I really don’t care about arguing this or debating it. Yes, you’re right on > all counts. It’s a micro optimization. I wasn't trying to argue or anything, just trying to understand if there was a big issue here. Thanks! > -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
Re: svn commit: r322951 - head
> On Oct 25, 2017, at 13:34, Bryan Drewery wrote: … > I don't understand what you're saying here. If I build with MK_TCSH=yes > and the host does not have tcsh, a failure occurs AFTER or BEFORE this > change? > Neither case makes sense to me. > What is the failure? > > The change here is to build-tools which just calls 'make build-tools' in > bin/csh which just builds 'gethost'. Yes. The relnotes concerns I mentioned are bogus. Yeah, a ~400 line C file isn’t that bad, I agree. I really don’t care about arguing this or debating it. Yes, you’re right on all counts. It’s a micro optimization. signature.asc Description: Message signed with OpenPGP using GPGMail
Re: svn commit: r322951 - head
On 8/27/17 9:15 AM, Ngie Cooper wrote:
> Author: ngie
> Date: Sun Aug 27 16:15:37 2017
> New Revision: 322951
> URL: https://svnweb.freebsd.org/changeset/base/322951
>
> Log:
> Respect MK_TCSH with build-tools and native-xtools
>
> This helps reduce the WORLDTMP footprint slightly.
>
> Based on a patch I submitted 5 years ago to GNATS.
>
> PR: 174051
> MFC after: 2 weeks
> Relnotes: yes (anyone who cross-builds with MK_TCSH=yes will run into
>build failures if the host doesn't have tcsh(1))
I don't understand what you're saying here. If I build with MK_TCSH=yes
and the host does not have tcsh, a failure occurs AFTER or BEFORE this
change?
Neither case makes sense to me.
What is the failure?
The change here is to build-tools which just calls 'make build-tools' in
bin/csh which just builds 'gethost'.
> # make build-tools
> grep 'ERR_' /root/git/freebsd/contrib/tcsh/sh.err.c | grep '^#define' >>
> sh.err.h
> cc -E -O2 -pipe -I. -I/root/git/freebsd/bin/csh
> -I/root/git/freebsd/contrib/tcsh -D_PATH_TCSHELL='"/bin/csh"' -g -std=gnu99
> -fstack-protector-strong -Wsystem-headers -Werror -Wno-pointer-sign
> -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable
> -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality
> -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef
> -Wno-address-of-packed-member -Wno-switch -Wno-switch-enum
> -Wno-knr-promoted-parameter -Wno-parentheses -fcolor-diagnostics
> -Qunused-arguments /root/git/freebsd/contrib/tcsh/tc.const.c
> /root/git/freebsd/contrib/tcsh/sh.char.h /root/git/freebsd/bin/csh/config.h
> /root/git/freebsd/contrib/tcsh/config_f.h
> /root/git/freebsd/contrib/tcsh/sh.types.h sh.err.h -D_h_tc_const | grep
> 'Char STR' | sed -e 's/Char \([a-zA-Z0-9_]*\)\(.*\)/extern Char \1[];/' |
> sort >> tc.const.h
> Building /usr/obj/root/git/freebsd/bin/csh/gethost
If the host does not have tcsh and MK_TCSH is set to yes and fails, then
we're missing building tcsh as a build tool (in bootstrap-tools). I
don't know where it is used though.
This is the only place I see using csh in the build:
> tools/test/malloc/Makefile: @csh -x -c "time ./malloc 50 2000
> 8192"
> tools/test/malloc/Makefile: @csh -x -c "time ./malloc5000 2000
> 8192"
> tools/test/malloc/Makefile: @csh -x -c "time ./malloc 50 14000
> 8192"
> tools/test/malloc/Makefile: @csh -x -c "time ./malloc2000 2
> 2048"
> Reminded by:Fabian Keil
This patch is overall fine but it saves 25KB in OBJDIR and ~1 second in
build time. Based on the reminder and the Relnotes, it seems like
whatever was intended to be fixed may not have been.
>
> Modified:
> head/Makefile.inc1
>
> Modified: head/Makefile.inc1
> ==
> --- head/Makefile.inc1Sun Aug 27 13:02:51 2017(r322950)
> +++ head/Makefile.inc1Sun Aug 27 16:15:37 2017(r322951)
> @@ -1984,8 +1984,12 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
> _rescue=rescue/rescue
> .endif
>
> +.if ${MK_TCSH} != "no"
> +_tcsh=bin/csh
> +.endif
> +
> .for _tool in \
> -bin/csh \
> +${_tcsh} \
> bin/sh \
> ${LOCAL_TOOL_DIRS} \
> lib/ncurses/ncurses \
> @@ -2143,7 +2147,7 @@ native-xtools: .PHONY
> bin/cat \
> bin/chmod \
> bin/cp \
> -bin/csh \
> +${_tcsh} \
> bin/echo \
> bin/expr \
> bin/hostname \
>
--
Regards,
Bryan Drewery
signature.asc
Description: OpenPGP digital signature
svn commit: r322951 - head
Author: ngie
Date: Sun Aug 27 16:15:37 2017
New Revision: 322951
URL: https://svnweb.freebsd.org/changeset/base/322951
Log:
Respect MK_TCSH with build-tools and native-xtools
This helps reduce the WORLDTMP footprint slightly.
Based on a patch I submitted 5 years ago to GNATS.
PR: 174051
MFC after:2 weeks
Relnotes: yes (anyone who cross-builds with MK_TCSH=yes will run into
build failures if the host doesn't have tcsh(1))
Reminded by: Fabian Keil
Modified:
head/Makefile.inc1
Modified: head/Makefile.inc1
==
--- head/Makefile.inc1 Sun Aug 27 13:02:51 2017(r322950)
+++ head/Makefile.inc1 Sun Aug 27 16:15:37 2017(r322951)
@@ -1984,8 +1984,12 @@ _gcc_tools= gnu/usr.bin/cc/cc_tools
_rescue=rescue/rescue
.endif
+.if ${MK_TCSH} != "no"
+_tcsh=bin/csh
+.endif
+
.for _tool in \
-bin/csh \
+${_tcsh} \
bin/sh \
${LOCAL_TOOL_DIRS} \
lib/ncurses/ncurses \
@@ -2143,7 +2147,7 @@ native-xtools: .PHONY
bin/cat \
bin/chmod \
bin/cp \
-bin/csh \
+${_tcsh} \
bin/echo \
bin/expr \
bin/hostname \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
