Re: svn commit: r328474 - head/sys/contrib/libnv

[Cy Schubert]

In message <20180127215658.GA75080@jarvis>, Mariusz Zaborski writes:
> 
>
> --ew6BAiZeqk4r7MaW
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Sat, Jan 27, 2018 at 07:32:39AM -0800, Cy Schubert wrote:
> > In message <201801271258.w0rcwml0078...@repo.freebsd.org>, Mariusz Zabors=
> ki=20
> > wri
> > tes:
> > > Author: oshogbo
> > > Date: Sat Jan 27 12:58:21 2018
> > > New Revision: 328474
> > > URL: https://svnweb.freebsd.org/changeset/base/328474
> > >
> > > Log:
> > >   Add SPDX tags for nv(9).
> > >  =20
> > >   MFC after:  2 weeks
> > >
> > > Modified:
> > >   head/sys/contrib/libnv/cnvlist.c
> > >   head/sys/contrib/libnv/dnvlist.c
> > >   head/sys/contrib/libnv/nv_impl.h
> > >   head/sys/contrib/libnv/nvlist.c
> > >   head/sys/contrib/libnv/nvlist_impl.h
> > >   head/sys/contrib/libnv/nvpair.c
> > >   head/sys/contrib/libnv/nvpair_impl.h
> > >
> >=20
> > When was it decided to add SPDX to contrib?
> The nv was development for and in FreeBSD.
> First whole library was in lib/libnv.
> Then the part which is also in the kernel was moved to sys/kern and sys/sys
> directories.
> The problem with that was that evrything in the sys/sys is instaled in
> /usr/include and in the *_impl.h we have things that should not be accesibl=
> e by
> developers.
>
> This was the main reason of moving libnv to contrib file at the time.
> If you have any other place where libnv can be kept I'm happy to move it.

It's native to FreeBSD then and not an import through a vendor branch. 
That's what was led to understand.

However this was not concern I had. As this is native FreeBSD code it 
should have SPDX tags. My concern about SPDX in contrib is MFV.

I think we should encourage our upstream source providers to include SPDX 
tags in their code we import into the vendor branches.


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r328474 - head/sys/contrib/libnv

[Mariusz Zaborski]

On Sat, Jan 27, 2018 at 07:32:39AM -0800, Cy Schubert wrote:
> In message <201801271258.w0rcwml0078...@repo.freebsd.org>, Mariusz Zaborski 
> wri
> tes:
> > Author: oshogbo
> > Date: Sat Jan 27 12:58:21 2018
> > New Revision: 328474
> > URL: https://svnweb.freebsd.org/changeset/base/328474
> >
> > Log:
> >   Add SPDX tags for nv(9).
> >   
> >   MFC after:2 weeks
> >
> > Modified:
> >   head/sys/contrib/libnv/cnvlist.c
> >   head/sys/contrib/libnv/dnvlist.c
> >   head/sys/contrib/libnv/nv_impl.h
> >   head/sys/contrib/libnv/nvlist.c
> >   head/sys/contrib/libnv/nvlist_impl.h
> >   head/sys/contrib/libnv/nvpair.c
> >   head/sys/contrib/libnv/nvpair_impl.h
> >
> 
> When was it decided to add SPDX to contrib?
The nv was development for and in FreeBSD.
First whole library was in lib/libnv.
Then the part which is also in the kernel was moved to sys/kern and sys/sys
directories.
The problem with that was that evrything in the sys/sys is instaled in
/usr/include and in the *_impl.h we have things that should not be accesible by
developers.

This was the main reason of moving libnv to contrib file at the time.
If you have any other place where libnv can be kept I'm happy to move it.

Thanks,
-- 
Mariusz Zaborski
oshogbo//vx | http://oshogbo.vexillium.org
FreeBSD commiter| https://freebsd.org
Software developer  | http://wheelsystems.com
If it's not broken, let's fix it till it is!!1


signature.asc
Description: PGP signature

Re: svn commit: r328474 - head/sys/contrib/libnv

[Pedro Giffuni]

On 01/27/18 10:32, Cy Schubert wrote:

In message <201801271258.w0rcwml0078...@repo.freebsd.org>, Mariusz Zaborski
wri
tes:

Author: oshogbo
Date: Sat Jan 27 12:58:21 2018
New Revision: 328474
URL: https://svnweb.freebsd.org/changeset/base/328474

Log:
   Add SPDX tags for nv(9).
   
   MFC after:	2 weeks


Modified:
   head/sys/contrib/libnv/cnvlist.c
   head/sys/contrib/libnv/dnvlist.c
   head/sys/contrib/libnv/nv_impl.h
   head/sys/contrib/libnv/nvlist.c
   head/sys/contrib/libnv/nvlist_impl.h
   head/sys/contrib/libnv/nvpair.c
   head/sys/contrib/libnv/nvpair_impl.h


When was it decided to add SPDX to contrib?




We didn't, it's up to upstream, but being the author (of at least part 
of it) he can do what he wants ;).


Pedro.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r328474 - head/sys/contrib/libnv

[Cy Schubert]

In message <201801271258.w0rcwml0078...@repo.freebsd.org>, Mariusz Zaborski 
wri
tes:
> Author: oshogbo
> Date: Sat Jan 27 12:58:21 2018
> New Revision: 328474
> URL: https://svnweb.freebsd.org/changeset/base/328474
>
> Log:
>   Add SPDX tags for nv(9).
>   
>   MFC after:  2 weeks
>
> Modified:
>   head/sys/contrib/libnv/cnvlist.c
>   head/sys/contrib/libnv/dnvlist.c
>   head/sys/contrib/libnv/nv_impl.h
>   head/sys/contrib/libnv/nvlist.c
>   head/sys/contrib/libnv/nvlist_impl.h
>   head/sys/contrib/libnv/nvpair.c
>   head/sys/contrib/libnv/nvpair_impl.h
>

When was it decided to add SPDX to contrib?


-- 
Cheers,
Cy Schubert 
FreeBSD UNIX:     Web:  http://www.FreeBSD.org

The need of the many outweighs the greed of the few.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r328474 - head/sys/contrib/libnv

[Mariusz Zaborski]

Author: oshogbo
Date: Sat Jan 27 12:58:21 2018
New Revision: 328474
URL: https://svnweb.freebsd.org/changeset/base/328474

Log:
  Add SPDX tags for nv(9).
  
  MFC after:2 weeks

Modified:
  head/sys/contrib/libnv/cnvlist.c
  head/sys/contrib/libnv/dnvlist.c
  head/sys/contrib/libnv/nv_impl.h
  head/sys/contrib/libnv/nvlist.c
  head/sys/contrib/libnv/nvlist_impl.h
  head/sys/contrib/libnv/nvpair.c
  head/sys/contrib/libnv/nvpair_impl.h

Modified: head/sys/contrib/libnv/cnvlist.c
==
--- head/sys/contrib/libnv/cnvlist.cSat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/cnvlist.cSat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2016 Adam Starak 
  * All rights reserved.
  *

Modified: head/sys/contrib/libnv/dnvlist.c
==
--- head/sys/contrib/libnv/dnvlist.cSat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/dnvlist.cSat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2013 The FreeBSD Foundation
  * All rights reserved.
  *

Modified: head/sys/contrib/libnv/nv_impl.h
==
--- head/sys/contrib/libnv/nv_impl.hSat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/nv_impl.hSat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2013 The FreeBSD Foundation
  * Copyright (c) 2013-2015 Mariusz Zaborski 
  * All rights reserved.

Modified: head/sys/contrib/libnv/nvlist.c
==
--- head/sys/contrib/libnv/nvlist.c Sat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/nvlist.c Sat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2009-2013 The FreeBSD Foundation
  * Copyright (c) 2013-2015 Mariusz Zaborski 
  * All rights reserved.

Modified: head/sys/contrib/libnv/nvlist_impl.h
==
--- head/sys/contrib/libnv/nvlist_impl.hSat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/nvlist_impl.hSat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2013 The FreeBSD Foundation
  * Copyright (c) 2013-2015 Mariusz Zaborski 
  * All rights reserved.

Modified: head/sys/contrib/libnv/nvpair.c
==
--- head/sys/contrib/libnv/nvpair.c Sat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/nvpair.c Sat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2009-2013 The FreeBSD Foundation
  * Copyright (c) 2013-2015 Mariusz Zaborski 
  * All rights reserved.

Modified: head/sys/contrib/libnv/nvpair_impl.h
==
--- head/sys/contrib/libnv/nvpair_impl.hSat Jan 27 12:55:34 2018
(r328473)
+++ head/sys/contrib/libnv/nvpair_impl.hSat Jan 27 12:58:21 2018
(r328474)
@@ -1,4 +1,6 @@
 /*-
+ * SPDX-License-Identifier: BSD-2-Clause-FreeBSD
+ *
  * Copyright (c) 2009-2013 The FreeBSD Foundation
  * Copyright (c) 2013-2015 Mariusz Zaborski 
  * All rights reserved.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"