Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Mark Johnston]

On Sun, May 20, 2018 at 10:59:20AM +, Alexey Dokuchaev wrote:
> On Sat, May 19, 2018 at 03:44:37PM -0400, Mark Johnston wrote:
> > ...
> > I don't really think it's important. The main consideration is the
> > toolchain. We use illumos as an upstream, which is pretty inactive at
> > this point. Joyent's illumos fork has put a lot of work into the CTF
> > toolchain, and OpenBSD has made some progress towards an ISC-licensed
> > ctfconvert utility. I'd like to import the latter, since the permissive
> > license means that we can use it in DDB. It requires more work because
> > of some missing functionality, though.
> > 
> > At some point I think we'd like to pursue one of these two upstreams,
> 
> Quick reality check question: why aren't *we* (FreeBSD) upstream, since
> Sun was killed by Oracle and we're more alive than illumos and OpenBSD?

Most of the non-trivial commits to the CTF toolchain in the past several
years were done by me, and they were just bug fixes. AFAIK no one is
actively working on improving the CTF toolchain in FreeBSD. The Joyent
fork has lots of improvements and cleanups that make the code easier to
maintain and more useful (for instance, librarifying ctfmerge(1)), and
OpenBSD's ctfconv(1) replaces both ctfconvert(1) and ctfmerge(1), and is
simpler. My point was merely that anyone seeking to overhaul the CTF
toolchain in FreeBSD should consider rebasing on one of these two
potential upstreams.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Alexey Dokuchaev]

On Sat, May 19, 2018 at 03:44:37PM -0400, Mark Johnston wrote:
> ...
> I don't really think it's important. The main consideration is the
> toolchain. We use illumos as an upstream, which is pretty inactive at
> this point. Joyent's illumos fork has put a lot of work into the CTF
> toolchain, and OpenBSD has made some progress towards an ISC-licensed
> ctfconvert utility. I'd like to import the latter, since the permissive
> license means that we can use it in DDB. It requires more work because
> of some missing functionality, though.
> 
> At some point I think we'd like to pursue one of these two upstreams,

Quick reality check question: why aren't *we* (FreeBSD) upstream, since
Sun was killed by Oracle and we're more alive than illumos and OpenBSD?

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Mark Johnston]

On Sat, May 19, 2018 at 11:00:22AM -0700, Matthew Macy wrote:
> On Sat, May 19, 2018 at 4:49 AM, Ed Maste  wrote:
> > On 19 May 2018 at 02:31, Matt Macy  wrote:
> >> Author: mmacy
> >> Date: Sat May 19 06:31:17 2018
> >> New Revision: 333872
> >> URL: https://svnweb.freebsd.org/changeset/base/333872
> >>
> >> Log:
> >>   ctfconvert: silence useless enum has too many values warning
> >
> > I agree it's reasonable to silence this warning as it is not
> > actionable for almost everyone who encounters it. It does indicate a
> > real problem in our tool chain though and I added an entry to
> > https://wiki.freebsd.org/DTraceTODO.
> 
> Conrad brought up the need to change the CTF ABI on IRC. This will
> involve an on-disk format change which he and I believe to be
> acceptable, but perhaps interoperability with other operating systems
> is still considered important.

I don't really think it's important. The main consideration is the
toolchain. We use illumos as an upstream, which is pretty inactive at
this point. Joyent's illumos fork has put a lot of work into the CTF
toolchain, and OpenBSD has made some progress towards an ISC-licensed
ctfconvert utility. I'd like to import the latter, since the permissive
license means that we can use it in DDB. It requires more work because
of some missing functionality, though.

At some point I think we'd like to pursue one of these two upstreams,
so it becomes a question of whether they're amenable to modifying the
CTF binary format (and there are some other limitations that ought to be
fixed in the process), and if not, whether it's painful to maintain the
local modifications needed to support large enums.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Matthew Macy]

On Sat, May 19, 2018 at 4:49 AM, Ed Maste  wrote:
> On 19 May 2018 at 02:31, Matt Macy  wrote:
>> Author: mmacy
>> Date: Sat May 19 06:31:17 2018
>> New Revision: 333872
>> URL: https://svnweb.freebsd.org/changeset/base/333872
>>
>> Log:
>>   ctfconvert: silence useless enum has too many values warning
>
> I agree it's reasonable to silence this warning as it is not
> actionable for almost everyone who encounters it. It does indicate a
> real problem in our tool chain though and I added an entry to
> https://wiki.freebsd.org/DTraceTODO.

Conrad brought up the need to change the CTF ABI on IRC. This will
involve an on-disk format change which he and I believe to be
acceptable, but perhaps interoperability with other operating systems
is still considered important.
-M
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Ed Maste]

On 19 May 2018 at 02:31, Matt Macy  wrote:
> Author: mmacy
> Date: Sat May 19 06:31:17 2018
> New Revision: 333872
> URL: https://svnweb.freebsd.org/changeset/base/333872
>
> Log:
>   ctfconvert: silence useless enum has too many values warning

I agree it's reasonable to silence this warning as it is not
actionable for almost everyone who encounters it. It does indicate a
real problem in our tool chain though and I added an entry to
https://wiki.freebsd.org/DTraceTODO.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Eitan Adler]

On 18 May 2018 at 23:31, Matt Macy  wrote:
> Author: mmacy
> Date: Sat May 19 06:31:17 2018
> New Revision: 333872
> URL: https://svnweb.freebsd.org/changeset/base/333872
>
> Log:
>   ctfconvert: silence useless enum has too many values warning

Thank you!

-- 
Eitan Adler
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r333872 - head/cddl/contrib/opensolaris/tools/ctf/cvt

[Matt Macy]

Author: mmacy
Date: Sat May 19 06:31:17 2018
New Revision: 333872
URL: https://svnweb.freebsd.org/changeset/base/333872

Log:
  ctfconvert: silence useless enum has too many values warning

Modified:
  head/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c

Modified: head/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c
==
--- head/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c   Sat May 19 05:58:05 
2018(r333871)
+++ head/cddl/contrib/opensolaris/tools/ctf/cvt/ctf.c   Sat May 19 06:31:17 
2018(r333872)
@@ -438,8 +438,6 @@ write_type(void *arg1, void *arg2)
i++; /* count up enum members */
 
if (i > CTF_MAX_VLEN) {
-   warning("enum %s has too many values: %d > %d\n",
-   tdesc_name(tp), i, CTF_MAX_VLEN);
i = CTF_MAX_VLEN;
}
 
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"