Re: svn commit: r335042 - head/usr.bin/top
On Thu, Jun 14, 2018 at 6:10 AM, Eitan Adler wrote: > > I do see some people adding their Copyright on some commits but overall > > we haven't done that as a project and I am curious if we should change > > in that regard. > > The rule of them is about 25% of the file, right? > The law that motivates this (but maybe not requires it) states only substantial change. One cannot mislead people about the copyright term which also feeds into it (which is one of the motivators for not doing it for trivial changes: it would lead people to believe that a copyright is being claimed that might not be substantial). Trouble is, there's no concrete rules for substantial in the laws, and the caselaw is substantially muddied. People know and use the terms, but there's no sharp line that can be drawn or articulated. Generally, the project has adopted a bit of a Potter Stewart like standard. A substantial change is situational. Generally, a 25% or more change is substantial. Sometimes, substantial changes can be less when important new functions are added. Other times, like with mechanical changes that may lack artistic expression, you can change 90% of the file (via indent) and not have it be substantial. The current case is on the boarder. There's a lot of code motion that doesn't change the functionality and just moves code around, inflating any scoring efforts. On the other hand, there's been some level of cleanup of the code as well on a very systemic basic through the whole code base. I've not paid extreme attention to every change, to be honest, but on the whole I think it's a close call. Generally, however, the project has been deferential to cases that are close calls where the author has legitimately asserted a claim. That deference, however, has not been extended in several instances where it's not a borderline case. So there's your answer, clear as mud. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335042 - head/usr.bin/top
On 13 June 2018 at 17:01, Bryan Drewery wrote: > On 6/13/2018 1:52 AM, Eitan Adler wrote: >> Author: eadler >> Date: Wed Jun 13 08:52:19 2018 >> New Revision: 335042 >> URL: https://svnweb.freebsd.org/changeset/base/335042 >> >> Log: >> top(1): add myself to authors >> >> At this point I've mucked enough with top(1) that all bugs should be >> blamed on me rather than William LeFebvre. >> > > Thank you for all of your work here... > > There's not exactly a guideline for this but I don't feel that > non-functional changes qualify as "authors". I actually meant what I wrote in the commit message: at this point it doesn't make sense to blame William. I'll revert the change to top.1 change as I don't care all that much. Personally, I like being liberal with credit though I understand that isn't the project's stance necessarily. > Especially the sorting chosen. I went with alphabetical. Perhaps I missed some rewrite you've done? Though none have > 'Relnotes: yes' so I am assuming they were all non-functional. Some were functional, I've not done a good job of marking them. > I do see some people adding their Copyright on some commits but overall > we haven't done that as a project and I am curious if we should change > in that regard. The rule of them is about 25% of the file, right? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335042 - head/usr.bin/top
On Wed, Jun 13, 2018 at 05:01:35PM -0700, Bryan Drewery wrote: > ... > Also I really abhor rewriting anything that's not broken as it causes > merge conflict pain downstream and just adds regression risk. +1. I'm still having mixed feelings about top(1) de-contrib and rewrite. At the very least, it should not be MFC'ed until it matures long enough in -CURRENT and all regressions are found and fixed (they pop up here and there now). Currently top(1) is still a pessimization compared to what it was before, so there's a lot to catch up with. ./danfe ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335042 - head/usr.bin/top
On 6/13/2018 1:52 AM, Eitan Adler wrote: > Author: eadler > Date: Wed Jun 13 08:52:19 2018 > New Revision: 335042 > URL: https://svnweb.freebsd.org/changeset/base/335042 > > Log: > top(1): add myself to authors > > At this point I've mucked enough with top(1) that all bugs should be > blamed on me rather than William LeFebvre. > Thank you for all of your work here... There's not exactly a guideline for this but I don't feel that non-functional changes qualify as "authors". Especially the sorting chosen. Perhaps I missed some rewrite you've done? Though none have 'Relnotes: yes' so I am assuming they were all non-functional. There's been 62 unique committers to usr.bin/top, which does not account for Submitted By. All of which are also missing from AUTHORS and Copyrights. I do see some people adding their Copyright on some commits but overall we haven't done that as a project and I am curious if we should change in that regard. Also I really abhor rewriting anything that's not broken as it causes merge conflict pain downstream and just adds regression risk. > Modified: > head/usr.bin/top/top.1 > head/usr.bin/top/utils.c > > Modified: head/usr.bin/top/top.1 > == > --- head/usr.bin/top/top.1Wed Jun 13 08:52:17 2018(r335041) > +++ head/usr.bin/top/top.1Wed Jun 13 08:52:19 2018(r335042) > @@ -360,6 +360,7 @@ process is waiting. > Lock names are prefixed with an asterisk \*(lq*\*(rq while sleep events > are not. > .Sh AUTHORS > +.An Eitan Adler Aq Mt ead...@freebsd.org > .An William LeFebvre, EECS Department, Northwestern University > .Sh BUGS > The command name for swapped processes should be tracked down, but this > > Modified: head/usr.bin/top/utils.c > == > --- head/usr.bin/top/utils.c Wed Jun 13 08:52:17 2018(r335041) > +++ head/usr.bin/top/utils.c Wed Jun 13 08:52:19 2018(r335042) > @@ -2,6 +2,7 @@ > * This program may be freely redistributed, > * but this entire comment MUST remain intact. > * > + * Copyright (c) 2018, Eitan Adler > * Copyright (c) 1984, 1989, William LeFebvre, Rice University > * Copyright (c) 1989, 1990, 1992, William LeFebvre, Northwestern University > * > -- Regards, Bryan Drewery signature.asc Description: OpenPGP digital signature
svn commit: r335042 - head/usr.bin/top
Author: eadler Date: Wed Jun 13 08:52:19 2018 New Revision: 335042 URL: https://svnweb.freebsd.org/changeset/base/335042 Log: top(1): add myself to authors At this point I've mucked enough with top(1) that all bugs should be blamed on me rather than William LeFebvre. Modified: head/usr.bin/top/top.1 head/usr.bin/top/utils.c Modified: head/usr.bin/top/top.1 == --- head/usr.bin/top/top.1 Wed Jun 13 08:52:17 2018(r335041) +++ head/usr.bin/top/top.1 Wed Jun 13 08:52:19 2018(r335042) @@ -360,6 +360,7 @@ process is waiting. Lock names are prefixed with an asterisk \*(lq*\*(rq while sleep events are not. .Sh AUTHORS +.An Eitan Adler Aq Mt ead...@freebsd.org .An William LeFebvre, EECS Department, Northwestern University .Sh BUGS The command name for swapped processes should be tracked down, but this Modified: head/usr.bin/top/utils.c == --- head/usr.bin/top/utils.cWed Jun 13 08:52:17 2018(r335041) +++ head/usr.bin/top/utils.cWed Jun 13 08:52:19 2018(r335042) @@ -2,6 +2,7 @@ * This program may be freely redistributed, * but this entire comment MUST remain intact. * + * Copyright (c) 2018, Eitan Adler * Copyright (c) 1984, 1989, William LeFebvre, Rice University * Copyright (c) 1989, 1990, 1992, William LeFebvre, Northwestern University * ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
