Re: svn commit: r335091 - head/sbin/nvmecontrol
On 6/13/18 10:21 PM, Warner Losh wrote: > > > On Wed, Jun 13, 2018 at 10:57 PM, Rodney W. Grimes > mailto:free...@pdx.rh.cn85.dnsmgr.net>> > wrote: > > [ Charset UTF-8 unsupported, converting... ] > > Actually, that file (nvmecontrol_ext.h) is completely new. I'm not sure > why > > it thought I copied it from util.c. Maybe it's a git svn integration > thing. > > If it is a totally new file why is it showing contect diff with > + and -'s? > > > Don't know, but the whole contents of this file is 1 line of extern function > statements. > > Since util.c is short, and I try to use identical copyright notices, I'm > thinking git thought it was a move through 'magic' and that's where svn got > confused into thinking it was a copy + modification which is where the diff > came from. Yes. git fails at this often since it's notion of a copy is "implicit guess" that you can't override vs "explicit action". I sometimes have to do fixups after an 'arc patch' of a diff that git mangles where I save off a copy of the .c file, svn revert -f the file, then svn add the new file so it shows up as a new file from scratch. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
In message , Warner Losh writes: >The year of first publication of the work; Please be aware that "year of first publicaiton of the work" is a surprising tricky legal concept, because neither "first", "publication" or "the work" means what a normal or sane person would expect. >But this only required for works published before March 1, 1989. It later >states: > >"Copyright notice is optional for unpublished works, foreign works, or >works published on or after March 1, 1989. When notice is optional, >copyright owners can use any form of notice they wish." This is just about the worst legal advise one can imagine, because US still runs a system of "Copyright Registration" and there is a lot riding on having done so "promptly" if you ever get into a lawsuit, and if you don't affix a notice it gets even worse. >The project wishes date ranges. :) I support that, for data-archaeological reasons, but the publication year cannot just be updated willy nilly. A notice of "2014-2017" literally means "Some individual parts, each of which clear the 'substantial' threshold, were published in 2014, others in 2015, others again in 2016 and some in 2017" This is why "2014-2017" is significantly different from "2014,2016-2017". It is also important to understand that Copyright cannot be "renewed" this way unless the changes are 'substantial' enough, which probably means they have to clear the 'derivative work' threshold to be safe. But there is no guidance to be found *anywhere* what it takes for source code to clear any of those thresholds, because nobody has gone to court on that question yet. And nobody is likely to do so in the next three decades, because almost no software has fallen out of copyright, and no software will do so in the next three decades (All Hail Mickey!) The legal advice I have received is that one should "probably not" update the publication year unless the changes amount to "a rewrite", but updating *a little* too aggressively will probably only be "harmless error" due to the total absense of statute text and case law. Nobody want to guess what the situation is for "live works", under which countinous software development (probably) falls, and when you start talking about changing maintainers, your friendly copyright lawyer will get that glazed "Thank goodness the lawsuits wont start until I'm dead" look. And of course all this gets much more "interesting" if APIs can truly be copyrighted, because then we need to find out what "an API" is in the first place. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
> So I found this > > https://www.copyright.gov/circs/circ03.pdf > > and it states two things: > > "A notice consists of three elements that generally appear as a single > continuous statement: ? The copyright symbol ? (or for phonorecords, the > symbol ? ); the word ?copyright?; or the abbreviation ?copr.?; ? The year > of first publication of the work; and ? The name of the copyright owner." > > But this only required for works published before March 1, 1989. It later > states: > > "Copyright notice is optional for unpublished works, foreign works, or > works published on or after March 1, 1989. When notice is optional, > copyright owners can use any form of notice they wish." > > The project wishes date ranges. :) > > But since we're not lawyers... https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf 2205.1(A) Year of Publication .. .. The year of first publication followed by multiple year dates ( e.g. , 1981, 1982, 1983) .. Though I have seen it commonly used in practive date-date, I have not actally seen that in any of the actual Copyright office publications, nor have I ever seen any case law that makes it bad to do. I am fine with date ranges, I have fine with lists, I am not fine with altering that "first publication date". I am also a bit concerned on the treating each commit as a "derived" work. > > Warner > > On Wed, Jun 13, 2018 at 11:37 PM, Juli Mallett wrote: > > > > > > > On 13 June 2018 at 22:35, Rodney W. Grimes > > wrote: > > > >> > On 13 June 2018 at 20:28, Rodney W. Grimes < > >> free...@pdx.rh.cn85.dnsmgr.net> > >> > wrote: > >> > > >> > > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > >> ... > >> > > > > > @@ -1,7 +1,8 @@ > >> > > > > > /*- > >> > > > > > - * Copyright (c) 2017 Netflix, Inc > >> > > > > > - * All rights reserved. > >> > > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > >> > > > > > * > >> > > > > > + * Copyright (C) 2018 Netflix > >> > > > > > >> > > > > You moved a copyright forward, that is not proper to do. > >> > > > > > >> > > > > >> > > > Thought it was. I honestly don't care where (nor does my employer), > >> so if > >> > > > you want to tweak it to be more conforming, be my guest. > >> > > > >> > > You can add a new date to the end of a list, but you should always > >> > > retain the oldest date, and many opinions are that all dates should > >> > > be retained unless they are continuous. > >> > > > >> > > >> > Do you have a citation for this, Rod? I ask because my impression was > >> that > >> > although it has often been done, and at one point may legitimately have > >> > been required, it is not any longer so. I'd love to have a concrete > >> source > >> > on this, though. > >> > >> One place to start is circ15: > >> https://www.copyright.gov/circs/circ15a.pdf > >> > >> Fundemental principle of copyright protections duration are from -first- > >> date of publication, that is covered in USC 17. If you miss represent > >> that date in your copyright your copyright can be held invalid. > >> The real smoking gun is: > >> 17 USC 401 b (2): > >> the year of first publication of the work; in the > >> case of compilations or derivative works incorporating > >> previously published material, the year date of first > >> publication of the compilation or derivative work is > >> sufficient. The year date may be omitted where a pictorial, > >> graphic, or sculptural work, with accompanying text matter, > >> if any, is reproduced in or on greeting cards, postcards, > >> stationery, jewelry, dolls, toys, or any useful articles; and > >> > >> The interpretation of compilation or derivative does open a grey > >> area here in software, and I can see how one might consider a > >> patch to create a derived work. > >> > > > > Per your quote: > > "the year of first publication of the work; in the > > case of compilations or derivative works incorporating > > previously published material, the year date of first > > publication of the compilation or derivative work is > > sufficient." > > > > It seems to plainly suggest listing one year, not several years, and > > certainly not by some convoluted scheme. > > > > We're not lawyers. I'm not sure this is a useful discussion. I'd love a > > citation for the multiple-years scheme you describe, which does not seem to > > be in USC 17. > > > > > > There is case law that putting a date later than first publication > >> appears as an attempt to move the duration of your protection > >> to be longer than it really should be. > >> > >> https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf > >> At 2202.2(A) Advantages to Using Notice on Post-Berne Works > >> "It identifies the year of first publication, > >> which may be used to determine the term of copyright > >> protection in the case of an anonymous work, > >> a
Re: svn commit: r335091 - head/sbin/nvmecontrol
So I found this https://www.copyright.gov/circs/circ03.pdf and it states two things: "A notice consists of three elements that generally appear as a single continuous statement: • The copyright symbol © (or for phonorecords, the symbol ℗ ); the word “copyright”; or the abbreviation “copr.”; • The year of first publication of the work; and • The name of the copyright owner." But this only required for works published before March 1, 1989. It later states: "Copyright notice is optional for unpublished works, foreign works, or works published on or after March 1, 1989. When notice is optional, copyright owners can use any form of notice they wish." The project wishes date ranges. :) But since we're not lawyers... Warner On Wed, Jun 13, 2018 at 11:37 PM, Juli Mallett wrote: > > > On 13 June 2018 at 22:35, Rodney W. Grimes > wrote: > >> > On 13 June 2018 at 20:28, Rodney W. Grimes < >> free...@pdx.rh.cn85.dnsmgr.net> >> > wrote: >> > >> > > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < >> ... >> > > > > > @@ -1,7 +1,8 @@ >> > > > > > /*- >> > > > > > - * Copyright (c) 2017 Netflix, Inc >> > > > > > - * All rights reserved. >> > > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD >> > > > > > * >> > > > > > + * Copyright (C) 2018 Netflix >> > > > > >> > > > > You moved a copyright forward, that is not proper to do. >> > > > > >> > > > >> > > > Thought it was. I honestly don't care where (nor does my employer), >> so if >> > > > you want to tweak it to be more conforming, be my guest. >> > > >> > > You can add a new date to the end of a list, but you should always >> > > retain the oldest date, and many opinions are that all dates should >> > > be retained unless they are continuous. >> > > >> > >> > Do you have a citation for this, Rod? I ask because my impression was >> that >> > although it has often been done, and at one point may legitimately have >> > been required, it is not any longer so. I'd love to have a concrete >> source >> > on this, though. >> >> One place to start is circ15: >> https://www.copyright.gov/circs/circ15a.pdf >> >> Fundemental principle of copyright protections duration are from -first- >> date of publication, that is covered in USC 17. If you miss represent >> that date in your copyright your copyright can be held invalid. >> The real smoking gun is: >> 17 USC 401 b (2): >> the year of first publication of the work; in the >> case of compilations or derivative works incorporating >> previously published material, the year date of first >> publication of the compilation or derivative work is >> sufficient. The year date may be omitted where a pictorial, >> graphic, or sculptural work, with accompanying text matter, >> if any, is reproduced in or on greeting cards, postcards, >> stationery, jewelry, dolls, toys, or any useful articles; and >> >> The interpretation of compilation or derivative does open a grey >> area here in software, and I can see how one might consider a >> patch to create a derived work. >> > > Per your quote: > "the year of first publication of the work; in the > case of compilations or derivative works incorporating > previously published material, the year date of first > publication of the compilation or derivative work is > sufficient." > > It seems to plainly suggest listing one year, not several years, and > certainly not by some convoluted scheme. > > We're not lawyers. I'm not sure this is a useful discussion. I'd love a > citation for the multiple-years scheme you describe, which does not seem to > be in USC 17. > > > There is case law that putting a date later than first publication >> appears as an attempt to move the duration of your protection >> to be longer than it really should be. >> >> https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf >> At 2202.2(A) Advantages to Using Notice on Post-Berne Works >> "It identifies the year of first publication, >> which may be used to determine the term of copyright >> protection in the case of an anonymous work, >> a pseudonymous work, or a work made for hire." >> >> Much of our work, and in this case of Netflix and these >> files, they are defanitly works made for hire, so this >> applies and identifying first date of publication is >> important. >> >> There is also: >> At 2203.1 Works First Published Between January 1, 1978 and February 28, >> 1989 >> This Applies to some of our code, as it has First publications >> in these date ranges, boils down to even though Berne says you dont >> have to have a notice, if you first published the work in this time >> frame you had to have a notice then, and you still have to have a >> notice now. >> >> Yes, Disney and others have done fun stuff with copyrights on *movies*, >> but that has other complications doing with re-mixes and all sorts of >> other >> things that make it possible for them to claim
Re: svn commit: r335091 - head/sbin/nvmecontrol
On 13 June 2018 at 22:35, Rodney W. Grimes wrote: > > On 13 June 2018 at 20:28, Rodney W. Grimes net> > > wrote: > > > > > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > ... > > > > > > @@ -1,7 +1,8 @@ > > > > > > /*- > > > > > > - * Copyright (c) 2017 Netflix, Inc > > > > > > - * All rights reserved. > > > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > > > * > > > > > > + * Copyright (C) 2018 Netflix > > > > > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > > > > > > > Thought it was. I honestly don't care where (nor does my employer), > so if > > > > you want to tweak it to be more conforming, be my guest. > > > > > > You can add a new date to the end of a list, but you should always > > > retain the oldest date, and many opinions are that all dates should > > > be retained unless they are continuous. > > > > > > > Do you have a citation for this, Rod? I ask because my impression was > that > > although it has often been done, and at one point may legitimately have > > been required, it is not any longer so. I'd love to have a concrete > source > > on this, though. > > One place to start is circ15: > https://www.copyright.gov/circs/circ15a.pdf > > Fundemental principle of copyright protections duration are from -first- > date of publication, that is covered in USC 17. If you miss represent > that date in your copyright your copyright can be held invalid. > The real smoking gun is: > 17 USC 401 b (2): > the year of first publication of the work; in the > case of compilations or derivative works incorporating > previously published material, the year date of first > publication of the compilation or derivative work is > sufficient. The year date may be omitted where a pictorial, > graphic, or sculptural work, with accompanying text matter, > if any, is reproduced in or on greeting cards, postcards, > stationery, jewelry, dolls, toys, or any useful articles; and > > The interpretation of compilation or derivative does open a grey > area here in software, and I can see how one might consider a > patch to create a derived work. > Per your quote: "the year of first publication of the work; in the case of compilations or derivative works incorporating previously published material, the year date of first publication of the compilation or derivative work is sufficient." It seems to plainly suggest listing one year, not several years, and certainly not by some convoluted scheme. We're not lawyers. I'm not sure this is a useful discussion. I'd love a citation for the multiple-years scheme you describe, which does not seem to be in USC 17. There is case law that putting a date later than first publication > appears as an attempt to move the duration of your protection > to be longer than it really should be. > > https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf > At 2202.2(A) Advantages to Using Notice on Post-Berne Works > "It identifies the year of first publication, > which may be used to determine the term of copyright > protection in the case of an anonymous work, > a pseudonymous work, or a work made for hire." > > Much of our work, and in this case of Netflix and these > files, they are defanitly works made for hire, so this > applies and identifying first date of publication is > important. > > There is also: > At 2203.1 Works First Published Between January 1, 1978 and February 28, > 1989 > This Applies to some of our code, as it has First publications > in these date ranges, boils down to even though Berne says you dont > have to have a notice, if you first published the work in this time > frame you had to have a notice then, and you still have to have a > notice now. > > Yes, Disney and others have done fun stuff with copyrights on *movies*, > but that has other complications doing with re-mixes and all sorts of other > things that make it possible for them to claim it is a new creative > work, not just a revision of an old work. > > I could re research the case law if you really want more. > > > > > It would be much simpler for you to commit: > > > - * Copyright (C) 2018 Netflix > > > + * Copyright (C) 2017-2018 Netflix > > > > > > Than for me to get approval: bde, phk. > > > > > > Thanks. > > > Rod > > > > > > > > > > > > Not sure about dropping the , Inc either. > > > > > > > > > > > > Doesn't matter. Different Netflix committers do different things and > I > > > was > > > > trying to move towards uniformity. > > > > > > Ok > > > > > > > Warner > > > > > > -- > > > Rod Grimes > > > rgri...@freebsd.org > > > > > > > > -- > Rod Grimes > rgri...@freebsd.org > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
> On 13 June 2018 at 20:28, Rodney W. Grimes > wrote: > > > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < ... > > > > > @@ -1,7 +1,8 @@ > > > > > /*- > > > > > - * Copyright (c) 2017 Netflix, Inc > > > > > - * All rights reserved. > > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > > * > > > > > + * Copyright (C) 2018 Netflix > > > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > > > > Thought it was. I honestly don't care where (nor does my employer), so if > > > you want to tweak it to be more conforming, be my guest. > > > > You can add a new date to the end of a list, but you should always > > retain the oldest date, and many opinions are that all dates should > > be retained unless they are continuous. > > > > Do you have a citation for this, Rod? I ask because my impression was that > although it has often been done, and at one point may legitimately have > been required, it is not any longer so. I'd love to have a concrete source > on this, though. One place to start is circ15: https://www.copyright.gov/circs/circ15a.pdf Fundemental principle of copyright protections duration are from -first- date of publication, that is covered in USC 17. If you miss represent that date in your copyright your copyright can be held invalid. The real smoking gun is: 17 USC 401 b (2): the year of first publication of the work; in the case of compilations or derivative works incorporating previously published material, the year date of first publication of the compilation or derivative work is sufficient. The year date may be omitted where a pictorial, graphic, or sculptural work, with accompanying text matter, if any, is reproduced in or on greeting cards, postcards, stationery, jewelry, dolls, toys, or any useful articles; and The interpretation of compilation or derivative does open a grey area here in software, and I can see how one might consider a patch to create a derived work. There is case law that putting a date later than first publication appears as an attempt to move the duration of your protection to be longer than it really should be. https://www.copyright.gov/comp3/chap2200/ch2200-notice.pdf At 2202.2(A) Advantages to Using Notice on Post-Berne Works "It identifies the year of first publication, which may be used to determine the term of copyright protection in the case of an anonymous work, a pseudonymous work, or a work made for hire." Much of our work, and in this case of Netflix and these files, they are defanitly works made for hire, so this applies and identifying first date of publication is important. There is also: At 2203.1 Works First Published Between January 1, 1978 and February 28, 1989 This Applies to some of our code, as it has First publications in these date ranges, boils down to even though Berne says you dont have to have a notice, if you first published the work in this time frame you had to have a notice then, and you still have to have a notice now. Yes, Disney and others have done fun stuff with copyrights on *movies*, but that has other complications doing with re-mixes and all sorts of other things that make it possible for them to claim it is a new creative work, not just a revision of an old work. I could re research the case law if you really want more. > > It would be much simpler for you to commit: > > - * Copyright (C) 2018 Netflix > > + * Copyright (C) 2017-2018 Netflix > > > > Than for me to get approval: bde, phk. > > > > Thanks. > > Rod > > > > > > > > > Not sure about dropping the , Inc either. > > > > > > > > > Doesn't matter. Different Netflix committers do different things and I > > was > > > trying to move towards uniformity. > > > > Ok > > > > > Warner > > > > -- > > Rod Grimes > > rgri...@freebsd.org > > > > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
On Wed, Jun 13, 2018 at 10:57 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > Actually, that file (nvmecontrol_ext.h) is completely new. I'm not sure > why > > it thought I copied it from util.c. Maybe it's a git svn integration > thing. > > If it is a totally new file why is it showing contect diff with > + and -'s? Don't know, but the whole contents of this file is 1 line of extern function statements. Since util.c is short, and I try to use identical copyright notices, I'm thinking git thought it was a move through 'magic' and that's where svn got confused into thinking it was a copy + modification which is where the diff came from. Warner > > Warner > > > > On Wed, Jun 13, 2018 at 9:31 PM, Warner Losh wrote: > > > > > Ah, that's what you were talking about. OK. Will do. > > > > > > Warner > > > > > > On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < > > > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > > >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > >> > > > >> > > > Author: imp > > >> > > > Date: Wed Jun 13 22:00:02 2018 > > >> > > > New Revision: 335091 > > >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > >> > > > > > >> > > > Log: > > >> > > > Make it possible to use print_controller from another program > > >> > > > > > >> > > > Rename print_controller to nvme_print_controller. Put it in > its > > >> > > > own file for easy inclusion. Move util.c to be nc_util.c to > not > > >> > > > conflict with camcontrol. add nvecontrol_ext.h to define > shared > > >> > > > interfaces. > > >> > > > > > >> > > > Sponsored by: Netflix > > >> > > > Differential Revision: https://reviews.freebsd.org/D15371 > > >> > > > > > >> > > > Added: > > >> > > > head/sbin/nvmecontrol/identify_ext.c > > >> > > > - copied, changed from r335089, > head/sbin/nvmecontrol/identify > > >> .c > > >> > > > head/sbin/nvmecontrol/nc_util.c > > >> > > > - copied, changed from r335089, > head/sbin/nvmecontrol/util.c > > >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > > >> changed) > > >> > > > - copied, changed from r335089, > head/sbin/nvmecontrol/util.c > > >> > > ... > > >> > > > > >> > > > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h > (from > > >> > > r335089, head/sbin/nvmecontrol/util.c) > > >> > > > > > >> > > == > > >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > >> > > (r335089, copy source) > > >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 > 22:00:02 > > >> 2018 > > >> > > (r335091) > > >> > > > @@ -1,7 +1,8 @@ > > >> > > > /*- > > >> > > > - * Copyright (c) 2017 Netflix, Inc > > >> > > > - * All rights reserved. > > >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > >> > > > * > > >> > > > + * Copyright (C) 2018 Netflix > > >> > > > > >> > > You moved a copyright forward, that is not proper to do. > > >> > > > > >> > > > >> > Thought it was. I honestly don't care where (nor does my employer), > so > > >> if > > >> > you want to tweak it to be more conforming, be my guest. > > >> > > >> You can add a new date to the end of a list, but you should always > > >> retain the oldest date, and many opinions are that all dates should > > >> be retained unless they are continuous. > > >> > > >> It would be much simpler for you to commit: > > >> - * Copyright (C) 2018 Netflix > > >> + * Copyright (C) 2017-2018 Netflix > > >> > > >> Than for me to get approval: bde, phk. > > >> > > >> Thanks. > > >> Rod > > >> > > >> > > > >> > > Not sure about dropping the , Inc either. > > >> > > > >> > > > >> > Doesn't matter. Different Netflix committers do different things > and I > > >> was > > >> > trying to move towards uniformity. > > >> > > >> Ok > > >> > > >> > Warner > > >> > > >> -- > > >> Rod Grimes > > >> rgri...@freebsd.org > > >> > > > > > > > > -- > Rod Grimes > rgri...@freebsd.org > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
> On Wed, Jun 13, 2018 at 9:31 PM, Juli Mallett wrote: > > > On 13 June 2018 at 20:28, Rodney W. Grimes > > wrote: > > > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> > > >> > > > Author: imp > >> > > > Date: Wed Jun 13 22:00:02 2018 > >> > > > New Revision: 335091 > >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > >> > > > > >> > > > Log: > >> > > > Make it possible to use print_controller from another program > >> > > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its > >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not > >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > >> > > > interfaces. > >> > > > > >> > > > Sponsored by: Netflix > >> > > > Differential Revision: https://reviews.freebsd.org/D15371 > >> > > > > >> > > > Added: > >> > > > head/sbin/nvmecontrol/identify_ext.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify > >> .c > >> > > > head/sbin/nvmecontrol/nc_util.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > >> changed) > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > ... > >> > > > >> > > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > >> > > r335089, head/sbin/nvmecontrol/util.c) > >> > > > > >> > > == > >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > >> > > (r335089, copy source) > >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > >> 2018 > >> > > (r335091) > >> > > > @@ -1,7 +1,8 @@ > >> > > > /*- > >> > > > - * Copyright (c) 2017 Netflix, Inc > >> > > > - * All rights reserved. > >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > >> > > > * > >> > > > + * Copyright (C) 2018 Netflix > >> > > > >> > > You moved a copyright forward, that is not proper to do. > >> > > > >> > > >> > Thought it was. I honestly don't care where (nor does my employer), so > >> if > >> > you want to tweak it to be more conforming, be my guest. > >> > >> You can add a new date to the end of a list, but you should always > >> retain the oldest date, and many opinions are that all dates should > >> be retained unless they are continuous. > >> > > > > Do you have a citation for this, Rod? I ask because my impression was > > that although it has often been done, and at one point may legitimately > > have been required, it is not any longer so. I'd love to have a concrete > > source on this, though. > > > > The project just does oldest and newest with a -. > > The US copyright office says you just need the newest. There's some concern Can you be more specific on where on the US copyright offices site? > elsewhere is different, but I have nothing concrete on that. > > I've never heard Rod's advice in the 20 years I've been minding the store > here and at small shops I've worked at. And have any of these places actually read the text of USC 17? > Warner > > > > > > > It would be much simpler for you to commit: > >> - * Copyright (C) 2018 Netflix > >> + * Copyright (C) 2017-2018 Netflix > >> > >> Than for me to get approval: bde, phk. > >> > >> Thanks. > >> Rod > >> > >> > > >> > > Not sure about dropping the , Inc either. > >> > > >> > > >> > Doesn't matter. Different Netflix committers do different things and I > >> was > >> > trying to move towards uniformity. > >> > >> Ok > >> > >> > Warner > >> > >> -- > >> Rod Grimes > >> rgri...@freebsd.org > >> > >> > > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
[ Charset UTF-8 unsupported, converting... ] > Actually, that file (nvmecontrol_ext.h) is completely new. I'm not sure why > it thought I copied it from util.c. Maybe it's a git svn integration thing. If it is a totally new file why is it showing contect diff with + and -'s? > Warner > > On Wed, Jun 13, 2018 at 9:31 PM, Warner Losh wrote: > > > Ah, that's what you were talking about. OK. Will do. > > > > Warner > > > > On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < > > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> > > >> > > > Author: imp > >> > > > Date: Wed Jun 13 22:00:02 2018 > >> > > > New Revision: 335091 > >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > >> > > > > >> > > > Log: > >> > > > Make it possible to use print_controller from another program > >> > > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its > >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not > >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > >> > > > interfaces. > >> > > > > >> > > > Sponsored by: Netflix > >> > > > Differential Revision: https://reviews.freebsd.org/D15371 > >> > > > > >> > > > Added: > >> > > > head/sbin/nvmecontrol/identify_ext.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify > >> .c > >> > > > head/sbin/nvmecontrol/nc_util.c > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > >> changed) > >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > >> > > ... > >> > > > >> > > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > >> > > r335089, head/sbin/nvmecontrol/util.c) > >> > > > > >> > > == > >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > >> > > (r335089, copy source) > >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > >> 2018 > >> > > (r335091) > >> > > > @@ -1,7 +1,8 @@ > >> > > > /*- > >> > > > - * Copyright (c) 2017 Netflix, Inc > >> > > > - * All rights reserved. > >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > >> > > > * > >> > > > + * Copyright (C) 2018 Netflix > >> > > > >> > > You moved a copyright forward, that is not proper to do. > >> > > > >> > > >> > Thought it was. I honestly don't care where (nor does my employer), so > >> if > >> > you want to tweak it to be more conforming, be my guest. > >> > >> You can add a new date to the end of a list, but you should always > >> retain the oldest date, and many opinions are that all dates should > >> be retained unless they are continuous. > >> > >> It would be much simpler for you to commit: > >> - * Copyright (C) 2018 Netflix > >> + * Copyright (C) 2017-2018 Netflix > >> > >> Than for me to get approval: bde, phk. > >> > >> Thanks. > >> Rod > >> > >> > > >> > > Not sure about dropping the , Inc either. > >> > > >> > > >> > Doesn't matter. Different Netflix committers do different things and I > >> was > >> > trying to move towards uniformity. > >> > >> Ok > >> > >> > Warner > >> > >> -- > >> Rod Grimes > >> rgri...@freebsd.org > >> > > > > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
On Wed, Jun 13, 2018 at 9:31 PM, Juli Mallett wrote: > On 13 June 2018 at 20:28, Rodney W. Grimes > wrote: > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> > > > Author: imp >> > > > Date: Wed Jun 13 22:00:02 2018 >> > > > New Revision: 335091 >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 >> > > > >> > > > Log: >> > > > Make it possible to use print_controller from another program >> > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared >> > > > interfaces. >> > > > >> > > > Sponsored by: Netflix >> > > > Differential Revision: https://reviews.freebsd.org/D15371 >> > > > >> > > > Added: >> > > > head/sbin/nvmecontrol/identify_ext.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify >> .c >> > > > head/sbin/nvmecontrol/nc_util.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props >> changed) >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > ... >> > > >> > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from >> > > r335089, head/sbin/nvmecontrol/util.c) >> > > > >> > > == >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 >> > > (r335089, copy source) >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 >> 2018 >> > > (r335091) >> > > > @@ -1,7 +1,8 @@ >> > > > /*- >> > > > - * Copyright (c) 2017 Netflix, Inc >> > > > - * All rights reserved. >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD >> > > > * >> > > > + * Copyright (C) 2018 Netflix >> > > >> > > You moved a copyright forward, that is not proper to do. >> > > >> > >> > Thought it was. I honestly don't care where (nor does my employer), so >> if >> > you want to tweak it to be more conforming, be my guest. >> >> You can add a new date to the end of a list, but you should always >> retain the oldest date, and many opinions are that all dates should >> be retained unless they are continuous. >> > > Do you have a citation for this, Rod? I ask because my impression was > that although it has often been done, and at one point may legitimately > have been required, it is not any longer so. I'd love to have a concrete > source on this, though. > The project just does oldest and newest with a -. The US copyright office says you just need the newest. There's some concern elsewhere is different, but I have nothing concrete on that. I've never heard Rod's advice in the 20 years I've been minding the store here and at small shops I've worked at. Warner > > It would be much simpler for you to commit: >> - * Copyright (C) 2018 Netflix >> + * Copyright (C) 2017-2018 Netflix >> >> Than for me to get approval: bde, phk. >> >> Thanks. >> Rod >> >> > >> > > Not sure about dropping the , Inc either. >> > >> > >> > Doesn't matter. Different Netflix committers do different things and I >> was >> > trying to move towards uniformity. >> >> Ok >> >> > Warner >> >> -- >> Rod Grimes >> rgri...@freebsd.org >> >> > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
Actually, that file (nvmecontrol_ext.h) is completely new. I'm not sure why it thought I copied it from util.c. Maybe it's a git svn integration thing. Warner On Wed, Jun 13, 2018 at 9:31 PM, Warner Losh wrote: > Ah, that's what you were talking about. OK. Will do. > > Warner > > On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > >> > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < >> > free...@pdx.rh.cn85.dnsmgr.net> wrote: >> > >> > > > Author: imp >> > > > Date: Wed Jun 13 22:00:02 2018 >> > > > New Revision: 335091 >> > > > URL: https://svnweb.freebsd.org/changeset/base/335091 >> > > > >> > > > Log: >> > > > Make it possible to use print_controller from another program >> > > > >> > > > Rename print_controller to nvme_print_controller. Put it in its >> > > > own file for easy inclusion. Move util.c to be nc_util.c to not >> > > > conflict with camcontrol. add nvecontrol_ext.h to define shared >> > > > interfaces. >> > > > >> > > > Sponsored by: Netflix >> > > > Differential Revision: https://reviews.freebsd.org/D15371 >> > > > >> > > > Added: >> > > > head/sbin/nvmecontrol/identify_ext.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify >> .c >> > > > head/sbin/nvmecontrol/nc_util.c >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props >> changed) >> > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c >> > > ... >> > > >> > > > >> > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from >> > > r335089, head/sbin/nvmecontrol/util.c) >> > > > >> > > == >> > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 >> > > (r335089, copy source) >> > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 >> 2018 >> > > (r335091) >> > > > @@ -1,7 +1,8 @@ >> > > > /*- >> > > > - * Copyright (c) 2017 Netflix, Inc >> > > > - * All rights reserved. >> > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD >> > > > * >> > > > + * Copyright (C) 2018 Netflix >> > > >> > > You moved a copyright forward, that is not proper to do. >> > > >> > >> > Thought it was. I honestly don't care where (nor does my employer), so >> if >> > you want to tweak it to be more conforming, be my guest. >> >> You can add a new date to the end of a list, but you should always >> retain the oldest date, and many opinions are that all dates should >> be retained unless they are continuous. >> >> It would be much simpler for you to commit: >> - * Copyright (C) 2018 Netflix >> + * Copyright (C) 2017-2018 Netflix >> >> Than for me to get approval: bde, phk. >> >> Thanks. >> Rod >> >> > >> > > Not sure about dropping the , Inc either. >> > >> > >> > Doesn't matter. Different Netflix committers do different things and I >> was >> > trying to move towards uniformity. >> >> Ok >> >> > Warner >> >> -- >> Rod Grimes >> rgri...@freebsd.org >> > > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
On 13 June 2018 at 20:28, Rodney W. Grimes wrote: > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > Author: imp > > > > Date: Wed Jun 13 22:00:02 2018 > > > > New Revision: 335091 > > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > > > > > Log: > > > > Make it possible to use print_controller from another program > > > > > > > > Rename print_controller to nvme_print_controller. Put it in its > > > > own file for easy inclusion. Move util.c to be nc_util.c to not > > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > > > interfaces. > > > > > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > > > > > Added: > > > > head/sbin/nvmecontrol/identify_ext.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/ > identify.c > > > > head/sbin/nvmecontrol/nc_util.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > changed) > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > ... > > > > > > > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > > > r335089, head/sbin/nvmecontrol/util.c) > > > > > > > == > > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > > (r335089, copy source) > > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > 2018 > > > (r335091) > > > > @@ -1,7 +1,8 @@ > > > > /*- > > > > - * Copyright (c) 2017 Netflix, Inc > > > > - * All rights reserved. > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > * > > > > + * Copyright (C) 2018 Netflix > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > Thought it was. I honestly don't care where (nor does my employer), so if > > you want to tweak it to be more conforming, be my guest. > > You can add a new date to the end of a list, but you should always > retain the oldest date, and many opinions are that all dates should > be retained unless they are continuous. > Do you have a citation for this, Rod? I ask because my impression was that although it has often been done, and at one point may legitimately have been required, it is not any longer so. I'd love to have a concrete source on this, though. > It would be much simpler for you to commit: > - * Copyright (C) 2018 Netflix > + * Copyright (C) 2017-2018 Netflix > > Than for me to get approval: bde, phk. > > Thanks. > Rod > > > > > > Not sure about dropping the , Inc either. > > > > > > Doesn't matter. Different Netflix committers do different things and I > was > > trying to move towards uniformity. > > Ok > > > Warner > > -- > Rod Grimes > rgri...@freebsd.org > > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
Ah, that's what you were talking about. OK. Will do. Warner On Wed, Jun 13, 2018 at 9:28 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > > > Author: imp > > > > Date: Wed Jun 13 22:00:02 2018 > > > > New Revision: 335091 > > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > > > > > Log: > > > > Make it possible to use print_controller from another program > > > > > > > > Rename print_controller to nvme_print_controller. Put it in its > > > > own file for easy inclusion. Move util.c to be nc_util.c to not > > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > > > interfaces. > > > > > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > > > > > Added: > > > > head/sbin/nvmecontrol/identify_ext.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/ > identify.c > > > > head/sbin/nvmecontrol/nc_util.c > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props > changed) > > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > ... > > > > > > > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > > > r335089, head/sbin/nvmecontrol/util.c) > > > > > > > == > > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > > (r335089, copy source) > > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 > 2018 > > > (r335091) > > > > @@ -1,7 +1,8 @@ > > > > /*- > > > > - * Copyright (c) 2017 Netflix, Inc > > > > - * All rights reserved. > > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > > * > > > > + * Copyright (C) 2018 Netflix > > > > > > You moved a copyright forward, that is not proper to do. > > > > > > > Thought it was. I honestly don't care where (nor does my employer), so if > > you want to tweak it to be more conforming, be my guest. > > You can add a new date to the end of a list, but you should always > retain the oldest date, and many opinions are that all dates should > be retained unless they are continuous. > > It would be much simpler for you to commit: > - * Copyright (C) 2018 Netflix > + * Copyright (C) 2017-2018 Netflix > > Than for me to get approval: bde, phk. > > Thanks. > Rod > > > > > > Not sure about dropping the , Inc either. > > > > > > Doesn't matter. Different Netflix committers do different things and I > was > > trying to move towards uniformity. > > Ok > > > Warner > > -- > Rod Grimes > rgri...@freebsd.org > ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
> On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < > free...@pdx.rh.cn85.dnsmgr.net> wrote: > > > > Author: imp > > > Date: Wed Jun 13 22:00:02 2018 > > > New Revision: 335091 > > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > > > Log: > > > Make it possible to use print_controller from another program > > > > > > Rename print_controller to nvme_print_controller. Put it in its > > > own file for easy inclusion. Move util.c to be nc_util.c to not > > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > > interfaces. > > > > > > Sponsored by: Netflix > > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > > > Added: > > > head/sbin/nvmecontrol/identify_ext.c > > > - copied, changed from r335089, head/sbin/nvmecontrol/identify.c > > > head/sbin/nvmecontrol/nc_util.c > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed) > > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > ... > > > > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > > r335089, head/sbin/nvmecontrol/util.c) > > > > > == > > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > > (r335089, copy source) > > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 2018 > > (r335091) > > > @@ -1,7 +1,8 @@ > > > /*- > > > - * Copyright (c) 2017 Netflix, Inc > > > - * All rights reserved. > > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > > * > > > + * Copyright (C) 2018 Netflix > > > > You moved a copyright forward, that is not proper to do. > > > > Thought it was. I honestly don't care where (nor does my employer), so if > you want to tweak it to be more conforming, be my guest. You can add a new date to the end of a list, but you should always retain the oldest date, and many opinions are that all dates should be retained unless they are continuous. It would be much simpler for you to commit: - * Copyright (C) 2018 Netflix + * Copyright (C) 2017-2018 Netflix Than for me to get approval: bde, phk. Thanks. Rod > > > Not sure about dropping the , Inc either. > > > Doesn't matter. Different Netflix committers do different things and I was > trying to move towards uniformity. Ok > Warner -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
On Wed, Jun 13, 2018 at 9:03 PM, Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > > Author: imp > > Date: Wed Jun 13 22:00:02 2018 > > New Revision: 335091 > > URL: https://svnweb.freebsd.org/changeset/base/335091 > > > > Log: > > Make it possible to use print_controller from another program > > > > Rename print_controller to nvme_print_controller. Put it in its > > own file for easy inclusion. Move util.c to be nc_util.c to not > > conflict with camcontrol. add nvecontrol_ext.h to define shared > > interfaces. > > > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D15371 > > > > Added: > > head/sbin/nvmecontrol/identify_ext.c > > - copied, changed from r335089, head/sbin/nvmecontrol/identify.c > > head/sbin/nvmecontrol/nc_util.c > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed) > > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > ... > > > > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from > r335089, head/sbin/nvmecontrol/util.c) > > > == > > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > (r335089, copy source) > > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 2018 > (r335091) > > @@ -1,7 +1,8 @@ > > /*- > > - * Copyright (c) 2017 Netflix, Inc > > - * All rights reserved. > > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > > * > > + * Copyright (C) 2018 Netflix > > You moved a copyright forward, that is not proper to do. > Thought it was. I honestly don't care where (nor does my employer), so if you want to tweak it to be more conforming, be my guest. > Not sure about dropping the , Inc either. Doesn't matter. Different Netflix committers do different things and I was trying to move towards uniformity. Warner ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r335091 - head/sbin/nvmecontrol
> Author: imp > Date: Wed Jun 13 22:00:02 2018 > New Revision: 335091 > URL: https://svnweb.freebsd.org/changeset/base/335091 > > Log: > Make it possible to use print_controller from another program > > Rename print_controller to nvme_print_controller. Put it in its > own file for easy inclusion. Move util.c to be nc_util.c to not > conflict with camcontrol. add nvecontrol_ext.h to define shared > interfaces. > > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D15371 > > Added: > head/sbin/nvmecontrol/identify_ext.c > - copied, changed from r335089, head/sbin/nvmecontrol/identify.c > head/sbin/nvmecontrol/nc_util.c > - copied, changed from r335089, head/sbin/nvmecontrol/util.c > head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed) > - copied, changed from r335089, head/sbin/nvmecontrol/util.c ... > > Copied and modified: head/sbin/nvmecontrol/nvmecontrol_ext.h (from r335089, > head/sbin/nvmecontrol/util.c) > == > --- head/sbin/nvmecontrol/util.c Wed Jun 13 21:10:23 2018 > (r335089, copy source) > +++ head/sbin/nvmecontrol/nvmecontrol_ext.h Wed Jun 13 22:00:02 2018 > (r335091) > @@ -1,7 +1,8 @@ > /*- > - * Copyright (c) 2017 Netflix, Inc > - * All rights reserved. > + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD > * > + * Copyright (C) 2018 Netflix You moved a copyright forward, that is not proper to do. Not sure about dropping the , Inc either. > + * > * Redistribution and use in source and binary forms, with or without > * modification, are permitted provided that the following conditions > * are met: > @@ -22,38 +23,8 @@ > * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > * SUCH DAMAGE. > + * > + * $FreeBSD$ > */ > -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r335091 - head/sbin/nvmecontrol
Author: imp
Date: Wed Jun 13 22:00:02 2018
New Revision: 335091
URL: https://svnweb.freebsd.org/changeset/base/335091
Log:
Make it possible to use print_controller from another program
Rename print_controller to nvme_print_controller. Put it in its
own file for easy inclusion. Move util.c to be nc_util.c to not
conflict with camcontrol. add nvecontrol_ext.h to define shared
interfaces.
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D15371
Added:
head/sbin/nvmecontrol/identify_ext.c
- copied, changed from r335089, head/sbin/nvmecontrol/identify.c
head/sbin/nvmecontrol/nc_util.c
- copied, changed from r335089, head/sbin/nvmecontrol/util.c
head/sbin/nvmecontrol/nvmecontrol_ext.h (contents, props changed)
- copied, changed from r335089, head/sbin/nvmecontrol/util.c
Deleted:
head/sbin/nvmecontrol/util.c
Modified:
head/sbin/nvmecontrol/Makefile
head/sbin/nvmecontrol/identify.c
Modified: head/sbin/nvmecontrol/Makefile
==
--- head/sbin/nvmecontrol/Makefile Wed Jun 13 21:10:33 2018
(r335090)
+++ head/sbin/nvmecontrol/Makefile Wed Jun 13 22:00:02 2018
(r335091)
@@ -2,8 +2,8 @@
PACKAGE=runtime
PROG= nvmecontrol
-SRCS= nvmecontrol.c devlist.c firmware.c format.c identify.c logpage.c \
- perftest.c reset.c ns.c nvme_util.c power.c util.c wdc.c
+SRCS= nvmecontrol.c devlist.c firmware.c format.c identify.c identify_ext.c
logpage.c \
+ perftest.c reset.c ns.c nvme_util.c power.c nc_util.c wdc.c
MAN= nvmecontrol.8
.PATH: ${SRCTOP}/sys/dev/nvme
Modified: head/sbin/nvmecontrol/identify.c
==
--- head/sbin/nvmecontrol/identify.cWed Jun 13 21:10:33 2018
(r335090)
+++ head/sbin/nvmecontrol/identify.cWed Jun 13 22:00:02 2018
(r335091)
@@ -41,187 +41,9 @@ __FBSDID("$FreeBSD$");
#include
#include "nvmecontrol.h"
+#include "nvmecontrol_ext.h"
static void
-print_controller(struct nvme_controller_data *cdata)
-{
- uint8_t str[128];
- char cbuf[UINT128_DIG + 1];
- uint16_t oncs, oacs;
- uint8_t compare, write_unc, dsm, vwc_present;
- uint8_t security, fmt, fw, nsmgmt;
- uint8_t fw_slot1_ro, fw_num_slots;
- uint8_t ns_smart;
- uint8_t sqes_max, sqes_min;
- uint8_t cqes_max, cqes_min;
-
- oncs = cdata->oncs;
- compare = (oncs >> NVME_CTRLR_DATA_ONCS_COMPARE_SHIFT) &
- NVME_CTRLR_DATA_ONCS_COMPARE_MASK;
- write_unc = (oncs >> NVME_CTRLR_DATA_ONCS_WRITE_UNC_SHIFT) &
- NVME_CTRLR_DATA_ONCS_WRITE_UNC_MASK;
- dsm = (oncs >> NVME_CTRLR_DATA_ONCS_DSM_SHIFT) &
- NVME_CTRLR_DATA_ONCS_DSM_MASK;
- vwc_present = (cdata->vwc >> NVME_CTRLR_DATA_VWC_PRESENT_SHIFT) &
- NVME_CTRLR_DATA_VWC_PRESENT_MASK;
-
- oacs = cdata->oacs;
- security = (oacs >> NVME_CTRLR_DATA_OACS_SECURITY_SHIFT) &
- NVME_CTRLR_DATA_OACS_SECURITY_MASK;
- fmt = (oacs >> NVME_CTRLR_DATA_OACS_FORMAT_SHIFT) &
- NVME_CTRLR_DATA_OACS_FORMAT_MASK;
- fw = (oacs >> NVME_CTRLR_DATA_OACS_FIRMWARE_SHIFT) &
- NVME_CTRLR_DATA_OACS_FIRMWARE_MASK;
- nsmgmt = (oacs >> NVME_CTRLR_DATA_OACS_NSMGMT_SHIFT) &
- NVME_CTRLR_DATA_OACS_NSMGMT_MASK;
-
- fw_num_slots = (cdata->frmw >> NVME_CTRLR_DATA_FRMW_NUM_SLOTS_SHIFT) &
- NVME_CTRLR_DATA_FRMW_NUM_SLOTS_MASK;
- fw_slot1_ro = (cdata->frmw >> NVME_CTRLR_DATA_FRMW_SLOT1_RO_SHIFT) &
- NVME_CTRLR_DATA_FRMW_SLOT1_RO_MASK;
-
- ns_smart = (cdata->lpa >> NVME_CTRLR_DATA_LPA_NS_SMART_SHIFT) &
- NVME_CTRLR_DATA_LPA_NS_SMART_MASK;
-
- sqes_min = (cdata->sqes >> NVME_CTRLR_DATA_SQES_MIN_SHIFT) &
- NVME_CTRLR_DATA_SQES_MIN_MASK;
- sqes_max = (cdata->sqes >> NVME_CTRLR_DATA_SQES_MAX_SHIFT) &
- NVME_CTRLR_DATA_SQES_MAX_MASK;
-
- cqes_min = (cdata->cqes >> NVME_CTRLR_DATA_CQES_MIN_SHIFT) &
- NVME_CTRLR_DATA_CQES_MIN_MASK;
- cqes_max = (cdata->cqes >> NVME_CTRLR_DATA_CQES_MAX_SHIFT) &
- NVME_CTRLR_DATA_CQES_MAX_MASK;
-
- printf("Controller Capabilities/Features\n");
- printf("\n");
- printf("Vendor ID: %04x\n", cdata->vid);
- printf("Subsystem Vendor ID: %04x\n", cdata->ssvid);
- nvme_strvis(str, cdata->sn, sizeof(str), NVME_SERIAL_NUMBER_LENGTH);
- printf("Serial Number: %s\n", str);
- nvme_strvis(str, cdata->mn, sizeof(str), NVME_MODEL_NUMBER_LENGTH);
- printf("Model Number:%s\n", str);
- nvme_strvis(str, cdata->fr, sizeof(str), NVME_FIRMWARE_REVISION_LENGTH);
- printf("Firmware Version:%s\n", str);
- printf("Recommended Arb Burst:
