Re: svn commit: r336742 - in head: etc sbin/dump

2018-07-27 Thread Brad Davis
On Fri, Jul 27, 2018, at 4:07 PM, Brad Davis wrote:
> On Fri, Jul 27, 2018, at 3:30 PM, Brad Davis wrote:
> > On Fri, Jul 27, 2018, at 3:26 PM, Antoine Brodin wrote:
> > > On Thu, Jul 26, 2018 at 6:45 PM, Brad Davis  wrote:
> > > > Author: brd
> > > > Date: Thu Jul 26 16:45:25 2018
> > > > New Revision: 336742
> > > > URL: https://svnweb.freebsd.org/changeset/base/336742
> > > >
> > > > Log:
> > > >   Move dumpdates creation to CONFS=
> > > >
> > > >   Approved by:  bapt (mentor)
> > > >   Differential Revision:https://reviews.freebsd.org/D16435
> > > 
> > > Hi,
> > > 
> > > This commit seems to prevent successful installation of FreeBSD.
> > 
> > It only seems to prevent upgrades, so my build a release VM test is not 
> > enough..  I am working on it right now.
> 
> I found the issue and I opened up the following review for one of my 
> mentors to approve and have prodded them:
> 
> https://reviews.freebsd.org/D16476
> 
> install(1) should be fixed, but this gets around the issue quickly so 
> people can move on.

Committed in r336794.


Regards,
Brad Davis
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r336742 - in head: etc sbin/dump

2018-07-27 Thread Brad Davis
On Fri, Jul 27, 2018, at 3:30 PM, Brad Davis wrote:
> On Fri, Jul 27, 2018, at 3:26 PM, Antoine Brodin wrote:
> > On Thu, Jul 26, 2018 at 6:45 PM, Brad Davis  wrote:
> > > Author: brd
> > > Date: Thu Jul 26 16:45:25 2018
> > > New Revision: 336742
> > > URL: https://svnweb.freebsd.org/changeset/base/336742
> > >
> > > Log:
> > >   Move dumpdates creation to CONFS=
> > >
> > >   Approved by:  bapt (mentor)
> > >   Differential Revision:https://reviews.freebsd.org/D16435
> > 
> > Hi,
> > 
> > This commit seems to prevent successful installation of FreeBSD.
> 
> It only seems to prevent upgrades, so my build a release VM test is not 
> enough..  I am working on it right now.

I found the issue and I opened up the following review for one of my mentors to 
approve and have prodded them:

https://reviews.freebsd.org/D16476

install(1) should be fixed, but this gets around the issue quickly so people 
can move on.


Regards,
Brad Davis
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r336742 - in head: etc sbin/dump

2018-07-27 Thread Brad Davis
On Fri, Jul 27, 2018, at 3:26 PM, Antoine Brodin wrote:
> On Thu, Jul 26, 2018 at 6:45 PM, Brad Davis  wrote:
> > Author: brd
> > Date: Thu Jul 26 16:45:25 2018
> > New Revision: 336742
> > URL: https://svnweb.freebsd.org/changeset/base/336742
> >
> > Log:
> >   Move dumpdates creation to CONFS=
> >
> >   Approved by:  bapt (mentor)
> >   Differential Revision:https://reviews.freebsd.org/D16435
> 
> Hi,
> 
> This commit seems to prevent successful installation of FreeBSD.

It only seems to prevent upgrades, so my build a release VM test is not 
enough..  I am working on it right now.


Regards,
Brad Davis
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r336742 - in head: etc sbin/dump

2018-07-27 Thread Antoine Brodin
On Thu, Jul 26, 2018 at 6:45 PM, Brad Davis  wrote:
> Author: brd
> Date: Thu Jul 26 16:45:25 2018
> New Revision: 336742
> URL: https://svnweb.freebsd.org/changeset/base/336742
>
> Log:
>   Move dumpdates creation to CONFS=
>
>   Approved by:  bapt (mentor)
>   Differential Revision:https://reviews.freebsd.org/D16435

Hi,

This commit seems to prevent successful installation of FreeBSD.

Cheers,

Antoine

>
> Modified:
>   head/etc/Makefile
>   head/sbin/dump/Makefile
>
> Modified: head/etc/Makefile
> ==
> --- head/etc/Makefile   Thu Jul 26 16:08:34 2018(r336741)
> +++ head/etc/Makefile   Thu Jul 26 16:45:25 2018(r336742)
> @@ -296,8 +296,6 @@ distribution:
> ${INSTALL_SYMLINK} mail/aliases ${DESTDIR}/etc/aliases; \
> fi
>  .endif
> -   ${INSTALL} -o ${BINOWN} -g operator -m 664 /dev/null \
> -   ${DESTDIR}/etc/dumpdates
>  .if ${MK_LOCATE} != "no"
> ${INSTALL} -o nobody -g ${BINGRP} -m 644 /dev/null \
> ${DESTDIR}/var/db/locate.database
>
> Modified: head/sbin/dump/Makefile
> ==
> --- head/sbin/dump/Makefile Thu Jul 26 16:08:34 2018(r336741)
> +++ head/sbin/dump/Makefile Thu Jul 26 16:45:25 2018(r336742)
> @@ -15,6 +15,10 @@
>
>  PACKAGE=runtime
>  PROG=  dump
> +CONFS= /dev/null
> +CONFSGRP=  operator
> +CONFSMODE= 664
> +CONFSNAME_/dev/null=   dumpdates
>  LINKS= ${BINDIR}/dump ${BINDIR}/rdump
>  CFLAGS+=-DRDUMP
>  SRCS=  itime.c main.c optr.c dumprmt.c tape.c traverse.c unctime.c cache.c
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r336742 - in head: etc sbin/dump

2018-07-26 Thread Brad Davis
Author: brd
Date: Thu Jul 26 16:45:25 2018
New Revision: 336742
URL: https://svnweb.freebsd.org/changeset/base/336742

Log:
  Move dumpdates creation to CONFS=
  
  Approved by:  bapt (mentor)
  Differential Revision:https://reviews.freebsd.org/D16435

Modified:
  head/etc/Makefile
  head/sbin/dump/Makefile

Modified: head/etc/Makefile
==
--- head/etc/Makefile   Thu Jul 26 16:08:34 2018(r336741)
+++ head/etc/Makefile   Thu Jul 26 16:45:25 2018(r336742)
@@ -296,8 +296,6 @@ distribution:
${INSTALL_SYMLINK} mail/aliases ${DESTDIR}/etc/aliases; \
fi
 .endif
-   ${INSTALL} -o ${BINOWN} -g operator -m 664 /dev/null \
-   ${DESTDIR}/etc/dumpdates
 .if ${MK_LOCATE} != "no"
${INSTALL} -o nobody -g ${BINGRP} -m 644 /dev/null \
${DESTDIR}/var/db/locate.database

Modified: head/sbin/dump/Makefile
==
--- head/sbin/dump/Makefile Thu Jul 26 16:08:34 2018(r336741)
+++ head/sbin/dump/Makefile Thu Jul 26 16:45:25 2018(r336742)
@@ -15,6 +15,10 @@
 
 PACKAGE=runtime
 PROG=  dump
+CONFS= /dev/null
+CONFSGRP=  operator
+CONFSMODE= 664
+CONFSNAME_/dev/null=   dumpdates
 LINKS= ${BINDIR}/dump ${BINDIR}/rdump
 CFLAGS+=-DRDUMP
 SRCS=  itime.c main.c optr.c dumprmt.c tape.c traverse.c unctime.c cache.c
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"