Re: svn commit: r341446 - head/release/amd64

[Ed Maste]

On Tue, 4 Dec 2018 at 03:38, Oliver Pinter
 wrote:
>
> No problem. Ed was directly CCd and notified on IRC.

Sorry for losing track of this one.

(If there's anything else that you expect I'm looking at but haven't
seen an update in a while please feel free to ping me.)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r341446 - head/release/amd64

[Rodney W. Grimes]

> Alexey Dokuchaev wrote:
> > On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote:
> >> New Revision: 341446
> >> URL: https://svnweb.freebsd.org/changeset/base/341446
> >>
> >> Log:
> >>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
> >>   
> >>   This fixes 'cdrom' target in the case when world was built by user,
> >>   and not root.
> > 
> > Could you please explain why -p should not have been used here?  I fail
> > to understand this from the commit log.  I've always considered preserving
> > various file metadata as a good thing to do, and this commit puzzles me.
> 
> Because the target is on msdosfs, and the only metadata that can be
> preserved is modification time which isn't that useful with the file
> being hidden in ESP.  OTOH, 'cp -p' fails trying to preserve owner/group
> if source is not owned by root (as commit message says).  Additional
> 'chmod' call done in HBSD doesn't do much as well -- it seems we can
> only set/unset owner's 'write' flag which corresponds to DOS 'readonly'
> attribute.
> 

I agree with this assesment, and the present state of the script,
besides cp followed by chmod is usually spelled ${INSTALL}.


-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r341446 - head/release/amd64

[Alexey Dokuchaev]

On Tue, Dec 04, 2018 at 11:52:34AM +0300, Yuri Pankov wrote:
> Alexey Dokuchaev wrote:
> > On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote:
> >> New Revision: 341446
> >> URL: https://svnweb.freebsd.org/changeset/base/341446
> >>
> >> Log:
> >>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
> >>   
> >>   This fixes 'cdrom' target in the case when world was built by user,
> >>   and not root.
> > 
> > Could you please explain why -p should not have been used here?  I fail
> > to understand this from the commit log.  I've always considered preserving
> > various file metadata as a good thing to do, and this commit puzzles me.
> 
> Because the target is on msdosfs, and the only metadata that can be
> preserved is modification time which isn't that useful with the file
> being hidden in ESP.  OTOH, 'cp -p' fails trying to preserve owner/group
> if source is not owned by root (as commit message says).  Additional
> 'chmod' call done in HBSD doesn't do much as well -- it seems we can
> only set/unset owner's 'write' flag which corresponds to DOS 'readonly'
> attribute.

Ah, I see now, so cp(1) was failing and that upset 'set -e'.  Thanks for
explanation.

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r341446 - head/release/amd64

[Yuri Pankov]

Alexey Dokuchaev wrote:
> On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote:
>> New Revision: 341446
>> URL: https://svnweb.freebsd.org/changeset/base/341446
>>
>> Log:
>>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
>>   
>>   This fixes 'cdrom' target in the case when world was built by user,
>>   and not root.
> 
> Could you please explain why -p should not have been used here?  I fail
> to understand this from the commit log.  I've always considered preserving
> various file metadata as a good thing to do, and this commit puzzles me.

Because the target is on msdosfs, and the only metadata that can be
preserved is modification time which isn't that useful with the file
being hidden in ESP.  OTOH, 'cp -p' fails trying to preserve owner/group
if source is not owned by root (as commit message says).  Additional
'chmod' call done in HBSD doesn't do much as well -- it seems we can
only set/unset owner's 'write' flag which corresponds to DOS 'readonly'
attribute.



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r341446 - head/release/amd64

[Alexey Dokuchaev]

On Mon, Dec 03, 2018 at 10:31:57PM +, Yuri Pankov wrote:
> New Revision: 341446
> URL: https://svnweb.freebsd.org/changeset/base/341446
> 
> Log:
>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
>   
>   This fixes 'cdrom' target in the case when world was built by user,
>   and not root.

Could you please explain why -p should not have been used here?  I fail
to understand this from the commit log.  I've always considered preserving
various file metadata as a good thing to do, and this commit puzzles me.

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r341446 - head/release/amd64

[Oliver Pinter]

On Tuesday, December 4, 2018, Yuri Pankov  wrote:

> Oliver Pinter wrote:
> >
> >
> > On Monday, December 3, 2018, Yuri Pankov  > > wrote:
> >
> > Author: yuripv
> > Date: Mon Dec  3 22:31:57 2018
> > New Revision: 341446
> > URL: https://svnweb.freebsd.org/changeset/base/341446
> > 
> >
> > Log:
> >   mkisoimages.sh: don't use -p flag when copying loader.efi to
> msdosfs.
> >
> >   This fixes 'cdrom' target in the case when world was built by user,
> >   and not root.
> >
> >   Reviewed by:  imp
> >   Differential revision:https://reviews.freebsd.org/D18414
> > 
> >
> >
> > This was a known issue
> > : https://lists.freebsd.org/pipermail/svn-src-head/2018-
> November/119689.html
>
> Sorry, I missed that.



No problem. Ed was directly CCd and notified on IRC.


>
> Looking at the HBSD change, does chmod step have any significance?



 It just ensures the correct file permissions.


> > Modified:
> >   head/release/amd64/mkisoimages.sh
> >
> > Modified: head/release/amd64/mkisoimages.sh
> > 
> ==
> > --- head/release/amd64/mkisoimages.sh   Mon Dec  3 22:09:23 2018
> > (r341445)
> > +++ head/release/amd64/mkisoimages.sh   Mon Dec  3 22:31:57 2018
> > (r341446)
> > @@ -49,7 +49,7 @@ if [ "$1" = "-b" ]; then
> > mkdir efi
> > mount -t msdosfs /dev/$device efi
> > mkdir -p efi/efi/boot
> > -   cp -p "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
> > +   cp "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
> > umount efi
> > rmdir efi
> > mdconfig -d -u $device
> > ___
> > svn-src-h...@freebsd.org  mailing
> list
> > https://lists.freebsd.org/mailman/listinfo/svn-src-head
> > 
> > To unsubscribe, send any mail to
> > "svn-src-head-unsubscr...@freebsd.org
> > "
> >
>
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r341446 - head/release/amd64

[Yuri Pankov]

Oliver Pinter wrote:
> 
> 
> On Monday, December 3, 2018, Yuri Pankov  > wrote:
> 
> Author: yuripv
> Date: Mon Dec  3 22:31:57 2018
> New Revision: 341446
> URL: https://svnweb.freebsd.org/changeset/base/341446
> 
> 
> Log:
>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
> 
>   This fixes 'cdrom' target in the case when world was built by user,
>   and not root.
> 
>   Reviewed by:  imp
>   Differential revision:        https://reviews.freebsd.org/D18414
> 
> 
> 
> This was a known issue
> : https://lists.freebsd.org/pipermail/svn-src-head/2018-November/119689.html

Sorry, I missed that.

Looking at the HBSD change, does chmod step have any significance?

> Modified:
>   head/release/amd64/mkisoimages.sh
> 
> Modified: head/release/amd64/mkisoimages.sh
> 
> ==
> --- head/release/amd64/mkisoimages.sh   Mon Dec  3 22:09:23 2018   
>     (r341445)
> +++ head/release/amd64/mkisoimages.sh   Mon Dec  3 22:31:57 2018   
>     (r341446)
> @@ -49,7 +49,7 @@ if [ "$1" = "-b" ]; then
>         mkdir efi
>         mount -t msdosfs /dev/$device efi
>         mkdir -p efi/efi/boot
> -       cp -p "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
> +       cp "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
>         umount efi
>         rmdir efi
>         mdconfig -d -u $device
> ___
> svn-src-h...@freebsd.org  mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> 
> To unsubscribe, send any mail to
> "svn-src-head-unsubscr...@freebsd.org
> "
> 




signature.asc
Description: OpenPGP digital signature

Re: svn commit: r341446 - head/release/amd64

[Oliver Pinter]

On Monday, December 3, 2018, Yuri Pankov  wrote:

> Author: yuripv
> Date: Mon Dec  3 22:31:57 2018
> New Revision: 341446
> URL: https://svnweb.freebsd.org/changeset/base/341446
>
> Log:
>   mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
>
>   This fixes 'cdrom' target in the case when world was built by user,
>   and not root.
>
>   Reviewed by:  imp
>   Differential revision:https://reviews.freebsd.org/D18414
>
>
This was a known issue :
https://lists.freebsd.org/pipermail/svn-src-head/2018-November/119689.html


> Modified:
>   head/release/amd64/mkisoimages.sh
>
> Modified: head/release/amd64/mkisoimages.sh
> 
> ==
> --- head/release/amd64/mkisoimages.sh   Mon Dec  3 22:09:23 2018
> (r341445)
> +++ head/release/amd64/mkisoimages.sh   Mon Dec  3 22:31:57 2018
> (r341446)
> @@ -49,7 +49,7 @@ if [ "$1" = "-b" ]; then
> mkdir efi
> mount -t msdosfs /dev/$device efi
> mkdir -p efi/efi/boot
> -   cp -p "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
> +   cp "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
> umount efi
> rmdir efi
> mdconfig -d -u $device
> ___
> svn-src-h...@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-head
> To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r341446 - head/release/amd64

[Yuri Pankov]

Author: yuripv
Date: Mon Dec  3 22:31:57 2018
New Revision: 341446
URL: https://svnweb.freebsd.org/changeset/base/341446

Log:
  mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs.
  
  This fixes 'cdrom' target in the case when world was built by user,
  and not root.
  
  Reviewed by:  imp
  Differential revision:https://reviews.freebsd.org/D18414

Modified:
  head/release/amd64/mkisoimages.sh

Modified: head/release/amd64/mkisoimages.sh
==
--- head/release/amd64/mkisoimages.sh   Mon Dec  3 22:09:23 2018
(r341445)
+++ head/release/amd64/mkisoimages.sh   Mon Dec  3 22:31:57 2018
(r341446)
@@ -49,7 +49,7 @@ if [ "$1" = "-b" ]; then
mkdir efi
mount -t msdosfs /dev/$device efi
mkdir -p efi/efi/boot
-   cp -p "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
+   cp "$BASEBITSDIR/boot/loader.efi" efi/efi/boot/bootx64.efi
umount efi
rmdir efi
mdconfig -d -u $device
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"