Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 7:09 PM Li-Wen Hsu wrote: > > On Wed, Feb 19, 2020 at 5:04 PM Dimitry Andric wrote: > > > > On 2020-02-18 09:11, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Tue Feb 18 08:11:52 2020 > > > New Revision: 358062 > > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > > > Log: > > >Update ncurses to 20200118 > > > > Apparently this breaks the gcc builds, because it can't find the > > function "box" anymore: > > > > --- all_subdir_usr.bin/clang/lldb --- > > /usr/local/bin/x86_64-unknown-freebsd12.0-ld: > > /tmp/obj/workspace/src/amd64.amd64/lib/clang/liblldb/liblldb.a(IOHandler.o): > > in function `curses::Window::Box(unsigned int, unsigned int)': > > /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: > > undefined reference to `box' > > /usr/local/bin/x86_64-unknown-freebsd12.0-ld: > > /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: > > undefined reference to `box' > > collect2: error: ld returned 1 exit status > > *** [lldb.full] Error code 1 > > > > See also: https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/13322/ > > For more information, currently the FreeBSD-head-amd64-gcc is using > amd64-gcc package via amd64-xtoolchain-gcc, which is 6.4 > A test build with amd64-gcc6, which is 6.5, just completed and it's fine. > I haven't checked this failure is due to our code itself, gcc versions > or the difference in the configuration of two gcc ports. Correct myself, gcc 6.5 has the same failure. There was an issue in the previous build. https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc6_build/1/console > I think I will create FreeBSD-head-amd64-gcc6 job uses newer and > preferred external tool chain, then the experimental ones like > FreeBSD-head-amd64-gcc9, 10 and llvm-devel. These are still in the CI roadmap. Li-Wen ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 05:18:25PM +0200, Konstantin Belousov wrote: > On Wed, Feb 19, 2020 at 10:41:27AM +0100, Baptiste Daroussin wrote: > > On Wed, Feb 19, 2020 at 11:02:11AM +0300, Yuri Pankov wrote: > > > On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > > > > > > > Author: bapt > > > > Date: Tue Feb 18 08:11:52 2020 > > > > New Revision: 358062 > > > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > > > > > Log: > > > > Update ncurses to 20200118 > > > > > > > > Among the changes from before: > > > > - Add support for extended colors on widechar version > > > > - Enable ncurses extended functions > > > > - Enable version 2 of the extended mouse support > > > > - Enable SCREEN extensions > > > > > > > > Modification that differs from upstream: > > > > - _nc_delink_entries used to be exposed and was turn static, > > > >turn it back as dynamic to not break abi > > > > - Adapt our old termcap.c to modern ncurses > > > > > > > > MFC after: 3 weeks > > > > > > Somewhat confusingly, I had to rebuild e.g. dialog4ports after this > > > change as it was displaying garbage. May be a brief headsup is in order > > > (or am I the only one seeing it)? > > > > I will add a not in UPDATING > > Does this mean that the ABI of the libraries changed ? > If yes, that means that the dso version bump is needed (curses seems to be > not versioned). That is what I do not understand yet, according to abi lab, no it hasn't changed. but the reality if that some unicode caracters are not properly rendered when using that new library without having been rebuilt with it. Best regards, Bapt signature.asc Description: PGP signature
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 10:41:27AM +0100, Baptiste Daroussin wrote: > On Wed, Feb 19, 2020 at 11:02:11AM +0300, Yuri Pankov wrote: > > On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > > > > > Author: bapt > > > Date: Tue Feb 18 08:11:52 2020 > > > New Revision: 358062 > > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > > > Log: > > > Update ncurses to 20200118 > > > > > > Among the changes from before: > > > - Add support for extended colors on widechar version > > > - Enable ncurses extended functions > > > - Enable version 2 of the extended mouse support > > > - Enable SCREEN extensions > > > > > > Modification that differs from upstream: > > > - _nc_delink_entries used to be exposed and was turn static, > > >turn it back as dynamic to not break abi > > > - Adapt our old termcap.c to modern ncurses > > > > > > MFC after: 3 weeks > > > > Somewhat confusingly, I had to rebuild e.g. dialog4ports after this change > > as it was displaying garbage. May be a brief headsup is in order (or am I > > the only one seeing it)? > > I will add a not in UPDATING Does this mean that the ABI of the libraries changed ? If yes, that means that the dso version bump is needed (curses seems to be not versioned). ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 04:45:27AM -0800, Rodney W. Grimes wrote: > > On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > > > > > Author: bapt > > > Date: Tue Feb 18 08:11:52 2020 > > > New Revision: 358062 > > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > > > Log: > > > Update ncurses to 20200118 > > > > > > Among the changes from before: > > > - Add support for extended colors on widechar version > > > - Enable ncurses extended functions > > > - Enable version 2 of the extended mouse support > > > - Enable SCREEN extensions > > > > > > Modification that differs from upstream: > > > - _nc_delink_entries used to be exposed and was turn static, > > >turn it back as dynamic to not break abi > > > - Adapt our old termcap.c to modern ncurses > > > > > > MFC after: 3 weeks > > > > Somewhat confusingly, I had to rebuild e.g. dialog4ports after this change > > as it was displaying garbage. May be a brief headsup is in order (or am I > > the only one seeing it)? > > If this is infact found to cause those types of dependency breakage I would > wonder about MFC: status. > Yes I don't plan to MFC without a fix on this, if any. Best regards, Bapt signature.asc Description: PGP signature
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
> On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > > > Author: bapt > > Date: Tue Feb 18 08:11:52 2020 > > New Revision: 358062 > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > Log: > > Update ncurses to 20200118 > > > > Among the changes from before: > > - Add support for extended colors on widechar version > > - Enable ncurses extended functions > > - Enable version 2 of the extended mouse support > > - Enable SCREEN extensions > > > > Modification that differs from upstream: > > - _nc_delink_entries used to be exposed and was turn static, > >turn it back as dynamic to not break abi > > - Adapt our old termcap.c to modern ncurses > > > > MFC after: 3 weeks > > Somewhat confusingly, I had to rebuild e.g. dialog4ports after this change as > it was displaying garbage. May be a brief headsup is in order (or am I the > only one seeing it)? If this is infact found to cause those types of dependency breakage I would wonder about MFC: status. -- Rod Grimes rgri...@freebsd.org ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 5:04 PM Dimitry Andric wrote: > > On 2020-02-18 09:11, Baptiste Daroussin wrote: > > Author: bapt > > Date: Tue Feb 18 08:11:52 2020 > > New Revision: 358062 > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > Log: > >Update ncurses to 20200118 > > Apparently this breaks the gcc builds, because it can't find the > function "box" anymore: > > --- all_subdir_usr.bin/clang/lldb --- > /usr/local/bin/x86_64-unknown-freebsd12.0-ld: > /tmp/obj/workspace/src/amd64.amd64/lib/clang/liblldb/liblldb.a(IOHandler.o): > in function `curses::Window::Box(unsigned int, unsigned int)': > /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: > undefined reference to `box' > /usr/local/bin/x86_64-unknown-freebsd12.0-ld: > /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: > undefined reference to `box' > collect2: error: ld returned 1 exit status > *** [lldb.full] Error code 1 > > See also: https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/13322/ For more information, currently the FreeBSD-head-amd64-gcc is using amd64-gcc package via amd64-xtoolchain-gcc, which is 6.4 A test build with amd64-gcc6, which is 6.5, just completed and it's fine. I haven't checked this failure is due to our code itself, gcc versions or the difference in the configuration of two gcc ports. I think I will create FreeBSD-head-amd64-gcc6 job uses newer and preferred external tool chain, then the experimental ones like FreeBSD-head-amd64-gcc9, 10 and llvm-devel. Best, Li-Wen ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On Wed, Feb 19, 2020 at 11:02:11AM +0300, Yuri Pankov wrote: > On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > > > Author: bapt > > Date: Tue Feb 18 08:11:52 2020 > > New Revision: 358062 > > URL: https://svnweb.freebsd.org/changeset/base/358062 > > > > Log: > > Update ncurses to 20200118 > > > > Among the changes from before: > > - Add support for extended colors on widechar version > > - Enable ncurses extended functions > > - Enable version 2 of the extended mouse support > > - Enable SCREEN extensions > > > > Modification that differs from upstream: > > - _nc_delink_entries used to be exposed and was turn static, > >turn it back as dynamic to not break abi > > - Adapt our old termcap.c to modern ncurses > > > > MFC after: 3 weeks > > Somewhat confusingly, I had to rebuild e.g. dialog4ports after this change as > it was displaying garbage. May be a brief headsup is in order (or am I the > only one seeing it)? I will add a not in UPDATING Best regards, Bapt signature.asc Description: PGP signature
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On 2020-02-18 09:11, Baptiste Daroussin wrote: Author: bapt Date: Tue Feb 18 08:11:52 2020 New Revision: 358062 URL: https://svnweb.freebsd.org/changeset/base/358062 Log: Update ncurses to 20200118 Apparently this breaks the gcc builds, because it can't find the function "box" anymore: --- all_subdir_usr.bin/clang/lldb --- /usr/local/bin/x86_64-unknown-freebsd12.0-ld: /tmp/obj/workspace/src/amd64.amd64/lib/clang/liblldb/liblldb.a(IOHandler.o): in function `curses::Window::Box(unsigned int, unsigned int)': /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: undefined reference to `box' /usr/local/bin/x86_64-unknown-freebsd12.0-ld: /workspace/src/contrib/llvm-project/lldb/source/Core/IOHandler.cpp:926: undefined reference to `box' collect2: error: ld returned 1 exit status *** [lldb.full] Error code 1 See also: https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/13322/ -Dimitry ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r358062 - in head: contrib/ncurses contrib/ncurses/doc contrib/ncurses/doc/html contrib/ncurses/form contrib/ncurses/include contrib/ncurses/man contrib/ncurses/menu contrib/ncurses/mi
On 18 Feb 2020, at 11:11, Baptiste Daroussin wrote: > > Author: bapt > Date: Tue Feb 18 08:11:52 2020 > New Revision: 358062 > URL: https://svnweb.freebsd.org/changeset/base/358062 > > Log: > Update ncurses to 20200118 > > Among the changes from before: > - Add support for extended colors on widechar version > - Enable ncurses extended functions > - Enable version 2 of the extended mouse support > - Enable SCREEN extensions > > Modification that differs from upstream: > - _nc_delink_entries used to be exposed and was turn static, >turn it back as dynamic to not break abi > - Adapt our old termcap.c to modern ncurses > > MFC after: 3 weeks Somewhat confusingly, I had to rebuild e.g. dialog4ports after this change as it was displaying garbage. May be a brief headsup is in order (or am I the only one seeing it)? ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"