Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Alexey Dokuchaev
On Thu, Jul 30, 2020 at 06:51:58PM +0200, Stefan E??er wrote:
> ...
> My guess is that he'll add a compile time switch to his version
> that will be added to our usr.bin Makefile and will suppress the
> start-up message in our base system version. (I'll keep the port
> version as is unless there is a strong preference to suppress it
> also in the port).

Yes, this is the correct approach, thank you Stefan.

./danfe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Ravi Pokala
-Original Message-
From:  on behalf of Stefan Eßer 

Date: 2020-07-30, Thursday at 09:55
To: Jessica Clarke , Ravi Pokala 
Cc: Baptiste Daroussin , Stefan Eßer , 
src-committers , , 

Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src 
tests tests/bc

Am 30.07.20 um 18:45 schrieb Jessica Clarke:
> On 30 Jul 2020, at 17:40, Ravi Pokala  wrote:
>>
>> -Original Message-
>> From:  on behalf of Jessica Clarke 

>> Date: 2020-07-30, Thursday at 09:35
>> To: Baptiste Daroussin 
>> Cc: Stefan Eßer , src-committers 
, , 

>> Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals 
src tests tests/bc
>>
>>On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
>>> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>>>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>>>>>> Author: se
>>>>>> Date: Sat Jul 11 07:33:18 2020
>>>>>> New Revision: 363091
>>>>>> URL: https://svnweb.freebsd.org/changeset/base/363091
>>>>>>
>>>>>> Log:
>>>>>> Update to version 3.1.3
>>>>>>
>>>>> Jumping on that commit, since the switch from our previous bc.
>>>>>
>>>>> The output of the interactive bc has changed, the previous version 
had a clean
>>>>> UI, the new version "pollutes" the output with plenty of lines about 
the
>>>>> copyright:
>>>>>
>>>>> 
>>>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>>>> Report bugs at: https://git.yzena.com/gavin/bc
>>>>>
>>>>> This is free software with ABSOLUTELY NO WARRANTY.
>>>>> 
>>>>>
>>>>> Imagine if all programs where doing that, it would be painful, do you 
think
>>>>> upstream can be convinced to remove those lines?
>>>>>
>>>>> I no the GNU version also has the same polluted output which was one 
of the
>>>>> reason I was happy with out previous version of bc.
>>>>
>>>> By default both will print such a banner if and only if being called
>>>> interactively. You can disable the banner explicitly with -q/--quiet
>>>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>>>> nicer to not have that printed, but it's not without precedent for
>>>> REPL-like things.
>>>
>>> Yes it is not without precedent for REPL-like things, still I dislike 
this and
>>> would be happy to get bc interactive be as nice as the previous one we 
had :)
>>>
>>> If not I will deal with it and just yell internally each time I run it 
:D
>>
>>`alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)
>>
>>Jess
>>
>> I was actually about to complain about the new `dc' not exiting after 
evaluating a '-e' expression, without an explicit 'q'. But then I noticed the 
"DC_EXPR_EXIT" envvar, which restores the desired behavior. That lead me to 
discover "DC_ENV_ARGS" and, correspondingly, "BC_ENV_ARGS"; that last one would 
be helpful here.
> 
> That does feel like the wrong default; even GNU dc doesn't do that, and
> the principle of least surprise would suggest exiting is the right
> thing to do. It's also unlikely you want to evaluate something and then
> use it interactively.

Interesting observation - I've got to admit that I hardly ever use dc
(despite being the owner of a collection of HP UPN calculators ;-) ).

Ironically, I couldn't wrap my head around HP RPN calculators in the '90s, so I 
used a TI-85 or TI-89 instead. Now, I do all my non-trivial math using RPN in 
`dc'. :-)

-Ravi

I'll forward this to the author of this bc/dc and I'm sure he will
offer a patched version (unless there are strong reasons for the
current behavior, e.g. compatibility with another dc ...)

Regards, STefan


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Stefan Eßer
Am 30.07.20 um 18:45 schrieb Jessica Clarke:
> On 30 Jul 2020, at 17:40, Ravi Pokala  wrote:
>>
>> -Original Message-
>> From:  on behalf of Jessica Clarke 
>> 
>> Date: 2020-07-30, Thursday at 09:35
>> To: Baptiste Daroussin 
>> Cc: Stefan Eßer , src-committers 
>> , , 
>> 
>> Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src 
>> tests tests/bc
>>
>>On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
>>> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>>>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>>>>>> Author: se
>>>>>> Date: Sat Jul 11 07:33:18 2020
>>>>>> New Revision: 363091
>>>>>> URL: https://svnweb.freebsd.org/changeset/base/363091
>>>>>>
>>>>>> Log:
>>>>>> Update to version 3.1.3
>>>>>>
>>>>> Jumping on that commit, since the switch from our previous bc.
>>>>>
>>>>> The output of the interactive bc has changed, the previous version had a 
>>>>> clean
>>>>> UI, the new version "pollutes" the output with plenty of lines about the
>>>>> copyright:
>>>>>
>>>>> 
>>>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>>>> Report bugs at: https://git.yzena.com/gavin/bc
>>>>>
>>>>> This is free software with ABSOLUTELY NO WARRANTY.
>>>>> 
>>>>>
>>>>> Imagine if all programs where doing that, it would be painful, do you 
>>>>> think
>>>>> upstream can be convinced to remove those lines?
>>>>>
>>>>> I no the GNU version also has the same polluted output which was one of 
>>>>> the
>>>>> reason I was happy with out previous version of bc.
>>>>
>>>> By default both will print such a banner if and only if being called
>>>> interactively. You can disable the banner explicitly with -q/--quiet
>>>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>>>> nicer to not have that printed, but it's not without precedent for
>>>> REPL-like things.
>>>
>>> Yes it is not without precedent for REPL-like things, still I dislike this 
>>> and
>>> would be happy to get bc interactive be as nice as the previous one we had 
>>> :)
>>>
>>> If not I will deal with it and just yell internally each time I run it :D
>>
>>`alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)
>>
>>Jess
>>
>> I was actually about to complain about the new `dc' not exiting after 
>> evaluating a '-e' expression, without an explicit 'q'. But then I noticed 
>> the "DC_EXPR_EXIT" envvar, which restores the desired behavior. That lead me 
>> to discover "DC_ENV_ARGS" and, correspondingly, "BC_ENV_ARGS"; that last one 
>> would be helpful here.
> 
> That does feel like the wrong default; even GNU dc doesn't do that, and
> the principle of least surprise would suggest exiting is the right
> thing to do. It's also unlikely you want to evaluate something and then
> use it interactively.

Interesting observation - I've got to admit that I hardly ever use dc
(despite being the owner of a collection of HP UPN calculators ;-) ).

I'll forward this to the author of this bc/dc and I'm sure he will
offer a patched version (unless there are strong reasons for the
current behavior, e.g. compatibility with another dc ...)

Regards, STefan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Stefan Eßer
Am 30.07.20 um 18:31 schrieb Baptiste Daroussin:
> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
 Author: se
 Date: Sat Jul 11 07:33:18 2020
 New Revision: 363091
 URL: https://svnweb.freebsd.org/changeset/base/363091

 Log:
  Update to version 3.1.3

>>> Jumping on that commit, since the switch from our previous bc.
>>>
>>> The output of the interactive bc has changed, the previous version had a 
>>> clean
>>> UI, the new version "pollutes" the output with plenty of lines about the
>>> copyright:
>>>
>>> 
>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>> Report bugs at: https://git.yzena.com/gavin/bc
>>>
>>> This is free software with ABSOLUTELY NO WARRANTY.
>>> 
>>>
>>> Imagine if all programs where doing that, it would be painful, do you think
>>> upstream can be convinced to remove those lines?
>>>
>>> I no the GNU version also has the same polluted output which was one of the
>>> reason I was happy with out previous version of bc.
>>
>> By default both will print such a banner if and only if being called
>> interactively. You can disable the banner explicitly with -q/--quiet
>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>> nicer to not have that printed, but it's not without precedent for
>> REPL-like things.
> 
> Yes it is not without precedent for REPL-like things, still I dislike this and
> would be happy to get bc interactive be as nice as the previous one we had :)
> 
> If not I will deal with it and just yell internally each time I run it :D

I'll forward this thread to the author - had already stated similar
thought to him for consideration.

Is very interested to prevent forks of his software - although not
forbidden by the license - but he wants to keep his sources as the
official and "clean" upstream for other projects.

My guess is that he'll add a compile time switch to his version
that will be added to our usr.bin Makefile and will suppress the
start-up message in our base system version. (I'll keep the port
version as is unless there is a strong preference to suppress it
also in the port).

I'd expect it to take a few days (since he only tags new versions
after running a fuzzer for a few days if non-trivial changes have
been performed and I know he improved something in the interpreter
without publishing it, yet) ...

Regards, STefan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread John Baldwin
On 7/30/20 9:31 AM, Baptiste Daroussin wrote:
> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
 Author: se
 Date: Sat Jul 11 07:33:18 2020
 New Revision: 363091
 URL: https://svnweb.freebsd.org/changeset/base/363091

 Log:
  Update to version 3.1.3

>>> Jumping on that commit, since the switch from our previous bc.
>>>
>>> The output of the interactive bc has changed, the previous version had a 
>>> clean
>>> UI, the new version "pollutes" the output with plenty of lines about the
>>> copyright:
>>>
>>> 
>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>> Report bugs at: https://git.yzena.com/gavin/bc
>>>
>>> This is free software with ABSOLUTELY NO WARRANTY.
>>> 
>>>
>>> Imagine if all programs where doing that, it would be painful, do you think
>>> upstream can be convinced to remove those lines?
>>>
>>> I no the GNU version also has the same polluted output which was one of the
>>> reason I was happy with out previous version of bc.
>>
>> By default both will print such a banner if and only if being called
>> interactively. You can disable the banner explicitly with -q/--quiet
>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>> nicer to not have that printed, but it's not without precedent for
>> REPL-like things.
> 
> Yes it is not without precedent for REPL-like things, still I dislike this and
> would be happy to get bc interactive be as nice as the previous one we had :)
> 
> If not I will deal with it and just yell internally each time I run it :D

FWIW, I also consider this a regression relative to the previous bc.
I had gotten used to the lack of spam when invoking bc and it was the
first thing I noticed when the new one was imported, just hadn't sat
down and wrote an e-mail about it yet.

-- 
John Baldwin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Jessica Clarke
On 30 Jul 2020, at 17:40, Ravi Pokala  wrote:
> 
> -Original Message-
> From:  on behalf of Jessica Clarke 
> 
> Date: 2020-07-30, Thursday at 09:35
> To: Baptiste Daroussin 
> Cc: Stefan Eßer , src-committers 
> , , 
> 
> Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src 
> tests tests/bc
> 
>On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
>> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>>>>> Author: se
>>>>> Date: Sat Jul 11 07:33:18 2020
>>>>> New Revision: 363091
>>>>> URL: https://svnweb.freebsd.org/changeset/base/363091
>>>>> 
>>>>> Log:
>>>>> Update to version 3.1.3
>>>>> 
>>>> Jumping on that commit, since the switch from our previous bc.
>>>> 
>>>> The output of the interactive bc has changed, the previous version had a 
>>>> clean
>>>> UI, the new version "pollutes" the output with plenty of lines about the
>>>> copyright:
>>>> 
>>>> 
>>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>>> Report bugs at: https://git.yzena.com/gavin/bc
>>>> 
>>>> This is free software with ABSOLUTELY NO WARRANTY.
>>>> 
>>>> 
>>>> Imagine if all programs where doing that, it would be painful, do you think
>>>> upstream can be convinced to remove those lines?
>>>> 
>>>> I no the GNU version also has the same polluted output which was one of the
>>>> reason I was happy with out previous version of bc.
>>> 
>>> By default both will print such a banner if and only if being called
>>> interactively. You can disable the banner explicitly with -q/--quiet
>>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>>> nicer to not have that printed, but it's not without precedent for
>>> REPL-like things.
>> 
>> Yes it is not without precedent for REPL-like things, still I dislike this 
>> and
>> would be happy to get bc interactive be as nice as the previous one we had :)
>> 
>> If not I will deal with it and just yell internally each time I run it :D
> 
>`alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)
> 
>Jess
> 
> I was actually about to complain about the new `dc' not exiting after 
> evaluating a '-e' expression, without an explicit 'q'. But then I noticed the 
> "DC_EXPR_EXIT" envvar, which restores the desired behavior. That lead me to 
> discover "DC_ENV_ARGS" and, correspondingly, "BC_ENV_ARGS"; that last one 
> would be helpful here.

That does feel like the wrong default; even GNU dc doesn't do that, and
the principle of least surprise would suggest exiting is the right
thing to do. It's also unlikely you want to evaluate something and then
use it interactively.

Jess

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Ravi Pokala
-Original Message-
From:  on behalf of Jessica Clarke 

Date: 2020-07-30, Thursday at 09:35
To: Baptiste Daroussin 
Cc: Stefan Eßer , src-committers 
, , 

Subject: Re: svn commit: r363091 - in head/contrib/bc: . include manuals src 
tests tests/bc

On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>>>> Author: se
>>>> Date: Sat Jul 11 07:33:18 2020
>>>> New Revision: 363091
>>>> URL: https://svnweb.freebsd.org/changeset/base/363091
>>>> 
>>>> Log:
>>>> Update to version 3.1.3
>>>> 
>>> Jumping on that commit, since the switch from our previous bc.
>>> 
>>> The output of the interactive bc has changed, the previous version had 
a clean
>>> UI, the new version "pollutes" the output with plenty of lines about the
>>> copyright:
>>> 
>>> 
>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>> Report bugs at: https://git.yzena.com/gavin/bc
>>> 
>>> This is free software with ABSOLUTELY NO WARRANTY.
>>> 
>>> 
>>> Imagine if all programs where doing that, it would be painful, do you 
think
>>> upstream can be convinced to remove those lines?
>>> 
>>> I no the GNU version also has the same polluted output which was one of 
the
>>> reason I was happy with out previous version of bc.
>> 
>> By default both will print such a banner if and only if being called
>> interactively. You can disable the banner explicitly with -q/--quiet
>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>> nicer to not have that printed, but it's not without precedent for
>> REPL-like things.
> 
> Yes it is not without precedent for REPL-like things, still I dislike 
this and
> would be happy to get bc interactive be as nice as the previous one we 
had :)
> 
> If not I will deal with it and just yell internally each time I run it :D

`alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)

Jess

I was actually about to complain about the new `dc' not exiting after 
evaluating a '-e' expression, without an explicit 'q'. But then I noticed the 
"DC_EXPR_EXIT" envvar, which restores the desired behavior. That lead me to 
discover "DC_ENV_ARGS" and, correspondingly, "BC_ENV_ARGS"; that last one would 
be helpful here.

Thanks,

Ravi (rpokala@)


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Baptiste Daroussin
On Thu, Jul 30, 2020 at 05:35:20PM +0100, Jessica Clarke wrote:
> On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
> > On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
> >> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
> >>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>  Author: se
>  Date: Sat Jul 11 07:33:18 2020
>  New Revision: 363091
>  URL: https://svnweb.freebsd.org/changeset/base/363091
>  
>  Log:
>  Update to version 3.1.3
>  
> >>> Jumping on that commit, since the switch from our previous bc.
> >>> 
> >>> The output of the interactive bc has changed, the previous version had a 
> >>> clean
> >>> UI, the new version "pollutes" the output with plenty of lines about the
> >>> copyright:
> >>> 
> >>> 
> >>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
> >>> Report bugs at: https://git.yzena.com/gavin/bc
> >>> 
> >>> This is free software with ABSOLUTELY NO WARRANTY.
> >>> 
> >>> 
> >>> Imagine if all programs where doing that, it would be painful, do you 
> >>> think
> >>> upstream can be convinced to remove those lines?
> >>> 
> >>> I no the GNU version also has the same polluted output which was one of 
> >>> the
> >>> reason I was happy with out previous version of bc.
> >> 
> >> By default both will print such a banner if and only if being called
> >> interactively. You can disable the banner explicitly with -q/--quiet
> >> for both GNU bc and this bc. I agree it's a bit noisy and would be
> >> nicer to not have that printed, but it's not without precedent for
> >> REPL-like things.
> > 
> > Yes it is not without precedent for REPL-like things, still I dislike this 
> > and
> > would be happy to get bc interactive be as nice as the previous one we had 
> > :)
> > 
> > If not I will deal with it and just yell internally each time I run it :D
> 
> `alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)
> 
That was my actual plan but it was less fun to write :D

Bapt


signature.asc
Description: PGP signature


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Jessica Clarke
On 30 Jul 2020, at 17:31, Baptiste Daroussin  wrote:
> On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
>> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
>>> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
 Author: se
 Date: Sat Jul 11 07:33:18 2020
 New Revision: 363091
 URL: https://svnweb.freebsd.org/changeset/base/363091
 
 Log:
 Update to version 3.1.3
 
>>> Jumping on that commit, since the switch from our previous bc.
>>> 
>>> The output of the interactive bc has changed, the previous version had a 
>>> clean
>>> UI, the new version "pollutes" the output with plenty of lines about the
>>> copyright:
>>> 
>>> 
>>> Copyright (c) 2018-2020 Gavin D. Howard and contributors
>>> Report bugs at: https://git.yzena.com/gavin/bc
>>> 
>>> This is free software with ABSOLUTELY NO WARRANTY.
>>> 
>>> 
>>> Imagine if all programs where doing that, it would be painful, do you think
>>> upstream can be convinced to remove those lines?
>>> 
>>> I no the GNU version also has the same polluted output which was one of the
>>> reason I was happy with out previous version of bc.
>> 
>> By default both will print such a banner if and only if being called
>> interactively. You can disable the banner explicitly with -q/--quiet
>> for both GNU bc and this bc. I agree it's a bit noisy and would be
>> nicer to not have that printed, but it's not without precedent for
>> REPL-like things.
> 
> Yes it is not without precedent for REPL-like things, still I dislike this and
> would be happy to get bc interactive be as nice as the previous one we had :)
> 
> If not I will deal with it and just yell internally each time I run it :D

`alias bc='bc -q'` / `alias bc bc -q` and preserve your inner zen? :)

Jess

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Baptiste Daroussin
On Thu, Jul 30, 2020 at 05:28:19PM +0100, Jessica Clarke wrote:
> On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
> > On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
> >> Author: se
> >> Date: Sat Jul 11 07:33:18 2020
> >> New Revision: 363091
> >> URL: https://svnweb.freebsd.org/changeset/base/363091
> >> 
> >> Log:
> >>  Update to version 3.1.3
> >> 
> > Jumping on that commit, since the switch from our previous bc.
> > 
> > The output of the interactive bc has changed, the previous version had a 
> > clean
> > UI, the new version "pollutes" the output with plenty of lines about the
> > copyright:
> > 
> > 
> > Copyright (c) 2018-2020 Gavin D. Howard and contributors
> > Report bugs at: https://git.yzena.com/gavin/bc
> > 
> > This is free software with ABSOLUTELY NO WARRANTY.
> > 
> > 
> > Imagine if all programs where doing that, it would be painful, do you think
> > upstream can be convinced to remove those lines?
> > 
> > I no the GNU version also has the same polluted output which was one of the
> > reason I was happy with out previous version of bc.
> 
> By default both will print such a banner if and only if being called
> interactively. You can disable the banner explicitly with -q/--quiet
> for both GNU bc and this bc. I agree it's a bit noisy and would be
> nicer to not have that printed, but it's not without precedent for
> REPL-like things.

Yes it is not without precedent for REPL-like things, still I dislike this and
would be happy to get bc interactive be as nice as the previous one we had :)

If not I will deal with it and just yell internally each time I run it :D

Bapt


signature.asc
Description: PGP signature


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Jessica Clarke
On 30 Jul 2020, at 17:20, Baptiste Daroussin  wrote:
> On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
>> Author: se
>> Date: Sat Jul 11 07:33:18 2020
>> New Revision: 363091
>> URL: https://svnweb.freebsd.org/changeset/base/363091
>> 
>> Log:
>>  Update to version 3.1.3
>> 
> Jumping on that commit, since the switch from our previous bc.
> 
> The output of the interactive bc has changed, the previous version had a clean
> UI, the new version "pollutes" the output with plenty of lines about the
> copyright:
> 
> 
> Copyright (c) 2018-2020 Gavin D. Howard and contributors
> Report bugs at: https://git.yzena.com/gavin/bc
> 
> This is free software with ABSOLUTELY NO WARRANTY.
> 
> 
> Imagine if all programs where doing that, it would be painful, do you think
> upstream can be convinced to remove those lines?
> 
> I no the GNU version also has the same polluted output which was one of the
> reason I was happy with out previous version of bc.

By default both will print such a banner if and only if being called
interactively. You can disable the banner explicitly with -q/--quiet
for both GNU bc and this bc. I agree it's a bit noisy and would be
nicer to not have that printed, but it's not without precedent for
REPL-like things.

Jess

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-30 Thread Baptiste Daroussin
On Sat, Jul 11, 2020 at 07:33:19AM +, Stefan Eßer wrote:
> Author: se
> Date: Sat Jul 11 07:33:18 2020
> New Revision: 363091
> URL: https://svnweb.freebsd.org/changeset/base/363091
> 
> Log:
>   Update to version 3.1.3
>   
Jumping on that commit, since the switch from our previous bc.

The output of the interactive bc has changed, the previous version had a clean
UI, the new version "pollutes" the output with plenty of lines about the
copyright:


Copyright (c) 2018-2020 Gavin D. Howard and contributors
Report bugs at: https://git.yzena.com/gavin/bc

This is free software with ABSOLUTELY NO WARRANTY.


Imagine if all programs where doing that, it would be painful, do you think
upstream can be convinced to remove those lines?

I no the GNU version also has the same polluted output which was one of the
reason I was happy with out previous version of bc.

Best regards,
Bapt


signature.asc
Description: PGP signature


svn commit: r363091 - in head/contrib/bc: . include manuals src tests tests/bc

2020-07-11 Thread Stefan Eßer
Author: se
Date: Sat Jul 11 07:33:18 2020
New Revision: 363091
URL: https://svnweb.freebsd.org/changeset/base/363091

Log:
  Update to version 3.1.3
  
  This version fixes the following evaluation, which lead to a parse error:
  
   echo "if (1 < 3) 1" | bc

Modified:
  head/contrib/bc/Makefile.in
  head/contrib/bc/NEWS.md
  head/contrib/bc/configure.sh
  head/contrib/bc/include/vm.h
  head/contrib/bc/locale_install.sh
  head/contrib/bc/locale_uninstall.sh
  head/contrib/bc/manuals/build.md
  head/contrib/bc/src/vm.c
  head/contrib/bc/tests/bc/stdin.txt
  head/contrib/bc/tests/bc/stdin_results.txt
  head/contrib/bc/tests/stdin.sh
Directory Properties:
  head/contrib/bc/   (props changed)

Modified: head/contrib/bc/Makefile.in
==
--- head/contrib/bc/Makefile.in Sat Jul 11 06:51:42 2020(r363090)
+++ head/contrib/bc/Makefile.in Sat Jul 11 07:33:18 2020(r363091)
@@ -29,7 +29,7 @@
 #
 .POSIX:
 
-VERSION = 3.1.1
+VERSION = 3.1.3
 
 SRC = %%SRC%%
 OBJ = %%OBJ%%
@@ -335,7 +335,7 @@ clean_tests: clean clean_config clean_coverage
@$(RM) -f bc.old
 
 install_locales:
-   $(LOCALE_INSTALL) $(NLSPATH) $(MAIN_EXEC) $(DESTDIR)
+   %%INSTALL_LOCALES%%
 
 install_bc_manpage:
$(SAFE_INSTALL) $(MANPAGE_INSTALL_ARGS) $(BC_MANPAGE) 
$(DESTDIR)$(MAN1DIR)/$(BC_MANPAGE_NAME)

Modified: head/contrib/bc/NEWS.md
==
--- head/contrib/bc/NEWS.md Sat Jul 11 06:51:42 2020(r363090)
+++ head/contrib/bc/NEWS.md Sat Jul 11 07:33:18 2020(r363091)
@@ -1,5 +1,25 @@
 # News
 
+## 3.1.3
+
+This is a production release that fixes one minor bug: if `bc` was invoked like
+the following, it would error:
+
+```
+echo "if (1 < 3) 1" | bc
+```
+
+Unless users run into this bug, they do not need to upgrade, but it is 
suggested
+that they do.
+
+## 3.1.2
+
+This is a production release that adds a way to install *all* locales. Users do
+***NOT*** need to upgrade.
+
+For package maintainers wishing to make use of the change, just pass `-l` to
+`configure.sh`.
+
 ## 3.1.1
 
 This is a production release that adds two Spanish locales. Users do ***NOT***

Modified: head/contrib/bc/configure.sh
==
--- head/contrib/bc/configure.shSat Jul 11 06:51:42 2020
(r363090)
+++ head/contrib/bc/configure.shSat Jul 11 07:33:18 2020
(r363091)
@@ -47,12 +47,12 @@ usage() {
 
printf 'usage: %s -h\n' "$script"
printf '   %s --help\n' "$script"
-   printf '   %s [-bD|-dB|-c] [-EfgGHMNPT] [-O OPT_LEVEL] [-k 
KARATSUBA_LEN]\n' "$script"
+   printf '   %s [-bD|-dB|-c] [-EfgGHlMNPT] [-O OPT_LEVEL] [-k 
KARATSUBA_LEN]\n' "$script"
printf '   %s \\\n' "$script"
printf '   [--bc-only --disable-dc|--dc-only 
--disable-bc|--coverage]  \\\n'
printf '   [--debug --disable-extra-math 
--disable-generated-tests]\\\n'
printf '   [--disable-history --disable-man-pages 
--disable-nls]   \\\n'
-   printf '   [--disable-prompt --disable-strip]   
   \\\n'
+   printf '   [--disable-prompt --disable-strip] 
[--install-all-locales]  \\\n'
printf '   [--opt=OPT_LEVEL] [--karatsuba-len=KARATSUBA_LEN]
   \\\n'
printf '   [--prefix=PREFIX] [--bindir=BINDIR] 
[--datarootdir=DATAROOTDIR] \\\n'
printf '   [--datadir=DATADIR] [--mandir=MANDIR] 
[--man1dir=MAN1DIR]   \\\n'
@@ -98,6 +98,10 @@ usage() {
printf '-k KARATSUBA_LEN, --karatsuba-len KARATSUBA_LEN\n'
printf 'Set the karatsuba length to KARATSUBA_LEN (default is 
64).\n'
printf 'It is an error if KARATSUBA_LEN is not a number or is 
less than 16.\n'
+   printf '-l, --install-all-locales\n'
+   printf 'Installs all locales, regardless of how many are on the 
system. This\n'
+   printf 'option is useful for package maintainers who want to 
make sure that\n'
+   printf 'a package contains all of the locales that end users 
might need.\n'
printf '-M, --disable-man-pages\n'
printf 'Disable installing manpages.\n'
printf '-N, --disable-nls\n'
@@ -319,8 +323,9 @@ nls=1
 prompt=1
 force=0
 strip_bin=1
+all_locales=0
 
-while getopts "bBcdDEfgGhHk:MNO:PST-" opt; do
+while getopts "bBcdDEfgGhHk:lMNO:PST-" opt; do
 
case "$opt" in
b) bc_only=1 ;;
@@ -335,6 +340,7 @@ while getopts "bBcdDEfgGhHk:MNO:PST-" opt; do
h) usage ;;
H) hist=0 ;;
k) karatsuba_len="$OPTARG" ;;
+   l) all_locales=1 ;;
M) install_manpages=0 ;;
N) nls=0 ;;
O) optimization="$OPTARG" ;;