Re: svn commit: r363171 - head/contrib/flex/src

[Adrian Chadd]

Hi!

On Tue, 14 Jul 2020 at 08:00, Jung-uk Kim  wrote:

> On 20. 7. 14., Adrian Chadd wrote:
> > Author: adrian
> > Date: Tue Jul 14 05:00:08 2020
> > New Revision: 363171
> > URL: https://svnweb.freebsd.org/changeset/base/363171
> >
> > Log:
> >   [flex] Fix compilation issue under mips-gcc-6.4
> >
> >   This was triggering a pointer-losing-constness error.
>


> It was discussed in this ML.
>
> https://lists.freebsd.org/pipermail/svn-src-head/2020-June/137432.html
>
> kevans even filed an upstream pull request.
>
> https://github.com/westes/flex/pull/449


Oh good!


>
>
> Why did you commit it without asking us?
>

Oh I'm sorry! I didn't realise you were already doing the work to get it
fixed upstream. I just saw things broken when building my test wifi setups
here at home and saw they were small fixes that could be submitted upstream.

I'm personally not a huge fan of sitting on patches that
fix builds/functionality whilst waiting for upstream - this was one of the
many reasons for migrating from CVS to SVN in the long distant past! - so I
figured it would be easy to commit.

I'll make sure I ask around a little more next time!



-adrian


> Jung-uk Kim
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r363171 - head/contrib/flex/src

[Jung-uk Kim]

On 20. 7. 14., Adrian Chadd wrote:
> Author: adrian
> Date: Tue Jul 14 05:00:08 2020
> New Revision: 363171
> URL: https://svnweb.freebsd.org/changeset/base/363171
> 
> Log:
>   [flex] Fix compilation issue under mips-gcc-6.4
>   
>   This was triggering a pointer-losing-constness error.
> 
> Modified:
>   head/contrib/flex/src/main.c
> 
> Modified: head/contrib/flex/src/main.c
> ==
> --- head/contrib/flex/src/main.c  Tue Jul 14 01:54:24 2020
> (r363170)
> +++ head/contrib/flex/src/main.c  Tue Jul 14 05:00:08 2020
> (r363171)
> @@ -342,7 +342,7 @@ void check_options (void)
>  /* Setup the filter chain. */
>  output_chain = filter_create_int(NULL, filter_tee_header, 
> headerfilename);
>  if ( !(m4 = getenv("M4"))) {
> - char *slash;
> + const char *slash;
>   m4 = M4;
>   if ((slash = strrchr(M4, '/')) != NULL) {
>   m4 = slash+1;
> 

It was discussed in this ML.

https://lists.freebsd.org/pipermail/svn-src-head/2020-June/137432.html

kevans even filed an upstream pull request.

https://github.com/westes/flex/pull/449

Why did you commit it without asking us?

Jung-uk Kim
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r363171 - head/contrib/flex/src

[Adrian Chadd]

Author: adrian
Date: Tue Jul 14 05:00:08 2020
New Revision: 363171
URL: https://svnweb.freebsd.org/changeset/base/363171

Log:
  [flex] Fix compilation issue under mips-gcc-6.4
  
  This was triggering a pointer-losing-constness error.

Modified:
  head/contrib/flex/src/main.c

Modified: head/contrib/flex/src/main.c
==
--- head/contrib/flex/src/main.cTue Jul 14 01:54:24 2020
(r363170)
+++ head/contrib/flex/src/main.cTue Jul 14 05:00:08 2020
(r363171)
@@ -342,7 +342,7 @@ void check_options (void)
 /* Setup the filter chain. */
 output_chain = filter_create_int(NULL, filter_tee_header, headerfilename);
 if ( !(m4 = getenv("M4"))) {
-   char *slash;
+   const char *slash;
m4 = M4;
if ((slash = strrchr(M4, '/')) != NULL) {
m4 = slash+1;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"