Re: svn commit: r363172 - head/contrib/bc/src
Am 14.07.20 um 19:31 schrieb Brooks Davis: > On Tue, Jul 14, 2020 at 05:02:18AM +, Adrian Chadd wrote: >> Author: adrian >> Date: Tue Jul 14 05:02:18 2020 >> New Revision: 363172 >> URL: https://svnweb.freebsd.org/changeset/base/363172 >> >> Log: >> [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. >> >> I guess this didn't like the case statements.. ? But this does quieten >> the compiler error. > > IMO it would be better to disable this warning for this (old) compiler > on this file rather than making a change here (in general we should be > removing these sorts of changes). That being said, we need to write > down some guidance on this so we have a clear set of principles and we > can figure out how we decided which compilers are on which side of the > line. I fully agree and have notified the "upstream". He may want to apply the change, but I do not expect him to tag a new release for this minor change. Since this is contributed software, I'd really appreciate, if a solution was only applied to the local build tree of the person affected by this local problem - a generally applicable solution can then be discussed and applied, if found to be necessary. Regards, STefan signature.asc Description: OpenPGP digital signature
Re: svn commit: r363172 - head/contrib/bc/src
On Tue, Jul 14, 2020 at 05:02:18AM +, Adrian Chadd wrote: > Author: adrian > Date: Tue Jul 14 05:02:18 2020 > New Revision: 363172 > URL: https://svnweb.freebsd.org/changeset/base/363172 > > Log: > [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. > > I guess this didn't like the case statements.. ? But this does quieten > the compiler error. IMO it would be better to disable this warning for this (old) compiler on this file rather than making a change here (in general we should be removing these sorts of changes). That being said, we need to write down some guidance on this so we have a clear set of principles and we can figure out how we decided which compilers are on which side of the line. -- Brooks signature.asc Description: PGP signature
Re: svn commit: r363172 - head/contrib/bc/src
On Tue, 14 Jul 2020 at 06:42, Warner Losh wrote:
> Did you intend to commit to contrib software that has an active upstream?
> This is going to cause conflicts in the future. Maybe you can submit it to
> the new upstream instead?
>
i was going to do both, for the changes to both flex and bc.
-adrian
>
> Warner
>
> On Mon, Jul 13, 2020 at 11:02 PM Adrian Chadd wrote:
>
>> Author: adrian
>> Date: Tue Jul 14 05:02:18 2020
>> New Revision: 363172
>> URL: https://svnweb.freebsd.org/changeset/base/363172
>>
>> Log:
>> [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0.
>>
>> I guess this didn't like the case statements.. ? But this does quieten
>> the compiler error.
>>
>> Modified:
>> head/contrib/bc/src/program.c
>>
>> Modified: head/contrib/bc/src/program.c
>>
>> ==
>> --- head/contrib/bc/src/program.c Tue Jul 14 05:00:08 2020
>> (r363171)
>> +++ head/contrib/bc/src/program.c Tue Jul 14 05:02:18 2020
>> (r363172)
>> @@ -180,7 +180,7 @@ static inline BcVec* bc_program_vec(const BcProgram *p
>>
>> static BcNum* bc_program_num(BcProgram *p, BcResult *r) {
>>
>> - BcNum *n;
>> + BcNum *n = NULL;
>>
>> switch (r->t) {
>>
>>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r363172 - head/contrib/bc/src
Did you intend to commit to contrib software that has an active upstream?
This is going to cause conflicts in the future. Maybe you can submit it to
the new upstream instead?
Warner
On Mon, Jul 13, 2020 at 11:02 PM Adrian Chadd wrote:
> Author: adrian
> Date: Tue Jul 14 05:02:18 2020
> New Revision: 363172
> URL: https://svnweb.freebsd.org/changeset/base/363172
>
> Log:
> [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0.
>
> I guess this didn't like the case statements.. ? But this does quieten
> the compiler error.
>
> Modified:
> head/contrib/bc/src/program.c
>
> Modified: head/contrib/bc/src/program.c
>
> ==
> --- head/contrib/bc/src/program.c Tue Jul 14 05:00:08 2020
> (r363171)
> +++ head/contrib/bc/src/program.c Tue Jul 14 05:02:18 2020
> (r363172)
> @@ -180,7 +180,7 @@ static inline BcVec* bc_program_vec(const BcProgram *p
>
> static BcNum* bc_program_num(BcProgram *p, BcResult *r) {
>
> - BcNum *n;
> + BcNum *n = NULL;
>
> switch (r->t) {
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r363172 - head/contrib/bc/src
Author: adrian
Date: Tue Jul 14 05:02:18 2020
New Revision: 363172
URL: https://svnweb.freebsd.org/changeset/base/363172
Log:
[bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0.
I guess this didn't like the case statements.. ? But this does quieten
the compiler error.
Modified:
head/contrib/bc/src/program.c
Modified: head/contrib/bc/src/program.c
==
--- head/contrib/bc/src/program.c Tue Jul 14 05:00:08 2020
(r363171)
+++ head/contrib/bc/src/program.c Tue Jul 14 05:02:18 2020
(r363172)
@@ -180,7 +180,7 @@ static inline BcVec* bc_program_vec(const BcProgram *p
static BcNum* bc_program_num(BcProgram *p, BcResult *r) {
- BcNum *n;
+ BcNum *n = NULL;
switch (r->t) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
