Re: svn commit: r364746 - in head: . cddl/compat/opensolaris/include cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cm
On Tue, Aug 25, 2020 at 02:21:27AM +, Matt Macy wrote: > New Revision: 364746 > URL: https://svnweb.freebsd.org/changeset/base/364746 > > Log: > Merge OpenZFS support in to HEAD. > > The primary benefit is maintaining a completely shared > code base with the community allowing FreeBSD to receive > new features sooner and with less effort. This commit raises several questions. To start, I see a lot of things checked in under `sys/contrib/openzfs' which do not belong to the kernel (e.g. userland programs, libraries, manpages, bash completions, test suite, etc/sudoers.d) or FreeBSD at all (init.d, initramfs, systemd). Why those bits were not cleaned up, or at least kept on the vendor branch only? > Improvements include: > project quotas, encrypted datasets, > allocation classes, vectorized raidz, > vectorized checksums, various command line > improvements, zstd compression. And what about regressions? Would illumos (opensolaris) ZFS be also offered, maybe from ports, for those of us who prefer stable and highly reliable implementation? > Added: head/cddl/lib/libicp/Makefile > ... > +core/kcf_prov_lib.c \ > +core/kcf_callprov.c \ > +core/kcf_mech_tabs.c \ > +core/kcf_prov_tabs.c \ > +$(ASM_SOURCES_C) > + > + > + > + > + > + > +SRCS= $(ASM_SOURCES_AS) $(KERNEL_C) There are many excessive whitespace bugs, this is the most prominent. How did they pass the review? ./danfe ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r364746 - in head: . cddl/compat/opensolaris/include cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/zdb cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/cm
In message <202008250221.07p2lrst044...@repo.freebsd.org>, Matt Macy writes: > Author: mmacy > Date: Tue Aug 25 02:21:27 2020 > New Revision: 364746 > URL: https://svnweb.freebsd.org/changeset/base/364746 > > Log: > Merge OpenZFS support in to HEAD. > > The primary benefit is maintaining a completely shared > code base with the community allowing FreeBSD to receive > new features sooner and with less effort. > > I would advise against doing 'zpool upgrade' > or creating indispensable pools using new > features until this change has had a month+ > to soak. > > Work on merging FreeBSD support in to what was > at the time "ZFS on Linux" began in August 2018. > I first publicly proposed transitioning FreeBSD > to (new) OpenZFS on December 18th, 2018. FreeBSD > support in OpenZFS was finally completed in December > 2019. A CFT for downstreaming OpenZFS support in > to FreeBSD was first issued on July 8th. All issues > that were reported have been addressed or, for > a couple of less critical matters there are > pull requests in progress with OpenZFS. iXsystems > has tested and dogfooded extensively internally. > The TrueNAS 12 release is based on OpenZFS with > some additional features that have not yet made > it upstream. > > Improvements include: > project quotas, encrypted datasets, > allocation classes, vectorized raidz, > vectorized checksums, various command line > improvements, zstd compression. > > Thanks to those who have helped along the way: > Ryan Moeller, Allan Jude, Zack Welch, and many > others. > > Sponsored by: iXsystems, Inc. > Differential Revision: https://reviews.freebsd.org/D25872 > Relnotes? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
