Re: svn commit: r366431 - head/sys/dev/usb/serial

2020-10-05 Thread Warner Losh 
On Mon, Oct 5, 2020 at 5:46 AM Ronald Klop  wrote:

> Hi,
>
> I was interested by this commit. But the commit and commit message don't
> have much information. I was surprised that the "Differential Revision"
> link contains a lot of info about this. How permanent is this
> review.freebsd.org server? Wil it stay after the git migration?
>

Yes. It's anticipated that we'll keep it around forever.

Warner


> Ronald.
>
>
> *Van:* Hans Petter Selasky 
> *Datum:* zondag, 4 oktober 2020 19:17
> *Aan:* src-committ...@freebsd.org, svn-src-all@freebsd.org,
> svn-src-h...@freebsd.org
> *Onderwerp:* svn commit: r366431 - head/sys/dev/usb/serial
>
> Author: hselasky
> Date: Sun Oct  4 17:17:16 2020
> New Revision: 366431
> URL: https://svnweb.freebsd.org/changeset/base/366431
>
> Log:
>   Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces
> to
>   the USB generic serial port driver, ugensa.
>
>   MFC after:1 week
>   Differential Revision:https://reviews.freebsd.org/D21863
>   Submitted by: greg_unrelenting.technology (Greg V)
>   Sponsored by: Mellanox Technologies // NVIDIA Networking
>
> Modified:
>   head/sys/dev/usb/serial/ugensa.c
>
> Modified: head/sys/dev/usb/serial/ugensa.c
>
> ==
> --- head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:07:13 2020
>(r366430)
> +++ head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:17:16 2020
>(r366431)
> @@ -161,6 +161,8 @@ static const STRUCT_USB_HOST_ID ugensa_devs[] = {
> {USB_VPI(USB_VENDOR_KYOCERA2, USB_PRODUCT_KYOCERA2_CDMA_MSM_K, 1)},
> {USB_VPI(USB_VENDOR_HP, USB_PRODUCT_HP_49GPLUS, 1)},
> {USB_VPI(USB_VENDOR_NOVATEL2, USB_PRODUCT_NOVATEL2_FLEXPACKGPS, 3)},
> +   {USB_VENDOR(USB_VENDOR_GOOGLE), USB_IFACE_CLASS(UICLASS_VENDOR),
> +   USB_IFACE_SUBCLASS(0x50), USB_IFACE_PROTOCOL(0x01),
> USB_DRIVER_INFO(10)},
>  };
>
>  DRIVER_MODULE(ugensa, uhub, ugensa_driver, ugensa_devclass, NULL, 0);
> ___
> svn-src-all@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
> --
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366431 - head/sys/dev/usb/serial

2020-10-05 Thread Ed Maste 
On Mon, 5 Oct 2020 at 07:46, Ronald Klop  wrote:
>
> Hi,
>
> I was interested by this commit. But the commit and commit message don't have 
> much information. I was surprised that the "Differential Revision" link 
> contains a lot of info about this. How permanent is this review.freebsd.org 
> server? Wil it stay after the git migration?

It will remain, but commit messages ought to contain all of the
information necessary to make sense of the commit even in the absence
of reviews.freebsd.org.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366431 - head/sys/dev/usb/serial

2020-10-05 Thread Ronald Klop 

Hi,

I was interested by this commit. But the commit and commit message don't have much 
information. I was surprised that the "Differential Revision" link contains a 
lot of info about this. How permanent is this review.freebsd.org server? Wil it stay 
after the git migration?

Ronald.

Van: Hans Petter Selasky 
Datum: zondag, 4 oktober 2020 19:17
Aan: src-committ...@freebsd.org, svn-src-all@freebsd.org, 
svn-src-h...@freebsd.org
Onderwerp: svn commit: r366431 - head/sys/dev/usb/serial


Author: hselasky
Date: Sun Oct  4 17:17:16 2020
New Revision: 366431
URL: https://svnweb.freebsd.org/changeset/base/366431

Log:
  Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to
  the USB generic serial port driver, ugensa.
  
  MFC after:1 week

  Differential Revision:https://reviews.freebsd.org/D21863
  Submitted by: greg_unrelenting.technology (Greg V)
  Sponsored by: Mellanox Technologies // NVIDIA Networking

Modified:
  head/sys/dev/usb/serial/ugensa.c

Modified: head/sys/dev/usb/serial/ugensa.c
==
--- head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:07:13 2020(r366430)
+++ head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:17:16 2020(r366431)
@@ -161,6 +161,8 @@ static const STRUCT_USB_HOST_ID ugensa_devs[] = {
{USB_VPI(USB_VENDOR_KYOCERA2, USB_PRODUCT_KYOCERA2_CDMA_MSM_K, 1)},
{USB_VPI(USB_VENDOR_HP, USB_PRODUCT_HP_49GPLUS, 1)},
{USB_VPI(USB_VENDOR_NOVATEL2, USB_PRODUCT_NOVATEL2_FLEXPACKGPS, 3)},
+   {USB_VENDOR(USB_VENDOR_GOOGLE), USB_IFACE_CLASS(UICLASS_VENDOR),
+   USB_IFACE_SUBCLASS(0x50), USB_IFACE_PROTOCOL(0x01), 
USB_DRIVER_INFO(10)},
 };
 
 DRIVER_MODULE(ugensa, uhub, ugensa_driver, ugensa_devclass, NULL, 0);

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"




___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366431 - head/sys/dev/usb/serial

2020-10-04 Thread Hans Petter Selasky 
Author: hselasky
Date: Sun Oct  4 17:17:16 2020
New Revision: 366431
URL: https://svnweb.freebsd.org/changeset/base/366431

Log:
  Add support for Google Cr50 (GSC) Closed Case Debugging UART interfaces to
  the USB generic serial port driver, ugensa.
  
  MFC after:1 week
  Differential Revision:https://reviews.freebsd.org/D21863
  Submitted by: greg_unrelenting.technology (Greg V)
  Sponsored by: Mellanox Technologies // NVIDIA Networking

Modified:
  head/sys/dev/usb/serial/ugensa.c

Modified: head/sys/dev/usb/serial/ugensa.c
==
--- head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:07:13 2020
(r366430)
+++ head/sys/dev/usb/serial/ugensa.cSun Oct  4 17:17:16 2020
(r366431)
@@ -161,6 +161,8 @@ static const STRUCT_USB_HOST_ID ugensa_devs[] = {
{USB_VPI(USB_VENDOR_KYOCERA2, USB_PRODUCT_KYOCERA2_CDMA_MSM_K, 1)},
{USB_VPI(USB_VENDOR_HP, USB_PRODUCT_HP_49GPLUS, 1)},
{USB_VPI(USB_VENDOR_NOVATEL2, USB_PRODUCT_NOVATEL2_FLEXPACKGPS, 3)},
+   {USB_VENDOR(USB_VENDOR_GOOGLE), USB_IFACE_CLASS(UICLASS_VENDOR),
+   USB_IFACE_SUBCLASS(0x50), USB_IFACE_PROTOCOL(0x01), 
USB_DRIVER_INFO(10)},
 };
 
 DRIVER_MODULE(ugensa, uhub, ugensa_driver, ugensa_devclass, NULL, 0);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"