Author: jhb
Date: Wed Nov 18 16:21:37 2020
New Revision: 367806
URL: https://svnweb.freebsd.org/changeset/base/367806

Log:
  Fix a few nits in vn_printf().
  
  - Mask out recently added VV_* bits to avoid printing them twice.
  
  - Keep VI_LOCKed on the same line as the rest of the flags.
  
  Reviewed by:  kib
  Obtained from:        CheriBSD
  Sponsored by: DARPA
  Differential Revision:        https://reviews.freebsd.org/D27261

Modified:
  head/sys/kern/vfs_subr.c

Modified: head/sys/kern/vfs_subr.c
==============================================================================
--- head/sys/kern/vfs_subr.c    Wed Nov 18 15:25:38 2020        (r367805)
+++ head/sys/kern/vfs_subr.c    Wed Nov 18 16:21:37 2020        (r367806)
@@ -4080,8 +4080,9 @@ vn_printf(struct vnode *vp, const char *fmt, ...)
        if (vp->v_vflag & VV_READLINK)
                strlcat(buf, "|VV_READLINK", sizeof(buf));
        flags = vp->v_vflag & ~(VV_ROOT | VV_ISTTY | VV_NOSYNC | VV_ETERNALDEV |
-           VV_CACHEDLABEL | VV_COPYONWRITE | VV_SYSTEM | VV_PROCDEP |
-           VV_NOKNOTE | VV_DELETED | VV_MD | VV_FORCEINSMQ);
+           VV_CACHEDLABEL | VV_VMSIZEVNLOCK | VV_COPYONWRITE | VV_SYSTEM |
+           VV_PROCDEP | VV_NOKNOTE | VV_DELETED | VV_MD | VV_FORCEINSMQ |
+           VV_READLINK);
        if (flags != 0) {
                snprintf(buf2, sizeof(buf2), "|VV(0x%lx)", flags);
                strlcat(buf, buf2, sizeof(buf));
@@ -4109,9 +4110,10 @@ vn_printf(struct vnode *vp, const char *fmt, ...)
                snprintf(buf2, sizeof(buf2), "|VMP(0x%lx)", flags);
                strlcat(buf, buf2, sizeof(buf));
        }
-       printf("    flags (%s)\n", buf + 1);
+       printf("    flags (%s)", buf + 1);
        if (mtx_owned(VI_MTX(vp)))
                printf(" VI_LOCKed");
+       printf("\n");
        if (vp->v_object != NULL)
                printf("    v_object %p ref %d pages %d "
                    "cleanbuf %d dirtybuf %d\n",
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to