Re: svn commit: r367929 - head/sys/dev/isp

2020-11-22 Thread Alexander Motin 
On 22.11.2020 10:23, Kyle Evans wrote:
> On Sat, Nov 21, 2020 at 11:43 PM Alexander Motin  wrote:
>> Author: mav
>> Date: Sun Nov 22 05:42:52 2020
>> New Revision: 367929
>> URL: https://svnweb.freebsd.org/changeset/base/367929
>>
>> Log:
>>   Fix build after 367926.
>>
>>   Option ISP_TARGET_MODE is evil.
>>
> 
> The LINT build appears to be broken following these, see:
> https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/18514/console
> 
> 09:02:49 --- isp_freebsd.o ---
> 09:02:49 /workspace/src/sys/dev/isp/isp_freebsd.c:1483:26: error: more
> '%' conversions than data arguments [-Werror,-Wformat]
> 09:02:49 KASSERT(atp == NULL, ("%s: atp is not NULL on noresrc!\n"));
> 09:02:49~^

Fixed in r367937.  Thanks.

-- 
Alexander Motin
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r367929 - head/sys/dev/isp

2020-11-22 Thread Kyle Evans 
On Sat, Nov 21, 2020 at 11:43 PM Alexander Motin  wrote:
>
> Author: mav
> Date: Sun Nov 22 05:42:52 2020
> New Revision: 367929
> URL: https://svnweb.freebsd.org/changeset/base/367929
>
> Log:
>   Fix build after 367926.
>
>   Option ISP_TARGET_MODE is evil.
>

The LINT build appears to be broken following these, see:
https://ci.freebsd.org/job/FreeBSD-head-amd64-LINT/18514/console

09:02:49 --- isp_freebsd.o ---
09:02:49 /workspace/src/sys/dev/isp/isp_freebsd.c:1483:26: error: more
'%' conversions than data arguments [-Werror,-Wformat]
09:02:49 KASSERT(atp == NULL, ("%s: atp is not NULL on noresrc!\n"));
09:02:49~^
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r367929 - head/sys/dev/isp

2020-11-21 Thread Alexander Motin 
Author: mav
Date: Sun Nov 22 05:42:52 2020
New Revision: 367929
URL: https://svnweb.freebsd.org/changeset/base/367929

Log:
  Fix build after 367926.
  
  Option ISP_TARGET_MODE is evil.

Modified:
  head/sys/dev/isp/isp.c

Modified: head/sys/dev/isp/isp.c
==
--- head/sys/dev/isp/isp.c  Sun Nov 22 05:34:51 2020(r367928)
+++ head/sys/dev/isp/isp.c  Sun Nov 22 05:42:52 2020(r367929)
@@ -742,6 +742,7 @@ isp_init(ispsoftc_t *isp)
if (!IS_26XX(isp))
icbp->icb_execthrottle = 0x;
 
+#ifdef ISP_TARGET_MODE
/*
 * Set target exchange count. Take half if we are supporting both roles.
 */
@@ -751,7 +752,7 @@ isp_init(ispsoftc_t *isp)
else
icbp->icb_xchgcnt = isp->isp_maxcmds;
}
-
+#endif
 
ownloopid = (isp->isp_confopts & ISP_CFG_OWNLOOPID) != 0;
icbp->icb_hardaddr = fcp->isp_loopid;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"