Re: svn commit: r239998 - head/contrib/dtc

2012-09-05 Thread Warner Losh

On Sep 2, 2012, at 2:22 PM, Aleksandr Rybalko wrote:

 On Sun, 2 Sep 2012 01:48:47 + (UTC)
 Andrew Turner and...@freebsd.org wrote:
 
 Author: andrew
 Date: Sun Sep  2 01:48:47 2012
 New Revision: 239998
 URL: http://svn.freebsd.org/changeset/base/239998
 
 Log:
  Fix a logic inversion in an assert to allow us to use dts files that
  include other files.
 
 Big Thanks for that!!!
 
 It's hard to add overlapping support also? So second instance of same
 node will be able to change attributes of previous one, such a status.
 Or add new attributes, like GPIO lines usage.
 
 Then we will be able to have per-SoC dts and per-board.   

Should already be fixed.  This is the latest dtc from upstream.

Warner

 
 Modified:
  head/contrib/dtc/dtc-lexer.l
 
 Modified: head/contrib/dtc/dtc-lexer.l
 ==
 --- head/contrib/dtc/dtc-lexer.l Sat Sep  1 23:33:49
 2012 (r239997) +++ head/contrib/dtc/dtc-lexer.l  Sun
 Sep  2 01:48:47 2012 (r239998) @@ -198,7 +198,7 @@ static void
 push_input_file(const char * {
  assert(filename);
 
 -assert(include_stack_pointer = MAX_INCLUDE_NESTING);
 +assert(include_stack_pointer  MAX_INCLUDE_NESTING);
 
  srcfile_push(filename);
 
 
 Thanks.
 
 WBW
 -- 
 Aleksandr Rybalko r...@ddteam.net

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org


Re: svn commit: r239998 - head/contrib/dtc

2012-09-05 Thread Warner Losh

On Sep 4, 2012, at 12:14 PM, Rafal Jaworowski wrote:

 
 On 2012-09-02, at 03:48, Andrew Turner wrote:
 
 Author: andrew
 Date: Sun Sep  2 01:48:47 2012
 New Revision: 239998
 URL: http://svn.freebsd.org/changeset/base/239998
 
 Log:
 Fix a logic inversion in an assert to allow us to use dts files that
 include other files.
 
 Modified:
 head/contrib/dtc/dtc-lexer.l
 
 Is this a bug in the dtc that should be upstreamed perhaps, or is it fixed at 
 the point beyond our recent import of the vendor package?

Neither.  This is in the hack I wrote to get around our lex not having all the 
features that dtc wants.

Warner

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org


Re: svn commit: r239998 - head/contrib/dtc

2012-09-04 Thread Rafal Jaworowski

On 2012-09-02, at 03:48, Andrew Turner wrote:

 Author: andrew
 Date: Sun Sep  2 01:48:47 2012
 New Revision: 239998
 URL: http://svn.freebsd.org/changeset/base/239998
 
 Log:
  Fix a logic inversion in an assert to allow us to use dts files that
  include other files.
 
 Modified:
  head/contrib/dtc/dtc-lexer.l

Is this a bug in the dtc that should be upstreamed perhaps, or is it fixed at 
the point beyond our recent import of the vendor package?

Rafal

___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org


Re: svn commit: r239998 - head/contrib/dtc

2012-09-02 Thread Aleksandr Rybalko
On Sun, 2 Sep 2012 01:48:47 + (UTC)
Andrew Turner and...@freebsd.org wrote:

 Author: andrew
 Date: Sun Sep  2 01:48:47 2012
 New Revision: 239998
 URL: http://svn.freebsd.org/changeset/base/239998
 
 Log:
   Fix a logic inversion in an assert to allow us to use dts files that
   include other files.

Big Thanks for that!!!

It's hard to add overlapping support also? So second instance of same
node will be able to change attributes of previous one, such a status.
Or add new attributes, like GPIO lines usage.

Then we will be able to have per-SoC dts and per-board.   

 
 Modified:
   head/contrib/dtc/dtc-lexer.l
 
 Modified: head/contrib/dtc/dtc-lexer.l
 ==
 --- head/contrib/dtc/dtc-lexer.l  Sat Sep  1 23:33:49
 2012  (r239997) +++ head/contrib/dtc/dtc-lexer.l  Sun
 Sep  2 01:48:47 2012  (r239998) @@ -198,7 +198,7 @@ static void
 push_input_file(const char * {
   assert(filename);
  
 - assert(include_stack_pointer = MAX_INCLUDE_NESTING);
 + assert(include_stack_pointer  MAX_INCLUDE_NESTING);
  
   srcfile_push(filename);
  

Thanks.

WBW
-- 
Aleksandr Rybalko r...@ddteam.net
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org


Re: svn commit: r239998 - head/contrib/dtc

2012-09-02 Thread Aleksandr Rybalko
On Sun, 2 Sep 2012 23:22:04 +0300
Aleksandr Rybalko r...@ddteam.net wrote:

 On Sun, 2 Sep 2012 01:48:47 + (UTC)
 Andrew Turner and...@freebsd.org wrote:
 
  Author: andrew
  Date: Sun Sep  2 01:48:47 2012
  New Revision: 239998
  URL: http://svn.freebsd.org/changeset/base/239998
  
  Log:
Fix a logic inversion in an assert to allow us to use dts files
  that include other files.
 
 Big Thanks for that!!!
 
 It's hard to add overlapping support also? So second instance of same
 node will be able to change attributes of previous one, such a
 status. Or add new attributes, like GPIO lines usage.
 
 Then we will be able to have per-SoC dts and per-board.

Sorry, that already supported, just a mistake in my DTS files. :)

One have uart@0x, second serial@0x.
Address is same, but name different.

Thanks again!

 
  
  Modified:
head/contrib/dtc/dtc-lexer.l
  
  Modified: head/contrib/dtc/dtc-lexer.l
  ==
  --- head/contrib/dtc/dtc-lexer.lSat Sep  1 23:33:49
  2012(r239997) +++ head/contrib/dtc/dtc-lexer.l  Sun
  Sep  2 01:48:47 2012(r239998) @@ -198,7 +198,7 @@ static
  void push_input_file(const char * {
  assert(filename);
   
  -   assert(include_stack_pointer = MAX_INCLUDE_NESTING);
  +   assert(include_stack_pointer  MAX_INCLUDE_NESTING);
   
  srcfile_push(filename);
   
 
 Thanks.
 
 WBW
 -- 
 Aleksandr Rybalko r...@ddteam.net


-- 
Aleksandr Rybalko r...@ddteam.net
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org