Re: svn commit: r252121 - in head/release/doc: en_US.ISO8859-1/errata share/xml

2013-06-24 Thread Glen Barber
On Mon, Jun 24, 2013 at 02:30:38PM +0900, Hiroki Sato wrote:
 gj Author: gjb
 gj Date: Sun Jun 23 20:19:00 2013
 gj New Revision: 252121
 gj URL: http://svnweb.freebsd.org/changeset/base/252121
 gj
 gj Log:
 gj   Add a new macro, release.current.release, to denote the head/ branch
 gj   with the -RELEASE suffix.  This fixes the incorrect text on the -CURRENT
 gj   errata page from showing '10.0-CURRENT' followed by 'until 9.1-RELEASE 
 is
 gj   released.'
 
  No, please revert this.  release.next is correct, but the value
  cannot be defined meaningfully for a branch which has no release yet.
  Errata never works for head, so please leave it as-is.  This errata
  document for FreeBSD 10.0-CURRENT will be maintained until the
  release of FreeBSD 10.0-RELEASE is still incorrect.
 

The previous version was incorrect.  Using release.next caused the page
to display:

This errata document for FreeBSD 10.0-CURRENT will be maintained
until the release of FreeBSD 9.1-RELEASE.

I do not see how my change is more incorrect than the previous version,
but if you would still like it reverted, I will do so.

Glen



pgpKPI9MwkcSY.pgp
Description: PGP signature


Re: svn commit: r252121 - in head/release/doc: en_US.ISO8859-1/errata share/xml

2013-06-24 Thread Hiroki Sato
Glen Barber g...@freebsd.org wrote
  in 20130624084009.gk1...@glenbarber.us:

gj On Mon, Jun 24, 2013 at 02:30:38PM +0900, Hiroki Sato wrote:
gj  gj Author: gjb
gj  gj Date: Sun Jun 23 20:19:00 2013
gj  gj New Revision: 252121
gj  gj URL: http://svnweb.freebsd.org/changeset/base/252121
gj  gj
gj  gj Log:
gj  gj   Add a new macro, release.current.release, to denote the head/ branch
gj  gj   with the -RELEASE suffix.  This fixes the incorrect text on the 
-CURRENT
gj  gj   errata page from showing '10.0-CURRENT' followed by 'until 
9.1-RELEASE is
gj  gj   released.'
gj 
gj   No, please revert this.  release.next is correct, but the value
gj   cannot be defined meaningfully for a branch which has no release yet.
gj   Errata never works for head, so please leave it as-is.  This errata
gj   document for FreeBSD 10.0-CURRENT will be maintained until the
gj   release of FreeBSD 10.0-RELEASE is still incorrect.
gj 
gj
gj The previous version was incorrect.  Using release.next caused the page
gj to display:

 It is just because the value of release.next is not updated.  Again,
 Errata for head never generates correct sentences *by design*.  It
 only works in a branch and we do not need to touch a copy on head
 since it is a placeholder.  If you want to fix the sentence, updating
 release.next is the correct way.  I do not care about which release
 number is in the sentence, but please do not change entity names.

gj I do not see how my change is more incorrect than the previous version,
gj but if you would still like it reverted, I will do so.

 Please do.

-- Hiroki


pgpcX8JwBH2yw.pgp
Description: PGP signature


Re: svn commit: r252121 - in head/release/doc: en_US.ISO8859-1/errata share/xml

2013-06-23 Thread Hiroki Sato
Glen Barber g...@freebsd.org wrote
  in 201306232019.r5nkj1gz064...@svn.freebsd.org:

gj Author: gjb
gj Date: Sun Jun 23 20:19:00 2013
gj New Revision: 252121
gj URL: http://svnweb.freebsd.org/changeset/base/252121
gj
gj Log:
gj   Add a new macro, release.current.release, to denote the head/ branch
gj   with the -RELEASE suffix.  This fixes the incorrect text on the -CURRENT
gj   errata page from showing '10.0-CURRENT' followed by 'until 9.1-RELEASE is
gj   released.'

 No, please revert this.  release.next is correct, but the value
 cannot be defined meaningfully for a branch which has no release yet.
 Errata never works for head, so please leave it as-is.  This errata
 document for FreeBSD 10.0-CURRENT will be maintained until the
 release of FreeBSD 10.0-RELEASE is still incorrect.

-- Hiroki


pgps2FUnADyaO.pgp
Description: PGP signature