Re: svn commit: r295254 - head/sys/arm/arm

[Zbigniew Bodek]

Hello Michal,

I have a fix for that that I will send for review soon (I need to test in
on some other platforms):
https://people.freebsd.org/~zbb/arm/other/0001-Fix-debug_monitor-code-for-older-ARMs-ARM11.patch

If you don't mind I will add you to the review on Phabricator.

Best regards
zbb

2016-02-04 14:32 GMT+01:00 Michal Meloun :

> Author: mmel
> Date: Thu Feb  4 13:32:29 2016
> New Revision: 295254
> URL: https://svnweb.freebsd.org/changeset/base/295254
>
> Log:
>   ARM: RPI-B kernel was broken by r294740. Make it functional again.
>
> Modified:
>   head/sys/arm/arm/debug_monitor.c
>
> Modified: head/sys/arm/arm/debug_monitor.c
>
> ==
> --- head/sys/arm/arm/debug_monitor.cThu Feb  4 12:49:28 2016
> (r295253)
> +++ head/sys/arm/arm/debug_monitor.cThu Feb  4 13:32:29 2016
> (r295254)
> @@ -845,8 +845,10 @@ dbg_arch_supported(void)
>  {
>
> switch (dbg_model) {
> +#ifdef not_yet
> case ID_DFR0_CP_DEBUG_M_V6:
> case ID_DFR0_CP_DEBUG_M_V6_1:
> +#endif
> case ID_DFR0_CP_DEBUG_M_V7:
> case ID_DFR0_CP_DEBUG_M_V7_1:   /* fall through */
> return (TRUE);
> ___
> svn-src-...@freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r295254 - head/sys/arm/arm

[Michal Meloun]

Yep, I'm ready to review your patch.
Allow me one question in forward.
How this patch affects JTAG based debugging of kernel? Mainly if I start
kernel under JTAG debugger, with active breakpoints (or watchpoints).

Michal

Dne 04.02.2016 v 14:41 Zbigniew Bodek napsal(a):
> Hello Michal,
> 
> I have a fix for that that I will send for review soon (I need to test
> in on some other platforms):
> https://people.freebsd.org/~zbb/arm/other/0001-Fix-debug_monitor-code-for-older-ARMs-ARM11.patch
> 
> 
> If you don't mind I will add you to the review on Phabricator.
> 
> Best regards
> zbb
> 
> 2016-02-04 14:32 GMT+01:00 Michal Meloun  >:
> 
> Author: mmel
> Date: Thu Feb  4 13:32:29 2016
> New Revision: 295254
> URL: https://svnweb.freebsd.org/changeset/base/295254
> 
> Log:
>   ARM: RPI-B kernel was broken by r294740. Make it functional again.
> 
> Modified:
>   head/sys/arm/arm/debug_monitor.c
> 
> Modified: head/sys/arm/arm/debug_monitor.c
> 
> ==
> --- head/sys/arm/arm/debug_monitor.cThu Feb  4 12:49:28 2016   
> (r295253)
> +++ head/sys/arm/arm/debug_monitor.cThu Feb  4 13:32:29 2016   
> (r295254)
> @@ -845,8 +845,10 @@ dbg_arch_supported(void)
>  {
> 
> switch (dbg_model) {
> +#ifdef not_yet
> case ID_DFR0_CP_DEBUG_M_V6:
> case ID_DFR0_CP_DEBUG_M_V6_1:
> +#endif
> case ID_DFR0_CP_DEBUG_M_V7:
> case ID_DFR0_CP_DEBUG_M_V7_1:   /* fall through */
> return (TRUE);
> ___
> svn-src-...@freebsd.org  mailing list
> https://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to
> "svn-src-all-unsubscr...@freebsd.org
> "
> 
> 

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r295254 - head/sys/arm/arm

[Zbigniew Bodek]

Hmm I didn't try that but I think the architecture supports using both
Monitor mode debugging (on a running system) and Halting debug mode (using
debugger).
However I will need to ensure whether any additional configuration is
required to use both at the same time.

Best regards
zbb

2016-02-04 15:45 GMT+01:00 Michal Meloun :

> Yep, I'm ready to review your patch.
> Allow me one question in forward.
> How this patch affects JTAG based debugging of kernel? Mainly if I start
> kernel under JTAG debugger, with active breakpoints (or watchpoints).
>
> Michal
>
> Dne 04.02.2016 v 14:41 Zbigniew Bodek napsal(a):
> > Hello Michal,
> >
> > I have a fix for that that I will send for review soon (I need to test
> > in on some other platforms):
> >
> https://people.freebsd.org/~zbb/arm/other/0001-Fix-debug_monitor-code-for-older-ARMs-ARM11.patch
> > <
> https://people.freebsd.org/%7Ezbb/arm/other/0001-Fix-debug_monitor-code-for-older-ARMs-ARM11.patch
> >
> >
> > If you don't mind I will add you to the review on Phabricator.
> >
> > Best regards
> > zbb
> >
> > 2016-02-04 14:32 GMT+01:00 Michal Meloun  > >:
> >
> > Author: mmel
> > Date: Thu Feb  4 13:32:29 2016
> > New Revision: 295254
> > URL: https://svnweb.freebsd.org/changeset/base/295254
> >
> > Log:
> >   ARM: RPI-B kernel was broken by r294740. Make it functional again.
> >
> > Modified:
> >   head/sys/arm/arm/debug_monitor.c
> >
> > Modified: head/sys/arm/arm/debug_monitor.c
> >
>  
> ==
> > --- head/sys/arm/arm/debug_monitor.cThu Feb  4 12:49:28 2016
> > (r295253)
> > +++ head/sys/arm/arm/debug_monitor.cThu Feb  4 13:32:29 2016
> > (r295254)
> > @@ -845,8 +845,10 @@ dbg_arch_supported(void)
> >  {
> >
> > switch (dbg_model) {
> > +#ifdef not_yet
> > case ID_DFR0_CP_DEBUG_M_V6:
> > case ID_DFR0_CP_DEBUG_M_V6_1:
> > +#endif
> > case ID_DFR0_CP_DEBUG_M_V7:
> > case ID_DFR0_CP_DEBUG_M_V7_1:   /* fall through */
> > return (TRUE);
> > ___
> > svn-src-...@freebsd.org  mailing
> list
> > https://lists.freebsd.org/mailman/listinfo/svn-src-all
> > To unsubscribe, send any mail to
> > "svn-src-all-unsubscr...@freebsd.org
> > "
> >
> >
>
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"