Re: svn commit: r327037 - head/sys/dev/acpica
In message, Warner Losh writes: > --001a1140eeb8e8b5ac0560cba79f > Content-Type: text/plain; charset="UTF-8" > > On Dec 20, 2017 1:33 PM, "Cy Schubert" wrote: > > In message <201712201914.vbkjeg68087...@repo.freebsd.org>, Warner Losh > writes: > > Author: imp > > Date: Wed Dec 20 19:14:16 2017 > > New Revision: 327037 > > URL: https://svnweb.freebsd.org/changeset/base/327037 > > > > Log: > > Simplify the code a bit. > > > > Replace clumsy for(;;) { if (foo) break; ...} with simpler > > while (!foo) { ... }. > > > > Sponsored by: Netflix > > Differential Revision: https://reviews.freebsd.org/D13546 > > > > Modified: > > head/sys/dev/acpica/acpi.c > > > > Modified: head/sys/dev/acpica/acpi.c > > > = > > = > > --- head/sys/dev/acpica/acpi.cWed Dec 20 19:14:11 2017 > (r32703 > > 6) > > +++ head/sys/dev/acpica/acpi.cWed Dec 20 19:14:16 2017 > (r32703 > > 7) > > @@ -1014,10 +1014,7 @@ acpi_hint_device_unit(device_t acdev, device_t > child, > > * name to see if one's resources are a subset of this device. > > */ > > line = 0; > > -for (;;) { > > - if (resource_find_dev(, name, , "at", NULL) != 0) > > - break; > > - > > +while (resource_find_dev(, name, , "at", NULL) == 0) { > > /* Must have an "at" for acpi or isa. */ > > resource_string_value(name, unit, "at", ); > > if (!(strcmp(s, "acpi0") == 0 || strcmp(s, "acpi") == 0 || > > > > > Would it make sense we upline this to reduce future MFV diffs? > > > No. This is 100% FreeBSD code. My mistake then. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r327037 - head/sys/dev/acpica
On Dec 20, 2017 1:33 PM, "Cy Schubert"wrote: In message <201712201914.vbkjeg68087...@repo.freebsd.org>, Warner Losh writes: > Author: imp > Date: Wed Dec 20 19:14:16 2017 > New Revision: 327037 > URL: https://svnweb.freebsd.org/changeset/base/327037 > > Log: > Simplify the code a bit. > > Replace clumsy for(;;) { if (foo) break; ...} with simpler > while (!foo) { ... }. > > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D13546 > > Modified: > head/sys/dev/acpica/acpi.c > > Modified: head/sys/dev/acpica/acpi.c > = > = > --- head/sys/dev/acpica/acpi.cWed Dec 20 19:14:11 2017 (r32703 > 6) > +++ head/sys/dev/acpica/acpi.cWed Dec 20 19:14:16 2017 (r32703 > 7) > @@ -1014,10 +1014,7 @@ acpi_hint_device_unit(device_t acdev, device_t child, > * name to see if one's resources are a subset of this device. > */ > line = 0; > -for (;;) { > - if (resource_find_dev(, name, , "at", NULL) != 0) > - break; > - > +while (resource_find_dev(, name, , "at", NULL) == 0) { > /* Must have an "at" for acpi or isa. */ > resource_string_value(name, unit, "at", ); > if (!(strcmp(s, "acpi0") == 0 || strcmp(s, "acpi") == 0 || > Would it make sense we upline this to reduce future MFV diffs? No. This is 100% FreeBSD code. Warner -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r327037 - head/sys/dev/acpica
In message <201712201914.vbkjeg68087...@repo.freebsd.org>, Warner Losh writes: > Author: imp > Date: Wed Dec 20 19:14:16 2017 > New Revision: 327037 > URL: https://svnweb.freebsd.org/changeset/base/327037 > > Log: > Simplify the code a bit. > > Replace clumsy for(;;) { if (foo) break; ...} with simpler > while (!foo) { ... }. > > Sponsored by: Netflix > Differential Revision: https://reviews.freebsd.org/D13546 > > Modified: > head/sys/dev/acpica/acpi.c > > Modified: head/sys/dev/acpica/acpi.c > = > = > --- head/sys/dev/acpica/acpi.cWed Dec 20 19:14:11 2017(r32703 > 6) > +++ head/sys/dev/acpica/acpi.cWed Dec 20 19:14:16 2017(r32703 > 7) > @@ -1014,10 +1014,7 @@ acpi_hint_device_unit(device_t acdev, device_t child, > * name to see if one's resources are a subset of this device. > */ > line = 0; > -for (;;) { > - if (resource_find_dev(, name, , "at", NULL) != 0) > - break; > - > +while (resource_find_dev(, name, , "at", NULL) == 0) { > /* Must have an "at" for acpi or isa. */ > resource_string_value(name, unit, "at", ); > if (!(strcmp(s, "acpi0") == 0 || strcmp(s, "acpi") == 0 || > Would it make sense we upline this to reduce future MFV diffs? -- Cheers, Cy SchubertFreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"