Re: svn commit: r336526 - head

2018-08-08 Thread Roger Pau Monné
On Thu, Jul 26, 2018 at 05:41:46PM +, Brooks Davis wrote:
> On Thu, Jul 26, 2018 at 06:15:46PM +0200, Roger Pau Monn?? wrote:
> > On Thu, Jul 26, 2018 at 09:05:18AM -0600, Ian Lepore wrote:
> > > On Thu, 2018-07-26 at 16:54 +0200, Roger Pau Monn? wrote:
> > > > On Thu, Jul 26, 2018 at 08:49:12AM -0600, Ian Lepore wrote:
> > > > > 
> > > > > On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monn? wrote:
> > > > > > 
> > > > > > On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > > > > > > 
> > > > > > > 
> > > > > > > Author: ian
> > > > > > > Date: Fri Jul 20 00:44:04 2018
> > > > > > > New Revision: 336526
> > > > > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > > > > 
> > > > > > > Log:
> > > > > > > ? Add ntpd to the list of users/groups to check before
> > > > > > > installing.
> > > > > > The Xen CI loop is getting this when trying to create dist media
> > > > > > for HEAD FreeBSD (`make -C release ftp`):
> > > > > > 
> > > > > > + LC_ALL=C
> > > > > > + export LC_ALL
> > > > > > +
> > > > > > PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbi
> > > > > > n:/u
> > > > > > sr/local/bin:/root/bin:/usr/lib/git-core
> > > > > > + http_proxy=http://cache:3128/
> > > > > > + export http_proxy
> > > > > > + https_proxy=http://cache:3128/
> > > > > > + export https_proxy
> > > > > > + exec
> > > > > > + cd /home/osstest/build.125515.build-amd64-freebsd
> > > > > > + rm -f build-ok-stamp
> > > > > > + cd freebsd
> > > > > > + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-
> > > > > > amd64-
> > > > > > freebsd/obj'
> > > > > > + export 'TARGET=amd64'
> > > > > > + make -C release ftp -DWITHOUT_AUTO_OBJ
> > > > > > + tee ../release-ftp-log
> > > > > > mkdir -p dist
> > > > > > cd /usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> > > > > > distributeworld DISTDIR=/usr/home/osstest/build.125515.build-
> > > > > > amd64-
> > > > > > freebsd/freebsd/release/dist
> > > > > > make[2]: "/usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> > > > > > cached toolchain metadata from build at??on Mon Jul 23 10:29:23
> > > > > > UTC
> > > > > > 2018
> > > > > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > > > > *** Error code 1
> > > > > > 
> > > > > > Stop.
> > > > > > make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/freebsd
> > > > > > *** Error code 1
> > > > > > 
> > > > > > Stop.
> > > > > > make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/freebsd
> > > > > > *** Error code 1
> > > > > > 
> > > > > > Stop.
> > > > > > make: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > > freebsd/freebsd/release
> > > > > > 
> > > > > > The full build log can be found at:
> > > > > > 
> > > > > > http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd
> > > > > > 64-f
> > > > > > reebsd/7.ts-freebsd-build.log
> > > > > > 
> > > > > > Note that it's ~100MB.
> > > > > > 
> > > > > > Thanks, Roger.
> > > > > > 
> > > > > If the script is creating a new distribution image from scratch, it
> > > > > should be using -DDB_FROM_SRC on all distrib* and install* make
> > > > > targets, to avoid using (and verifying against) the passwd database
> > > > > on
> > > > > the build system.
> > > > Shouldn't then that be set by default for the ftp release target?
> > > > The sole purpose of that target is to create the sets that go to the
> > > > servers AFAICT.
> > > > 
> > > > Or maybe it's the distributeworld target the one missing the
> > > > DB_FROM_SRC?
> > > > 
> > > > Roger.
> > > > 
> > > 
> > > I don't know anything about the release scripts or how they work.
> > > 
> > > I started down the path of trying to make the build system
> > > automatically set DB_FROM_SRC if DESTDIR is anything other than "/",
> > > but I realized that's wrong too... I occasionally mount an sdcard from
> > > some embedded system on my build machine and update it from a
> > > crossbuild using DESTDIR=/mnt, and in a case like that, using the
> > > passwd database from the system being updated is the right thing to do
> > > and DB_FROM_SRC isn't right (although it would work most of the time
> > > for most people).
> > > 
> > > Right now there's no way to even properly use the passwd data from the
> > > target system, and when I tried to do that, I ran into other bugs. The
> > > only options now are to use the running system even when it's not
> > > what's being installed (clearly wrong) or use DB_FROM_SRC to bypass the
> > > checks, but also bypass using the passwd data from the target system
> > > (but it works okay as long as none of the names/uids < 1024 have been
> > > changed on the target system/image).
> > 
> > But when executing something like the distributeworld target there's

Re: svn commit: r336526 - head

2018-07-29 Thread Ravi Pokala
-Original Message-
From: Will Andrews 
Date: 2018-07-28, Saturday at 18:44
To: Ravi Pokala 
Cc: Ian Lepore , "src-committ...@freebsd.org" 
, , 

Subject: Re: svn commit: r336526 - head

> Hi Ravi,
> Thanks for taking an initial stab, I applied your patch and quickly realized 
> the problem is deeper than it looks.  This is because installworld and the 
> second stage of mergemaster/etcupdate require the "pre" phase to take effect 
> in their view of the system (specifically, the "ntpd" user must exist from 
> their /etc/passwd, etc).  For traditional upgrades, this occurs by simply 
> rebooting.
> 
> I've committed a revised version of your original patch, and have upgraded 
> across this barrier using beinstall.  Please give it a try and let me know 
> how it goes.
> 
> Thanks!
> --Will.

It worked! Thanks so much for following up on this, Will! :-)

-Ravi (rpokala@)

On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala  wrote:

-Original Message-
From: Ravi Pokala 
Date: 2018-07-20, Friday at 10:53
To: Ian Lepore , , 
, , Will Andrews 

Subject: Re: svn commit: r336526 - head

> -Original Message-
> From:  on behalf of Ian Lepore 
> 
> Date: 2018-07-20, Friday at 10:38
> To: Ravi Pokala , , 
> , 
> Subject: Re: svn commit: r336526 - head
> 
>> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
>>> Hi Ian,
>>> 
>>> -Original Message-
>>> From:  on behalf of Ian Lepore 
>>> Date: 2018-07-19, Thursday at 17:44
>>> To: , , 
>>> Subject: svn commit: r336526 - head
>>> 
>>>> 
>>>> Author: ian
>>>> Date: Fri Jul 20 00:44:04 2018
>>>> New Revision: 336526
>>>> URL: https://svnweb.freebsd.org/changeset/base/336526
>>>> 
>>>> Log:
>>>>   Add ntpd to the list of users/groups to check before installing.
>>>> 
>>>> Modified:
>>>>   head/Makefile.inc1
>>> When trying to installworld:
>>> 
>>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
>>> 
>>> But there is no UPDATING entry about this. (Also, shouldn't it be 
>>> ${SRCTOP}/UPDATING?)
>>> 
>>> Thanks,
>>> 
>>> Ravi (rpokala@)
>> 
>> I wondered about that too, when I accidentally stumbled across the
>> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
>> UPDATING for some of the other things in the CHECK_UIDS list to see
>> what had been said about such changes in the past, even searching
>> through old-old svn history, and found nothing.
>> 
>> I finally settled on the thought that the reference to UPDATING was to
>> the stuff at the bottom that never changes. In particular to the
>> section around line 1595 that documents the instalkernel, reboot,
>> mergemaster, installworld sequence. The mergemaster part should take
>> care of the new userid, I guess.
>> 
>> -- Ian
> 
> Interesting. I was attempting the install via the `beinstall.sh' script. 
> CCing will@, since he wrote it.
> 
> Thanks,
> 
> Ravi (rpokala@)



After some discussion on IRC, I created this patch to fix `beinstall.sh'.

https://people.freebsd.org/~rpokala/beinstall.patch

However, I'm a bit afraid of testing it, until someone who actually knows 
`etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-)

Can anyone take a look and assuage my fears?

Thanks,

Ravi (rpokala@)









___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-28 Thread Will Andrews
Hi Ravi,

Thanks for taking an initial stab, I applied your patch and quickly
realized the problem is deeper than it looks.  This is because installworld
and the second stage of mergemaster/etcupdate require the "pre" phase to
take effect in their view of the system (specifically, the "ntpd" user must
exist from their /etc/passwd, etc).  For traditional upgrades, this occurs
by simply rebooting.

I've committed a revised version of your original patch, and have upgraded
across this barrier using beinstall.  Please give it a try and let me know
how it goes.

Thanks!
--Will.

On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala  wrote:

> -Original Message-
> From: Ravi Pokala 
> Date: 2018-07-20, Friday at 10:53
> To: Ian Lepore , , <
> svn-src-...@freebsd.org>, , Will Andrews
> 
> Subject: Re: svn commit: r336526 - head
>
> > -Original Message-
> > From:  on behalf of Ian Lepore <
> i...@freebsd.org>
> > Date: 2018-07-20, Friday at 10:38
> > To: Ravi Pokala , , <
> svn-src-...@freebsd.org>, 
> > Subject: Re: svn commit: r336526 - head
> >
> >> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> >>> Hi Ian,
> >>>
> >>> -Original Message-
> >>> From:  on behalf of Ian Lepore
> >>> Date: 2018-07-19, Thursday at 17:44
> >>> To: , ,
> >>> Subject: svn commit: r336526 - head
> >>>
> >>>>
> >>>> Author: ian
> >>>> Date: Fri Jul 20 00:44:04 2018
> >>>> New Revision: 336526
> >>>> URL: https://svnweb.freebsd.org/changeset/base/336526
> >>>>
> >>>> Log:
> >>>>   Add ntpd to the list of users/groups to check before installing.
> >>>>
> >>>> Modified:
> >>>>   head/Makefile.inc1
> >>> When trying to installworld:
> >>>
> >>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> >>>
> >>> But there is no UPDATING entry about this. (Also, shouldn't it be
> ${SRCTOP}/UPDATING?)
> >>>
> >>> Thanks,
> >>>
> >>> Ravi (rpokala@)
> >>
> >> I wondered about that too, when I accidentally stumbled across the
> >> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> >> UPDATING for some of the other things in the CHECK_UIDS list to see
> >> what had been said about such changes in the past, even searching
> >> through old-old svn history, and found nothing.
> >>
> >> I finally settled on the thought that the reference to UPDATING was to
> >> the stuff at the bottom that never changes. In particular to the
> >> section around line 1595 that documents the instalkernel, reboot,
> >> mergemaster, installworld sequence. The mergemaster part should take
> >> care of the new userid, I guess.
> >>
> >> -- Ian
> >
> > Interesting. I was attempting the install via the `beinstall.sh' script.
> CCing will@, since he wrote it.
> >
> > Thanks,
> >
> > Ravi (rpokala@)
>
> After some discussion on IRC, I created this patch to fix `beinstall.sh'.
>
> https://people.freebsd.org/~rpokala/beinstall.patch
>
> However, I'm a bit afraid of testing it, until someone who actually knows
> `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-)
>
> Can anyone take a look and assuage my fears?
>
> Thanks,
>
> Ravi (rpokala@)
>
>
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Brooks Davis
On Thu, Jul 26, 2018 at 06:15:46PM +0200, Roger Pau Monn?? wrote:
> On Thu, Jul 26, 2018 at 09:05:18AM -0600, Ian Lepore wrote:
> > On Thu, 2018-07-26 at 16:54 +0200, Roger Pau Monn? wrote:
> > > On Thu, Jul 26, 2018 at 08:49:12AM -0600, Ian Lepore wrote:
> > > > 
> > > > On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monn? wrote:
> > > > > 
> > > > > On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > > > > > 
> > > > > > 
> > > > > > Author: ian
> > > > > > Date: Fri Jul 20 00:44:04 2018
> > > > > > New Revision: 336526
> > > > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > > > 
> > > > > > Log:
> > > > > > ? Add ntpd to the list of users/groups to check before
> > > > > > installing.
> > > > > The Xen CI loop is getting this when trying to create dist media
> > > > > for HEAD FreeBSD (`make -C release ftp`):
> > > > > 
> > > > > + LC_ALL=C
> > > > > + export LC_ALL
> > > > > +
> > > > > PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbi
> > > > > n:/u
> > > > > sr/local/bin:/root/bin:/usr/lib/git-core
> > > > > + http_proxy=http://cache:3128/
> > > > > + export http_proxy
> > > > > + https_proxy=http://cache:3128/
> > > > > + export https_proxy
> > > > > + exec
> > > > > + cd /home/osstest/build.125515.build-amd64-freebsd
> > > > > + rm -f build-ok-stamp
> > > > > + cd freebsd
> > > > > + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-
> > > > > amd64-
> > > > > freebsd/obj'
> > > > > + export 'TARGET=amd64'
> > > > > + make -C release ftp -DWITHOUT_AUTO_OBJ
> > > > > + tee ../release-ftp-log
> > > > > mkdir -p dist
> > > > > cd /usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> > > > > distributeworld DISTDIR=/usr/home/osstest/build.125515.build-
> > > > > amd64-
> > > > > freebsd/freebsd/release/dist
> > > > > make[2]: "/usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> > > > > cached toolchain metadata from build at??on Mon Jul 23 10:29:23
> > > > > UTC
> > > > > 2018
> > > > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > > > *** Error code 1
> > > > > 
> > > > > Stop.
> > > > > make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/freebsd
> > > > > *** Error code 1
> > > > > 
> > > > > Stop.
> > > > > make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/freebsd
> > > > > *** Error code 1
> > > > > 
> > > > > Stop.
> > > > > make: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > > freebsd/freebsd/release
> > > > > 
> > > > > The full build log can be found at:
> > > > > 
> > > > > http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd
> > > > > 64-f
> > > > > reebsd/7.ts-freebsd-build.log
> > > > > 
> > > > > Note that it's ~100MB.
> > > > > 
> > > > > Thanks, Roger.
> > > > > 
> > > > If the script is creating a new distribution image from scratch, it
> > > > should be using -DDB_FROM_SRC on all distrib* and install* make
> > > > targets, to avoid using (and verifying against) the passwd database
> > > > on
> > > > the build system.
> > > Shouldn't then that be set by default for the ftp release target?
> > > The sole purpose of that target is to create the sets that go to the
> > > servers AFAICT.
> > > 
> > > Or maybe it's the distributeworld target the one missing the
> > > DB_FROM_SRC?
> > > 
> > > Roger.
> > > 
> > 
> > I don't know anything about the release scripts or how they work.
> > 
> > I started down the path of trying to make the build system
> > automatically set DB_FROM_SRC if DESTDIR is anything other than "/",
> > but I realized that's wrong too... I occasionally mount an sdcard from
> > some embedded system on my build machine and update it from a
> > crossbuild using DESTDIR=/mnt, and in a case like that, using the
> > passwd database from the system being updated is the right thing to do
> > and DB_FROM_SRC isn't right (although it would work most of the time
> > for most people).
> > 
> > Right now there's no way to even properly use the passwd data from the
> > target system, and when I tried to do that, I ran into other bugs. The
> > only options now are to use the running system even when it's not
> > what's being installed (clearly wrong) or use DB_FROM_SRC to bypass the
> > checks, but also bypass using the passwd data from the target system
> > (but it works okay as long as none of the names/uids < 1024 have been
> > changed on the target system/image).
> 
> But when executing something like the distributeworld target there's
> nothing to check. You cannot check against the current DB, and there's
> no destination DB since you are just generating install sets. Hence I
> think that at least for distributeworld and maybe other targets
> DB_FROM_SRC should be set by default in order to restore previous
> behavior.


Re: svn commit: r336526 - head

2018-07-26 Thread Roger Pau Monné
On Thu, Jul 26, 2018 at 09:05:18AM -0600, Ian Lepore wrote:
> On Thu, 2018-07-26 at 16:54 +0200, Roger Pau Monné wrote:
> > On Thu, Jul 26, 2018 at 08:49:12AM -0600, Ian Lepore wrote:
> > > 
> > > On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monné wrote:
> > > > 
> > > > On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > > > > 
> > > > > 
> > > > > Author: ian
> > > > > Date: Fri Jul 20 00:44:04 2018
> > > > > New Revision: 336526
> > > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > > 
> > > > > Log:
> > > > >   Add ntpd to the list of users/groups to check before
> > > > > installing.
> > > > The Xen CI loop is getting this when trying to create dist media
> > > > for HEAD FreeBSD (`make -C release ftp`):
> > > > 
> > > > + LC_ALL=C
> > > > + export LC_ALL
> > > > +
> > > > PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbi
> > > > n:/u
> > > > sr/local/bin:/root/bin:/usr/lib/git-core
> > > > + http_proxy=http://cache:3128/
> > > > + export http_proxy
> > > > + https_proxy=http://cache:3128/
> > > > + export https_proxy
> > > > + exec
> > > > + cd /home/osstest/build.125515.build-amd64-freebsd
> > > > + rm -f build-ok-stamp
> > > > + cd freebsd
> > > > + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-
> > > > amd64-
> > > > freebsd/obj'
> > > > + export 'TARGET=amd64'
> > > > + make -C release ftp -DWITHOUT_AUTO_OBJ
> > > > + tee ../release-ftp-log
> > > > mkdir -p dist
> > > > cd /usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> > > > distributeworld DISTDIR=/usr/home/osstest/build.125515.build-
> > > > amd64-
> > > > freebsd/freebsd/release/dist
> > > > make[2]: "/usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> > > > cached toolchain metadata from build at  on Mon Jul 23 10:29:23
> > > > UTC
> > > > 2018
> > > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > > *** Error code 1
> > > > 
> > > > Stop.
> > > > make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/freebsd
> > > > *** Error code 1
> > > > 
> > > > Stop.
> > > > make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/freebsd
> > > > *** Error code 1
> > > > 
> > > > Stop.
> > > > make: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > > freebsd/freebsd/release
> > > > 
> > > > The full build log can be found at:
> > > > 
> > > > http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd
> > > > 64-f
> > > > reebsd/7.ts-freebsd-build.log
> > > > 
> > > > Note that it's ~100MB.
> > > > 
> > > > Thanks, Roger.
> > > > 
> > > If the script is creating a new distribution image from scratch, it
> > > should be using -DDB_FROM_SRC on all distrib* and install* make
> > > targets, to avoid using (and verifying against) the passwd database
> > > on
> > > the build system.
> > Shouldn't then that be set by default for the ftp release target?
> > The sole purpose of that target is to create the sets that go to the
> > servers AFAICT.
> > 
> > Or maybe it's the distributeworld target the one missing the
> > DB_FROM_SRC?
> > 
> > Roger.
> > 
> 
> I don't know anything about the release scripts or how they work.
> 
> I started down the path of trying to make the build system
> automatically set DB_FROM_SRC if DESTDIR is anything other than "/",
> but I realized that's wrong too... I occasionally mount an sdcard from
> some embedded system on my build machine and update it from a
> crossbuild using DESTDIR=/mnt, and in a case like that, using the
> passwd database from the system being updated is the right thing to do
> and DB_FROM_SRC isn't right (although it would work most of the time
> for most people).
> 
> Right now there's no way to even properly use the passwd data from the
> target system, and when I tried to do that, I ran into other bugs. The
> only options now are to use the running system even when it's not
> what's being installed (clearly wrong) or use DB_FROM_SRC to bypass the
> checks, but also bypass using the passwd data from the target system
> (but it works okay as long as none of the names/uids < 1024 have been
> changed on the target system/image).

But when executing something like the distributeworld target there's
nothing to check. You cannot check against the current DB, and there's
no destination DB since you are just generating install sets. Hence I
think that at least for distributeworld and maybe other targets
DB_FROM_SRC should be set by default in order to restore previous
behavior.

Thanks, Roger.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Ian Lepore
On Thu, 2018-07-26 at 16:54 +0200, Roger Pau Monné wrote:
> On Thu, Jul 26, 2018 at 08:49:12AM -0600, Ian Lepore wrote:
> > 
> > On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monné wrote:
> > > 
> > > On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > > > 
> > > > 
> > > > Author: ian
> > > > Date: Fri Jul 20 00:44:04 2018
> > > > New Revision: 336526
> > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > 
> > > > Log:
> > > >   Add ntpd to the list of users/groups to check before
> > > > installing.
> > > The Xen CI loop is getting this when trying to create dist media
> > > for HEAD FreeBSD (`make -C release ftp`):
> > > 
> > > + LC_ALL=C
> > > + export LC_ALL
> > > +
> > > PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbi
> > > n:/u
> > > sr/local/bin:/root/bin:/usr/lib/git-core
> > > + http_proxy=http://cache:3128/
> > > + export http_proxy
> > > + https_proxy=http://cache:3128/
> > > + export https_proxy
> > > + exec
> > > + cd /home/osstest/build.125515.build-amd64-freebsd
> > > + rm -f build-ok-stamp
> > > + cd freebsd
> > > + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-
> > > amd64-
> > > freebsd/obj'
> > > + export 'TARGET=amd64'
> > > + make -C release ftp -DWITHOUT_AUTO_OBJ
> > > + tee ../release-ftp-log
> > > mkdir -p dist
> > > cd /usr/home/osstest/build.125515.build-amd64-
> > > freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> > > distributeworld DISTDIR=/usr/home/osstest/build.125515.build-
> > > amd64-
> > > freebsd/freebsd/release/dist
> > > make[2]: "/usr/home/osstest/build.125515.build-amd64-
> > > freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> > > freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> > > cached toolchain metadata from build at  on Mon Jul 23 10:29:23
> > > UTC
> > > 2018
> > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > *** Error code 1
> > > 
> > > Stop.
> > > make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > freebsd/freebsd
> > > *** Error code 1
> > > 
> > > Stop.
> > > make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > freebsd/freebsd
> > > *** Error code 1
> > > 
> > > Stop.
> > > make: stopped in /usr/home/osstest/build.125515.build-amd64-
> > > freebsd/freebsd/release
> > > 
> > > The full build log can be found at:
> > > 
> > > http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd
> > > 64-f
> > > reebsd/7.ts-freebsd-build.log
> > > 
> > > Note that it's ~100MB.
> > > 
> > > Thanks, Roger.
> > > 
> > If the script is creating a new distribution image from scratch, it
> > should be using -DDB_FROM_SRC on all distrib* and install* make
> > targets, to avoid using (and verifying against) the passwd database
> > on
> > the build system.
> Shouldn't then that be set by default for the ftp release target?
> The sole purpose of that target is to create the sets that go to the
> servers AFAICT.
> 
> Or maybe it's the distributeworld target the one missing the
> DB_FROM_SRC?
> 
> Roger.
> 

I don't know anything about the release scripts or how they work.

I started down the path of trying to make the build system
automatically set DB_FROM_SRC if DESTDIR is anything other than "/",
but I realized that's wrong too... I occasionally mount an sdcard from
some embedded system on my build machine and update it from a
crossbuild using DESTDIR=/mnt, and in a case like that, using the
passwd database from the system being updated is the right thing to do
and DB_FROM_SRC isn't right (although it would work most of the time
for most people).

Right now there's no way to even properly use the passwd data from the
target system, and when I tried to do that, I ran into other bugs. The
only options now are to use the running system even when it's not
what's being installed (clearly wrong) or use DB_FROM_SRC to bypass the
checks, but also bypass using the passwd data from the target system
(but it works okay as long as none of the names/uids < 1024 have been
changed on the target system/image).

-- Ian
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Roger Pau Monné
On Thu, Jul 26, 2018 at 08:49:12AM -0600, Ian Lepore wrote:
> On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monné wrote:
> > On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > > 
> > > Author: ian
> > > Date: Fri Jul 20 00:44:04 2018
> > > New Revision: 336526
> > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > 
> > > Log:
> > >   Add ntpd to the list of users/groups to check before installing.
> > The Xen CI loop is getting this when trying to create dist media
> > for HEAD FreeBSD (`make -C release ftp`):
> > 
> > + LC_ALL=C
> > + export LC_ALL
> > +
> > PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/u
> > sr/local/bin:/root/bin:/usr/lib/git-core
> > + http_proxy=http://cache:3128/
> > + export http_proxy
> > + https_proxy=http://cache:3128/
> > + export https_proxy
> > + exec
> > + cd /home/osstest/build.125515.build-amd64-freebsd
> > + rm -f build-ok-stamp
> > + cd freebsd
> > + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-amd64-
> > freebsd/obj'
> > + export 'TARGET=amd64'
> > + make -C release ftp -DWITHOUT_AUTO_OBJ
> > + tee ../release-ftp-log
> > mkdir -p dist
> > cd /usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> > distributeworld DISTDIR=/usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd/release/dist
> > make[2]: "/usr/home/osstest/build.125515.build-amd64-
> > freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> > cached toolchain metadata from build at  on Mon Jul 23 10:29:23 UTC
> > 2018
> > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > *** Error code 1
> > 
> > Stop.
> > make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd
> > *** Error code 1
> > 
> > Stop.
> > make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd
> > *** Error code 1
> > 
> > Stop.
> > make: stopped in /usr/home/osstest/build.125515.build-amd64-
> > freebsd/freebsd/release
> > 
> > The full build log can be found at:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd64-f
> > reebsd/7.ts-freebsd-build.log
> > 
> > Note that it's ~100MB.
> > 
> > Thanks, Roger.
> > 
> 
> If the script is creating a new distribution image from scratch, it
> should be using -DDB_FROM_SRC on all distrib* and install* make
> targets, to avoid using (and verifying against) the passwd database on
> the build system.

Shouldn't then that be set by default for the ftp release target?
The sole purpose of that target is to create the sets that go to the
servers AFAICT.

Or maybe it's the distributeworld target the one missing the
DB_FROM_SRC?

Roger.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Ian Lepore
On Thu, 2018-07-26 at 15:58 +0200, Roger Pau Monné wrote:
> On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> > 
> > Author: ian
> > Date: Fri Jul 20 00:44:04 2018
> > New Revision: 336526
> > URL: https://svnweb.freebsd.org/changeset/base/336526
> > 
> > Log:
> >   Add ntpd to the list of users/groups to check before installing.
> The Xen CI loop is getting this when trying to create dist media
> for HEAD FreeBSD (`make -C release ftp`):
> 
> + LC_ALL=C
> + export LC_ALL
> +
> PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/u
> sr/local/bin:/root/bin:/usr/lib/git-core
> + http_proxy=http://cache:3128/
> + export http_proxy
> + https_proxy=http://cache:3128/
> + export https_proxy
> + exec
> + cd /home/osstest/build.125515.build-amd64-freebsd
> + rm -f build-ok-stamp
> + cd freebsd
> + export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-amd64-
> freebsd/obj'
> + export 'TARGET=amd64'
> + make -C release ftp -DWITHOUT_AUTO_OBJ
> + tee ../release-ftp-log
> mkdir -p dist
> cd /usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd/release/.. && make TARGET_ARCH=amd64 TARGET=amd64
> distributeworld DISTDIR=/usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd/release/dist
> make[2]: "/usr/home/osstest/build.125515.build-amd64-
> freebsd/obj/usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd/amd64.amd64/toolchain-metadata.mk" line 1: Using
> cached toolchain metadata from build at  on Mon Jul 23 10:29:23 UTC
> 2018
> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> *** Error code 1
> 
> Stop.
> make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd
> *** Error code 1
> 
> Stop.
> make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/home/osstest/build.125515.build-amd64-
> freebsd/freebsd/release
> 
> The full build log can be found at:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd64-f
> reebsd/7.ts-freebsd-build.log
> 
> Note that it's ~100MB.
> 
> Thanks, Roger.
> 

If the script is creating a new distribution image from scratch, it
should be using -DDB_FROM_SRC on all distrib* and install* make
targets, to avoid using (and verifying against) the passwd database on
the build system.

-- Ian
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Will Andrews
Hi Ravi,

I don't think you have to worry.  These commands are confined to the
temporary mount point used for the BE during the install phase, so they
won't affect your running system (which is sort of the point of using
beinstall instead of doing it the "traditional" way).  I haven't had a
chance yet to test it, but I would expect it works fine.

Very minor nit: I'd distinguish the "pre" phase from the post in the error
message.

Thanks for looking into this.

--Will.

On Wed, Jul 25, 2018 at 11:28 PM, Ravi Pokala  wrote:

> -Original Message-
> From: Ravi Pokala 
> Date: 2018-07-20, Friday at 10:53
> To: Ian Lepore , , <
> svn-src-...@freebsd.org>, , Will Andrews
> 
> Subject: Re: svn commit: r336526 - head
>
> > -Original Message-
> > From:  on behalf of Ian Lepore <
> i...@freebsd.org>
> > Date: 2018-07-20, Friday at 10:38
> > To: Ravi Pokala , , <
> svn-src-...@freebsd.org>, 
> > Subject: Re: svn commit: r336526 - head
> >
> >> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> >>> Hi Ian,
> >>>
> >>> -Original Message-
> >>> From:  on behalf of Ian Lepore
> >>> Date: 2018-07-19, Thursday at 17:44
> >>> To: , ,
> >>> Subject: svn commit: r336526 - head
> >>>
> >>>>
> >>>> Author: ian
> >>>> Date: Fri Jul 20 00:44:04 2018
> >>>> New Revision: 336526
> >>>> URL: https://svnweb.freebsd.org/changeset/base/336526
> >>>>
> >>>> Log:
> >>>>   Add ntpd to the list of users/groups to check before installing.
> >>>>
> >>>> Modified:
> >>>>   head/Makefile.inc1
> >>> When trying to installworld:
> >>>
> >>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> >>>
> >>> But there is no UPDATING entry about this. (Also, shouldn't it be
> ${SRCTOP}/UPDATING?)
> >>>
> >>> Thanks,
> >>>
> >>> Ravi (rpokala@)
> >>
> >> I wondered about that too, when I accidentally stumbled across the
> >> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> >> UPDATING for some of the other things in the CHECK_UIDS list to see
> >> what had been said about such changes in the past, even searching
> >> through old-old svn history, and found nothing.
> >>
> >> I finally settled on the thought that the reference to UPDATING was to
> >> the stuff at the bottom that never changes. In particular to the
> >> section around line 1595 that documents the instalkernel, reboot,
> >> mergemaster, installworld sequence. The mergemaster part should take
> >> care of the new userid, I guess.
> >>
> >> -- Ian
> >
> > Interesting. I was attempting the install via the `beinstall.sh' script.
> CCing will@, since he wrote it.
> >
> > Thanks,
> >
> > Ravi (rpokala@)
>
> After some discussion on IRC, I created this patch to fix `beinstall.sh'.
>
> https://people.freebsd.org/~rpokala/beinstall.patch
>
> However, I'm a bit afraid of testing it, until someone who actually knows
> `etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-)
>
> Can anyone take a look and assuage my fears?
>
> Thanks,
>
> Ravi (rpokala@)
>
>
>
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-26 Thread Roger Pau Monné
On Fri, Jul 20, 2018 at 12:44:04AM +, Ian Lepore wrote:
> Author: ian
> Date: Fri Jul 20 00:44:04 2018
> New Revision: 336526
> URL: https://svnweb.freebsd.org/changeset/base/336526
> 
> Log:
>   Add ntpd to the list of users/groups to check before installing.

The Xen CI loop is getting this when trying to create dist media
for HEAD FreeBSD (`make -C release ftp`):

+ LC_ALL=C
+ export LC_ALL
+ 
PATH=/usr/lib/ccache:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin:/usr/lib/git-core
+ http_proxy=http://cache:3128/
+ export http_proxy
+ https_proxy=http://cache:3128/
+ export https_proxy
+ exec
+ cd /home/osstest/build.125515.build-amd64-freebsd
+ rm -f build-ok-stamp
+ cd freebsd
+ export 'MAKEOBJDIRPREFIX=/home/osstest/build.125515.build-amd64-freebsd/obj'
+ export 'TARGET=amd64'
+ make -C release ftp -DWITHOUT_AUTO_OBJ
+ tee ../release-ftp-log
mkdir -p dist
cd /usr/home/osstest/build.125515.build-amd64-freebsd/freebsd/release/.. && 
make TARGET_ARCH=amd64 TARGET=amd64 distributeworld 
DISTDIR=/usr/home/osstest/build.125515.build-amd64-freebsd/freebsd/release/dist
make[2]: 
"/usr/home/osstest/build.125515.build-amd64-freebsd/obj/usr/home/osstest/build.125515.build-amd64-freebsd/freebsd/amd64.amd64/toolchain-metadata.mk"
 line 1: Using cached toolchain metadata from build at  on Mon Jul 23 10:29:23 
UTC 2018
ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
*** Error code 1

Stop.
make[2]: stopped in /usr/home/osstest/build.125515.build-amd64-freebsd/freebsd
*** Error code 1

Stop.
make[1]: stopped in /usr/home/osstest/build.125515.build-amd64-freebsd/freebsd
*** Error code 1

Stop.
make: stopped in 
/usr/home/osstest/build.125515.build-amd64-freebsd/freebsd/release

The full build log can be found at:

http://logs.test-lab.xenproject.org/osstest/logs/125569/build-amd64-freebsd/7.ts-freebsd-build.log

Note that it's ~100MB.

Thanks, Roger.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-25 Thread Ravi Pokala
-Original Message-
From: Ravi Pokala 
Date: 2018-07-20, Friday at 10:53
To: Ian Lepore , , 
, , Will Andrews 

Subject: Re: svn commit: r336526 - head

> -Original Message-
> From:  on behalf of Ian Lepore 
> 
> Date: 2018-07-20, Friday at 10:38
> To: Ravi Pokala , , 
> , 
> Subject: Re: svn commit: r336526 - head
> 
>> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
>>> Hi Ian,
>>> 
>>> -Original Message-
>>> From:  on behalf of Ian Lepore 
>>> Date: 2018-07-19, Thursday at 17:44
>>> To: , , 
>>> Subject: svn commit: r336526 - head
>>> 
>>>> 
>>>> Author: ian
>>>> Date: Fri Jul 20 00:44:04 2018
>>>> New Revision: 336526
>>>> URL: https://svnweb.freebsd.org/changeset/base/336526
>>>> 
>>>> Log:
>>>>   Add ntpd to the list of users/groups to check before installing.
>>>> 
>>>> Modified:
>>>>   head/Makefile.inc1
>>> When trying to installworld:
>>> 
>>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
>>> 
>>> But there is no UPDATING entry about this. (Also, shouldn't it be 
>>> ${SRCTOP}/UPDATING?)
>>> 
>>> Thanks,
>>> 
>>> Ravi (rpokala@)
>> 
>> I wondered about that too, when I accidentally stumbled across the
>> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
>> UPDATING for some of the other things in the CHECK_UIDS list to see
>> what had been said about such changes in the past, even searching
>> through old-old svn history, and found nothing.
>> 
>> I finally settled on the thought that the reference to UPDATING was to
>> the stuff at the bottom that never changes. In particular to the
>> section around line 1595 that documents the instalkernel, reboot,
>> mergemaster, installworld sequence. The mergemaster part should take
>> care of the new userid, I guess.
>> 
>> -- Ian
> 
> Interesting. I was attempting the install via the `beinstall.sh' script. 
> CCing will@, since he wrote it.
> 
> Thanks,
> 
> Ravi (rpokala@)

After some discussion on IRC, I created this patch to fix `beinstall.sh'.

https://people.freebsd.org/~rpokala/beinstall.patch

However, I'm a bit afraid of testing it, until someone who actually knows 
`etcupdate' and `mergemaster' can confirm that it won't blow up my box. :-)

Can anyone take a look and assuage my fears?

Thanks,

Ravi (rpokala@)


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Mark Johnston
On Fri, Jul 20, 2018 at 07:32:52PM +, Li-Wen Hsu wrote:
> On Fri, Jul 20, 2018 at 14:40:56 -0400, Mark Johnston wrote:
> > On Fri, Jul 20, 2018 at 11:38:23AM -0600, Ian Lepore wrote:
> > > On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > > > Hi Ian,
> > > > 
> > > > -Original Message-
> > > > From:  on behalf of Ian Lepore 
> > > > Date: 2018-07-19, Thursday at 17:44
> > > > To: , , 
> > > > Subject: svn commit: r336526 - head
> > > > 
> > > > > 
> > > > > Author: ian
> > > > > Date: Fri Jul 20 00:44:04 2018
> > > > > New Revision: 336526
> > > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > > 
> > > > > Log:
> > > > >   Add ntpd to the list of users/groups to check before installing.
> > > > > 
> > > > > Modified:
> > > > >   head/Makefile.inc1
> > > > When trying to installworld:
> > > > 
> > > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > > 
> > > > But there is no UPDATING entry about this. (Also, shouldn't it be 
> > > > ${SRCTOP}/UPDATING?)
> > > > 
> > > > Thanks,
> > > > 
> > > > Ravi (rpokala@)
> > > 
> > > I wondered about that too, when I accidentally stumbled across the
> > > CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> > > UPDATING for some of the other things in the CHECK_UIDS list to see
> > > what had been said about such changes in the past, even searching
> > > through old-old svn history, and found nothing.
> > > 
> > > I finally settled on the thought that the reference to UPDATING was to
> > > the stuff at the bottom that never changes. In particular to the
> > > section around line 1595 that documents the instalkernel, reboot,
> > > mergemaster, installworld sequence. The mergemaster part should take
> > > care of the new userid, I guess.
> > 
> > I thought it would too, but it's bombing out for me:
> > 
> > *** Creating the temporary root environment in /var/tmp/temproot
> >  *** /var/tmp/temproot ready for use
> >  *** Creating and populating directory structure in /var/tmp/temproot
> > 
> > mtree: unknown user `ntpd'
> > mtree: failed at line 49 of the specification
> > 
> >   *** FATAL ERROR: Cannot 'cd' to /home/mark/src/freebsd-dev and 
> > install files to
> >   the temproot environment
> > 
> > I see that line 49 of BSD.var.dist references the new uids, so I guess
> > there's a chicken and egg problem here?
> 
> I thought we should use mergemaster or etcupdate with -p for "pre-world"
> mode.

Oops, I'd forgotten about that flag.  That fixes it for me, thanks.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Li-Wen Hsu
On Fri, Jul 20, 2018 at 14:40:56 -0400, Mark Johnston wrote:
> On Fri, Jul 20, 2018 at 11:38:23AM -0600, Ian Lepore wrote:
> > On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > > Hi Ian,
> > > 
> > > -Original Message-
> > > From:  on behalf of Ian Lepore 
> > > Date: 2018-07-19, Thursday at 17:44
> > > To: , , 
> > > Subject: svn commit: r336526 - head
> > > 
> > > > 
> > > > Author: ian
> > > > Date: Fri Jul 20 00:44:04 2018
> > > > New Revision: 336526
> > > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > > 
> > > > Log:
> > > >   Add ntpd to the list of users/groups to check before installing.
> > > > 
> > > > Modified:
> > > >   head/Makefile.inc1
> > > When trying to installworld:
> > > 
> > > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > > 
> > > But there is no UPDATING entry about this. (Also, shouldn't it be 
> > > ${SRCTOP}/UPDATING?)
> > > 
> > > Thanks,
> > > 
> > > Ravi (rpokala@)
> > 
> > I wondered about that too, when I accidentally stumbled across the
> > CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> > UPDATING for some of the other things in the CHECK_UIDS list to see
> > what had been said about such changes in the past, even searching
> > through old-old svn history, and found nothing.
> > 
> > I finally settled on the thought that the reference to UPDATING was to
> > the stuff at the bottom that never changes. In particular to the
> > section around line 1595 that documents the instalkernel, reboot,
> > mergemaster, installworld sequence. The mergemaster part should take
> > care of the new userid, I guess.
> 
> I thought it would too, but it's bombing out for me:
> 
>   *** Creating the temporary root environment in /var/tmp/temproot
>*** /var/tmp/temproot ready for use
>*** Creating and populating directory structure in /var/tmp/temproot
> 
>   mtree: unknown user `ntpd'
>   mtree: failed at line 49 of the specification
> 
> *** FATAL ERROR: Cannot 'cd' to /home/mark/src/freebsd-dev and 
> install files to
> the temproot environment
> 
> I see that line 49 of BSD.var.dist references the new uids, so I guess
> there's a chicken and egg problem here?

I thought we should use mergemaster or etcupdate with -p for "pre-world"
mode.

Li-Wen

-- 
Li-Wen Hsu 
https://lwhsu.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Mark Johnston
On Fri, Jul 20, 2018 at 11:38:23AM -0600, Ian Lepore wrote:
> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > Hi Ian,
> > 
> > -Original Message-
> > From:  on behalf of Ian Lepore 
> > Date: 2018-07-19, Thursday at 17:44
> > To: , , 
> > Subject: svn commit: r336526 - head
> > 
> > > 
> > > Author: ian
> > > Date: Fri Jul 20 00:44:04 2018
> > > New Revision: 336526
> > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > > 
> > > Log:
> > >   Add ntpd to the list of users/groups to check before installing.
> > > 
> > > Modified:
> > >   head/Makefile.inc1
> > When trying to installworld:
> > 
> > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> > 
> > But there is no UPDATING entry about this. (Also, shouldn't it be 
> > ${SRCTOP}/UPDATING?)
> > 
> > Thanks,
> > 
> > Ravi (rpokala@)
> 
> I wondered about that too, when I accidentally stumbled across the
> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> UPDATING for some of the other things in the CHECK_UIDS list to see
> what had been said about such changes in the past, even searching
> through old-old svn history, and found nothing.
> 
> I finally settled on the thought that the reference to UPDATING was to
> the stuff at the bottom that never changes. In particular to the
> section around line 1595 that documents the instalkernel, reboot,
> mergemaster, installworld sequence. The mergemaster part should take
> care of the new userid, I guess.

I thought it would too, but it's bombing out for me:

*** Creating the temporary root environment in /var/tmp/temproot
 *** /var/tmp/temproot ready for use
 *** Creating and populating directory structure in /var/tmp/temproot

mtree: unknown user `ntpd'
mtree: failed at line 49 of the specification

  *** FATAL ERROR: Cannot 'cd' to /home/mark/src/freebsd-dev and 
install files to
  the temproot environment

I see that line 49 of BSD.var.dist references the new uids, so I guess
there's a chicken and egg problem here?
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Ravi Pokala
-Original Message-
From:  on behalf of Ian Lepore 

Date: 2018-07-20, Friday at 10:38
To: Ravi Pokala , , 
, 
Subject: Re: svn commit: r336526 - head

> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
>> Hi Ian,
>> 
>> -Original Message-
>> From:  on behalf of Ian Lepore 
>> Date: 2018-07-19, Thursday at 17:44
>> To: , , 
>> Subject: svn commit: r336526 - head
>> 
>>> 
>>> Author: ian
>>> Date: Fri Jul 20 00:44:04 2018
>>> New Revision: 336526
>>> URL: https://svnweb.freebsd.org/changeset/base/336526
>>> 
>>> Log:
>>>   Add ntpd to the list of users/groups to check before installing.
>>> 
>>> Modified:
>>>   head/Makefile.inc1
>> When trying to installworld:
>> 
>> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
>> 
>> But there is no UPDATING entry about this. (Also, shouldn't it be 
>> ${SRCTOP}/UPDATING?)
>> 
>> Thanks,
>> 
>> Ravi (rpokala@)
> 
> I wondered about that too, when I accidentally stumbled across the
> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> UPDATING for some of the other things in the CHECK_UIDS list to see
> what had been said about such changes in the past, even searching
> through old-old svn history, and found nothing.
> 
> I finally settled on the thought that the reference to UPDATING was to
> the stuff at the bottom that never changes. In particular to the
> section around line 1595 that documents the instalkernel, reboot,
> mergemaster, installworld sequence. The mergemaster part should take
> care of the new userid, I guess.
> 
> -- Ian

Interesting. I was attempting the install via the `beinstall.sh' script. CCing 
will@, since he wrote it.

Thanks,

Ravi (rpokala@)


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Warner Losh
On Fri, Jul 20, 2018 at 11:38 AM, Ian Lepore  wrote:

> On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> > Hi Ian,
> >
> > -Original Message-
> > From:  on behalf of Ian Lepore
> > Date: 2018-07-19, Thursday at 17:44
> > To: , ,
> > Subject: svn commit: r336526 - head
> >
> > >
> > > Author: ian
> > > Date: Fri Jul 20 00:44:04 2018
> > > New Revision: 336526
> > > URL: https://svnweb.freebsd.org/changeset/base/336526
> > >
> > > Log:
> > >   Add ntpd to the list of users/groups to check before installing.
> > >
> > > Modified:
> > >   head/Makefile.inc1
> > When trying to installworld:
> >
> > ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> >
> > But there is no UPDATING entry about this. (Also, shouldn't it be
> ${SRCTOP}/UPDATING?)
> >
> > Thanks,
> >
> > Ravi (rpokala@)
>
> I wondered about that too, when I accidentally stumbled across the
> CHECK_UIDS thing and realized I should add ntpd to it. I searched in
> UPDATING for some of the other things in the CHECK_UIDS list to see
> what had been said about such changes in the past, even searching
> through old-old svn history, and found nothing.
>
> I finally settled on the thought that the reference to UPDATING was to
> the stuff at the bottom that never changes. In particular to the
> section around line 1595 that documents the instalkernel, reboot,
> mergemaster, installworld sequence. The mergemaster part should take
> care of the new userid, I guess.
>

It should. While what you say is true, it's also been true that in the past
people have often listed new userid's in the UPDATING text at the top to
give people more info about whether or not it's safe to skip mergemaster
and/or make alternative plans if it isn't and they don't use mergemaster :)

Warner
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Ian Lepore
On Fri, 2018-07-20 at 09:56 -0700, Ravi Pokala wrote:
> Hi Ian,
> 
> -Original Message-
> From:  on behalf of Ian Lepore 
> Date: 2018-07-19, Thursday at 17:44
> To: , , 
> Subject: svn commit: r336526 - head
> 
> > 
> > Author: ian
> > Date: Fri Jul 20 00:44:04 2018
> > New Revision: 336526
> > URL: https://svnweb.freebsd.org/changeset/base/336526
> > 
> > Log:
> >   Add ntpd to the list of users/groups to check before installing.
> > 
> > Modified:
> >   head/Makefile.inc1
> When trying to installworld:
> 
> ERROR: Required ntpd user is missing, see /usr/src/UPDATING.
> 
> But there is no UPDATING entry about this. (Also, shouldn't it be 
> ${SRCTOP}/UPDATING?)
> 
> Thanks,
> 
> Ravi (rpokala@)

I wondered about that too, when I accidentally stumbled across the
CHECK_UIDS thing and realized I should add ntpd to it. I searched in
UPDATING for some of the other things in the CHECK_UIDS list to see
what had been said about such changes in the past, even searching
through old-old svn history, and found nothing.

I finally settled on the thought that the reference to UPDATING was to
the stuff at the bottom that never changes. In particular to the
section around line 1595 that documents the instalkernel, reboot,
mergemaster, installworld sequence. The mergemaster part should take
care of the new userid, I guess.

-- Ian
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r336526 - head

2018-07-20 Thread Ravi Pokala
Hi Ian,

-Original Message-
From:  on behalf of Ian Lepore 

Date: 2018-07-19, Thursday at 17:44
To: , , 

Subject: svn commit: r336526 - head

> Author: ian
> Date: Fri Jul 20 00:44:04 2018
> New Revision: 336526
> URL: https://svnweb.freebsd.org/changeset/base/336526
> 
> Log:
>   Add ntpd to the list of users/groups to check before installing.
> 
> Modified:
>   head/Makefile.inc1

When trying to installworld:

ERROR: Required ntpd user is missing, see /usr/src/UPDATING.

But there is no UPDATING entry about this. (Also, shouldn't it be 
${SRCTOP}/UPDATING?)

Thanks,

Ravi (rpokala@)


___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"