Re: svn commit: r250339 - head/sys/x86/acpica
On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: Author: attilio Date: Tue May 7 22:49:56 2013 New Revision: 250339 URL: http://svnweb.freebsd.org/changeset/base/250339 Log: Add functions to do ACPI System Locality Information Table parsing and printing at boot. For reference on table informations and purposes please review ACPI specs. Sponsored by: EMC / Isilon storage division Obtained from: jeff Reviewed by:jhb (earlier version) Eh, I don't recall reviewing this. However, acpidump already dumps this table, and we should dump tables via acpidump, not in dmesg. -- John Baldwin ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r250339 - head/sys/x86/acpica
On Wed, May 8, 2013 at 6:01 PM, John Baldwin j...@freebsd.org wrote: On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: Author: attilio Date: Tue May 7 22:49:56 2013 New Revision: 250339 URL: http://svnweb.freebsd.org/changeset/base/250339 Log: Add functions to do ACPI System Locality Information Table parsing and printing at boot. For reference on table informations and purposes please review ACPI specs. Sponsored by: EMC / Isilon storage division Obtained from: jeff Reviewed by:jhb (earlier version) Eh, I don't recall reviewing this. However, acpidump already dumps this table, and we should dump tables via acpidump, not in dmesg. Now that I read better this patch is based upon a patch you submitted originally (see the private thread NUMA WIP). We already print some useful ACPI table information at boot really (APIC ACPI table case) and this is only printed out when having MAXMEMDOM 1. Finally I have also sent you this patch and you didn't object. However if you really dislike it I can print under bootverbose maybe? Attilio -- Peace can only be achieved by understanding - A. Einstein ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
Re: svn commit: r250339 - head/sys/x86/acpica
On Wednesday, May 08, 2013 2:21:12 pm Attilio Rao wrote: On Wed, May 8, 2013 at 6:01 PM, John Baldwin j...@freebsd.org wrote: On Tuesday, May 07, 2013 6:49:57 pm Attilio Rao wrote: Author: attilio Date: Tue May 7 22:49:56 2013 New Revision: 250339 URL: http://svnweb.freebsd.org/changeset/base/250339 Log: Add functions to do ACPI System Locality Information Table parsing and printing at boot. For reference on table informations and purposes please review ACPI specs. Sponsored by: EMC / Isilon storage division Obtained from: jeff Reviewed by:jhb (earlier version) Eh, I don't recall reviewing this. However, acpidump already dumps this table, and we should dump tables via acpidump, not in dmesg. Now that I read better this patch is based upon a patch you submitted originally (see the private thread NUMA WIP). We already print some useful ACPI table information at boot really (APIC ACPI table case) and this is only printed out when having MAXMEMDOM 1. Finally I have also sent you this patch and you didn't object. Humm, that was in an old thread, and I never responded to say ok to this. However, the patch I posted in that thread is the patch to dump the SLIT in acpidump and it was comitted back in r241198. That is the place to dump these tables, not in dmesg. We do not dump the raw contents of any other ACPI tables in dmesg, and have actively moved other tables out to userland (e.g. $PIR is dumped via a userland tool only). However if you really dislike it I can print under bootverbose maybe? No, it does not belong in dmesg at all. Code to use its contents and honor it when setting the domain lists would be fine :), but printing it when you can more easily get it via acpidump -t is just clutter. -- John Baldwin ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
svn commit: r250339 - head/sys/x86/acpica
Author: attilio
Date: Tue May 7 22:49:56 2013
New Revision: 250339
URL: http://svnweb.freebsd.org/changeset/base/250339
Log:
Add functions to do ACPI System Locality Information Table parsing
and printing at boot.
For reference on table informations and purposes please review ACPI specs.
Sponsored by: EMC / Isilon storage division
Obtained from:jeff
Reviewed by: jhb (earlier version)
Modified:
head/sys/x86/acpica/srat.c
Modified: head/sys/x86/acpica/srat.c
==
--- head/sys/x86/acpica/srat.c Tue May 7 22:46:24 2013(r250338)
+++ head/sys/x86/acpica/srat.c Tue May 7 22:49:56 2013(r250339)
@@ -331,6 +331,48 @@ srat_walk_table(acpi_subtable_handler *h
acpi_walk_subtables(srat + 1, (char *)srat + srat-Header.Length,
handler, arg);
}
+
+static void
+acpi_handle_slit(ACPI_TABLE_SLIT *slit)
+{
+ UINT64 i, j;
+
+ printf(ACPI System Locality Information Table: %ju localities\n,
+ (uintmax_t)slit-LocalityCount);
+ printf( );
+ for (i = 0; i slit-LocalityCount; i++)
+ printf( %3ju, (uintmax_t)i);
+ printf(\n +);
+ for (i = 0; i slit-LocalityCount; i++)
+ printf();
+ printf(\n);
+ for (i = 0; i slit-LocalityCount; i++) {
+ printf( %3ju |, (uintmax_t)i);
+ for (j = 0; j slit-LocalityCount; j++)
+ printf( %3u,
+ slit-Entry[i * slit-LocalityCount + j]);
+ printf(\n);
+ }
+}
+
+static void
+parse_slit(void *arg __unused)
+{
+ ACPI_TABLE_SLIT *slit;
+ vm_paddr_t slit_physaddr;
+
+ if (resource_disabled(slit, 0))
+ return;
+
+ slit_physaddr = acpi_find_table(ACPI_SIG_SLIT);
+ if (slit_physaddr == 0)
+ return;
+ slit = acpi_map_table(slit_physaddr, ACPI_SIG_SLIT);
+ acpi_handle_slit(slit);
+ acpi_unmap_table(slit);
+}
+
+SYSINIT(parse_slit, SI_SUB_VM - 1, SI_ORDER_SECOND, parse_slit, NULL);
/*
* Setup per-CPU ACPI IDs.
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to svn-src-head-unsubscr...@freebsd.org
