Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
As I recall, from ZFS, but I’m not positive. Either that, or something else was using 0x40. Sean. > On Mar 16, 2016, at 9:29 PM, Xin LIwrote: > > +sef who created the patch... > > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers wrote: >> >> >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: >>> >>> Author: delphij >>> Date: Fri Sep 4 00:14:20 2015 >>> New Revision: 287445 >>> URL: https://svnweb.freebsd.org/changeset/base/287445 >>> >>> Log: >>> Expose an interface to determine if an ACE is inherited. >>> >>> Submitted by: sef >>> Reviewed by: trasz >>> MFC after:2 weeks >>> Differential Revision:https://reviews.freebsd.org/D3540 >>> >>> Modified: >>> head/bin/setfacl/setfacl.1 >>> head/lib/libc/posix1e/acl_add_flag_np.3 >>> head/lib/libc/posix1e/acl_support_nfs4.c >>> head/share/man/man9/acl.9 >>> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c >>> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h >>> head/sys/kern/subr_acl_nfs4.c >>> head/sys/sys/acl.h >>> head/tools/regression/acltools/tools-crossfs.test >>> head/tools/regression/acltools/tools-nfs4-psarc.test >>> head/tools/regression/acltools/tools-nfs4-trivial.test >>> head/tools/regression/acltools/tools-nfs4.test >> >> >> ... >> >>> >>> Modified: head/sys/sys/acl.h >>> >>> == >>> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) >>> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015(r287445) >>> @@ -249,11 +249,12 @@ typedef void *acl_t; >>> #defineACL_ENTRY_INHERIT_ONLY 0x0008 >>> #defineACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 >>> #defineACL_ENTRY_FAILED_ACCESS 0x0020 >>> +#defineACL_ENTRY_INHERITED 0x0080 >>> >>> #defineACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | >>> \ >>> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ >>> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ >>> -ACL_ENTRY_FAILED_ACCESS) >>> +ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) >>> >>> /* >>> * Undefined value in ae_id field. ae_id should be set to this value >> >> >> Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead >> of 0x0040 ? >> > > > > -- > Xin LI https://www.delphij.net/ > FreeBSD - The Power to Serve! Live free or die ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
Do you happen to know if ACL_ENTRY_INHERITED is written to disk, or does it only exist in-core? On Wed, Mar 16, 2016 at 10:37 PM, Sean Faganwrote: > As I recall, from ZFS, but I’m not positive. Either that, or something > else was using 0x40. > > Sean. > > On Mar 16, 2016, at 9:29 PM, Xin LI wrote: > > > > +sef who created the patch... > > > > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers > wrote: > >> > >> > >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: > >>> > >>> Author: delphij > >>> Date: Fri Sep 4 00:14:20 2015 > >>> New Revision: 287445 > >>> URL: https://svnweb.freebsd.org/changeset/base/287445 > >>> > >>> Log: > >>> Expose an interface to determine if an ACE is inherited. > >>> > >>> Submitted by: sef > >>> Reviewed by: trasz > >>> MFC after:2 weeks > >>> Differential Revision:https://reviews.freebsd.org/D3540 > >>> > >>> Modified: > >>> head/bin/setfacl/setfacl.1 > >>> head/lib/libc/posix1e/acl_add_flag_np.3 > >>> head/lib/libc/posix1e/acl_support_nfs4.c > >>> head/share/man/man9/acl.9 > >>> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c > >>> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h > >>> head/sys/kern/subr_acl_nfs4.c > >>> head/sys/sys/acl.h > >>> head/tools/regression/acltools/tools-crossfs.test > >>> head/tools/regression/acltools/tools-nfs4-psarc.test > >>> head/tools/regression/acltools/tools-nfs4-trivial.test > >>> head/tools/regression/acltools/tools-nfs4.test > >> > >> > >> ... > >> > >>> > >>> Modified: head/sys/sys/acl.h > >>> > >>> > == > >>> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) > >>> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015(r287445) > >>> @@ -249,11 +249,12 @@ typedef void *acl_t; > >>> #defineACL_ENTRY_INHERIT_ONLY 0x0008 > >>> #defineACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 > >>> #defineACL_ENTRY_FAILED_ACCESS 0x0020 > >>> +#defineACL_ENTRY_INHERITED 0x0080 > >>> > >>> #defineACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT > | > >>> \ > >>> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ > >>> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ > >>> -ACL_ENTRY_FAILED_ACCESS) > >>> +ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) > >>> > >>> /* > >>> * Undefined value in ae_id field. ae_id should be set to this value > >> > >> > >> Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED > instead > >> of 0x0040 ? > >> > > > > > > > > -- > > Xin LI https://www.delphij.net/ > > FreeBSD - The Power to Serve! Live free or die > > ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
+sef who created the patch... On Wed, Mar 16, 2016 at 3:40 PM, Alan Somerswrote: > > > On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: >> >> Author: delphij >> Date: Fri Sep 4 00:14:20 2015 >> New Revision: 287445 >> URL: https://svnweb.freebsd.org/changeset/base/287445 >> >> Log: >> Expose an interface to determine if an ACE is inherited. >> >> Submitted by: sef >> Reviewed by: trasz >> MFC after:2 weeks >> Differential Revision:https://reviews.freebsd.org/D3540 >> >> Modified: >> head/bin/setfacl/setfacl.1 >> head/lib/libc/posix1e/acl_add_flag_np.3 >> head/lib/libc/posix1e/acl_support_nfs4.c >> head/share/man/man9/acl.9 >> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c >> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h >> head/sys/kern/subr_acl_nfs4.c >> head/sys/sys/acl.h >> head/tools/regression/acltools/tools-crossfs.test >> head/tools/regression/acltools/tools-nfs4-psarc.test >> head/tools/regression/acltools/tools-nfs4-trivial.test >> head/tools/regression/acltools/tools-nfs4.test > > > ... > >> >> Modified: head/sys/sys/acl.h >> >> == >> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) >> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015(r287445) >> @@ -249,11 +249,12 @@ typedef void *acl_t; >> #defineACL_ENTRY_INHERIT_ONLY 0x0008 >> #defineACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 >> #defineACL_ENTRY_FAILED_ACCESS 0x0020 >> +#defineACL_ENTRY_INHERITED 0x0080 >> >> #defineACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | >> \ >> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ >> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ >> -ACL_ENTRY_FAILED_ACCESS) >> +ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) >> >> /* >> * Undefined value in ae_id field. ae_id should be set to this value > > > Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead > of 0x0040 ? > -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
On Thu, Sep 3, 2015 at 6:14 PM, Xin LIwrote: > Author: delphij > Date: Fri Sep 4 00:14:20 2015 > New Revision: 287445 > URL: https://svnweb.freebsd.org/changeset/base/287445 > > Log: > Expose an interface to determine if an ACE is inherited. > > Submitted by: sef > Reviewed by: trasz > MFC after:2 weeks > Differential Revision:https://reviews.freebsd.org/D3540 > > Modified: > head/bin/setfacl/setfacl.1 > head/lib/libc/posix1e/acl_add_flag_np.3 > head/lib/libc/posix1e/acl_support_nfs4.c > head/share/man/man9/acl.9 > head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c > head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h > head/sys/kern/subr_acl_nfs4.c > head/sys/sys/acl.h > head/tools/regression/acltools/tools-crossfs.test > head/tools/regression/acltools/tools-nfs4-psarc.test > head/tools/regression/acltools/tools-nfs4-trivial.test > head/tools/regression/acltools/tools-nfs4.test > ... > Modified: head/sys/sys/acl.h > > == > --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) > +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015(r287445) > @@ -249,11 +249,12 @@ typedef void *acl_t; > #defineACL_ENTRY_INHERIT_ONLY 0x0008 > #defineACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 > #defineACL_ENTRY_FAILED_ACCESS 0x0020 > +#defineACL_ENTRY_INHERITED 0x0080 > > #defineACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | \ > ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ > ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ > -ACL_ENTRY_FAILED_ACCESS) > +ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) > > /* > * Undefined value in ae_id field. ae_id should be set to this value > Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead of 0x0040 ? ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
It’s written to disk. Although that actually depends on the filesystem. Sean. > On Mar 16, 2016, at 9:55 PM, Alan Somerswrote: > > Do you happen to know if ACL_ENTRY_INHERITED is written to disk, or does it > only exist in-core? > > On Wed, Mar 16, 2016 at 10:37 PM, Sean Fagan wrote: > As I recall, from ZFS, but I’m not positive. Either that, or something else > was using 0x40. > > Sean. > > On Mar 16, 2016, at 9:29 PM, Xin LI wrote: > > > > +sef who created the patch... > > > > On Wed, Mar 16, 2016 at 3:40 PM, Alan Somers wrote: > >> > >> > >> On Thu, Sep 3, 2015 at 6:14 PM, Xin LI wrote: > >>> > >>> Author: delphij > >>> Date: Fri Sep 4 00:14:20 2015 > >>> New Revision: 287445 > >>> URL: https://svnweb.freebsd.org/changeset/base/287445 > >>> > >>> Log: > >>> Expose an interface to determine if an ACE is inherited. > >>> > >>> Submitted by: sef > >>> Reviewed by: trasz > >>> MFC after:2 weeks > >>> Differential Revision:https://reviews.freebsd.org/D3540 > >>> > >>> Modified: > >>> head/bin/setfacl/setfacl.1 > >>> head/lib/libc/posix1e/acl_add_flag_np.3 > >>> head/lib/libc/posix1e/acl_support_nfs4.c > >>> head/share/man/man9/acl.9 > >>> head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c > >>> head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h > >>> head/sys/kern/subr_acl_nfs4.c > >>> head/sys/sys/acl.h > >>> head/tools/regression/acltools/tools-crossfs.test > >>> head/tools/regression/acltools/tools-nfs4-psarc.test > >>> head/tools/regression/acltools/tools-nfs4-trivial.test > >>> head/tools/regression/acltools/tools-nfs4.test > >> > >> > >> ... > >> > >>> > >>> Modified: head/sys/sys/acl.h > >>> > >>> == > >>> --- head/sys/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) > >>> +++ head/sys/sys/acl.h Fri Sep 4 00:14:20 2015(r287445) > >>> @@ -249,11 +249,12 @@ typedef void *acl_t; > >>> #defineACL_ENTRY_INHERIT_ONLY 0x0008 > >>> #defineACL_ENTRY_SUCCESSFUL_ACCESS 0x0010 > >>> #defineACL_ENTRY_FAILED_ACCESS 0x0020 > >>> +#defineACL_ENTRY_INHERITED 0x0080 > >>> > >>> #defineACL_FLAGS_BITS (ACL_ENTRY_FILE_INHERIT | > >>> \ > >>> ACL_ENTRY_DIRECTORY_INHERIT | ACL_ENTRY_NO_PROPAGATE_INHERIT | \ > >>> ACL_ENTRY_INHERIT_ONLY | ACL_ENTRY_SUCCESSFUL_ACCESS | \ > >>> -ACL_ENTRY_FAILED_ACCESS) > >>> +ACL_ENTRY_FAILED_ACCESS | ACL_ENTRY_INHERITED) > >>> > >>> /* > >>> * Undefined value in ae_id field. ae_id should be set to this value > >> > >> > >> Out of curiosity, why did you choose 0x0080 for ACL_ENTRY_INHERITED instead > >> of 0x0040 ? > >> > > > > > > > > -- > > Xin LI https://www.delphij.net/ > > FreeBSD - The Power to Serve! Live free or die > > ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r287445 - in head: bin/setfacl lib/libc/posix1e share/man/man9 sys/cddl/compat/opensolaris/kern sys/cddl/contrib/opensolaris/uts/common/sys sys/kern sys/sys tools/regression/acltools
Author: delphij Date: Fri Sep 4 00:14:20 2015 New Revision: 287445 URL: https://svnweb.freebsd.org/changeset/base/287445 Log: Expose an interface to determine if an ACE is inherited. Submitted by: sef Reviewed by: trasz MFC after:2 weeks Differential Revision:https://reviews.freebsd.org/D3540 Modified: head/bin/setfacl/setfacl.1 head/lib/libc/posix1e/acl_add_flag_np.3 head/lib/libc/posix1e/acl_support_nfs4.c head/share/man/man9/acl.9 head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h head/sys/kern/subr_acl_nfs4.c head/sys/sys/acl.h head/tools/regression/acltools/tools-crossfs.test head/tools/regression/acltools/tools-nfs4-psarc.test head/tools/regression/acltools/tools-nfs4-trivial.test head/tools/regression/acltools/tools-nfs4.test Modified: head/bin/setfacl/setfacl.1 == --- head/bin/setfacl/setfacl.1 Thu Sep 3 22:15:56 2015(r287444) +++ head/bin/setfacl/setfacl.1 Fri Sep 4 00:14:20 2015(r287445) @@ -26,7 +26,7 @@ .\" .\" $FreeBSD$ .\" -.Dd April 1, 2013 +.Dd September 4, 2015 .Dt SETFACL 1 .Os .Sh NAME @@ -378,9 +378,11 @@ dir_inherit inherit_only .It n no_propagate +.It I +inherited .El .Pp -Inheritance flags may be only set on directories. +Other than the "inherited" flag, inheritance flags may be only set on directories. .It Ar "ACL type" The ACL type field is either .Dq Li allow Modified: head/lib/libc/posix1e/acl_add_flag_np.3 == --- head/lib/libc/posix1e/acl_add_flag_np.3 Thu Sep 3 22:15:56 2015 (r287444) +++ head/lib/libc/posix1e/acl_add_flag_np.3 Fri Sep 4 00:14:20 2015 (r287445) @@ -25,7 +25,7 @@ .\" .\" $FreeBSD$ .\" -.Dd October 30, 2014 +.Dd September 4, 2015 .Dt ACL_ADD_FLAG_NP 3 .Os .Sh NAME @@ -56,6 +56,7 @@ Valid values are: .It ACL_ENTRY_DIRECTORY_INHERIT Ta "Will be inherited by directories." .It ACL_ENTRY_NO_PROPAGATE_INHERIT Ta "Will not propagate." .It ACL_ENTRY_INHERIT_ONLY Ta "Inherit-only." +.It ACL_ENTRY_INHERITED Ta "Inherited from parent" .El .Sh RETURN VALUES .Rv -std acl_add_flag_np Modified: head/lib/libc/posix1e/acl_support_nfs4.c == --- head/lib/libc/posix1e/acl_support_nfs4.cThu Sep 3 22:15:56 2015 (r287444) +++ head/lib/libc/posix1e/acl_support_nfs4.cFri Sep 4 00:14:20 2015 (r287445) @@ -48,6 +48,7 @@ struct flagnames_struct a_flags[] = { ACL_ENTRY_NO_PROPAGATE_INHERIT, "no_propagate", 'n'}, { ACL_ENTRY_SUCCESSFUL_ACCESS, "successfull_access", 'S'}, { ACL_ENTRY_FAILED_ACCESS, "failed_access", 'F'}, + { ACL_ENTRY_INHERITED, "inherited", 'I' }, /* * There is no ACE_IDENTIFIER_GROUP here - SunOS does not show it * in the "flags" field. There is no ACE_OWNER, ACE_GROUP or Modified: head/share/man/man9/acl.9 == --- head/share/man/man9/acl.9 Thu Sep 3 22:15:56 2015(r287444) +++ head/share/man/man9/acl.9 Fri Sep 4 00:14:20 2015(r287445) @@ -25,7 +25,7 @@ .\" .\" $FreeBSD$ .\" -.Dd September 18, 2009 +.Dd September 4, 2015 .Dt ACL 9 .Os .Sh NAME @@ -203,7 +203,13 @@ The following values are valid: .It Dv ACL_ENTRY_DIRECTORY_INHERIT .It Dv ACL_ENTRY_NO_PROPAGATE_INHERIT .It Dv ACL_ENTRY_INHERIT_ONLY +.It Dv ACL_ENTRY_INHERITED .El +The +.Dv ACL_ENTRY_INHERITED +flag is set on an ACE that has been inherited from its parent. +It may also be set programmatically, and is valid on both files +and directories. .El .Sh SEE ALSO .Xr acl 3 , Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c == --- head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c Thu Sep 3 22:15:56 2015(r287444) +++ head/sys/cddl/compat/opensolaris/kern/opensolaris_acl.c Fri Sep 4 00:14:20 2015(r287445) @@ -64,6 +64,8 @@ struct zfs2bsd flags[] = {{ACE_FILE_INHE ACL_ENTRY_NO_PROPAGATE_INHERIT}, {ACE_INHERIT_ONLY_ACE, ACL_ENTRY_INHERIT_ONLY}, + {ACE_INHERITED_ACE, + ACL_ENTRY_INHERITED}, {ACE_SUCCESSFUL_ACCESS_ACE_FLAG, ACL_ENTRY_SUCCESSFUL_ACCESS}, {ACE_FAILED_ACCESS_ACE_FLAG, Modified: head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h == --- head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h Thu Sep 3 22:15:56 2015(r287444) +++ head/sys/cddl/contrib/opensolaris/uts/common/sys/acl.h Fri Sep 4 00:14:20