Re: svn commit: r290234 - head/share/misc
On Mon, Nov 02, 2015 at 07:13:46AM +, Alexey Dokuchaev wrote: A> On Sun, Nov 01, 2015 at 04:54:55PM +, Michal Meloun wrote: A> > New Revision: 290234 A> > URL: https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > Install myself as src committer. A> > A> > Approved by: kib (mentor) A> > > Description of fields to fill in above: 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small advice: do not rely on "svn ci" calling your $EDITOR for A> you, compose the message yourself first and then do "svn ci -F $logfile". A> For one-liners, "svn ci -m message" works even better. Alternatively: rely on $EDITOR, but don't trust the line: --This line, and those below, will be ignored-- Finalize your message manually. P.S. Not that there is bugs in the svn, but you can have touched the line. -- Totus tuus, Glebius. ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r290234 - head/share/misc
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Dne 02.11.2015 v 11:37 Gleb Smirnoff napsal(a): > On Mon, Nov 02, 2015 at 07:13:46AM +, Alexey Dokuchaev wrote: > A> On Sun, Nov 01, 2015 at 04:54:55PM +, Michal Meloun wrote: > A> > New Revision: 290234 A> > URL: > https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > > Install myself as src committer. A> > A> > Approved by: kib > (mentor) A> > > Description of fields to fill in above: > 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small > advice: do not rely on "svn ci" calling your $EDITOR for A> you, > compose the message yourself first and then do "svn ci -F > $logfile". A> For one-liners, "svn ci -m message" works even > better. > > Alternatively: rely on $EDITOR, but don't trust the line: > > --This line, and those below, will be ignored-- > > Finalize your message manually. > > P.S. Not that there is bugs in the svn, but you can have touched > the line. > I'm sorry to all, it’s my bug. Commit using editor (but using git) is standard practice here @work. So I automatically select same workflow for FreeBSD. Anyway, I already got hit from kib@, so I'll use a file for commit log next time. But i'm pretty sure that i have not touched template. I only deleted all prepared unfilled lines (for PR:, MFC: ...) and then i paste commit message. And, ironically, only - --This line, and those below, will be ignored-- line has been omitted from real commit log. Michal -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJWN01GAAoJEGkesmtexaqqGvEIAICYBFTeblZZ+C3Y82JqN97h fnFHNG0wyJEhj9a4jDBWyAJldU4kesa2XHw2I8dGIUB9Iz+Vp0nnib5WIvhWPL7S t1NdQDyy9MELAXx0v4wNnyDexl+YYM9nEGvQokesFV/V0vI+6WctjMM8S8tnRs1e hVu80ZgbvJOTTV6OuNl9/Cjo4oPeh3IWZMlLuYP95pV4vzlgoF6CPimrdki8gVMX dW/9DUIJd1bX73LYoCtwfM0WZEFFbbgrpBO8DJbSWEmx1hJUQmk5mYE8jUYDk9Ot 8wxE+3n1g5ovZUQGREiR5s+3xu7MJ8PSroLIM69kJUvER0pAedXkDphYm/l8v8g= =s8VI -END PGP SIGNATURE- ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r290234 - head/share/misc
On Mon, Nov 02, 2015 at 12:47:18PM +0100, Michal Meloun wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Dne 02.11.2015 v 11:37 Gleb Smirnoff napsal(a): > > On Mon, Nov 02, 2015 at 07:13:46AM +, Alexey Dokuchaev wrote: > > A> On Sun, Nov 01, 2015 at 04:54:55PM +, Michal Meloun wrote: > > A> > New Revision: 290234 A> > URL: > > https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > > > Install myself as src committer. A> > A> > Approved by: kib > > (mentor) A> > > Description of fields to fill in above: > > 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small > > advice: do not rely on "svn ci" calling your $EDITOR for A> you, > > compose the message yourself first and then do "svn ci -F > > $logfile". A> For one-liners, "svn ci -m message" works even > > better. > > > > Alternatively: rely on $EDITOR, but don't trust the line: > > > > --This line, and those below, will be ignored-- > > > > Finalize your message manually. > > > > P.S. Not that there is bugs in the svn, but you can have touched > > the line. > > > > I'm sorry to all, it?s my bug. > Commit using editor (but using git) is standard practice here @work. > So I automatically select same workflow for FreeBSD. > Anyway, I already got hit from kib@, so I'll use a file for commit log I hope you mean 'hint'. > next time. > > But i'm pretty sure that i have not touched template. > I only deleted all prepared unfilled lines (for PR:, MFC: ...) > and then i paste commit message. > And, ironically, only > > - --This line, and those below, will be ignored-- > > line has been omitted from real commit log. > > Michal > > > > > -BEGIN PGP SIGNATURE- > Version: GnuPG v2 > > iQEcBAEBCAAGBQJWN01GAAoJEGkesmtexaqqGvEIAICYBFTeblZZ+C3Y82JqN97h > fnFHNG0wyJEhj9a4jDBWyAJldU4kesa2XHw2I8dGIUB9Iz+Vp0nnib5WIvhWPL7S > t1NdQDyy9MELAXx0v4wNnyDexl+YYM9nEGvQokesFV/V0vI+6WctjMM8S8tnRs1e > hVu80ZgbvJOTTV6OuNl9/Cjo4oPeh3IWZMlLuYP95pV4vzlgoF6CPimrdki8gVMX > dW/9DUIJd1bX73LYoCtwfM0WZEFFbbgrpBO8DJbSWEmx1hJUQmk5mYE8jUYDk9Ot > 8wxE+3n1g5ovZUQGREiR5s+3xu7MJ8PSroLIM69kJUvER0pAedXkDphYm/l8v8g= > =s8VI > -END PGP SIGNATURE- ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
svn commit: r290234 - head/share/misc
Author: mmel Date: Sun Nov 1 16:54:55 2015 New Revision: 290234 URL: https://svnweb.freebsd.org/changeset/base/290234 Log: Install myself as src committer. Approved by: kib (mentor) > Description of fields to fill in above: 76 columns --| > PR: If a GNATS PR is affected by the change. > Submitted by: If someone else sent in the change. > Reviewed by: If someone else reviewed your modification. > Approved by: If you needed approval for this commit. > Obtained from:If the change is from a third party. > MFC after:N [day[s]|week[s]|month[s]]. Request a reminder email. > MFH: Ports tree branch name. Request approval for merge. > Relnotes: Set to 'yes' for mention in release notes. > Security: Vulnerability reference (one per line) or description. > Sponsored by: If the change was sponsored by an organization. > Differential Revision:https://reviews.freebsd.org/D### (*full* phabric URL needed). > Empty fields above will be automatically removed. Mshare/misc/committers-src.dot Modified: head/share/misc/committers-src.dot Modified: head/share/misc/committers-src.dot == --- head/share/misc/committers-src.dot Sun Nov 1 12:00:55 2015 (r290233) +++ head/share/misc/committers-src.dot Sun Nov 1 16:54:55 2015 (r290234) @@ -235,6 +235,7 @@ melifaro [label="Alexander V. Chernikov\ mjacob [label="Matt Jacob\nmja...@freebsd.org\n1997/08/13"] mjg [label="Mateusz Guzik\n...@freebsd.org\n2012/06/04"] mlaier [label="Max Laier\nmla...@freebsd.org\n2004/02/10"] +mmel [label="Michal Meloun\nm...@freebsd.org\n2015/11/01"] monthadar [label="Monthadar Al Jaberi\nmontha...@freebsd.org\n2012/04/02"] mp [label="Mark Peek\n...@freebsd.org\n2001/07/27"] mr [label="Michael Reifenberger\n...@freebsd.org\n2001/09/30"] @@ -572,6 +573,7 @@ kib -> jlh kib -> jpaetzel kib -> lulf kib -> melifaro +kib -> mmel kib -> pho kib -> pluknet kib -> rdivacky ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
Re: svn commit: r290234 - head/share/misc
On Sun, Nov 01, 2015 at 04:54:55PM +, Michal Meloun wrote: > New Revision: 290234 > URL: https://svnweb.freebsd.org/changeset/base/290234 > > Log: > Install myself as src committer. > > Approved by:kib (mentor) > > Description of fields to fill in above: 76 columns --| > [ garbage omitteed ] Here is a small advice: do not rely on "svn ci" calling your $EDITOR for you, compose the message yourself first and then do "svn ci -F $logfile". For one-liners, "svn ci -m message" works even better. ./danfe ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
