Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Nathan Whitehorn]

On 09/01/17 09:54, Ian Lepore wrote:

On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote:

Wait, why?  The PR doesn't explain it any better than this commit
message.

On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel 
wrote:

Author: jpaetzel
Date: Fri Sep  1 15:54:53 2017
New Revision: 323087
URL: https://svnweb.freebsd.org/changeset/base/323087

Log:
   Take options IPSEC out of GENERIC

   PR:   220170
   Submitted by: delphij
   Reviewed by:  ae, glebius
   MFC after:2 weeks
   Differential Revision:D11806

The differential revision (which should be cited using the complete url
in the commit) seems to indicate that it's because it can be kldloaded.

This change misses the armv6 platform, where the option appears in
std.armv6, which gets included in GENERIC (and all other armv6
configs).

This change seems to warrant an entry in UPDATING, because it's going
to catch a lot of people by surprise.  Even people with custom kernels,
if they follow the advice of the handbook and "include GENERIC" then
override things.

-- Ian



I realize this is immediately moot because the commit has been reverted, 
but please remember about powerpc/conf/GENERIC64 for future such 
changes. This is the "GENERIC" kernel for the powerpc64 architecture, 
which does not have its own arch directory.

-Nathan
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Rodney W. Grimes]

[ Charset UTF-8 unsupported, converting... ]
> Author: jpaetzel
> Date: Fri Sep  1 15:54:53 2017
> New Revision: 323087
> URL: https://svnweb.freebsd.org/changeset/base/323087
> 
> Log:
>   Take options IPSEC out of GENERIC
>   
>   PR: 220170
>   Submitted by:   delphij
>   Reviewed by:ae, glebius
>   MFC after:  2 weeks
>   Differential Revision:  D11806
> 
> Modified:
>   head/sys/amd64/conf/GENERIC
>   head/sys/arm64/conf/GENERIC
>   head/sys/i386/conf/GENERIC
>   head/sys/powerpc/conf/GENERIC
>   head/sys/riscv/conf/GENERIC
>   head/sys/sparc64/conf/GENERIC
> 
> Modified: head/sys/amd64/conf/GENERIC
> ==
> --- head/sys/amd64/conf/GENERIC   Fri Sep  1 11:51:07 2017
> (r323086)
> +++ head/sys/amd64/conf/GENERIC   Fri Sep  1 15:54:53 2017
> (r323087)
> @@ -28,7 +28,6 @@ options SCHED_ULE   # ULE scheduler
>  options  PREEMPTION  # Enable kernel thread preemption
>  options  INET# InterNETworking
>  options  INET6   # IPv6 communications protocols
> -options  IPSEC   # IP (v4/v6) security
>  options  IPSEC_SUPPORT   # Allow kldload of ipsec and tcpmd5
>  options  TCP_OFFLOAD # TCP offload
>  options  TCP_HHOOK   # hhook(9) framework for TCP
> 
> Modified: head/sys/arm64/conf/GENERIC
> ==
> --- head/sys/arm64/conf/GENERIC   Fri Sep  1 11:51:07 2017
> (r323086)
> +++ head/sys/arm64/conf/GENERIC   Fri Sep  1 15:54:53 2017
> (r323087)
> @@ -29,7 +29,6 @@ options PREEMPTION  # Enable kernel thread 
> preemption
>  options  INET# InterNETworking
>  options  INET6   # IPv6 communications protocols
>  options  IPSEC   # IP (v4/v6) security
> -options  IPSEC_SUPPORT   # Allow kldload of ipsec and 
> tcpmd5

Was this a miss fire???

>  options  TCP_HHOOK   # hhook(9) framework for TCP
>  options  TCP_OFFLOAD # TCP offload
>  options  SCTP# Stream Control Transmission Protocol
> 
> Modified: head/sys/i386/conf/GENERIC
> ==
> --- head/sys/i386/conf/GENERICFri Sep  1 11:51:07 2017
> (r323086)
> +++ head/sys/i386/conf/GENERICFri Sep  1 15:54:53 2017
> (r323087)
> @@ -30,7 +30,6 @@ options SCHED_ULE   # ULE scheduler
>  options  PREEMPTION  # Enable kernel thread preemption
>  options  INET# InterNETworking
>  options  INET6   # IPv6 communications protocols
> -options  IPSEC   # IP (v4/v6) security
>  options  IPSEC_SUPPORT   # Allow kldload of ipsec and 
> tcpmd5
>  options  TCP_HHOOK   # hhook(9) framework for TCP
>  options  TCP_OFFLOAD # TCP offload
> 
> Modified: head/sys/powerpc/conf/GENERIC
> ==
> --- head/sys/powerpc/conf/GENERIC Fri Sep  1 11:51:07 2017
> (r323086)
> +++ head/sys/powerpc/conf/GENERIC Fri Sep  1 15:54:53 2017
> (r323087)
> @@ -37,7 +37,6 @@ options SCHED_ULE   #ULE scheduler
>  options  PREEMPTION  #Enable kernel thread preemption
>  options  INET#InterNETworking
>  options  INET6   #IPv6 communications protocols
> -options  IPSEC   # IP (v4/v6) security
>  options  IPSEC_SUPPORT   # Allow kldload of ipsec and 
> tcpmd5
>  options  TCP_HHOOK   # hhook(9) framework for TCP
>  options  SCTP#Stream Control Transmission Protocol
> 
> Modified: head/sys/riscv/conf/GENERIC
> ==
> --- head/sys/riscv/conf/GENERIC   Fri Sep  1 11:51:07 2017
> (r323086)
> +++ head/sys/riscv/conf/GENERIC   Fri Sep  1 15:54:53 2017
> (r323087)
> @@ -33,7 +33,6 @@ options PREEMPTION  # Enable kernel thread 
> preemption
>  options  INET# InterNETworking
>  options  INET6   # IPv6 communications protocols
>  options  TCP_HHOOK   # hhook(9) framework for TCP
> -options  IPSEC   # IP (v4/v6) security
>  options  IPSEC_SUPPORT   # Allow kldload of ipsec and 
> tcpmd5
>  options  TCP_OFFLOAD # TCP offload
>  options  SCTP# Stream Control Transmission Protocol
> 
> Modified: head/sys/sparc64/conf/GENERIC
> 

Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Ian Lepore]

On Fri, 2017-09-01 at 09:06 -0700, Conrad Meyer wrote:
> Wait, why?  The PR doesn't explain it any better than this commit
> message.
> 
> On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel 
> wrote:
> > 
> > Author: jpaetzel
> > Date: Fri Sep  1 15:54:53 2017
> > New Revision: 323087
> > URL: https://svnweb.freebsd.org/changeset/base/323087
> > 
> > Log:
> >   Take options IPSEC out of GENERIC
> > 
> >   PR:   220170
> >   Submitted by: delphij
> >   Reviewed by:  ae, glebius
> >   MFC after:2 weeks
> >   Differential Revision:D11806

The differential revision (which should be cited using the complete url
in the commit) seems to indicate that it's because it can be kldloaded.

This change misses the armv6 platform, where the option appears in
std.armv6, which gets included in GENERIC (and all other armv6
configs).

This change seems to warrant an entry in UPDATING, because it's going
to catch a lot of people by surprise.  Even people with custom kernels,
if they follow the advice of the handbook and "include GENERIC" then
override things.

-- Ian
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Sergey Kandaurov]

1 сент. 2017 г. 18:55 пользователь "Josh Paetzel" 
написал:

Author: jpaetzel
Date: Fri Sep  1 15:54:53 2017
New Revision: 323087
URL: https://svnweb.freebsd.org/changeset/base/323087

Log:
  Take options IPSEC out of GENERIC

  PR:   220170
  Submitted by: delphij
  Reviewed by:  ae, glebius
  MFC after:2 weeks
  Differential Revision:D11806

Modified:
  head/sys/amd64/conf/GENERIC
  head/sys/arm64/conf/GENERIC
  head/sys/i386/conf/GENERIC
  head/sys/powerpc/conf/GENERIC
  head/sys/riscv/conf/GENERIC
  head/sys/sparc64/conf/GENERIC

Modified: head/sys/amd64/conf/GENERIC

==
--- head/sys/amd64/conf/GENERIC Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/amd64/conf/GENERIC Fri Sep  1 15:54:53 2017(r323087)
@@ -28,7 +28,6 @@ options   SCHED_ULE   # ULE scheduler
 optionsPREEMPTION  # Enable kernel thread preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
-optionsIPSEC   # IP (v4/v6) security
 optionsIPSEC_SUPPORT   # Allow kldload of ipsec and tcpmd5
 optionsTCP_OFFLOAD # TCP offload
 optionsTCP_HHOOK   # hhook(9) framework for TCP

Modified: head/sys/arm64/conf/GENERIC

==
--- head/sys/arm64/conf/GENERIC Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/arm64/conf/GENERIC Fri Sep  1 15:54:53 2017(r323087)
@@ -29,7 +29,6 @@ options   PREEMPTION  # Enable kernel
thread preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
 optionsIPSEC   # IP (v4/v6) security
-optionsIPSEC_SUPPORT


Looks like the wrong line is removed.
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Conrad Meyer]

Wait, why?  The PR doesn't explain it any better than this commit message.

On Fri, Sep 1, 2017 at 8:54 AM, Josh Paetzel  wrote:
> Author: jpaetzel
> Date: Fri Sep  1 15:54:53 2017
> New Revision: 323087
> URL: https://svnweb.freebsd.org/changeset/base/323087
>
> Log:
>   Take options IPSEC out of GENERIC
>
>   PR:   220170
>   Submitted by: delphij
>   Reviewed by:  ae, glebius
>   MFC after:2 weeks
>   Differential Revision:D11806
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r323087 - in head/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf

[Josh Paetzel]

Author: jpaetzel
Date: Fri Sep  1 15:54:53 2017
New Revision: 323087
URL: https://svnweb.freebsd.org/changeset/base/323087

Log:
  Take options IPSEC out of GENERIC
  
  PR:   220170
  Submitted by: delphij
  Reviewed by:  ae, glebius
  MFC after:2 weeks
  Differential Revision:D11806

Modified:
  head/sys/amd64/conf/GENERIC
  head/sys/arm64/conf/GENERIC
  head/sys/i386/conf/GENERIC
  head/sys/powerpc/conf/GENERIC
  head/sys/riscv/conf/GENERIC
  head/sys/sparc64/conf/GENERIC

Modified: head/sys/amd64/conf/GENERIC
==
--- head/sys/amd64/conf/GENERIC Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/amd64/conf/GENERIC Fri Sep  1 15:54:53 2017(r323087)
@@ -28,7 +28,6 @@ options   SCHED_ULE   # ULE scheduler
 optionsPREEMPTION  # Enable kernel thread preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
-optionsIPSEC   # IP (v4/v6) security
 optionsIPSEC_SUPPORT   # Allow kldload of ipsec and tcpmd5
 optionsTCP_OFFLOAD # TCP offload
 optionsTCP_HHOOK   # hhook(9) framework for TCP

Modified: head/sys/arm64/conf/GENERIC
==
--- head/sys/arm64/conf/GENERIC Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/arm64/conf/GENERIC Fri Sep  1 15:54:53 2017(r323087)
@@ -29,7 +29,6 @@ options   PREEMPTION  # Enable kernel thread 
preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
 optionsIPSEC   # IP (v4/v6) security
-optionsIPSEC_SUPPORT   # Allow kldload of ipsec and 
tcpmd5
 optionsTCP_HHOOK   # hhook(9) framework for TCP
 optionsTCP_OFFLOAD # TCP offload
 optionsSCTP# Stream Control Transmission Protocol

Modified: head/sys/i386/conf/GENERIC
==
--- head/sys/i386/conf/GENERIC  Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/i386/conf/GENERIC  Fri Sep  1 15:54:53 2017(r323087)
@@ -30,7 +30,6 @@ options   SCHED_ULE   # ULE scheduler
 optionsPREEMPTION  # Enable kernel thread preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
-optionsIPSEC   # IP (v4/v6) security
 optionsIPSEC_SUPPORT   # Allow kldload of ipsec and 
tcpmd5
 optionsTCP_HHOOK   # hhook(9) framework for TCP
 optionsTCP_OFFLOAD # TCP offload

Modified: head/sys/powerpc/conf/GENERIC
==
--- head/sys/powerpc/conf/GENERIC   Fri Sep  1 11:51:07 2017
(r323086)
+++ head/sys/powerpc/conf/GENERIC   Fri Sep  1 15:54:53 2017
(r323087)
@@ -37,7 +37,6 @@ options   SCHED_ULE   #ULE scheduler
 optionsPREEMPTION  #Enable kernel thread preemption
 optionsINET#InterNETworking
 optionsINET6   #IPv6 communications protocols
-optionsIPSEC   # IP (v4/v6) security
 optionsIPSEC_SUPPORT   # Allow kldload of ipsec and 
tcpmd5
 optionsTCP_HHOOK   # hhook(9) framework for TCP
 optionsSCTP#Stream Control Transmission Protocol

Modified: head/sys/riscv/conf/GENERIC
==
--- head/sys/riscv/conf/GENERIC Fri Sep  1 11:51:07 2017(r323086)
+++ head/sys/riscv/conf/GENERIC Fri Sep  1 15:54:53 2017(r323087)
@@ -33,7 +33,6 @@ options   PREEMPTION  # Enable kernel thread 
preemption
 optionsINET# InterNETworking
 optionsINET6   # IPv6 communications protocols
 optionsTCP_HHOOK   # hhook(9) framework for TCP
-optionsIPSEC   # IP (v4/v6) security
 optionsIPSEC_SUPPORT   # Allow kldload of ipsec and 
tcpmd5
 optionsTCP_OFFLOAD # TCP offload
 optionsSCTP# Stream Control Transmission Protocol

Modified: head/sys/sparc64/conf/GENERIC
==
--- head/sys/sparc64/conf/GENERIC   Fri Sep  1 11:51:07 2017
(r323086)
+++ head/sys/sparc64/conf/GENERIC   Fri Sep  1 15:54:53 2017
(r323087)
@@ -30,7 +30,6 @@ options   SCHED_ULE   # ULE scheduler
 options