Re: svn commit: r342349 - head/usr.sbin/ctladm

[Marcelo Araujo]

Em sáb, 22 de dez de 2018 às 02:53, Alexander Motin 
escreveu:

> On 21.12.2018 13:37, Marcelo Araujo wrote:
> > Em sáb, 22 de dez de 2018 às 01:22, Alexander Motin  > > escreveu:
> >
> > Author: mav
> > Date: Fri Dec 21 17:22:15 2018
> > New Revision: 342349
> > URL: https://svnweb.freebsd.org/changeset/base/342349
> >
> > Log:
> >   Fix passing wrong variables to nvlist_destroy() after r333446.
> >
> >   Reported by:  Alexander Fedorov (IT-Grad.ru)
> >   MFC after:5 days
> >
> >
> > Thanks to fix that!
>
> Welcome.
>
> > Out of curiosity, that was reported by email, bugzilla or any other
> place?
> Directly to me via OpenZFS slack.
>
> --
> Alexander Motin
>

Thank you!

Best,
-- 

-- 
Marcelo Araujo(__)ara...@freebsd.org
\\\'',)http://www.FreeBSD.org    \/  \ ^
Power To Server. .\. /_)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r342349 - head/usr.sbin/ctladm

[Marcelo Araujo]

Em sáb, 22 de dez de 2018 às 01:22, Alexander Motin 
escreveu:

> Author: mav
> Date: Fri Dec 21 17:22:15 2018
> New Revision: 342349
> URL: https://svnweb.freebsd.org/changeset/base/342349
>
> Log:
>   Fix passing wrong variables to nvlist_destroy() after r333446.
>
>   Reported by:  Alexander Fedorov (IT-Grad.ru)
>   MFC after:5 days
>

Thanks to fix that!

Out of curiosity, that was reported by email, bugzilla or any other place?

Best,


>
> Modified:
>   head/usr.sbin/ctladm/ctladm.c
>
> Modified: head/usr.sbin/ctladm/ctladm.c
>
> ==
> --- head/usr.sbin/ctladm/ctladm.c   Fri Dec 21 17:18:33 2018
> (r342348)
> +++ head/usr.sbin/ctladm/ctladm.c   Fri Dec 21 17:22:15 2018
> (r342349)
> @@ -667,7 +667,7 @@ cctl_port(int fd, int argc, char **argv, char *combine
> }
>
>  bailout:
> -   nvlist_destroy(req.args_nvl);
> +   nvlist_destroy(option_list);
> free(driver);
> return (retval);
>
> @@ -2542,7 +2542,7 @@ cctl_create_lun(int fd, int argc, char **argv, char
> *c
> fprintf(stdout, "Device ID: %s\n",
> req.reqdata.create.device_id);
>
>  bailout:
> -   nvlist_destroy(req.args_nvl);
> +   nvlist_destroy(option_list);
> return (retval);
>  }
>
> @@ -2644,7 +2644,7 @@ cctl_rm_lun(int fd, int argc, char **argv, char
> *combi
> printf("LUN %d removed successfully\n", lun_id);
>
>  bailout:
> -   nvlist_destroy(req.args_nvl);
> +   nvlist_destroy(option_list);
> return (retval);
>  }
>
> @@ -2764,7 +2764,7 @@ cctl_modify_lun(int fd, int argc, char **argv, char
> *c
> printf("LUN %d modified successfully\n", lun_id);
>
>  bailout:
> -   nvlist_destroy(req.args_nvl);
> +   nvlist_destroy(option_list);
> return (retval);
>  }
>
>
>

-- 

-- 
Marcelo Araujo(__)ara...@freebsd.org
\\\'',)http://www.FreeBSD.org    \/  \ ^
Power To Server. .\. /_)
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r342349 - head/usr.sbin/ctladm

[Alexander Motin]

Author: mav
Date: Fri Dec 21 17:22:15 2018
New Revision: 342349
URL: https://svnweb.freebsd.org/changeset/base/342349

Log:
  Fix passing wrong variables to nvlist_destroy() after r333446.
  
  Reported by:  Alexander Fedorov (IT-Grad.ru)
  MFC after:5 days

Modified:
  head/usr.sbin/ctladm/ctladm.c

Modified: head/usr.sbin/ctladm/ctladm.c
==
--- head/usr.sbin/ctladm/ctladm.c   Fri Dec 21 17:18:33 2018
(r342348)
+++ head/usr.sbin/ctladm/ctladm.c   Fri Dec 21 17:22:15 2018
(r342349)
@@ -667,7 +667,7 @@ cctl_port(int fd, int argc, char **argv, char *combine
}
 
 bailout:
-   nvlist_destroy(req.args_nvl);
+   nvlist_destroy(option_list);
free(driver);
return (retval);
 
@@ -2542,7 +2542,7 @@ cctl_create_lun(int fd, int argc, char **argv, char *c
fprintf(stdout, "Device ID: %s\n", req.reqdata.create.device_id);
 
 bailout:
-   nvlist_destroy(req.args_nvl);
+   nvlist_destroy(option_list);
return (retval);
 }
 
@@ -2644,7 +2644,7 @@ cctl_rm_lun(int fd, int argc, char **argv, char *combi
printf("LUN %d removed successfully\n", lun_id);
 
 bailout:
-   nvlist_destroy(req.args_nvl);
+   nvlist_destroy(option_list);
return (retval);
 }
 
@@ -2764,7 +2764,7 @@ cctl_modify_lun(int fd, int argc, char **argv, char *c
printf("LUN %d modified successfully\n", lun_id);
 
 bailout:
-   nvlist_destroy(req.args_nvl);
+   nvlist_destroy(option_list);
return (retval);
 }
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"