Re: svn commit: r353012 - head/usr.sbin/bsdinstall/scripts

2019-10-02 Thread Glen Barber
On Wed, Oct 02, 2019 at 10:13:01AM -0600, Ian Lepore wrote:
> On Wed, 2019-10-02 at 16:09 +, Glen Barber wrote:
> > Author: gjb
> > Date: Wed Oct  2 16:09:28 2019
> > New Revision: 353012
> > URL: https://svnweb.freebsd.org/changeset/base/353012
> > 
> > Log:
> >   Add a comment explaining why the opensolaris_load line in loader.conf
> >   is explicitly added.
> >   
> >   Requested by: rgrimes
> >   MFC after:3 days
> >   MFC with: r353004
> >   Sponsored by: Rubicon Communications, LLC (Netgate)
> > 
> > Modified:
> >   head/usr.sbin/bsdinstall/scripts/config
> > 
> > Modified: head/usr.sbin/bsdinstall/scripts/config
> > ==
> > --- head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:08:01 2019
> > (r353011)
> > +++ head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:09:28 2019
> > (r353012)
> > @@ -44,6 +44,8 @@ cp $BSDINSTALL_TMPETC/* $BSDINSTALL_CHROOT/etc
> >  
> >  cat $BSDINSTALL_TMPBOOT/loader.conf.* >> $BSDINSTALL_TMPBOOT/loader.conf
> >  rm $BSDINSTALL_TMPBOOT/loader.conf.*
> > +# The 'opensolaris_load' line is a workaround for arm64, which does not
> > +# automatically load opensolaris.ko with zfs.ko.
> >  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo 
> > "opensolaris_load=\"YES\"" >> $BSDINSTALL_TMPBOOT/loader.conf
> >  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "zfs_load=\"YES\"" >> 
> > $BSDINSTALL_TMPBOOT/loader.conf
> >  
> 
> Is this our long-existing problem of not being able to run kldxref as
> part of a cross build and install?  Or is this some other arm64-
> specific problem?
> 

This is a good question.  I do not see an error in the log when kldxref
is invoked, but I am not certain if that necessarily means anything.

Glen



signature.asc
Description: PGP signature


Re: svn commit: r353012 - head/usr.sbin/bsdinstall/scripts

2019-10-02 Thread Rodney W. Grimes
> On Wed, 2019-10-02 at 16:09 +, Glen Barber wrote:
> > Author: gjb
> > Date: Wed Oct  2 16:09:28 2019
> > New Revision: 353012
> > URL: https://svnweb.freebsd.org/changeset/base/353012
> > 
> > Log:
> >   Add a comment explaining why the opensolaris_load line in loader.conf
> >   is explicitly added.
> >   
> >   Requested by: rgrimes
> >   MFC after:3 days
> >   MFC with: r353004
> >   Sponsored by: Rubicon Communications, LLC (Netgate)
> > 
> > Modified:
> >   head/usr.sbin/bsdinstall/scripts/config
> > 
> > Modified: head/usr.sbin/bsdinstall/scripts/config
> > ==
> > --- head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:08:01 2019
> > (r353011)
> > +++ head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:09:28 2019
> > (r353012)
> > @@ -44,6 +44,8 @@ cp $BSDINSTALL_TMPETC/* $BSDINSTALL_CHROOT/etc
> >  
> >  cat $BSDINSTALL_TMPBOOT/loader.conf.* >> $BSDINSTALL_TMPBOOT/loader.conf
> >  rm $BSDINSTALL_TMPBOOT/loader.conf.*
> > +# The 'opensolaris_load' line is a workaround for arm64, which does not
> > +# automatically load opensolaris.ko with zfs.ko.
> >  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo 
> > "opensolaris_load=\"YES\"" >> $BSDINSTALL_TMPBOOT/loader.conf
> >  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "zfs_load=\"YES\"" >> 
> > $BSDINSTALL_TMPBOOT/loader.conf
> >  
> 
> Is this our long-existing problem of not being able to run kldxref as
> part of a cross build and install?  Or is this some other arm64-
> specific problem?

I think it boils down to that, though I have not re-investigated the
issue since kldxref was fixed to run on arm64 (which was the orignal
problem).


-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r353012 - head/usr.sbin/bsdinstall/scripts

2019-10-02 Thread Rodney W. Grimes
> Author: gjb
> Date: Wed Oct  2 16:09:28 2019
> New Revision: 353012
> URL: https://svnweb.freebsd.org/changeset/base/353012
> 
> Log:
>   Add a comment explaining why the opensolaris_load line in loader.conf
>   is explicitly added.

Thank you,
Rod

>   
>   Requested by:   rgrimes
>   MFC after:  3 days
>   MFC with:   r353004
>   Sponsored by:   Rubicon Communications, LLC (Netgate)
> 
> Modified:
>   head/usr.sbin/bsdinstall/scripts/config
> 
> Modified: head/usr.sbin/bsdinstall/scripts/config
> ==
> --- head/usr.sbin/bsdinstall/scripts/config   Wed Oct  2 16:08:01 2019
> (r353011)
> +++ head/usr.sbin/bsdinstall/scripts/config   Wed Oct  2 16:09:28 2019
> (r353012)
> @@ -44,6 +44,8 @@ cp $BSDINSTALL_TMPETC/* $BSDINSTALL_CHROOT/etc
>  
>  cat $BSDINSTALL_TMPBOOT/loader.conf.* >> $BSDINSTALL_TMPBOOT/loader.conf
>  rm $BSDINSTALL_TMPBOOT/loader.conf.*
> +# The 'opensolaris_load' line is a workaround for arm64, which does not
> +# automatically load opensolaris.ko with zfs.ko.
>  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "opensolaris_load=\"YES\"" 
> >> $BSDINSTALL_TMPBOOT/loader.conf
>  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "zfs_load=\"YES\"" >> 
> $BSDINSTALL_TMPBOOT/loader.conf
>  
> 

-- 
Rod Grimes rgri...@freebsd.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


Re: svn commit: r353012 - head/usr.sbin/bsdinstall/scripts

2019-10-02 Thread Ian Lepore
On Wed, 2019-10-02 at 16:09 +, Glen Barber wrote:
> Author: gjb
> Date: Wed Oct  2 16:09:28 2019
> New Revision: 353012
> URL: https://svnweb.freebsd.org/changeset/base/353012
> 
> Log:
>   Add a comment explaining why the opensolaris_load line in loader.conf
>   is explicitly added.
>   
>   Requested by:   rgrimes
>   MFC after:  3 days
>   MFC with:   r353004
>   Sponsored by:   Rubicon Communications, LLC (Netgate)
> 
> Modified:
>   head/usr.sbin/bsdinstall/scripts/config
> 
> Modified: head/usr.sbin/bsdinstall/scripts/config
> ==
> --- head/usr.sbin/bsdinstall/scripts/config   Wed Oct  2 16:08:01 2019
> (r353011)
> +++ head/usr.sbin/bsdinstall/scripts/config   Wed Oct  2 16:09:28 2019
> (r353012)
> @@ -44,6 +44,8 @@ cp $BSDINSTALL_TMPETC/* $BSDINSTALL_CHROOT/etc
>  
>  cat $BSDINSTALL_TMPBOOT/loader.conf.* >> $BSDINSTALL_TMPBOOT/loader.conf
>  rm $BSDINSTALL_TMPBOOT/loader.conf.*
> +# The 'opensolaris_load' line is a workaround for arm64, which does not
> +# automatically load opensolaris.ko with zfs.ko.
>  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "opensolaris_load=\"YES\"" 
> >> $BSDINSTALL_TMPBOOT/loader.conf
>  df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "zfs_load=\"YES\"" >> 
> $BSDINSTALL_TMPBOOT/loader.conf
>  

Is this our long-existing problem of not being able to run kldxref as
part of a cross build and install?  Or is this some other arm64-
specific problem?

-- Ian

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"


svn commit: r353012 - head/usr.sbin/bsdinstall/scripts

2019-10-02 Thread Glen Barber
Author: gjb
Date: Wed Oct  2 16:09:28 2019
New Revision: 353012
URL: https://svnweb.freebsd.org/changeset/base/353012

Log:
  Add a comment explaining why the opensolaris_load line in loader.conf
  is explicitly added.
  
  Requested by: rgrimes
  MFC after:3 days
  MFC with: r353004
  Sponsored by: Rubicon Communications, LLC (Netgate)

Modified:
  head/usr.sbin/bsdinstall/scripts/config

Modified: head/usr.sbin/bsdinstall/scripts/config
==
--- head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:08:01 2019
(r353011)
+++ head/usr.sbin/bsdinstall/scripts/config Wed Oct  2 16:09:28 2019
(r353012)
@@ -44,6 +44,8 @@ cp $BSDINSTALL_TMPETC/* $BSDINSTALL_CHROOT/etc
 
 cat $BSDINSTALL_TMPBOOT/loader.conf.* >> $BSDINSTALL_TMPBOOT/loader.conf
 rm $BSDINSTALL_TMPBOOT/loader.conf.*
+# The 'opensolaris_load' line is a workaround for arm64, which does not
+# automatically load opensolaris.ko with zfs.ko.
 df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "opensolaris_load=\"YES\"" >> 
$BSDINSTALL_TMPBOOT/loader.conf
 df -t zfs $BSDINSTALL_CHROOT > /dev/null && echo "zfs_load=\"YES\"" >> 
$BSDINSTALL_TMPBOOT/loader.conf
 
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"