Re: svn commit: r364435 - head/usr.sbin/kldxref

[Matteo Riondato]

> On Aug 20, 2020, at 2:50 PM, Dimitry Andric  wrote:
> 
> Author: dim
> Date: Thu Aug 20 18:50:46 2020
> New Revision: 364435
> URL: https://svnweb.freebsd.org/changeset/base/364435
> 
> Log:
>  Bump kldxref's MAXSEGS to 16, to stop complaints about the kernel
>  supposedly having too many segments, when lld 11 links it. Such kernels
>  should load just fine.

Hi,

I was doing an upgrade from 12.2-R to HEAD today, and at the end of 
installkernel I got the warning  “kldxref: too many segments”. Still, the 
system seems to claim that installkernel succeded. I believe the message is 
caused by the fact that the system kldxref is used to kldxref the new kernel, 
rather than using the one from buildworld (I got this idea by looking at 
KLDXREF_CMD in sys/conf/kern.opts.mk). 

I don’t know if the message is innocuous or not (although I’d love to know), 
but I also wonder whether installkernel should pick the buildworld kldxref 
rather than the installed one.

Thanks,
Matteo

___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Re: svn commit: r364435 - head/usr.sbin/kldxref

[Brandon Bergren]

>   Note that we may still do some tweaking of our kernel linker scripts, to
>   lower the number of segments, although the exact benefit is not entirely
>   clear.
> 

No real benefit, except for when using loading via sources other than 
loader(8). If any platforms other than powerpc64 need this, they can get full 
control over the image generation with the PHDRS directive like we do there.

IIRC there are benefits to *having* more segments on i386/amd64 as it makes 
link_elf_protect() more effective in some cases.

-- 
  Brandon Bergren
  bdra...@freebsd.org
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

svn commit: r364435 - head/usr.sbin/kldxref

[Dimitry Andric]

Author: dim
Date: Thu Aug 20 18:50:46 2020
New Revision: 364435
URL: https://svnweb.freebsd.org/changeset/base/364435

Log:
  Bump kldxref's MAXSEGS to 16, to stop complaints about the kernel
  supposedly having too many segments, when lld 11 links it. Such kernels
  should load just fine.
  
  Note that we may still do some tweaking of our kernel linker scripts, to
  lower the number of segments, although the exact benefit is not entirely
  clear.

Modified:
  head/usr.sbin/kldxref/ef.c

Modified: head/usr.sbin/kldxref/ef.c
==
--- head/usr.sbin/kldxref/ef.c  Thu Aug 20 18:31:50 2020(r364434)
+++ head/usr.sbin/kldxref/ef.c  Thu Aug 20 18:50:46 2020(r364435)
@@ -49,7 +49,7 @@
 
 #include "ef.h"
 
-#defineMAXSEGS 3
+#defineMAXSEGS 16
 struct ef_file {
char*ef_name;
struct elf_file *ef_efile;
___
svn-src-head@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"