Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread Mishal Shah via swift-dev 
Thanks! 

> On Apr 3, 2017, at 9:22 PM, Hugh Bellamy  wrote:
> 
> Ah I see. I've sent in https://github.com/apple/swift/pull/8529 
> 
> 
> Thanks
> Hugh
> 
> On 4 April 2017 at 10:57, mishal_shah  > wrote:
> We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid 
> python lint failure. 
> 
> Thanks,
> Mishal Shah
> 
>> On Apr 3, 2017, at 8:17 PM, Hugh Bellamy > > wrote:
>> 
>> This issue was fixed in https://github.com/apple/swift/pull/8384 
>> , I think.
>> 
>> On 4 April 2017 at 06:31, Vedant Kumar > > wrote:
>> This doesn't look related to my changes.
>> 
>> + Hugh, since he's at least touched the file.
>> 
>> vedant
>> 
>> > On Apr 3, 2017, at 4:29 PM, no-re...@swift.org  
>> > wrote:
>> >
>> > [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>> >
>> > Build URL:
>> > https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/ 
>> > 
>> > Project:  oss-swift-4.0-incremental-RA-osx
>> > Date of build:Mon, 03 Apr 2017 15:39:24 -0700
>> > Build duration:   49 min
>> > Identified problems:
>> >
>> >   • Regression test failed: This build failed because a regression 
>> > test in the test suite FAILed. Below is a list of all errors:
>> >   • Indication 1
>> > Tests:
>> >
>> > Name: Swift(macosx-x86_64)
>> > Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
>> >   • Failed: Swift(macosx-x86_64).Python.gyb.swift
>> > Name: Swift-Unit
>> > Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>> >
>> > Changes
>> >
>> >   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
>> > Revert "[InlineCost] Fix codesize issue caused by r286814"
>> >
>> >   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
>> >   • edit: 
>> > test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>> >   • edit: test/Transforms/Inline/inline-cold.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
>> >   • edit: lib/Analysis/InlineCost.cpp
>> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
>> >   • edit: test/Transforms/Inline/inline-optsize.ll
>> >   • edit: test/Transforms/Inline/alloca-bonus.ll
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>> >
>> >   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
>> > Revert "[Inliner] Tweak inline threshold for code size regression"
>> >
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >
>> >   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
>> > Revert "[InlineCost] Remove skew when calculating call costs"
>> >
>> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >   • edit: 
>> > test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>> >   • edit: test/Transforms/Inline/inline-optsize.ll
>> >   • edit: test/Transforms/Inline/inline-cold.ll
>> >   • edit: test/Transforms/Inline/alloca-bonus.ll
>> >   • edit: lib/Analysis/InlineCost.cpp
>> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
>> >
>> >   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
>> > Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>> >
>> >   • edit: test/Transforms/Inline/inline-fp.ll
>> >   • edit: include/llvm/Analysis/InlineCost.h
>> >   • edit: test/Transforms/Inline/ephemeral.ll
>> 
>> 
> 
> 

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread Hugh Bellamy via swift-dev 
Ah I see. I've sent in https://github.com/apple/swift/pull/8529

Thanks
Hugh

On 4 April 2017 at 10:57, mishal_shah  wrote:

> We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid
> python lint failure.
>
> Thanks,
> Mishal Shah
>
> On Apr 3, 2017, at 8:17 PM, Hugh Bellamy  wrote:
>
> This issue was fixed in https://github.com/apple/swift/pull/8384, I think.
>
> On 4 April 2017 at 06:31, Vedant Kumar  wrote:
>
>> This doesn't look related to my changes.
>>
>> + Hugh, since he's at least touched the file.
>>
>> vedant
>>
>> > On Apr 3, 2017, at 4:29 PM, no-re...@swift.org wrote:
>> >
>> > [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
>> >
>> > Build URL:https://ci.swift.org/job/oss-s
>> wift-4.0-incremental-RA-osx/71/
>> > Project:  oss-swift-4.0-incremental-RA-osx
>> > Date of build:Mon, 03 Apr 2017 15:39:24 -0700
>> > Build duration:   49 min
>> > Identified problems:
>> >
>> >   • Regression test failed: This build failed because a regression
>> test in the test suite FAILed. Below is a list of all errors:
>> >   • Indication 1
>> > Tests:
>> >
>> > Name: Swift(macosx-x86_64)
>> > Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
>> >   • Failed: Swift(macosx-x86_64).Python.gyb.swift
>> > Name: Swift-Unit
>> > Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
>> >
>> > Changes
>> >
>> >   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant
>> Kumar:
>> > Revert "[InlineCost] Fix codesize issue caused by r286814"
>> >
>> >   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
>> >   • edit: test/Transforms/Inline/optimiz
>> ation-remarks-passed-yaml.ll
>> >   • edit: test/Transforms/Inline/inline-cold.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
>> >   • edit: lib/Analysis/InlineCost.cpp
>> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
>> >   • edit: test/Transforms/Inline/inline-optsize.ll
>> >   • edit: test/Transforms/Inline/alloca-bonus.ll
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>> >
>> >   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant
>> Kumar:
>> > Revert "[Inliner] Tweak inline threshold for code size regression"
>> >
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >
>> >   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant
>> Kumar:
>> > Revert "[InlineCost] Remove skew when calculating call costs"
>> >
>> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>> >   • edit: test/Transforms/Inline/ptr-diff.ll
>> >   • edit: test/Transforms/Inline/optimiz
>> ation-remarks-passed-yaml.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>> >   • edit: test/Transforms/Inline/inline-optsize.ll
>> >   • edit: test/Transforms/Inline/inline-cold.ll
>> >   • edit: test/Transforms/Inline/alloca-bonus.ll
>> >   • edit: lib/Analysis/InlineCost.cpp
>> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
>> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
>> >
>> >   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant
>> Kumar:
>> > Revert "[InlineCost] Reduce inline thresholds to compensate for cost
>> >
>> >   • edit: test/Transforms/Inline/inline-fp.ll
>> >   • edit: include/llvm/Analysis/InlineCost.h
>> >   • edit: test/Transforms/Inline/ephemeral.ll
>>
>>
>
>
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread mishal_shah via swift-dev 
We need to cherry-pick this fix (PR#8384) into swift-4.0-branch to avoid python 
lint failure. 

Thanks,
Mishal Shah
> On Apr 3, 2017, at 8:17 PM, Hugh Bellamy  wrote:
> 
> This issue was fixed in https://github.com/apple/swift/pull/8384 
> , I think.
> 
> On 4 April 2017 at 06:31, Vedant Kumar  > wrote:
> This doesn't look related to my changes.
> 
> + Hugh, since he's at least touched the file.
> 
> vedant
> 
> > On Apr 3, 2017, at 4:29 PM, no-re...@swift.org  
> > wrote:
> >
> > [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
> >
> > Build URL:https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/ 
> > 
> > Project:  oss-swift-4.0-incremental-RA-osx
> > Date of build:Mon, 03 Apr 2017 15:39:24 -0700
> > Build duration:   49 min
> > Identified problems:
> >
> >   • Regression test failed: This build failed because a regression test 
> > in the test suite FAILed. Below is a list of all errors:
> >   • Indication 1
> > Tests:
> >
> > Name: Swift(macosx-x86_64)
> > Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> >   • Failed: Swift(macosx-x86_64).Python.gyb.swift
> > Name: Swift-Unit
> > Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
> >
> > Changes
> >
> >   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> > Revert "[InlineCost] Fix codesize issue caused by r286814"
> >
> >   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> >   • edit: 
> > test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> >   • edit: test/Transforms/Inline/inline-cold.ll
> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
> >   • edit: lib/Analysis/InlineCost.cpp
> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
> >   • edit: test/Transforms/Inline/inline-optsize.ll
> >   • edit: test/Transforms/Inline/alloca-bonus.ll
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> >
> >   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> > Revert "[Inliner] Tweak inline threshold for code size regression"
> >
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >
> >   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> > Revert "[InlineCost] Remove skew when calculating call costs"
> >
> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >   • edit: 
> > test/Transforms/Inline/optimization-remarks-passed-yaml.ll
> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
> >   • edit: test/Transforms/Inline/inline-optsize.ll
> >   • edit: test/Transforms/Inline/inline-cold.ll
> >   • edit: test/Transforms/Inline/alloca-bonus.ll
> >   • edit: lib/Analysis/InlineCost.cpp
> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
> >
> >   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> > Revert "[InlineCost] Reduce inline thresholds to compensate for cost
> >
> >   • edit: test/Transforms/Inline/inline-fp.ll
> >   • edit: include/llvm/Analysis/InlineCost.h
> >   • edit: test/Transforms/Inline/ephemeral.ll
> 
> 

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread Hugh Bellamy via swift-dev 
This issue was fixed in https://github.com/apple/swift/pull/8384, I think.

On 4 April 2017 at 06:31, Vedant Kumar  wrote:

> This doesn't look related to my changes.
>
> + Hugh, since he's at least touched the file.
>
> vedant
>
> > On Apr 3, 2017, at 4:29 PM, no-re...@swift.org wrote:
> >
> > [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
> >
> > Build URL:https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/
> 71/
> > Project:  oss-swift-4.0-incremental-RA-osx
> > Date of build:Mon, 03 Apr 2017 15:39:24 -0700
> > Build duration:   49 min
> > Identified problems:
> >
> >   • Regression test failed: This build failed because a regression
> test in the test suite FAILed. Below is a list of all errors:
> >   • Indication 1
> > Tests:
> >
> > Name: Swift(macosx-x86_64)
> > Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
> >   • Failed: Swift(macosx-x86_64).Python.gyb.swift
> > Name: Swift-Unit
> > Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
> >
> > Changes
> >
> >   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> > Revert "[InlineCost] Fix codesize issue caused by r286814"
> >
> >   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
> >   • edit: test/Transforms/Inline/
> optimization-remarks-passed-yaml.ll
> >   • edit: test/Transforms/Inline/inline-cold.ll
> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
> >   • edit: lib/Analysis/InlineCost.cpp
> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
> >   • edit: test/Transforms/Inline/inline-optsize.ll
> >   • edit: test/Transforms/Inline/alloca-bonus.ll
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> >
> >   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> > Revert "[Inliner] Tweak inline threshold for code size regression"
> >
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >
> >   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> > Revert "[InlineCost] Remove skew when calculating call costs"
> >
> >   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> >   • edit: test/Transforms/Inline/ptr-diff.ll
> >   • edit: test/Transforms/Inline/
> optimization-remarks-passed-yaml.ll
> >   • edit: test/Transforms/Inline/inline-hot-callsite.ll
> >   • edit: test/Transforms/Inline/inline-optsize.ll
> >   • edit: test/Transforms/Inline/inline-cold.ll
> >   • edit: test/Transforms/Inline/alloca-bonus.ll
> >   • edit: lib/Analysis/InlineCost.cpp
> >   • edit: test/Transforms/Inline/inline-cold-callee.ll
> >   • edit: test/Transforms/Inline/inline-hot-callee.ll
> >
> >   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> > Revert "[InlineCost] Reduce inline thresholds to compensate for cost
> >
> >   • edit: test/Transforms/Inline/inline-fp.ll
> >   • edit: include/llvm/Analysis/InlineCost.h
> >   • edit: test/Transforms/Inline/ephemeral.ll
>
>
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

[swift-dev] Emitted SIL does not parse

2017-04-03 Thread Ben Ng via swift-dev 
I see that SR-3774 already exists, but that ticket was about declarations not 
appearing in the emitted SIL.

I'm able to get declarations to appear with the -frontend flag, but the emitted 
SIL still doesn't parse on master:

> $  echo 'print("moof")' > test.swift
> $  swiftc -frontend -emit-sil test.swift > test.sil
> $  swiftc -parse-sil test.sil
>
> Assertion failed: ((Qualifier != StoreOwnershipQualifier::Unqualified) || 
> F.hasUnqualifiedOwnership() && "Unqualified inst in qualified function"), 
> function createStore, file /swift-dev/swift/include/swift/SIL/SILBuilder.h, 
> line 503.
> 0  swift                    0x00011298d4d8 
> llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 40
> 1  swift                    0x00011298db86 SignalHandler(int) + 454
> 2  libsystem_platform.dylib 0x7fffa48ceb3a _sigtramp + 26
> 3  libsystem_platform.dylib 00 _sigtramp + 1534268640
> 4  libsystem_c.dylib        0x7fffa4753420 abort + 129
> 5  libsystem_c.dylib        0x7fffa471a893 basename_r + 0
> 6  swift                    0x00011017b2fc 
> swift::SILBuilder::createStore(swift::SILLocation, swift::SILValue, 
> swift::SILValue, swift::StoreOwnershipQualifier) + 396
> 7  swift                    0x00011038ddec (anonymous 
> namespace)::SILParser::parseSILInstruction(swift::SILBasicBlock*, 
> swift::SILBuilder&) + 70412
> 8  swift                    0x000110373217 swift::Parser::parseDeclSIL() 
> + 5111
> 9  swift                    0x00011033112d swift::Parser::parseTopLevel() 
> + 269
> 10 swift                    0x000110367edb 
> swift::parseIntoSourceFile(swift::SourceFile&, unsigned int, bool*, 
> swift::SILParserState*, swift::PersistentParserState*, 
> swift::DelayedParsingCallbacks*) + 283
> 11 swift                    0x00011011da0c 
> swift::CompilerInstance::performSema() + 3580
> 12 swift                    0x00010f676f6d 
> swift::performFrontend(llvm::ArrayRef, char const*, void*, 
> swift::FrontendObserver*) + 4621
> 13 swift                    0x00010f6338f0 main + 3312
> 14 libdyld.dylib            0x7fffa46bf235 start + 1

Is this a bug? Am I using the wrong combination of flags?

Ben Ng
https://benng.me
___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (swift 4.0) #71

2017-04-03 Thread Vedant Kumar via swift-dev 
This doesn't look related to my changes.

+ Hugh, since he's at least touched the file.

vedant

> On Apr 3, 2017, at 4:29 PM, no-re...@swift.org wrote:
> 
> [FAILURE] oss-swift-4.0-incremental-RA-osx [#71]
> 
> Build URL:https://ci.swift.org/job/oss-swift-4.0-incremental-RA-osx/71/
> Project:  oss-swift-4.0-incremental-RA-osx
> Date of build:Mon, 03 Apr 2017 15:39:24 -0700
> Build duration:   49 min
> Identified problems:
> 
>   • Regression test failed: This build failed because a regression test 
> in the test suite FAILed. Below is a list of all errors:
>   • Indication 1
> Tests:
> 
> Name: Swift(macosx-x86_64)
> Failed: 1 test(s), Passed: 9103 test(s), Total: 9104 test(s)
>   • Failed: Swift(macosx-x86_64).Python.gyb.swift
> Name: Swift-Unit
> Failed: 0 test(s), Passed: 476 test(s), Total: 476 test(s)
> 
> Changes
> 
>   • Commit f683c24ef812b985e0e93c0aaa962062677b0af4 by Vedant Kumar:
> Revert "[InlineCost] Fix codesize issue caused by r286814"
> 
>   • edit: test/Transforms/Inline/inline-fast-math-flags.ll
>   • edit: 
> test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>   • edit: test/Transforms/Inline/inline-cold.ll
>   • edit: test/Transforms/Inline/inline-hot-callee.ll
>   • edit: lib/Analysis/InlineCost.cpp
>   • edit: test/Transforms/Inline/inline-cold-callee.ll
>   • edit: test/Transforms/Inline/inline-optsize.ll
>   • edit: test/Transforms/Inline/alloca-bonus.ll
>   • edit: test/Transforms/Inline/ptr-diff.ll
>   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>   • edit: test/Transforms/Inline/inline_unreachable-2.ll
> 
>   • Commit 57278f9a2b853e79b47aaff61b25a952aade98f8 by Vedant Kumar:
> Revert "[Inliner] Tweak inline threshold for code size regression"
> 
>   • edit: test/Transforms/Inline/ptr-diff.ll
> 
>   • Commit e3511601a3c036006fab2becb4802b8f27055f02 by Vedant Kumar:
> Revert "[InlineCost] Remove skew when calculating call costs"
> 
>   • edit: test/Transforms/Inline/inline_unreachable-2.ll
>   • edit: test/Transforms/Inline/ptr-diff.ll
>   • edit: 
> test/Transforms/Inline/optimization-remarks-passed-yaml.ll
>   • edit: test/Transforms/Inline/inline-hot-callsite.ll
>   • edit: test/Transforms/Inline/inline-optsize.ll
>   • edit: test/Transforms/Inline/inline-cold.ll
>   • edit: test/Transforms/Inline/alloca-bonus.ll
>   • edit: lib/Analysis/InlineCost.cpp
>   • edit: test/Transforms/Inline/inline-cold-callee.ll
>   • edit: test/Transforms/Inline/inline-hot-callee.ll
> 
>   • Commit 022afe34b9c86521a7d17bcd75811b6f1c39daba by Vedant Kumar:
> Revert "[InlineCost] Reduce inline thresholds to compensate for cost
> 
>   • edit: test/Transforms/Inline/inline-fp.ll
>   • edit: include/llvm/Analysis/InlineCost.h
>   • edit: test/Transforms/Inline/ephemeral.ll

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev