Re: [swift-corelibs-dev] URLSession test fest!

[Pushkar N Kulkarni via swift-corelibs-dev]

Hi Tony, PRs 911 and 913 reminded me of this conversation you started. The current unit testing infrastructure for URLSession may prove insufficient for future contributions. I've been looking at these tests written by Mike Ferenduros and they appear quite exhaustive! The only issue is that they connect to an external HTTP test service - http://httpbin.org.  A quick look at httpbin.org tells me it has sufficient functionality to aid in URLSession unit testing. Do you think it would make sense to emulate this functionality within TestFoundation?Pushkar N Kulkarni,
IBM RuntimesSimplicity is prerequisite for reliability - Edsger W. Dijkstra
-swift-corelibs-dev-boun...@swift.org wrote: -To: swift-corelibs-dev From: Tony Parker via swift-corelibs-dev Sent by: swift-corelibs-dev-boun...@swift.orgDate: 01/25/2017 01:13AMSubject: [swift-corelibs-dev] URLSession test fest!Hi everyone,As we’re wrapping up Swift 3.1, I think it’d be a great opportunity to have a quality focus area on one of our most important APIs: URLSession. If you’ve been wondering how to make a meaningful contribution, this is the perfect time.It’d be great to greatly expand both unit test and higher level test coverage of URLSession. For testing that can’t really be part of a unit test and CI like poorly performing networks or esoteric configurations, it would also be nice to build a different kind of test tool. That tool would provide a lot of knobs for controlling a URLSession. We could make this tool part of the swift-corelibs-foundation project.Is anyone interested in chipping in here? We don’t have to start big. Even small contributions could get us moving in the right direction.Thanks,- Tony___swift-corelibs-dev mailing listswift-corelibs-dev@swift.orghttps://lists.swift.org/mailman/listinfo/swift-corelibs-dev

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] URLSession test fest!

[Peter Tomaselli via swift-corelibs-dev]

Just one outside data point on this: as someone who's been wanting to 
contribute to the test fest, I agree that being able to test against 
httpbin.org (or some other pre-existing server — as opposed to the loopback 
server) would make it much easier to make useful contributions.

Not that the loopback server is bad, but I trashed several attempts at a 
contribution due to lack of confidence about my changes. Specifically, with 
both "ends" of the test apparatus in flux (for example, having to add 
"features" to the loopback server just so that features of URLSession could be 
tested), I found it very hard to know if either end was correct. 

So, just two cents from a lurker here, but this sounds like a great idea to me. 
Cheers,

Peter

> On Mar 9, 2017, at 4:38 PM, Tony Parker via swift-corelibs-dev 
>  wrote:
> 
> Hi Pushkar,
> 
> Another option is to continue to use httpbin.org, but make the tests that use 
> that network service not part of the normal unit tests but runnable on demand 
> by us as we develop. That means we don’t have to reimplement the whole thing 
> but we at least have some tools at our disposal to help debug and diagnose 
> issues. As we make fixes we can improve our local unit test server’s 
> infrastructure to prevent regressions.
> 
> - Tony
> 
>> On Mar 9, 2017, at 7:02 AM, Pushkar N Kulkarni  wrote:
>> 
>> Hi Tony, 
>> 
>> PRs 911 and 913 reminded me of this conversation you started. 
>> 
>> The current unit testing infrastructure for URLSession may prove 
>> insufficient for future contributions. I've been looking at these tests 
>> written by Mike Ferenduros and they appear quite exhaustive! The only issue 
>> is that they connect to an external HTTP test service - http://httpbin.org.  
>> 
>> A quick look at httpbin.org tells me it has sufficient functionality to aid 
>> in URLSession unit testing. Do you think it would make sense to emulate this 
>> functionality within TestFoundation?
>> 
>> 
>> Pushkar N Kulkarni,
>> IBM Runtimes
>> 
>> Simplicity is prerequisite for reliability - Edsger W. Dijkstra
>> 
>> 
>> 
>> -swift-corelibs-dev-boun...@swift.org wrote: -
>> To: swift-corelibs-dev 
>> From: Tony Parker via swift-corelibs-dev 
>> Sent by: swift-corelibs-dev-boun...@swift.org
>> Date: 01/25/2017 01:13AM
>> Subject: [swift-corelibs-dev] URLSession test fest!
>> 
>> Hi everyone,
>> 
>> As we’re wrapping up Swift 3.1, I think it’d be a great opportunity to have 
>> a quality focus area on one of our most important APIs: URLSession. If 
>> you’ve been wondering how to make a meaningful contribution, this is the 
>> perfect time.
>> 
>> It’d be great to greatly expand both unit test and higher level test 
>> coverage of URLSession. For testing that can’t really be part of a unit test 
>> and CI like poorly performing networks or esoteric configurations, it would 
>> also be nice to build a different kind of test tool. That tool would provide 
>> a lot of knobs for controlling a URLSession. We could make this tool part of 
>> the swift-corelibs-foundation project.
>> 
>> Is anyone interested in chipping in here? We don’t have to start big. Even 
>> small contributions could get us moving in the right direction.
>> 
>> Thanks,
>> - Tony
>> 
>> 
>> 
>> ___
>> swift-corelibs-dev mailing list
>> swift-corelibs-dev@swift.org
>> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
>> 
> 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev
___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-dev] CI outage tomorrow for upgrade

[mishal_shah via swift-dev]

Xcode update has been completed on ci.swift.org. 

Thanks,
Mishal Shah
> On Mar 8, 2017, at 3:05 PM, Nicole Jacque via swift-dev  
> wrote:
> 
> Hi All-
> 
> We will have a CI outage for a couple of hours tomorrow starting at 11 
> Pacific, in order to upgrade the CI machines to the latest Xcode beta and 
> SDKs.   We’ll send out a message when the upgrade is complete.
> 
> As mentioned in the Swift 3.1 Release Process blog post, we have begun 
> posting periodic snapshots for the swift-3.1-branch branch at: 
> https://swift.org/download/#snapshots  
> and will continue to post snapshots (if tests are passing) after the upgrade. 
>  The latest snapshot closely resembles the content of the Swift compiler in 
> the beta, however, you may encounter issues (in place of the toolchain 
> shipped in the beta itself) using it with Xcode because of SDK differences.  
> The snapshot posted after we’ve upgraded CI and re-built with the beta SDKs 
> should resolve any issues.  The Xcode beta is available for download at: 
> https://developer.apple.com/download/ 
> 
> Cheers!
> Nicole
> 
> ___
> swift-dev mailing list
> swift-dev@swift.org
> https://lists.swift.org/mailman/listinfo/swift-dev

___
swift-dev mailing list
swift-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-dev

Re: [swift-corelibs-dev] URLSession test fest!

[Tony Parker via swift-corelibs-dev]

Hi Pushkar,

Another option is to continue to use httpbin.org , but 
make the tests that use that network service not part of the normal unit tests 
but runnable on demand by us as we develop. That means we don’t have to 
reimplement the whole thing but we at least have some tools at our disposal to 
help debug and diagnose issues. As we make fixes we can improve our local unit 
test server’s infrastructure to prevent regressions.

- Tony

> On Mar 9, 2017, at 7:02 AM, Pushkar N Kulkarni  wrote:
> 
> Hi Tony, 
> 
> PRs 911 and 913 reminded me of this conversation you started. 
> 
> The current unit testing infrastructure for URLSession may prove insufficient 
> for future contributions. I've been looking at these tests 
> 
>  written by Mike Ferenduros and they appear quite exhaustive! The only issue 
> is that they connect to an external HTTP test service - http://httpbin.org. 
>   
> 
> A quick look at httpbin.org tells me it has sufficient functionality to aid 
> in URLSession unit testing. Do you think it would make sense to emulate this 
> functionality within TestFoundation?
> 
> 
> Pushkar N Kulkarni,
> IBM Runtimes
> 
> Simplicity is prerequisite for reliability - Edsger W. Dijkstra
> 
> 
> 
> -swift-corelibs-dev-boun...@swift.org 
>  wrote: -
> To: swift-corelibs-dev  >
> From: Tony Parker via swift-corelibs-dev 
> Sent by: swift-corelibs-dev-boun...@swift.org 
> 
> Date: 01/25/2017 01:13AM
> Subject: [swift-corelibs-dev] URLSession test fest!
> 
> Hi everyone,
> 
> As we’re wrapping up Swift 3.1, I think it’d be a great opportunity to have a 
> quality focus area on one of our most important APIs: URLSession. If you’ve 
> been wondering how to make a meaningful contribution, this is the perfect 
> time.
> 
> It’d be great to greatly expand both unit test and higher level test coverage 
> of URLSession. For testing that can’t really be part of a unit test and CI 
> like poorly performing networks or esoteric configurations, it would also be 
> nice to build a different kind of test tool. That tool would provide a lot of 
> knobs for controlling a URLSession. We could make this tool part of the 
> swift-corelibs-foundation project.
> 
> Is anyone interested in chipping in here? We don’t have to start big. Even 
> small contributions could get us moving in the right direction.
> 
> Thanks,
> - Tony
> 
> 
> 
> ___
> swift-corelibs-dev mailing list
> swift-corelibs-dev@swift.org 
> https://lists.swift.org/mailman/listinfo/swift-corelibs-dev 
> 
> 

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

[swift-corelibs-dev] More on the memory leak in NSString/String.cString(with:)

[Pushkar N Kulkarni via swift-corelibs-dev]

Hello there,  We have been talking about a known memory leak in String.cString(using: encoding) and String.utf8String over a JIRA report and a closed PR where we considered the option of  freeing up the memory allocated by NSString.cString() in String.cString() - this approach isn’t acceptable because it leaves the leak unresolved with NSString.cString().  Thanks to Tony and Philippe for their comments. The options we are left with are:1. See Philippe’s suggestion here - implement an NSData backing and the needed autorelease() simulation on Linux.2. What Tony suggests here - "eliding these methods from NSString and implementing them differently in String"Does anyone else have other approaches to solve this problem? I am curious about how we will go ahead here and wanted to make sure there is a consensus.  Thanks for your time!Pushkar N Kulkarni,
IBM RuntimesSimplicity is prerequisite for reliability - Edsger W. Dijkstra


___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] URLSession test fest!

[Pushkar N Kulkarni via swift-corelibs-dev]

Peter: I agree. A stable testing infrastructure is absolutely necessary.  Tony: I am curious about where the sources for these tests (that use the external httpbin.org) will be placed? Will it makes sense to have them in TestFoundation and have a guard to exclude them during normal test execution?Pushkar N Kulkarni,
IBM RuntimesSimplicity is prerequisite for reliability - Edsger W. Dijkstra
-Peter Tomaselli  wrote: -To: Tony Parker From: Peter Tomaselli Date: 03/10/2017 04:47AMCc: Pushkar N Kulkarni , swift-corelibs-dev Subject: Re: [swift-corelibs-dev] URLSession test fest!Just one outside data point on this: as someone who's been wanting to contribute to the test fest, I agree that being able to test against httpbin.org (or some other pre-existing server — as opposed to the loopback server) would make it much easier to make useful contributions.Not that the loopback server is bad, but I trashed several attempts at a contribution due to lack of confidence about my changes. Specifically, with both "ends" of the test apparatus in flux (for example, having to add "features" to the loopback server just so that features of URLSession could be tested), I found it very hard to know if either end was correct. So, just two cents from a lurker here, but this sounds like a great idea to me. Cheers,PeterOn Mar 9, 2017, at 4:38 PM, Tony Parker via swift-corelibs-dev  wrote:Hi Pushkar,Another option is to continue to use httpbin.org, but make the tests that use that network service not part of the normal unit tests but runnable on demand by us as we develop. That means we don’t have to reimplement the whole thing but we at least have some tools at our disposal to help debug and diagnose issues. As we make fixes we can improve our local unit test server’s infrastructure to prevent regressions.- TonyOn Mar 9, 2017, at 7:02 AM, Pushkar N Kulkarni  wrote:Hi Tony, PRs 911 and 913 reminded me of this conversation you started. The current unit testing infrastructure for URLSession may prove insufficient for future contributions. I've been looking at these tests written by Mike Ferenduros and they appear quite exhaustive! The only issue is that they connect to an external HTTP test service - http://httpbin.org.  A quick look at httpbin.org tells me it has sufficient functionality to aid in URLSession unit testing. Do you think it would make sense to emulate this functionality within TestFoundation?Pushkar N Kulkarni,IBM RuntimesSimplicity is prerequisite for reliability - Edsger W. Dijkstra-swift-corelibs-dev-boun...@swift.org wrote: -To: swift-corelibs-dev From: Tony Parker via swift-corelibs-dev Sent by: swift-corelibs-dev-boun...@swift.orgDate: 01/25/2017 01:13AMSubject: [swift-corelibs-dev] URLSession test fest!Hi everyone,As we’re wrapping up Swift 3.1, I think it’d be a great opportunity to have a quality focus area on one of our most important APIs: URLSession. If you’ve been wondering how to make a meaningful contribution, this is the perfect time.It’d be great to greatly expand both unit test and higher level test coverage of URLSession. For testing that can’t really be part of a unit test and CI like poorly performing networks or esoteric configurations, it would also be nice to build a different kind of test tool. That tool would provide a lot of knobs for controlling a URLSession. We could make this tool part of the swift-corelibs-foundation project.Is anyone interested in chipping in here? We don’t have to start big. Even small contributions could get us moving in the right direction.Thanks,- Tony___swift-corelibs-dev mailing listswift-corelibs-dev@swift.orghttps://lists.swift.org/mailman/listinfo/swift-corelibs-dev
___swift-corelibs-dev mailing listswift-corelibs-dev@swift.orghttps://lists.swift.org/mailman/listinfo/swift-corelibs-dev

___
swift-corelibs-dev mailing list
swift-corelibs-dev@swift.org
https://lists.swift.org/mailman/listinfo/swift-corelibs-dev