Review request for 8132771: [TEST_BUG][macosx] Test javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX

[Avik Niyogi]

Hi All,

Kindly review the fix for JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8132771 


Webrev: http://cr.openjdk.java.net/~aniyogi/8132771/webrev.00/ 


Issue: LastNodeLowerHalfDrop Test case throws an exception when the behaviour 
is as expected.

Cause: The robot does not have enough delay to run appropriately.

Fix: The test case was fixed to have enough delay for the test case.

With Regards,
Avik Niyogi

Re: Swing dialogs diff between b119 and b120

[Alexander Scherbatiy]

  Hello Christopher,

  I tried FileChooserDemo and SwingSet2 with jigsaw build b120 on Mac 
OS X 10.9 and found nothing wrong.


  Does your app use special types of file filters on the JFileChooser? 
Which order is used to add these filters and "accept all files filter"?
  Could you provide a code snippet and steps how to reproduce the issue 
you have run into?


  Thanks,
  Alexandr.

On 30/05/16 15:40, Alan Bateman wrote:


Forwarding to Alexander Scherbatiy and swing-dev as I suspect that 
this is nothing to do with Project Jigsaw.


Alexander - any reports of issues with the changes to JDK-8152677 in 
jdk-9+120?


-Alan


On 30/05/2016 12:27, Christopher Tipper wrote:

Hi,

I feel awkward posting here I am not a professional developer but I 
have a

moderately substantial Swing drawing app that I have been reviewing the
Early Access builds of jdk-9.

I also don't have any debugging info but somewhere between build 119 and
120 the majority of the dialogs have stopped activating. No 
exceptions are
thrown I don't have any log messages but this includes JFileChooser 
dialogs
so I was wondering if your developers may have some idea how to 
locate the

issue, considering that some work has been proceeding on JFileChooser in
the last few weeks according to JIRA. My dialogs are fully functional in
build 119 (main dev branch) but not functional in build 120 (jigsaw 
branch)
Sorry I downloaded the wrong build last week and I don't have build 
119 of

the jigsaw branch (all 250MB of it).

Platform OS X 10.10.5, jdk9-ea+120, not at my mac so am currently 
unable to

run more tests.

Best wishes,
Christopher

Re: Review request for 8144161: [TESTBUG] [macosx] Test javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java fails for mac

[Alexander Scherbatiy]

The fix looks good to me.

Thanks,
Alexandr.

On 30/05/16 08:15, Avik Niyogi wrote:

A gentle reminder. Please review the bug fix.
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ 



With Regards,
Avik Niyogi
On 27-May-2016, at 12:59 pm, Avik Niyogi > wrote:


A gentle reminder. Please review the bug fix:
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ 



With Regards,
Avik Niyogi

On 25-May-2016, at 2:30 pm, Avik Niyogi > wrote:


Changes updated to same webrev.01
http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01 



With regards,
Avik Niyogi

On 25-May-2016, at 2:21 pm, Rajeev Chamyal 
> wrote:


Looks ok to me.
Can you please add specific class imports instead of *.
Regards,
Rajeev Chamyal
*From:*Avik Niyogi
*Sent:*25 May 2016 12:53
*To:*Alexander Scherbatiy
*Cc:*Rajeev Chamyal; swing-dev@openjdk.java.net 

*Subject:*Re:  Review request for 8144161: [TESTBUG] 
[macosx] Test 
javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java 
fails for mac

Hi All,
Please find updated changes as per inputs received:
 Bug: https://bugs.openjdk.java.net/browse/JDK-8144161
Webrev: http://cr.openjdk.java.net/~aniyogi/8144161/webrev.01/ 


With Regards,
Avik Niyogi

On 24-May-2016, at 5:58 pm, Alexander Scherbatiy
> wrote:
On 24/05/16 15:22, Avik Niyogi wrote:

Hi All,
Kindly review the fix for JDK9.
*Bug*: https://bugs.openjdk.java.net/browse/JDK-8144161

*Webrev*:http://
cr.openjdk.java.net/~aniyogi/8144161/webrev.00/

*Issue*: Test case throws an exception when the behaviour
is as expected.
*Cause*: The expected behaviour for comboBox was not
accounted for Aqua look and feel in test case.
*Fix*: The test case was fixed to account for the Aqua LAF
behaviour for comboBox dropdown menu which extends beyond
the screen Insets (the dock height) for Mac.

  - the bug link points to the bug 7124218 instead of 8144161
  - The exception should be re-thrown on the line 63
  - Some code formatting change is not clear (see for example
line 24 or 133)

  Thanks,
  Alexandr.

With Regards,
Avik Niyogi

Re: Review Request JDK-8152419 JColorChooser throws Exception

[Alexander Scherbatiy]

On 30/05/16 12:39, Prem Balakrishnan wrote:


Hi*,*

Please review fix for JDK9,

*Bug:*https://bugs.openjdk.java.net/browse/JDK-8152419

*Webrev:*http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.00/ 



*Issue:*

JColorChooser throws Exception(NegativeArraySizeException)

*Fix:*

Absolute value is passed while creating array.

   If component size is 10x10 and insets are [30, 30, 30, 30] the 
absolute value of the difference will be  abs(10 - 30 - 30)=50.
   It seems that the right component size should be zero or some 
minimal values which is max(width-insets.left-insets.right, minWidthValue).


  Thanks,
  Alexandr.


Regards,
Prem

Re: Native look and feel on linux [2]

[Alexey Ivanov]

Hi Yan,

If your application sets LaF explicitly in the code, you cannot override 
it with swing.properties.


The Look-and-Feel set using swing.properties file or 
-Dswing.systemlaf= will change the default LaF used by Swing 
apps. For example, Swing uses Metal Look-and-Feel by default on Linux 
platform: If the application does not explicitly set its LaF, the app 
will be displayed in Metal LaF. If you change 'swing.systemlaf' property 
to GTK, the application will use GTK LaF.


If the application explicitly sets its Look-and-Feel at runtime, then 
that application will be run using the LaF it set. You cannot change it.



Regards,
Alexey

On 28.05.2016 0:41, Yan wrote:

You can put swing.properties file to /lib directory as described

here:
https://docs.oracle.com/javase/tutorial/uiswing/lookandfeel/plaf.html#properties

The contents of the file would be:

swing.systemlaf=com.sun.java.swing.plaf.gtk.GTKLookAndFeel

This property file will set GTK LaF for all applications that use this

JRE to run.

High! I've did what you've said, placed file with this line in
/usr/lib/jvm/java-7-openjdk-amd64/lib/ , but nothing have changed. Maybe
I do wrong something?

Once again, I have simple java app, which sets LAF using this:
UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
and I have no env variables like _JAVA_OPTIONS

Regards, Yan

Review Request JDK-8152419 JColorChooser throws Exception

[Prem Balakrishnan]

Hi,

Please review fix for JDK9,

Bug: https://bugs.openjdk.java.net/browse/JDK-8152419 

Webrev: http://cr.openjdk.java.net/~pkbalakr/8152419/webrev.00/ 

 

  

Issue:

JColorChooser throws Exception(NegativeArraySizeException)

 

Fix:

Absolute value is passed while creating array.

 

Regards,
Prem