Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-07 Thread Rajeev Chamyal 
Looks good to me.

 

Regards,

Rajeev Chamyal

 

From: Avik Niyogi 
Sent: 08 September 2016 11:00
To: Rajeev Chamyal
Cc: Alexandr Scherbatiy; swing-dev@openjdk.java.net
Subject: Re:  8163274: [TEST_BUG][macosx] apparent regression: 
javax/swing/JColorChooser/Test7194184.java

 

A gentle reminder, please review code changes as indicated in new webrev.

 

With Regards,

Avik Niyogi

 

On 07-Sep-2016, at 9:50 pm, Alexandr Scherbatiy mailto:alexandr.scherba...@oracle.com"alexandr.scherba...@oracle.com> wrote:

 

The fix looks good to me.

Thanks,
Alexandr.

On 9/7/2016 9:02 AM, Avik Niyogi wrote:

Hi All, 

Kindly review the updated fix for JDK9 with new inputs incorporated.

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Eaniyogi/8163274/webrev.01/"http://cr.openjdk.java.net/~aniyogi/8163274/webrev.01/

 

With Regards,

Avik Niyogi

 

On 07-Sep-2016, at 11:03 am, Rajeev Chamyal mailto:rajeev.cham...@oracle.com"rajeev.cham...@oracle.com> wrote:

 

Looks good to me.

 

Regards,

Rajeev Chamyal

 

From: Alexandr Scherbatiy 
Sent: 06 September 2016 16:16
To: Avik Niyogi; Rajeev Chamyal; HYPERLINK 
"mailto:swing-dev@openjdk.java.net"swing-dev@openjdk.java.net
Subject: Re:  8163274: [TEST_BUG][macosx] apparent regression: 
javax/swing/JColorChooser/Test7194184.java

 

The fix looks good to me.

Thanks,
Alexandr.

On 9/6/2016 9:12 AM, Avik Niyogi wrote:

Hi All,

 

Kindly review the fix for JDK9.  

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8163274

 

Webrev: HYPERLINK 
"http://cr.openjdk.java.net/%7Eaniyogi/8163274/webrev.00/"http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/

 

Issue: This test javax/swing/JColorChooser/Test7194184.java throws exception 
due to event delay.

 

Cause:  Delay for event idling was not added.

 

Fix: Appropriate changes for autoWaitForIdle() were added.

 

With Regards,

Avik Niyogi

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-07 Thread Avik Niyogi 
A gentle reminder, please review code changes as indicated in new webrev.

With Regards,
Avik Niyogi

> On 07-Sep-2016, at 9:50 pm, Alexandr Scherbatiy 
>  wrote:
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 9/7/2016 9:02 AM, Avik Niyogi wrote:
>> Hi All,
>> Kindly review the updated fix for JDK9 with new inputs incorporated.
>> Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.01/ 
>> 
>> 
>> With Regards,
>> Avik Niyogi
>> 
>>> On 07-Sep-2016, at 11:03 am, Rajeev Chamyal >> > wrote:
>>> 
>>> Looks good to me.
>>>  
>>> Regards,
>>> Rajeev Chamyal
>>>  
>>> From: Alexandr Scherbatiy 
>>> Sent: 06 September 2016 16:16
>>> To: Avik Niyogi; Rajeev Chamyal; swing-dev@openjdk.java.net 
>>> 
>>> Subject: Re:  8163274: [TEST_BUG][macosx] apparent regression: 
>>> javax/swing/JColorChooser/Test7194184.java
>>>  
>>> The fix looks good to me.
>>> 
>>> Thanks,
>>> Alexandr.
>>> 
>>> On 9/6/2016 9:12 AM, Avik Niyogi wrote:
>>> Hi All,
>>>  
>>> Kindly review the fix for JDK9.  
>>>  
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8163274 
>>> 
>>>  
>>> Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/ 
>>> 
>>>  
>>> Issue: This test javax/swing/JColorChooser/Test7194184.java throws 
>>> exception due to event delay.
>>>  
>>> Cause:  Delay for event idling was not added.
>>>  
>>> Fix: Appropriate changes for autoWaitForIdle() were added.
>>>  
>>> With Regards,
>>> Avik Niyogi
>>>  
>> 
>

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Alexandr Scherbatiy 


Hello,

Could you review the updated fix:
  http://cr.openjdk.java.net/~alexsch/8165485/webrev.01

 Round line end decoration is used to draw  combo box and scroll bar icons.

 [1], [2], and [3] screenshots show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.

  [1] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x_01.png
  [2] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x_01.png
  [3] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x_01.png


  Thanks,
  Alexandr.

On 9/7/2016 7:54 PM, Phil Race wrote:
drawPolyline does not seem to be an option here because of the 
different colours.
Filling custom shapes may be overkill. Round looks to me to be the 
best of these three.


-phil.


On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote:

On 9/6/2016 6:10 PM, Sergey Bylokhov wrote:
It seems that there are some small artifacts on some of the 
components, please take a look to the corners of the selected 
checkbox. In 1x the corners have correct edges but in x2,x4 there 
are some missing pixels. Similar issue is in the text area(take a 
look to the white border).
  Links [1], [2], and [3] shows drawing the scroll bar buttons using 
different types of a line ends decoration (cap, round, and square). 
All of them have one or another drawing artifact with scales 2 and 4.


  [1] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-butt.png
  [2] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-round.png
  [3] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-square.png


  Thanks,
  Alexandr.


On 06.09.16 13:18, Alexandr Scherbatiy wrote:


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8165485
  webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00

  The icons drawing is changed to use ovals and polygons for
JRadioButton, JCheckBox, JComboBox, and JScrollBar.

  The screenshots [1], [2], and [3] show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.

  [1]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x.png 


  [2]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x.png 


  [3]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x.png 



 Thanks,
 Alexandr.

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Phil Race 
drawPolyline does not seem to be an option here because of the different 
colours.
Filling custom shapes may be overkill. Round looks to me to be the best 
of these three.


-phil.


On 9/7/2016 9:19 AM, Alexandr Scherbatiy wrote:

On 9/6/2016 6:10 PM, Sergey Bylokhov wrote:
It seems that there are some small artifacts on some of the 
components, please take a look to the corners of the selected 
checkbox. In 1x the corners have correct edges but in x2,x4 there are 
some missing pixels. Similar issue is in the text area(take a look to 
the white border).
  Links [1], [2], and [3] shows drawing the scroll bar buttons using 
different types of a line ends decoration (cap, round, and square). 
All of them have one or another drawing artifact with scales 2 and 4.


  [1] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-butt.png
  [2] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-round.png
  [3] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-square.png


  Thanks,
  Alexandr.


On 06.09.16 13:18, Alexandr Scherbatiy wrote:


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8165485
  webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00

  The icons drawing is changed to use ovals and polygons for
JRadioButton, JCheckBox, JComboBox, and JScrollBar.

  The screenshots [1], [2], and [3] show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.

  [1]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x.png 


  [2]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x.png 


  [3]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x.png 



 Thanks,
 Alexandr.

Re: 8163274: [TEST_BUG][macosx] apparent regression: javax/swing/JColorChooser/Test7194184.java

2016-09-07 Thread Alexandr Scherbatiy 

The fix looks good to me.

Thanks,
Alexandr.

On 9/7/2016 9:02 AM, Avik Niyogi wrote:

Hi All,
Kindly review the updated fix for JDK9 with new inputs incorporated.
*Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.01/ 
*


With Regards,
Avik Niyogi

On 07-Sep-2016, at 11:03 am, Rajeev Chamyal 
> wrote:


Looks good to me.
Regards,
Rajeev Chamyal
*From:*Alexandr Scherbatiy
*Sent:*06 September 2016 16:16
*To:*Avik Niyogi; Rajeev Chamyal; swing-dev@openjdk.java.net 

*Subject:*Re:  8163274: [TEST_BUG][macosx] apparent 
regression: javax/swing/JColorChooser/Test7194184.java


The fix looks good to me.

Thanks,
Alexandr.

On 9/6/2016 9:12 AM, Avik Niyogi wrote:

Hi All,
Kindly review the fix for JDK9.
*Bug: https://bugs.openjdk.java.net/browse/JDK-8163274*
*Webrev: http://cr.openjdk.java.net/~aniyogi/8163274/webrev.00/
*
*Issue: *This
test javax/swing/JColorChooser/Test7194184.java throws exception
due to event delay.
*Cause: * Delay for event idling was not added.
*Fix:* Appropriate changes for autoWaitForIdle() were added.
With Regards,
Avik Niyogi

Re: [9] Review request for 8165485 Bad rendering of Swing UI controls with Motif L on HiDPI display

2016-09-07 Thread Alexandr Scherbatiy 

On 9/6/2016 6:10 PM, Sergey Bylokhov wrote:
It seems that there are some small artifacts on some of the 
components, please take a look to the corners of the selected 
checkbox. In 1x the corners have correct edges but in x2,x4 there are 
some missing pixels. Similar issue is in the text area(take a look to 
the white border).
  Links [1], [2], and [3] shows drawing the scroll bar buttons using 
different types of a line ends decoration (cap, round, and square). All 
of them have one or another drawing artifact with scales 2 and 4.


  [1] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-butt.png
  [2] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-round.png
  [3] 
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/motif-icons-cap-square.png


  Thanks,
  Alexandr.


On 06.09.16 13:18, Alexandr Scherbatiy wrote:


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8165485
  webrev: http://cr.openjdk.java.net/~alexsch/8165485/webrev.00

  The icons drawing is changed to use ovals and polygons for
JRadioButton, JCheckBox, JComboBox, and JScrollBar.

  The screenshots [1], [2], and [3] show difference between icons
drawing before and after the fix for scales 1x, 2x, and 4x.

  [1]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-1x.png 


  [2]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-2x.png 


  [3]
http://cr.openjdk.java.net/~alexsch/8165485/screenshots/icons-motif-4x.png 



 Thanks,
 Alexandr.

[9] Review request for 8165594 Bad rendering of Swing UI controls with Windows Classic L on HiDPI display

2016-09-07 Thread Alexandr Scherbatiy 


Hello,

Could you review the fix:
  bug: https://bugs.openjdk.java.net/browse/JDK-8165594
  webrev: http://cr.openjdk.java.net/~alexsch/8165594/webrev.00

  The icons drawing is changed to use ovals and polygons for 
JRadioButton, JCheckBox, JComboBox, and JScrollBar.


  The screenshots [1], [2], and [3] shows difference between icons 
drawing before and after the fix for scales 1x, 2x, and 4x.


  [1] 
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-1x.png
  [2] 
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-2x.png
  [3] 
http://cr.openjdk.java.net/~alexsch/8165594/screenshots/icons-windows-classic-4x.png


 Thanks,
 Alexandr.