Re: RFR: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
On Mon, 4 Jan 2021 05:09:55 GMT, Prasanta Sadhukhan wrote: > This test use to fail in macos in mach5 nightly testing long time back. It > used to fail in ubuntu17.10 due to unsupported wayland display mode. Recent > run of this test on supported platforms does not fail. > Modified the test slightly to be consistent with other test regarding robot > delays, moved frame to center of screen. > Mach5 job running several iterations of the test in all platforms is ok. Link > in JBS. Thank you for your confirmation. Looks fine. - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1923
Re: RFR: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
On Mon, 4 Jan 2021 23:01:25 GMT, Sergey Bylokhov wrote: >> Yes, it works >> >> reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25 >> -Dsun.java2d.d3d=true ScaledFrameBackgroundTest >> Mode: othervm [/othervm specified] >> Additional options from @modules: --add-modules java.desktop >> elapsed time (seconds): 6.049 >> --configuration:(3/43)-- >> Boot Layer >> add modules: java.desktop >> >> --System.out:(0/0)-- >> --System.err:(1/16)-- >> STATUS:Passed. > >> reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25 >> -Dsun.java2d.d3d=true > > You have set it via the property, but the bug was reported on the system > where the 125% dpi was set in the windows settings and the test was run as-is. I have tried that as well. In fact, my windows display setting is 125% and it worked without this property change in uiscale. - PR: https://git.openjdk.java.net/jdk/pull/1923
Re: RFR: 8193942: Regression automated test '/open/test/jdk/javax/swing/JFrame/8175301/ScaledFrameBackgroundTest.java' fails
On Mon, 4 Jan 2021 06:59:10 GMT, Prasanta Sadhukhan wrote: > reason: User specified action: run main/othervm -Dsun.java2d.uiScale=1.25 > -Dsun.java2d.d3d=true You have set it via the property, but the bug was reported on the system where the 125% dpi was set in the windows settings and the test was run as-is. - PR: https://git.openjdk.java.net/jdk/pull/1923
Integrated: 8257809: JNI warnings from Toolkit JPEG image decoding
On Sun, 20 Dec 2020 01:37:47 GMT, Phil Race wrote: > The fix is to reverse the order of acquisition to get dst before src so that > the call to GetArrayLength() comes first. > This also necessitates moving the RELEASE_ARRAYS() call on an error condition > to the new "2nd" block. > > The new regression test passes on all platforms and all the other headless > tests passed too. > So do the automated headful tests. This pull request has now been integrated. Changeset: e6f99260 Author:Phil Race URL: https://git.openjdk.java.net/jdk/commit/e6f99260 Stats: 126 lines in 4 files changed: 116 ins; 10 del; 0 mod 8257809: JNI warnings from Toolkit JPEG image decoding Reviewed-by: serb - PR: https://git.openjdk.java.net/jdk/pull/1850
Re: RFR: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button" [v2]
On Mon, 4 Jan 2021 11:22:37 GMT, Sergey Bylokhov wrote: >> test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 105: >> >>> 103: locy = bounds.y + insets.top; >>> 104: frw = bounds.width - insets.left - insets.right; >>> 105: frh = bounds.height - insets.top - insets.bottom; >> >> If the intent is to do away with window decorations, can't we just call >> frame.setUndecorated instead of this snippet? >> Also, it will be better to post a mach5 job in JBS running several >> iterations as it fails in mach5 primarily. > > Or even check the location of the button only? This is the simple fix and i don't want to make the analysis are too small because this will make artifacts harder to analyze. Test runs are linked in the bug comment. - PR: https://git.openjdk.java.net/jdk/pull/1929
Re: RFR: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button" [v2]
> 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with > "Exception: Failed to hide opaque button" Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Imports fixed. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1929/files - new: https://git.openjdk.java.net/jdk/pull/1929/files/94f6f859..1a8a0a19 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1929=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1929=00-01 Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1929.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1929/head:pull/1929 PR: https://git.openjdk.java.net/jdk/pull/1929
Re: RFR: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Mon, 4 Jan 2021 10:32:30 GMT, Prasanta Sadhukhan wrote: >> 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with >> "Exception: Failed to hide opaque button" > > test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 105: > >> 103: locy = bounds.y + insets.top; >> 104: frw = bounds.width - insets.left - insets.right; >> 105: frh = bounds.height - insets.top - insets.bottom; > > If the intent is to do away with window decorations, can't we just call > frame.setUndecorated instead of this snippet? > Also, it will be better to post a mach5 job in JBS running several iterations > as it fails in mach5 primarily. Or even check the location of the button only? - PR: https://git.openjdk.java.net/jdk/pull/1929
Re: RFR: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Mon, 4 Jan 2021 10:07:08 GMT, Alexander Zuev wrote: > 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with > "Exception: Failed to hide opaque button" test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 105: > 103: locy = bounds.y + insets.top; > 104: frw = bounds.width - insets.left - insets.right; > 105: frh = bounds.height - insets.top - insets.bottom; If the intent is to do away with window decorations, can't we just call frame.setUndecorated instead of this snippet? Also, it will be better to post a mach5 job in JBS running several iterations as it fails in mach5 primarily. - PR: https://git.openjdk.java.net/jdk/pull/1929
RFR: 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button" - Commit messages: - 8258643: javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button" - Merge pull request #7 from openjdk/master - Merge pull request #6 from openjdk/master - Merge pull request #5 from openjdk/master - Merge pull request #4 from openjdk/master - Merge pull request #3 from openjdk/master - Merge pull request #2 from openjdk/master - Merge pull request #1 from openjdk/master Changes: https://git.openjdk.java.net/jdk/pull/1929/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1929=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258643 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/1929.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1929/head:pull/1929 PR: https://git.openjdk.java.net/jdk/pull/1929
Re: RFR: JDK-8258884: [TEST_BUG] Convert applet-based test open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java to a regular java test [v2]
> Hi All, Could you please review this fix for JDK16? > > Problem Description: The test > open/test/jdk/javax/swing/JMenuItem/8031573/bug8031573.java is applet based. > > Fix: Rewritten the above applet based test to a regular java test. > > Best Regards, > K Suman Rajkumaar K Suman Rajkumaar has updated the pull request incrementally with one additional commit since the last revision: Update bug8031573.java Corrected the jtreg tag from @run main bug8031573 to @run main/manual bug8031573 to make this test as a manual test. - Changes: - all: https://git.openjdk.java.net/jdk/pull/1878/files - new: https://git.openjdk.java.net/jdk/pull/1878/files/9dbc094d..5f1ab6ea Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=1878=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=1878=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/1878.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1878/head:pull/1878 PR: https://git.openjdk.java.net/jdk/pull/1878
