Re: RFR: 8202880: Test javax/swing/JPopupMenu/8075063/ContextMenuScrollTest.java fails [v2]
> This test was unstable in linux in nightly testing. Modified to move the > frame to center of screen so that the left-taskbar of linux doesn't interfere > with the mouse movement along with delay after frame is visible to make it > more stable. > Mach5 job running for several iterations on all platforms is ok. Link in JBS. Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Address review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/2061/files - new: https://git.openjdk.java.net/jdk/pull/2061/files/ca7e5589..bc7ef81f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2061=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2061=00-01 Stats: 15 lines in 2 files changed: 6 ins; 7 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2061.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2061/head:pull/2061 PR: https://git.openjdk.java.net/jdk/pull/2061
Re: [jdk16] RFR: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Fri, 15 Jan 2021 06:12:15 GMT, Sergey Bylokhov wrote: > Looks like this test still fails in the mainline as well: > https://bugs.openjdk.java.net/browse/JDK-8259650 Yes but the reason is different. Now it seems like component's screenshot taken when component is not fully painted. Looking into it. - PR: https://git.openjdk.java.net/jdk16/pull/119
Re: [jdk16] RFR: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Fri, 15 Jan 2021 05:35:06 GMT, Prasanta Sadhukhan wrote: >> Backport from mainline. > > Marked as reviewed by psadhukhan (Reviewer). Looks like this test still fails in the mainline as well: https://bugs.openjdk.java.net/browse/JDK-8259650 - PR: https://git.openjdk.java.net/jdk16/pull/119
Re: [jdk16] RFR: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Wed, 13 Jan 2021 22:26:47 GMT, Alexander Zuev wrote: > Backport from mainline. Marked as reviewed by psadhukhan (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/119
Re: [jdk16] RFR: 8258643: [TESTBUG] javax/swing/JComponent/7154030/bug7154030.java failed with "Exception: Failed to hide opaque button"
On Wed, 13 Jan 2021 22:26:47 GMT, Alexander Zuev wrote: > Backport from mainline. Marked as reviewed by trebari (Committer). - PR: https://git.openjdk.java.net/jdk16/pull/119
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Thu, 14 Jan 2021 17:19:11 GMT, Naoto Sato wrote:
>> Leo Jiang has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> since the last revision:
>>
>> - Merge branch 'master' into msgdrop
>> - JDK-8259732: JDK 16 L10n resource file update - msg drop 10
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
> line 518:
>
>> 516: doclet.footer_specified=\
>> 517: The -footer option is no longer supported and will be ignored.\n\
>> 518: It may be removed in a future release.
>
> I believe this is to fix no newline at the end (unrelated to l10n changes).
> Do we need to change the copyright year for this?
Actually I was correcting the L217, changed {) -> {}. But 2 days ago, Jonathan
Gibbons fixed it in another commit 6bb6093. I found his fix after running the
merge. Looks both of us forgot to update the copyright year. Any suggestion?
doclet.help.systemProperties.body=\
The {0} page lists references to system properties.
-
PR: https://git.openjdk.java.net/jdk16/pull/123
Integrated: 8259522: Apply java.io.Serial annotations in java.desktop
On Mon, 11 Jan 2021 06:21:52 GMT, Sergey Bylokhov wrote: > Please review the application of @java.io.Serial annotation (JDK-8202385) to > types in the desktop module to enable stricter compile-time checking of > serialization-related declarations. > > This annotation can be applied to these methods in the module: > > private void writeObject(java.io.ObjectOutputStream stream) throws > IOException > private void readObject(java.io.ObjectInputStream stream) throws > IOException, ClassNotFoundException > private void readObjectNoData() throws ObjectStreamException > ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException > ANY-ACCESS-MODIFIER Object readResolve() throws ObjectStreamException > private static final ObjectStreamField[] serialPersistentFields > private static final long serialVersionUID > > Notes: > - I have tried to update the comments for serialVersionUID as accurately as > possible, but mostly based on the source code history and bugs in JBS where > that field was added > - Some of the readObject/writeObject methods in the javax.swing package > does not have a spec, because this package and some others are excluded from > the serialization specification. > > A similar fix was implemented for java.base module as well: > http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062046.html This pull request has now been integrated. Changeset: 978bed6c Author:Sergey Bylokhov URL: https://git.openjdk.java.net/jdk/commit/978bed6c Stats: 3424 lines in 343 files changed: 2264 ins; 287 del; 873 mod 8259522: Apply java.io.Serial annotations in java.desktop Reviewed-by: aivanov, psadhukhan - PR: https://git.openjdk.java.net/jdk/pull/2020
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
On Thu, 14 Jan 2021 14:27:25 GMT, Leo Jiang wrote: >> This is the changes for JDK 16 msg drop 10. > > Leo Jiang has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains two additional commits since > the last revision: > > - Merge branch 'master' into msgdrop > - JDK-8259732: JDK 16 L10n resource file update - msg drop 10 src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties line 518: > 516: doclet.footer_specified=\ > 517: The -footer option is no longer supported and will be ignored.\n\ > 518: It may be removed in a future release. I believe this is to fix no newline at the end (unrelated to l10n changes). Do we need to change the copyright year for this? - PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10
On Thu, 14 Jan 2021 14:10:12 GMT, Leo Jiang wrote: >> This is the changes for JDK 16 msg drop 10. > > [webrev.tar.gz](https://github.com/openjdk/jdk16/files/5814846/webrev.tar.gz) > > Since they're Unicode escape sequences in the l10n resource files, so I > attached a human readable webrev, created by `git webrev` and converted. Pls > find this to help your review. @naotoj Would you have time to take a look at this change? Very appreciated! - PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10 [v2]
> This is the changes for JDK 16 msg drop 10. Leo Jiang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into msgdrop - JDK-8259732: JDK 16 L10n resource file update - msg drop 10 - Changes: - all: https://git.openjdk.java.net/jdk16/pull/123/files - new: https://git.openjdk.java.net/jdk16/pull/123/files/230117b4..d72f444a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk16=123=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk16=123=00-01 Stats: 718 lines in 32 files changed: 616 ins; 38 del; 64 mod Patch: https://git.openjdk.java.net/jdk16/pull/123.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123 PR: https://git.openjdk.java.net/jdk16/pull/123
Re: [jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10
On Thu, 14 Jan 2021 14:00:00 GMT, Leo Jiang wrote: > This is the changes for JDK 16 msg drop 10. [webrev.tar.gz](https://github.com/openjdk/jdk16/files/5814846/webrev.tar.gz) Since they're Unicode escape sequences in the l10n resource files, so I attached a human readable webrev, created by `git webrev` and converted. Pls find this to help your review. - PR: https://git.openjdk.java.net/jdk16/pull/123
[jdk16] RFR: JDK-8259732: JDK 16 L10n resource file update - msg drop 10
This is the changes for JDK 16 msg drop 10. - Commit messages: - JDK-8259732: JDK 16 L10n resource file update - msg drop 10 Changes: https://git.openjdk.java.net/jdk16/pull/123/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16=123=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259732 Stats: 215 lines in 30 files changed: 118 ins; 16 del; 81 mod Patch: https://git.openjdk.java.net/jdk16/pull/123.diff Fetch: git fetch https://git.openjdk.java.net/jdk16 pull/123/head:pull/123 PR: https://git.openjdk.java.net/jdk16/pull/123
