Re: RFR: 8049700: Deprecate obsolete classes and methods in javax/swing/plaf/basic [v6]
On Wed, 10 Feb 2021 18:04:16 GMT, Phil Race wrote: >> Tejpal Rebari has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed deprecation from methods of class which is also getting deprecated > > Are these methods all expected to be used only by a L rather than an > application ? > If by an application, then forRemoval seems too strong to me. > If by a L then I think you need to go research what open source L there > are out there and see how many of them are affected. Then we can decide about > forRemoval. @prrace Please take a look. - PR: https://git.openjdk.java.net/jdk/pull/1958
Re: RFR: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button" [v3]
On Thu, 4 Mar 2021 17:21:43 GMT, Alexander Zuev wrote: >> test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 115: >> >>> 113: Graphics g = fullScreen.getGraphics(); >>> 114: g.setColor(Color.RED); >>> 115: g.drawRect(locx - 1, locy - 1, frw + 1, frh + 1); >> >> I believe we need to call g.dispose to dispose this object which we >> normallydo after getGraphics() call. > > It is not necessary in such a short test, JVM will exit after test ends which > will clear all the resources captured by this Graphics instance. BTW it will be closed/released only if the tests are run in the othervm mode, but jtreg tests might share the single VM for a group of tests. - PR: https://git.openjdk.java.net/jdk/pull/2790
Re: RFR: 8261689: javax/swing/JComponent/7154030/bug7154030.java still fails with "Exception: Failed to hide opaque button" [v3]
On Thu, 4 Mar 2021 02:56:05 GMT, Prasanta Sadhukhan wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved checking block up to keep consistency of operations. > > test/jdk/javax/swing/JComponent/7154030/bug7154030.java line 115: > >> 113: Graphics g = fullScreen.getGraphics(); >> 114: g.setColor(Color.RED); >> 115: g.drawRect(locx - 1, locy - 1, frw + 1, frh + 1); > > I believe we need to call g.dispose to dispose this object which we > normallydo after getGraphics() call. It is not necessary in such a short test, JVM will exit after test ends which will clear all the resources captured by this Graphics instance. - PR: https://git.openjdk.java.net/jdk/pull/2790
