[9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-03 Thread Avik Niyogi 
The bug fix looks good to me.

With Regards,
Avik Niyogi
> On 03-Jun-2016, at 11:31 am, Rajeev Chamyal <rajeev.cham...@oracle.com> wrote:
> 
>  
>  
> From: Alexandr Scherbatiy 
> Sent: 02 June 2016 12:00
> To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net 
> <mailto:swing-dev@openjdk.java.net>
> Subject: Re:  [9] Review request for JDK-[TEST_BUG] 
> test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed
>  
> 
> The fix looks good to me.
> 
> Thanks,
> Alexandr.
> 
> On 6/2/2016 8:13 AM, Rajeev Chamyal wrote:
> Hello Alexandr,
>  
> Please review the updated webrev.
> http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/ 
> <http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/>
>  
> Regards,
> Rajeev Chamyal
>  
> From: Alexandr Scherbatiy 
> Sent: 02 June 2016 01:20
> To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net 
> <mailto:swing-dev@openjdk.java.net>
> Subject: Re:  [9] Review request for JDK-[TEST_BUG] 
> test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed
>  
> On 6/1/2016 10:35 PM, Rajeev Chamyal wrote:
> 
> 
> Hello All,
>  
> Please review the following webrev
>  
> Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erchamyal/8158358/webrev.00/>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8158358 
> <https://bugs.openjdk.java.net/browse/JDK-8158358>
>  
> Fix : Fixed the compilation error.
>The initial summary of the test should be preserved.
> 
>   Thanks,
>   Alexandr.
> 
> 
>  
> Regards,
> Rajeev Chamyal
>  
>  
>

Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-02 Thread Alexandr Scherbatiy 


The fix looks good to me.

Thanks,
Alexandr.

On 6/2/2016 8:13 AM, Rajeev Chamyal wrote:


Hello Alexandr,

Please review the updated webrev.

http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/ 
<http://cr.openjdk.java.net/%7Erchamyal/8158358/webrev.01/>


Regards,

Rajeev Chamyal

*From:*Alexandr Scherbatiy
*Sent:* 02 June 2016 01:20
*To:* Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
*Subject:* Re:  [9] Review request for JDK-[TEST_BUG] 
test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed


On 6/1/2016 10:35 PM, Rajeev Chamyal wrote:

Hello All,

Please review the following webrev

Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/
<http://cr.openjdk.java.net/%7Erchamyal/8158358/webrev.00/>

Bug : https://bugs.openjdk.java.net/browse/JDK-8158358

Fix : Fixed the compilation error.

   The initial summary of the test should be preserved.

  Thanks,
  Alexandr.

Regards,

Rajeev Chamyal

Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-01 Thread Rajeev Chamyal 
Hello Alexandr,

 

Please review the updated webrev.

http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/

 

Regards,

Rajeev Chamyal

 

From: Alexandr Scherbatiy 
Sent: 02 June 2016 01:20
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re:  [9] Review request for JDK-[TEST_BUG] 
test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

 

On 6/1/2016 10:35 PM, Rajeev Chamyal wrote:



Hello All,

 

Please review the following webrev

 

Webrev : HYPERLINK 
"http://cr.openjdk.java.net/%7Erchamyal/8158358/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/

Bug : https://bugs.openjdk.java.net/browse/JDK-8158358 

 

Fix : Fixed the compilation error.

   The initial summary of the test should be preserved.

  Thanks,
  Alexandr.



 

Regards,

Rajeev Chamyal

Re: [9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-01 Thread Alexandr Scherbatiy 

On 6/1/2016 10:35 PM, Rajeev Chamyal wrote:


Hello All,

Please review the following webrev

Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/ 



Bug : https://bugs.openjdk.java.net/browse/JDK-8158358

Fix : Fixed the compilation error.


   The initial summary of the test should be preserved.

  Thanks,
  Alexandr.


Regards,

Rajeev Chamyal

[9] Review request for JDK-[TEST_BUG] test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java: compilation failed

2016-06-01 Thread Rajeev Chamyal 
Hello All,

 

Please review the following webrev

 

Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/

Bug : https://bugs.openjdk.java.net/browse/JDK-8158358 

 

Fix : Fixed the compilation error.

 

Regards,

Rajeev Chamyal