Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

2016-05-31 Thread Alexandr Scherbatiy 

The fix looks good to me.

Thanks,
Alexandr.

On 5/31/2016 4:39 PM, Sergey Bylokhov wrote:

Thanks.
Looks fine.

On 31.05.16 16:38, Avik Niyogi wrote:

Hi Sergey,
I ran the relevant test cases:
ActionListenerCalledTwiceTest
ScreenMenuBarInputTwice
with different keyboard preferences and locales.
Also tried different LAFs but found that only default (aqua) LAF is 
relevant for this case.


With Regards,
Avik Niyogi

On 31-May-2016, at 7:05 pm, Sergey Bylokhov 
 wrote:


Hi, Avik.
Please confirm that you run all tests for the previous regressions 
which were fixed in this code recently. (use different system locales).


On 31.05.16 16:28, Avik Niyogi wrote:

Hi All,

Kindly review the fix for JDK9.
*Bug: *https://bugs.openjdk.java.net/browse/JDK-8158230

*Webrev:* http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/

*Issue*: ActionEvent is not fired for menu item with option
apple.laf.useScreenMenuBar

*Cause*: The case for event that is not a Keydown has to be handled

*Fix*: With fixing the if - else loop, the correct behaviour was 
confirmed.


With Regards,
Avik Niyogi



--
Best regards, Sergey.

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

2016-05-31 Thread Sergey Bylokhov 

Thanks.
Looks fine.

On 31.05.16 16:38, Avik Niyogi wrote:

Hi Sergey,
I ran the relevant test cases:
ActionListenerCalledTwiceTest
ScreenMenuBarInputTwice
with different keyboard preferences and locales.
Also tried different LAFs but found that only default (aqua) LAF is relevant 
for this case.

With Regards,
Avik Niyogi


On 31-May-2016, at 7:05 pm, Sergey Bylokhov  wrote:

Hi, Avik.
Please confirm that you run all tests for the previous regressions which were 
fixed in this code recently. (use different system locales).

On 31.05.16 16:28, Avik Niyogi wrote:

Hi All,

Kindly review the fix for JDK9.
*Bug: *https://bugs.openjdk.java.net/browse/JDK-8158230

*Webrev:* http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/

*Issue*: ActionEvent is not fired for menu item with option
apple.laf.useScreenMenuBar

*Cause*: The case for event that is not a Keydown has to be handled

*Fix*: With fixing the if - else loop, the correct behaviour was confirmed.

With Regards,
Avik Niyogi



--
Best regards, Sergey.





--
Best regards, Sergey.

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

2016-05-31 Thread Avik Niyogi 
Hi Sergey,
I ran the relevant test cases:
ActionListenerCalledTwiceTest
ScreenMenuBarInputTwice
with different keyboard preferences and locales.
Also tried different LAFs but found that only default (aqua) LAF is relevant 
for this case.

With Regards,
Avik Niyogi

> On 31-May-2016, at 7:05 pm, Sergey Bylokhov  
> wrote:
> 
> Hi, Avik.
> Please confirm that you run all tests for the previous regressions which were 
> fixed in this code recently. (use different system locales).
> 
> On 31.05.16 16:28, Avik Niyogi wrote:
>> Hi All,
>> 
>> Kindly review the fix for JDK9.
>> *Bug: *https://bugs.openjdk.java.net/browse/JDK-8158230
>> 
>> *Webrev:* http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/
>> 
>> *Issue*: ActionEvent is not fired for menu item with option
>> apple.laf.useScreenMenuBar
>> 
>> *Cause*: The case for event that is not a Keydown has to be handled
>> 
>> *Fix*: With fixing the if - else loop, the correct behaviour was confirmed.
>> 
>> With Regards,
>> Avik Niyogi
> 
> 
> -- 
> Best regards, Sergey.

Re: 8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

2016-05-31 Thread Sergey Bylokhov 

Hi, Avik.
Please confirm that you run all tests for the previous regressions which 
were fixed in this code recently. (use different system locales).


On 31.05.16 16:28, Avik Niyogi wrote:

Hi All,

Kindly review the fix for JDK9.
*Bug: *https://bugs.openjdk.java.net/browse/JDK-8158230

*Webrev:* http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/

*Issue*: ActionEvent is not fired for menu item with option
apple.laf.useScreenMenuBar

*Cause*: The case for event that is not a Keydown has to be handled

*Fix*: With fixing the if - else loop, the correct behaviour was confirmed.

With Regards,
Avik Niyogi



--
Best regards, Sergey.

8158230: [macosx] ActionEvent is not fired for menu item with option apple.laf.useScreenMenuBar

2016-05-31 Thread Avik Niyogi 
Hi All,

Kindly review the fix for JDK9.
Bug: https://bugs.openjdk.java.net/browse/JDK-8158230 


Webrev: http://cr.openjdk.java.net/~aniyogi/8158230/webrev.00/ 


Issue: ActionEvent is not fired for menu item with option 
apple.laf.useScreenMenuBar

Cause: The case for event that is not a Keydown has to be handled

Fix: With fixing the if - else loop, the correct behaviour was confirmed.

With Regards,
Avik Niyogi