Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Prasanta Sadhukhan]

+1


On 11/23/2016 7:52 PM, Sergey Bylokhov wrote:

On 22.11.16 8:49, Avik Niyogi wrote:

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/
Change note: Instead of rethrow of a RuntimeException, used
printStackTrace()


+1



With Regards,
Avik Niyogi


On 22-Nov-2016, at 4:01 am, Sergey Bylokhov
> wrote:

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, 
ex);

can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi



On 14-Nov-2016, at 9:03 pm, Avik Niyogi 
> wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.


On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
 
>

wrote:

On 14.11.16 17:18, Avik Niyogi wrote:

I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.


Can you please clarify how you set the L for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"




On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
 
>

wrote:

On 14.11.16 6:43, Avik Niyogi wrote:

This is OS X Specific.


Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.


On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
 
>

wrote:

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.


This behavior is OSX specific or it is related to the Aqua L
which is default on OSX?


In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov


> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: 
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*


*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on 
OS X


*Cause: * The test case does not apply for OS X and should
work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.







--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

On 22.11.16 8:49, Avik Niyogi wrote:

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/
Change note: Instead of rethrow of a RuntimeException, used
printStackTrace()


+1



With Regards,
Avik Niyogi


On 22-Nov-2016, at 4:01 am, Sergey Bylokhov
> wrote:

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi



On 14-Nov-2016, at 9:03 pm, Avik Niyogi 
> wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.


On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
 >
wrote:

On 14.11.16 17:18, Avik Niyogi wrote:

I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.


Can you please clarify how you set the L for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"




On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
 >
wrote:

On 14.11.16 6:43, Avik Niyogi wrote:

This is OS X Specific.


Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.


On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
 >
wrote:

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.


This behavior is OSX specific or it is related to the Aqua L
which is default on OSX?


In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov

> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should
work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.







--
Best regards, Sergey.





--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below:
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.02/ 

Change note: Instead of rethrow of a RuntimeException, used printStackTrace()

With Regards,
Avik Niyogi

> On 22-Nov-2016, at 4:01 am, Sergey Bylokhov  
> wrote:
> 
> Hi, Avik.
> Is it necessary to use logging in the test?
> I guess that this code
> Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
> can be replaced by rethrow a RuntimeException exception?
> 
> On 17.11.16 13:45, Avik Niyogi wrote:
>> Hi All,
>> Please review the code changes made as suggested by reviewers for JDK9
>> as available for perusal in the link below
>> http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/ 
>> 
>> With Regards,
>> Avik Niyogi
>> 
>> 
>>> On 14-Nov-2016, at 9:03 pm, Avik Niyogi >> 
>>> >> wrote:
>>> 
>>> If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
>>> but for default settings on mac it is not working.
>>> 
 On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
  
 >> 
 wrote:
 
 On 14.11.16 17:18, Avik Niyogi wrote:
> I checked with MetalLAF as well. does not seem to work. also, tried
> with a native Mac app. Does not have any option for radio button
> focus traversal.
 
 Can you please clarify how you set the L for this test? I also
 checked it and the test passed on the current jdk9-client in case of
 "-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"
 
> 
>> On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
>>  
>> >> 
>> wrote:
>> 
>> On 14.11.16 6:43, Avik Niyogi wrote:
>>> This is OS X Specific.
>> 
>> Are you sure? I guess the test will pass if will be run using
>> MetalLookAndFeel.
>> 
 On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
  
 >>
 wrote:
 
 On 10.11.16 9:53, Avik Niyogi wrote:
> Arrow buttons for traversing a radio button group is not the
> expected OS X behaviour.
 
 This behavior is OSX specific or it is related to the Aqua L
 which is default on OSX?
 
> In OS X in default OS X apps, for radio button focus traversing
> to work, custom actions must be set using System Preferences.
>> On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov
>> 
>> > >> wrote:
>> 
>> On 09.11.16 11:06, Avik Niyogi wrote:
>>> *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*
>>> 
>>> *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*
>>> 
>>> *Issue: *The test case :
>>> javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
>>> 
>>> *Cause: * The test case does not apply for OS X and should
>>> work for
>>> windows and Linux
>> 
>> What is the reason why the test does not work on OSX?
>> 
>> 
>> --
>> Best regards, Sergey.
> 
 
 
 --
 Best regards, Sergey.
>>> 
>> 
>> 
>> --
>> Best regards, Sergey.
> 
 
 
 --
 Best regards, Sergey.
>>> 
>> 
> 
> 
> -- 
> Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

Hi, Avik.
Is it necessary to use logging in the test?
I guess that this code
Logger.getLogger(bug8033699.class.getName()).log(Level.SEVERE, null, ex);
can be replaced by rethrow a RuntimeException exception?

On 17.11.16 13:45, Avik Niyogi wrote:

Hi All,
Please review the code changes made as suggested by reviewers for JDK9
as available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/
With Regards,
Avik Niyogi



On 14-Nov-2016, at 9:03 pm, Avik Niyogi > wrote:

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works
but for default settings on mac it is not working.


On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov
> wrote:

On 14.11.16 17:18, Avik Niyogi wrote:

I checked with MetalLAF as well. does not seem to work. also, tried
with a native Mac app. Does not have any option for radio button
focus traversal.


Can you please clarify how you set the L for this test? I also
checked it and the test passed on the current jdk9-client in case of
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"




On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov
> wrote:

On 14.11.16 6:43, Avik Niyogi wrote:

This is OS X Specific.


Are you sure? I guess the test will pass if will be run using
MetalLookAndFeel.


On 14-Nov-2016, at 2:18 am, Sergey Bylokhov
>
wrote:

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the
expected OS X behaviour.


This behavior is OSX specific or it is related to the Aqua L
which is default on OSX?


In OS X in default OS X apps, for radio button focus traversing
to work, custom actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov
> wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should
work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.







--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

A gentle reminder, please review the code changes done as per the inputs 
received from reviewers.
Thanks in advance.
With Regards,
Avik Niyogi

> On 17-Nov-2016, at 4:15 pm, Avik Niyogi  wrote:
> 
> Hi All,
> Please review the code changes made as suggested by reviewers for JDK9 as 
> available for perusal in the link below
> http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/ 
> 
> With Regards,
> Avik Niyogi
> 
> 
>> On 14-Nov-2016, at 9:03 pm, Avik Niyogi > > wrote:
>> 
>> If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works but 
>> for default settings on mac it is not working.
>> 
>>> On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov >> > wrote:
>>> 
>>> On 14.11.16 17:18, Avik Niyogi wrote:
 I checked with MetalLAF as well. does not seem to work. also, tried with a 
 native Mac app. Does not have any option for radio button focus traversal.
>>> 
>>> Can you please clarify how you set the L for this test? I also checked it 
>>> and the test passed on the current jdk9-client in case of 
>>> "-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"
>>> 
 
> On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov  > wrote:
> 
> On 14.11.16 6:43, Avik Niyogi wrote:
>> This is OS X Specific.
> 
> Are you sure? I guess the test will pass if will be run using 
> MetalLookAndFeel.
> 
>>> On 14-Nov-2016, at 2:18 am, Sergey Bylokhov >> > wrote:
>>> 
>>> On 10.11.16 9:53, Avik Niyogi wrote:
 Arrow buttons for traversing a radio button group is not the expected 
 OS X behaviour.
>>> 
>>> This behavior is OSX specific or it is related to the Aqua L which is 
>>> default on OSX?
>>> 
 In OS X in default OS X apps, for radio button focus traversing to 
 work, custom actions must be set using System Preferences.
> On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov 
> > 
> wrote:
> 
> On 09.11.16 11:06, Avik Niyogi wrote:
>> *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160* 
>> 
>> 
>> *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/* 
>> 
>> 
>> *Issue: *The test case :
>> javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
>> 
>> *Cause: * The test case does not apply for OS X and should work for
>> windows and Linux
> 
> What is the reason why the test does not work on OSX?
> 
> 
> --
> Best regards, Sergey.
 
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>> 
> 
> 
> --
> Best regards, Sergey.
 
>>> 
>>> 
>>> -- 
>>> Best regards, Sergey.
>> 
> 

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

Hi All,
Please review the code changes made as suggested by reviewers for JDK9 as 
available for perusal in the link below
http://cr.openjdk.java.net/~aniyogi/8167160/webrev.01/ 

With Regards,
Avik Niyogi


> On 14-Nov-2016, at 9:03 pm, Avik Niyogi  wrote:
> 
> If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works but for 
> default settings on mac it is not working.
> 
>> On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov > > wrote:
>> 
>> On 14.11.16 17:18, Avik Niyogi wrote:
>>> I checked with MetalLAF as well. does not seem to work. also, tried with a 
>>> native Mac app. Does not have any option for radio button focus traversal.
>> 
>> Can you please clarify how you set the L for this test? I also checked it 
>> and the test passed on the current jdk9-client in case of 
>> "-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"
>> 
>>> 
 On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov > wrote:
 
 On 14.11.16 6:43, Avik Niyogi wrote:
> This is OS X Specific.
 
 Are you sure? I guess the test will pass if will be run using 
 MetalLookAndFeel.
 
>> On 14-Nov-2016, at 2:18 am, Sergey Bylokhov > > wrote:
>> 
>> On 10.11.16 9:53, Avik Niyogi wrote:
>>> Arrow buttons for traversing a radio button group is not the expected 
>>> OS X behaviour.
>> 
>> This behavior is OSX specific or it is related to the Aqua L which is 
>> default on OSX?
>> 
>>> In OS X in default OS X apps, for radio button focus traversing to 
>>> work, custom actions must be set using System Preferences.
 On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov 
 > wrote:
 
 On 09.11.16 11:06, Avik Niyogi wrote:
> *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160* 
> 
> 
> *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/* 
> 
> 
> *Issue: *The test case :
> javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
> 
> *Cause: * The test case does not apply for OS X and should work for
> windows and Linux
 
 What is the reason why the test does not work on OSX?
 
 
 --
 Best regards, Sergey.
>>> 
>> 
>> 
>> --
>> Best regards, Sergey.
> 
 
 
 --
 Best regards, Sergey.
>>> 
>> 
>> 
>> -- 
>> Best regards, Sergey.
> 

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

If I use UIManager.setLookAndFeel() to metalLookAndFeel then it works but for 
default settings on mac it is not working.

> On 14-Nov-2016, at 8:03 pm, Sergey Bylokhov  
> wrote:
> 
> On 14.11.16 17:18, Avik Niyogi wrote:
>> I checked with MetalLAF as well. does not seem to work. also, tried with a 
>> native Mac app. Does not have any option for radio button focus traversal.
> 
> Can you please clarify how you set the L for this test? I also checked it 
> and the test passed on the current jdk9-client in case of 
> "-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"
> 
>> 
>>> On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov  
>>> wrote:
>>> 
>>> On 14.11.16 6:43, Avik Niyogi wrote:
 This is OS X Specific.
>>> 
>>> Are you sure? I guess the test will pass if will be run using 
>>> MetalLookAndFeel.
>>> 
> On 14-Nov-2016, at 2:18 am, Sergey Bylokhov  
> wrote:
> 
> On 10.11.16 9:53, Avik Niyogi wrote:
>> Arrow buttons for traversing a radio button group is not the expected OS 
>> X behaviour.
> 
> This behavior is OSX specific or it is related to the Aqua L which is 
> default on OSX?
> 
>> In OS X in default OS X apps, for radio button focus traversing to work, 
>> custom actions must be set using System Preferences.
>>> On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov 
>>>  wrote:
>>> 
>>> On 09.11.16 11:06, Avik Niyogi wrote:
 *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*
 
 *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*
 
 *Issue: *The test case :
 javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
 
 *Cause: * The test case does not apply for OS X and should work for
 windows and Linux
>>> 
>>> What is the reason why the test does not work on OSX?
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>> 
> 
> 
> --
> Best regards, Sergey.
 
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>> 
> 
> 
> -- 
> Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

On 14.11.16 17:18, Avik Niyogi wrote:

I checked with MetalLAF as well. does not seem to work. also, tried with a 
native Mac app. Does not have any option for radio button focus traversal.


Can you please clarify how you set the L for this test? I also checked 
it and the test passed on the current jdk9-client in case of 
"-Dswing.defaultlaf=javax.swing.plaf.metal.MetalLookAndFeel"





On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov  wrote:

On 14.11.16 6:43, Avik Niyogi wrote:

This is OS X Specific.


Are you sure? I guess the test will pass if will be run using MetalLookAndFeel.


On 14-Nov-2016, at 2:18 am, Sergey Bylokhov  wrote:

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the expected OS X 
behaviour.


This behavior is OSX specific or it is related to the Aqua L which is default 
on OSX?


In OS X in default OS X apps, for radio button focus traversing to work, custom 
actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov  wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

I checked with MetalLAF as well. does not seem to work. also, tried with a 
native Mac app. Does not have any option for radio button focus traversal.

> On 14-Nov-2016, at 6:22 pm, Sergey Bylokhov  
> wrote:
> 
> On 14.11.16 6:43, Avik Niyogi wrote:
>> This is OS X Specific.
> 
> Are you sure? I guess the test will pass if will be run using 
> MetalLookAndFeel.
> 
>>> On 14-Nov-2016, at 2:18 am, Sergey Bylokhov  
>>> wrote:
>>> 
>>> On 10.11.16 9:53, Avik Niyogi wrote:
 Arrow buttons for traversing a radio button group is not the expected OS X 
 behaviour.
>>> 
>>> This behavior is OSX specific or it is related to the Aqua L which is 
>>> default on OSX?
>>> 
 In OS X in default OS X apps, for radio button focus traversing to work, 
 custom actions must be set using System Preferences.
> On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov  
> wrote:
> 
> On 09.11.16 11:06, Avik Niyogi wrote:
>> *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*
>> 
>> *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*
>> 
>> *Issue: *The test case :
>> javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
>> 
>> *Cause: * The test case does not apply for OS X and should work for
>> windows and Linux
> 
> What is the reason why the test does not work on OSX?
> 
> 
> --
> Best regards, Sergey.
 
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>> 
> 
> 
> -- 
> Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

On 14.11.16 6:43, Avik Niyogi wrote:

This is OS X Specific.


Are you sure? I guess the test will pass if will be run using 
MetalLookAndFeel.



On 14-Nov-2016, at 2:18 am, Sergey Bylokhov  wrote:

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the expected OS X 
behaviour.


This behavior is OSX specific or it is related to the Aqua L which is default 
on OSX?


In OS X in default OS X apps, for radio button focus traversing to work, custom 
actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov  wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.





--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

This is OS X Specific.
> On 14-Nov-2016, at 2:18 am, Sergey Bylokhov  
> wrote:
> 
> On 10.11.16 9:53, Avik Niyogi wrote:
>> Arrow buttons for traversing a radio button group is not the expected OS X 
>> behaviour.
> 
> This behavior is OSX specific or it is related to the Aqua L which is 
> default on OSX?
> 
>> In OS X in default OS X apps, for radio button focus traversing to work, 
>> custom actions must be set using System Preferences.
>>> On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov  
>>> wrote:
>>> 
>>> On 09.11.16 11:06, Avik Niyogi wrote:
 *Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*
 
 *Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*
 
 *Issue: *The test case :
 javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X
 
 *Cause: * The test case does not apply for OS X and should work for
 windows and Linux
>>> 
>>> What is the reason why the test does not work on OSX?
>>> 
>>> 
>>> --
>>> Best regards, Sergey.
>> 
> 
> 
> -- 
> Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

On 10.11.16 9:53, Avik Niyogi wrote:

Arrow buttons for traversing a radio button group is not the expected OS X 
behaviour.


This behavior is OSX specific or it is related to the Aqua L which is 
default on OSX?



In OS X in default OS X apps, for radio button focus traversing to work, custom 
actions must be set using System Preferences.

On 09-Nov-2016, at 6:51 pm, Sergey Bylokhov  wrote:

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.





--
Best regards, Sergey.

Re: 8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Sergey Bylokhov]

On 09.11.16 11:06, Avik Niyogi wrote:

*Bug: https://bugs.openjdk.java.net/browse/JDK-8167160*

*Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/*

*Issue: *The test case :
javax/swing/JRadioButton/8033699/bug8033699.java fails on OS X

*Cause: * The test case does not apply for OS X and should work for
windows and Linux


What is the reason why the test does not work on OSX?


--
Best regards, Sergey.

8167160: [TEST_BUG][PIT] failure of javax/swing/JRadioButton/8033699/bug8033699.java

[Avik Niyogi]

Hi All,

Kindly review the proposed webrev for JDK9. 

Bug: https://bugs.openjdk.java.net/browse/JDK-8167160 


Webrev: http://cr.openjdk.java.net/~aniyogi/8167160/webrev.00/ 


Issue: The test case : javax/swing/JRadioButton/8033699/bug8033699.java fails 
on OS X

Cause:  The test case does not apply for OS X and should work for windows and 
Linux

Fix: Appropriatechanges in test case parameters were added.

With Regards,